Re: [VOTE] Release Lucene 9.4.0 RC3

2022-09-27 Thread Patrick Zhai
+1 (non-binding) SUCCESS! [0:57:17.821452] On Tue, Sep 27, 2022 at 3:32 PM Michael McCandless < luc...@mikemccandless.com> wrote: > +1, smoke tester: > > SUCCESS! [0:26:01.696388] > > > Mike McCandless > > http://blog.mikemccandless.com > > > On Tue, Sep 27, 2022 at 3:45 PM Anshum Gupta >

Re: [VOTE] Release Lucene 9.4.0 RC3

2022-09-27 Thread Michael McCandless
+1, smoke tester: SUCCESS! [0:26:01.696388] Mike McCandless http://blog.mikemccandless.com On Tue, Sep 27, 2022 at 3:45 PM Anshum Gupta wrote: > +1 (binding) > > Smoketester is happy! > SUCCESS! [0:54:06.589484] > > On Tue, Sep 27, 2022 at 6:15 AM Michael Sokolov > wrote: > >> Please vote

Re: [VOTE] Release Lucene 9.4.0 RC3

2022-09-27 Thread Anshum Gupta
+1 (binding) Smoketester is happy! SUCCESS! [0:54:06.589484] On Tue, Sep 27, 2022 at 6:15 AM Michael Sokolov wrote: > Please vote for release candidate 3 for Lucene 9.4.0 > > The artifacts can be downloaded from: > >

Re: IMPORTANT: Please update your gradle.properties file in your Lucene checkout!

2022-09-27 Thread Uwe Schindler
Again: delete the gradle.properties, start gradlew and be happy. No need to install JDK 19 or set any env var. It just works™. Eclipse IDE will also work fine (it will hide the classes). Idea is under investigation. In worst case disable compilation of the problematic core/src/java19 folder in

Re: IMPORTANT: Please update your gradle.properties file in your Lucene checkout!

2022-09-27 Thread Robert Muir
the 'gradlew -q javaToolChains' command is useful to see which JVMs gradle knows about. On Tue, Sep 27, 2022 at 3:34 PM Uwe Schindler wrote: > > You just need to recreate Gradle properties, e.g. by deleting the old file. > > If you do not change anything Gradle will just work. On first build it

Re: IMPORTANT: Please update your gradle.properties file in your Lucene checkout!

2022-09-27 Thread Uwe Schindler
You just need to recreate Gradle properties, e.g. by deleting the old file. If you do not change anything Gradle will just work. On first build it will autoprovision JDK 19 like any other dependency into the Gradle cache like Maven artifacts and use it to compile the java 19 specific classes.

Re: IMPORTANT: Please update your gradle.properties file in your Lucene checkout!

2022-09-27 Thread David Smiley
> If you do not want Gradle to auto-provision the Java 19 for compilation of those Preview classes, pass environment variable JAVA19_HOME=/path/to/jdk19 to your build! That seems inverted; maybe I misunderstand? If say we're working locally without Java 19 and don't want to bother it during dev,

Re: [VOTE] Release Lucene 9.4.0 RC3

2022-09-27 Thread Adrien Grand
+1 SUCCESS! [1:13:37.634770] On Tue, Sep 27, 2022 at 6:44 PM Uwe Schindler wrote: > Hi, > > Policeman Jenkins checked the release candidate 3 (RC3) for me ( > https://jenkins.thetaphi.de/job/Lucene-Release-Tester/22/console): > > SUCCESS! [1:42:45.782213] > Finished: SUCCESS > > I also checked

Re: [VOTE] Release Lucene 9.4.0 RC3

2022-09-27 Thread Uwe Schindler
Hi, Policeman Jenkins checked the release candidate 3 (RC3) for me (https://jenkins.thetaphi.de/job/Lucene-Release-Tester/22/console): SUCCESS! [1:42:45.782213] Finished: SUCCESS I also checked Luke downloaded from the binary JAR and tested Java 19 support: * When starting Luke with Java

Re: [VOTE] Release Lucene 9.4.0 RC3

2022-09-27 Thread Robert Muir
+1 Smoketester works for me again without hassles, thanks Uwe. I tested both java 11 and java 17. SUCCESS! [2:49:13.336252] P.S. It would be nice option in the future to be able to test other versions that we have MR-jar'd code for (e.g. 19 in this case). On Tue, Sep 27, 2022 at 9:15 AM

Re: [VOTE] Release Lucene 9.4.0 RC2

2022-09-27 Thread Ignacio Vera
Thank you Mike, sorry for all the extra work! On Tue, Sep 27, 2022 at 3:14 PM Michael Sokolov wrote: > OK, well I am glad we were able to fix quickly. > > This vote is failed; I've re-spun RC3 and will start a new vote thread > > On Tue, Sep 27, 2022 at 5:52 AM Uwe Schindler wrote: > > > > Hi,

[VOTE] Release Lucene 9.4.0 RC3

2022-09-27 Thread Michael Sokolov
Please vote for release candidate 3 for Lucene 9.4.0 The artifacts can be downloaded from: https://dist.apache.org/repos/dist/dev/lucene/lucene-9.4.0-RC3-rev-d2e22e18c6c92b6a6ba0bbc26d78b5e82832f956 You can run the smoke tester directly with this command: python3 -u

Re: [VOTE] Release Lucene 9.4.0 RC2

2022-09-27 Thread Michael Sokolov
OK, well I am glad we were able to fix quickly. This vote is failed; I've re-spun RC3 and will start a new vote thread On Tue, Sep 27, 2022 at 5:52 AM Uwe Schindler wrote: > > Hi, > > I also added the small build system changes and the localSettings fix for > Smoketester to make Robert happy

Re: [VOTE] Release Lucene 9.4.0 RC2

2022-09-27 Thread Uwe Schindler
Hi, I also added the small build system changes and the localSettings fix for Smoketester to make Robert happy with validating release :-) Uwe Am 27.09.2022 um 10:59 schrieb Ignacio Vera: I pushed a fix to all relevant branches: https://github.com/apache/lucene/pull/11825 On Tue, Sep

Re: [VOTE] Release Lucene 9.4.0 RC2

2022-09-27 Thread Ignacio Vera
I pushed a fix to all relevant branches: https://github.com/apache/lucene/pull/11825 On Tue, Sep 27, 2022 at 10:44 AM Anshum Gupta wrote: > Thanks Ignacio for noticing and reporting that. I agree with Uwe, it makes > sense to cancel this vote and get the fix in. > > Thank you for being

Re: [VOTE] Release Lucene 9.4.0 RC2

2022-09-27 Thread Anshum Gupta
Thanks Ignacio for noticing and reporting that. I agree with Uwe, it makes sense to cancel this vote and get the fix in. Thank you for being patient, Mike :) On Tue, Sep 27, 2022 at 1:20 AM Uwe Schindler wrote: > Hi, > > that's too bad! As not many have ran smoke tester, I think it may be a >

Re: [VOTE] Release Lucene 9.4.0 RC2

2022-09-27 Thread Uwe Schindler
Hi, that's too bad! As not many have ran smoke tester, I think it may be a good idea to now stop the release. If we respin, I will backport some small build system fixes like support for Eclipse and Smoketester bootup (regarding MR-JAR) also to the 9.4 branch. But that's not urgent. Uwe

Re: [VOTE] Release Lucene 9.4.0 RC2

2022-09-27 Thread Ignacio Vera
Hi, I just noticed an important regression on polygon queries using the LatLonPoint field, see https://github.com/apache/lucene/issues/11824. It feels like an important regression so it might be worth a respinning. Sorry about that. On Mon, Sep 26, 2022 at 10:30 PM Anshum Gupta wrote: > +1