[
https://issues.apache.org/jira/browse/LUCENE-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13937331#comment-13937331
]
Chris Male edited comment on LUCENE-5376 at 3/16/14 8:59 PM:
-
[
https://issues.apache.org/jira/browse/LUCENE-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13937331#comment-13937331
]
Chris Male commented on LUCENE-5376:
Why's motivated the new branch?
Add a demo
[
https://issues.apache.org/jira/browse/LUCENE-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13937343#comment-13937343
]
Chris Male commented on LUCENE-5376:
Sweet!
Add a demo search server
[
https://issues.apache.org/jira/browse/LUCENE-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917260#comment-13917260
]
Chris Male commented on LUCENE-5483:
+1
hunspell inaccuracies
[
https://issues.apache.org/jira/browse/LUCENE-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914954#comment-13914954
]
Chris Male commented on LUCENE-5468:
Those are some pretty amazing reductions, well
[
https://issues.apache.org/jira/browse/LUCENE-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915045#comment-13915045
]
Chris Male commented on LUCENE-5468:
Is the longestOnly option a standard Hunspell
[
https://issues.apache.org/jira/browse/LUCENE-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915047#comment-13915047
]
Chris Male commented on LUCENE-5376:
Hey Mike,
What's the endzone here? Any thoughts
[
https://issues.apache.org/jira/browse/LUCENE-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915053#comment-13915053
]
Chris Male commented on LUCENE-5468:
Awesome, sounds like a great addition then.
[
https://issues.apache.org/jira/browse/LUCENE-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915231#comment-13915231
]
Chris Male commented on LUCENE-5468:
I dont think we should make the recusionCap
[
https://issues.apache.org/jira/browse/LUCENE-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915240#comment-13915240
]
Chris Male commented on LUCENE-5468:
Yeah I guess. We can go over that in a new
[
https://issues.apache.org/jira/browse/LUCENE-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13909943#comment-13909943
]
Chris Male commented on LUCENE-5468:
Multiple dictionaries was never in the original
[
https://issues.apache.org/jira/browse/LUCENE-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13909952#comment-13909952
]
Chris Male commented on LUCENE-5468:
Sounds good
Hunspell very high memory use when
[
https://issues.apache.org/jira/browse/SOLR-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867291#comment-13867291
]
Chris Male commented on SOLR-5621:
--
+1 for trunk
Let Solr use Lucene's SeacherManager
[
https://issues.apache.org/jira/browse/LUCENE-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13759514#comment-13759514
]
Chris Male commented on LUCENE-5057:
The example you describe is sort of at the heart
[
https://issues.apache.org/jira/browse/LUCENE-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13759863#comment-13759863
]
Chris Male commented on LUCENE-5057:
I don't think the problem is related to
[
https://issues.apache.org/jira/browse/LUCENE-4616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529343#comment-13529343
]
Chris Male commented on LUCENE-4616:
I agree with Ryan, we shouldn't try to
[
https://issues.apache.org/jira/browse/LUCENE-4616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529349#comment-13529349
]
Chris Male commented on LUCENE-4616:
Another option, more big picture I guess, is to
[
https://issues.apache.org/jira/browse/LUCENE-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505294#comment-13505294
]
Chris Male commented on LUCENE-4569:
John,
I don't really know much about the API
[
https://issues.apache.org/jira/browse/LUCENE-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13499565#comment-13499565
]
Chris Male commented on LUCENE-4271:
{quote}
I think it's odd to add syntax to
[
https://issues.apache.org/jira/browse/LUCENE-4542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13492892#comment-13492892
]
Chris Male commented on LUCENE-4542:
Rafał,
Thanks for creating the patches, they
[
https://issues.apache.org/jira/browse/LUCENE-4542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491845#comment-13491845
]
Chris Male commented on LUCENE-4542:
+1 I absolutely agree we need to make this
[
https://issues.apache.org/jira/browse/LUCENE-4542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Male reassigned LUCENE-4542:
--
Assignee: Chris Male
Make RECURSION_CAP in HunspellStemmer configurable
[
https://issues.apache.org/jira/browse/LUCENE-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13487417#comment-13487417
]
Chris Male commented on LUCENE-4511:
+1 to these improvements.
Another typo: to
[
https://issues.apache.org/jira/browse/LUCENE-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463384#comment-13463384
]
Chris Male commented on LUCENE-4427:
I've no great attachment to this code but it's
[
https://issues.apache.org/jira/browse/LUCENE-4419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461548#comment-13461548
]
Chris Male commented on LUCENE-4419:
I really don't see the benefit of randomly
[
https://issues.apache.org/jira/browse/LUCENE-4419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461564#comment-13461564
]
Chris Male commented on LUCENE-4419:
bq. I'm all for what you suggest – a test that
[
https://issues.apache.org/jira/browse/LUCENE-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461320#comment-13461320
]
Chris Male edited comment on LUCENE-4412 at 9/23/12 4:03 PM:
-
[
https://issues.apache.org/jira/browse/LUCENE-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461320#comment-13461320
]
Chris Male commented on LUCENE-4412:
One of the big challenges for this API is the
[
https://issues.apache.org/jira/browse/LUCENE-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460439#comment-13460439
]
Chris Male commented on LUCENE-4412:
Thanks for raising those concerns David.
Chris Male created LUCENE-4412:
--
Summary: Reconsider FunctionValues / ValueSource API
Key: LUCENE-4412
URL: https://issues.apache.org/jira/browse/LUCENE-4412
Project: Lucene - Core
Issue Type:
[
https://issues.apache.org/jira/browse/LUCENE-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13459295#comment-13459295
]
Chris Male commented on LUCENE-4409:
+1 That's pretty damn cool
[
https://issues.apache.org/jira/browse/LUCENE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13459341#comment-13459341
]
Chris Male commented on LUCENE-4175:
With the very near release of 4.0, I don't think
[
https://issues.apache.org/jira/browse/LUCENE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13456892#comment-13456892
]
Chris Male commented on LUCENE-3997:
bq. I propose, instead of using lucene-core as
[
https://issues.apache.org/jira/browse/LUCENE-4388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13456561#comment-13456561
]
Chris Male commented on LUCENE-4388:
Interesting idea. I like the idea of Strategys
[
https://issues.apache.org/jira/browse/LUCENE-4388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13456757#comment-13456757
]
Chris Male commented on LUCENE-4388:
bq. The reasoning is similar to how a standard
[
https://issues.apache.org/jira/browse/LUCENE-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13456405#comment-13456405
]
Chris Male commented on LUCENE-4389:
I have faith in your knowledge on this and there
[
https://issues.apache.org/jira/browse/LUCENE-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13455768#comment-13455768
]
Chris Male commented on LUCENE-4208:
Things are looking pretty good, we're almost
[
https://issues.apache.org/jira/browse/LUCENE-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13453746#comment-13453746
]
Chris Male commented on LUCENE-4208:
I disagree that makeQuery shouldn't exist.
[
https://issues.apache.org/jira/browse/LUCENE-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13454581#comment-13454581
]
Chris Male commented on LUCENE-4208:
bq. TwoDoubles is getting overhauled to support
[
https://issues.apache.org/jira/browse/LUCENE-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13452884#comment-13452884
]
Chris Male commented on LUCENE-4369:
As I say, I totally support renaming this field
[
https://issues.apache.org/jira/browse/LUCENE-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13452924#comment-13452924
]
Chris Male commented on LUCENE-4369:
I like ExactMatchField, good suggestion.
[
https://issues.apache.org/jira/browse/LUCENE-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13453674#comment-13453674
]
Chris Male commented on LUCENE-4375:
In the future, once we remove much of the
[
https://issues.apache.org/jira/browse/LUCENE-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13453708#comment-13453708
]
Chris Male commented on LUCENE-4208:
I don't think there is a clear solution here.
[
https://issues.apache.org/jira/browse/LUCENE-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13451508#comment-13451508
]
Chris Male commented on LUCENE-4208:
I actually totally agree with David here. Using
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13451579#comment-13451579
]
Chris Male commented on LUCENE-3312:
David, just at a guess I imagine the branch used
[
https://issues.apache.org/jira/browse/LUCENE-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13451730#comment-13451730
]
Chris Male commented on LUCENE-4369:
I'm +1 for renaming this field (and even
[
https://issues.apache.org/jira/browse/SOLR-3686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13451507#comment-13451507
]
Chris Male commented on SOLR-3686:
--
bq. If I'm the only intellij user left, I guess I
[
https://issues.apache.org/jira/browse/LUCENE-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448758#comment-13448758
]
Chris Male commented on LUCENE-4186:
bq. SpatialArgs.toString()'s logic was moved to
[
https://issues.apache.org/jira/browse/LUCENE-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448801#comment-13448801
]
Chris Male commented on LUCENE-4186:
bq. It'd be nice if this could be done at index
[
https://issues.apache.org/jira/browse/LUCENE-4365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449400#comment-13449400
]
Chris Male commented on LUCENE-4365:
Great work improving this Steven, what a mess!
[
https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447617#comment-13447617
]
Chris Male commented on LUCENE-4354:
hamcrest is a transitive dependency of junit,
[
https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447634#comment-13447634
]
Chris Male commented on LUCENE-4354:
Ignoring the scope issue, the validation has
[
https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447638#comment-13447638
]
Chris Male commented on LUCENE-4354:
It's not just an issue of what ends up in the
[
https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447714#comment-13447714
]
Chris Male commented on LUCENE-4354:
Yeah I think tests should be catching them. Do
[
https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448478#comment-13448478
]
Chris Male commented on LUCENE-4362:
Well damn.
ban tab-indented
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13446962#comment-13446962
]
Chris Male commented on LUCENE-3312:
Thanks Uwe and Nikola!
Break
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13445842#comment-13445842
]
Chris Male commented on LUCENE-3312:
I've thought about this a little bit.
{quote}
[
https://issues.apache.org/jira/browse/SOLR-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13444841#comment-13444841
]
Chris Male commented on SOLR-3700:
--
bq. Is there any reason not to develop it as a Lucene
[
https://issues.apache.org/jira/browse/LUCENE-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13444908#comment-13444908
]
Chris Male commented on LUCENE-4343:
+1 to the improvements and pursuing making it
Chris Male
Chris Male
[
https://issues.apache.org/jira/browse/LUCENE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13437458#comment-13437458
]
Chris Male commented on LUCENE-4197:
+1
Small improvements to
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13436755#comment-13436755
]
Chris Male commented on LUCENE-3312:
We definitely need to clean up StorableFieldType
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13434970#comment-13434970
]
Chris Male commented on LUCENE-3312:
Is it going to be possible to address
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13431719#comment-13431719
]
Chris Male commented on LUCENE-3312:
Hey Nikola,
bq. except for mentioned
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13431828#comment-13431828
]
Chris Male commented on LUCENE-3312:
Wow, I have replicated the same behaviour. On
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13431833#comment-13431833
]
Chris Male commented on LUCENE-3312:
Ah I think I found the problem, it's in
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13431839#comment-13431839
]
Chris Male commented on LUCENE-3312:
Yup found it.
The problem is in the branch
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13431841#comment-13431841
]
Chris Male commented on LUCENE-3312:
Nikola, we should probably move all of
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13431849#comment-13431849
]
Chris Male commented on LUCENE-3312:
Yeah we definitely shouldn't return a new list.
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13431851#comment-13431851
]
Chris Male commented on LUCENE-3312:
Oh we should also include a unit test that
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13431867#comment-13431867
]
Chris Male commented on LUCENE-3312:
Nikola,
On a totally note totally unrelated to
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13431867#comment-13431867
]
Chris Male edited comment on LUCENE-3312 at 8/9/12 2:51 PM:
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13431880#comment-13431880
]
Chris Male commented on LUCENE-3312:
{code}
public final ListField getFields() {
[
https://issues.apache.org/jira/browse/LUCENE-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428583#comment-13428583
]
Chris Male commented on LUCENE-3616:
With all the various typed XYZField
[
https://issues.apache.org/jira/browse/LUCENE-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428594#comment-13428594
]
Chris Male commented on LUCENE-3616:
bq. In my opinion if i have a
[
https://issues.apache.org/jira/browse/LUCENE-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Male updated LUCENE-4256:
---
Attachment: LUCENE-4256-version.patch
Going to do this in smaller steps so they are easier to
[
https://issues.apache.org/jira/browse/LUCENE-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13425627#comment-13425627
]
Chris Male commented on LUCENE-4271:
Is the intention to mandate the !var syntax too?
[
https://issues.apache.org/jira/browse/LUCENE-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424903#comment-13424903
]
Chris Male commented on LUCENE-4271:
Will a query have a single set of params, or
[
https://issues.apache.org/jira/browse/LUCENE-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424322#comment-13424322
]
Chris Male commented on LUCENE-4268:
+1
Rename
[
https://issues.apache.org/jira/browse/LUCENE-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424358#comment-13424358
]
Chris Male commented on LUCENE-4208:
Having thought about this more I think the best
[
https://issues.apache.org/jira/browse/LUCENE-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423811#comment-13423811
]
Chris Male commented on LUCENE-4260:
+1
Factor subPackages out of
[
https://issues.apache.org/jira/browse/LUCENE-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423851#comment-13423851
]
Chris Male commented on LUCENE-4208:
I'm considered this obfuscates the actual
[
https://issues.apache.org/jira/browse/LUCENE-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423851#comment-13423851
]
Chris Male edited comment on LUCENE-4208 at 7/27/12 1:02 PM:
-
[
https://issues.apache.org/jira/browse/LUCENE-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422869#comment-13422869
]
Chris Male commented on LUCENE-4257:
Thanks for getting to this Robert, it's a good
[
https://issues.apache.org/jira/browse/LUCENE-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422878#comment-13422878
]
Chris Male commented on LUCENE-4173:
I thought you were anti-degradation at indexing
[
https://issues.apache.org/jira/browse/LUCENE-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Male updated LUCENE-4256:
---
Attachment: LUCENE-4256-further.patch
I took Robert's patch and extended it further, fixing the
[
https://issues.apache.org/jira/browse/LUCENE-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422941#comment-13422941
]
Chris Male commented on LUCENE-4256:
Thanks Robert I'll take your prototype and roll
[
https://issues.apache.org/jira/browse/LUCENE-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422876#comment-13422876
]
Chris Male commented on LUCENE-4256:
{quote}
I think of it as just a way of taking
[
https://issues.apache.org/jira/browse/LUCENE-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423073#comment-13423073
]
Chris Male commented on LUCENE-4173:
I do like it yeah. I think it improves 'simple'
[
https://issues.apache.org/jira/browse/LUCENE-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423083#comment-13423083
]
Chris Male commented on LUCENE-4173:
Why dont we use an enum instead of a boolean?
[
https://issues.apache.org/jira/browse/LUCENE-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422049#comment-13422049
]
Chris Male commented on LUCENE-4044:
Shall we merge and then address automation?
[
https://issues.apache.org/jira/browse/LUCENE-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422121#comment-13422121
]
Chris Male commented on LUCENE-4044:
Thanks Uwe, patches look good, +1 to committing
[
https://issues.apache.org/jira/browse/LUCENE-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422788#comment-13422788
]
Chris Male commented on LUCENE-4255:
I originally added InitializationException as a
[
https://issues.apache.org/jira/browse/LUCENE-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422803#comment-13422803
]
Chris Male commented on LUCENE-4255:
Yup it's good! +1
clean up
Chris Male created LUCENE-4256:
--
Summary: Improve Analysis Factory configuration workflow
Key: LUCENE-4256
URL: https://issues.apache.org/jira/browse/LUCENE-4256
Project: Lucene - Core
Issue
[
https://issues.apache.org/jira/browse/LUCENE-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422866#comment-13422866
]
Chris Male commented on LUCENE-4256:
bq. I don't think we should do this: else there
[
https://issues.apache.org/jira/browse/LUCENE-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13421316#comment-13421316
]
Chris Male commented on LUCENE-4044:
I was testing my Solr integration code and ran
[
https://issues.apache.org/jira/browse/LUCENE-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13421356#comment-13421356
]
Chris Male commented on LUCENE-4044:
Hm, the problem is that MockTokenizerFactory
[
https://issues.apache.org/jira/browse/LUCENE-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13421366#comment-13421366
]
Chris Male commented on LUCENE-4044:
{quote}
A second problem I see is the fact that
1 - 100 of 971 matches
Mail list logo