[jira] [Resolved] (LUCENE-8809) Refresh and rollback concurrently can leave segment states unclosed

2019-06-05 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen resolved LUCENE-8809. - Resolution: Fixed [~simonw]  Thanks for the ping. I have re-committed this to 8.1. > Refresh

[jira] [Commented] (LUCENE-8809) Refresh and rollback concurrently can leave segment states unclosed

2019-05-28 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849737#comment-16849737 ] Nhat Nguyen commented on LUCENE-8809: - [~janhoy] Thank you for adding a changes entry. > Refresh

[jira] [Commented] (LUCENE-8809) Refresh and rollback concurrently can leave segment states unclosed

2019-05-27 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848957#comment-16848957 ] Nhat Nguyen commented on LUCENE-8809: - [~janhoy] Thanks for looking. {quote}it looks pretty

[jira] [Commented] (LUCENE-8809) Refresh and rollback concurrently can leave segment states unclosed

2019-05-27 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848885#comment-16848885 ] Nhat Nguyen commented on LUCENE-8809: - [~janhoy] I have reverted my commit on 7.7. > Refresh and

[jira] [Updated] (LUCENE-8809) Refresh and rollback concurrently can leave segment states unclosed

2019-05-27 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8809: Fix Version/s: (was: 7.7.2) > Refresh and rollback concurrently can leave segment states

[jira] [Created] (LUCENE-8813) testIndexTooManyDocs fails

2019-05-24 Thread Nhat Nguyen (JIRA)
Nhat Nguyen created LUCENE-8813: --- Summary: testIndexTooManyDocs fails Key: LUCENE-8813 URL: https://issues.apache.org/jira/browse/LUCENE-8813 Project: Lucene - Core Issue Type: Test

[jira] [Resolved] (LUCENE-8809) Refresh and rollback concurrently can leave segment states unclosed

2019-05-23 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen resolved LUCENE-8809. - Resolution: Fixed Assignee: Nhat Nguyen Fix Version/s: 8.2

[jira] [Updated] (LUCENE-8809) Refresh and rollback concurrently can leave segment states unclosed

2019-05-23 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8809: Affects Version/s: 7.7 > Refresh and rollback concurrently can leave segment states unclosed >

[jira] [Created] (LUCENE-8809) Refresh and rollback concurrently can leave segment states unclosed

2019-05-23 Thread Nhat Nguyen (JIRA)
Nhat Nguyen created LUCENE-8809: --- Summary: Refresh and rollback concurrently can leave segment states unclosed Key: LUCENE-8809 URL: https://issues.apache.org/jira/browse/LUCENE-8809 Project: Lucene -

[jira] [Updated] (LUCENE-8734) nextWriteDelGen of SegmentCommitInfo should be persisted

2019-03-21 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8734: Labels: pull-request-available (was: ) > nextWriteDelGen of SegmentCommitInfo should be

[jira] [Created] (LUCENE-8734) nextWriteDelGen of SegmentCommitInfo should be persisted

2019-03-21 Thread Nhat Nguyen (JIRA)
Nhat Nguyen created LUCENE-8734: --- Summary: nextWriteDelGen of SegmentCommitInfo should be persisted Key: LUCENE-8734 URL: https://issues.apache.org/jira/browse/LUCENE-8734 Project: Lucene - Core

[jira] [Commented] (LUCENE-8609) Allow getting consistent docstats from IndexWriter

2018-12-13 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720453#comment-16720453 ] Nhat Nguyen commented on LUCENE-8609: - +1 to deprecate  maxDoc and numDocs. > Allow getting

[jira] [Resolved] (LUCENE-8518) TestIndexWriter#testSoftUpdateDocuments fails in Elastic CI

2018-11-30 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen resolved LUCENE-8518. - Resolution: Fixed Lucene Fields: (was: New,Patch Available) Fixed in 

[jira] [Commented] (LUCENE-8558) Adding NumericDocValuesFields is slowing down the indexing process significantly

2018-11-02 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673866#comment-16673866 ] Nhat Nguyen commented on LUCENE-8558: - [~Chalasani] Good find. Would you like to submit a patch for

[jira] [Commented] (LUCENE-8518) TestIndexWriter#testSoftUpdateDocuments fails in Elastic CI

2018-09-30 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633603#comment-16633603 ] Nhat Nguyen commented on LUCENE-8518: - I believe my analysis is not correct. I'll have another look.

[jira] [Updated] (LUCENE-8518) TestIndexWriter#testSoftUpdateDocuments fails in Elastic CI

2018-09-30 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8518: Attachment: (was: LUCENE-8518.patch) > TestIndexWriter#testSoftUpdateDocuments fails in

[jira] [Created] (LUCENE-8518) TestIndexWriter#testSoftUpdateDocuments fails in Elastic CI

2018-09-30 Thread Nhat Nguyen (JIRA)
Nhat Nguyen created LUCENE-8518: --- Summary: TestIndexWriter#testSoftUpdateDocuments fails in Elastic CI Key: LUCENE-8518 URL: https://issues.apache.org/jira/browse/LUCENE-8518 Project: Lucene - Core

[jira] [Commented] (LUCENE-8506) TestAddIndexes.testAddIndicesWithSoftDeletes() failures

2018-09-19 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620757#comment-16620757 ] Nhat Nguyen commented on LUCENE-8506: - Thanks [~steve_rowe] for linking these issues. >

[jira] [Commented] (LUCENE-8484) Drop fully deleted reader in SubReaderWrapper

2018-09-19 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620687#comment-16620687 ] Nhat Nguyen commented on LUCENE-8484: - [~steve_rowe] Yes. > Drop fully deleted reader in

[jira] [Resolved] (LUCENE-8484) Drop fully deleted reader in SubReaderWrapper

2018-09-19 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen resolved LUCENE-8484. - Resolution: Fixed > Drop fully deleted reader in SubReaderWrapper >

[jira] [Commented] (LUCENE-8484) Drop fully deleted reader in SubReaderWrapper

2018-09-18 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619943#comment-16619943 ] Nhat Nguyen commented on LUCENE-8484: - [~simonw] This change causes testAddIndicesWithSoftDeletes

[jira] [Updated] (LUCENE-8484) Drop fully deleted reader in SubReaderWrapper

2018-09-18 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8484: Attachment: LUCENE-8484.patch > Drop fully deleted reader in SubReaderWrapper >

[jira] [Commented] (LUCENE-8472) Soft-deletes merge retention query should be rewritten

2018-09-03 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602294#comment-16602294 ] Nhat Nguyen commented on LUCENE-8472: - Thanks [~jpountz]. > Soft-deletes merge retention query

[jira] [Created] (LUCENE-8472) Soft-deletes merge retention query should be rewritten

2018-08-29 Thread Nhat Nguyen (JIRA)
Nhat Nguyen created LUCENE-8472: --- Summary: Soft-deletes merge retention query should be rewritten Key: LUCENE-8472 URL: https://issues.apache.org/jira/browse/LUCENE-8472 Project: Lucene - Core

[jira] [Commented] (LUCENE-8471) Expose the number of bytes currently being flushed in IndexWriter

2018-08-29 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596395#comment-16596395 ] Nhat Nguyen commented on LUCENE-8471: - I think we should change only `flushBytes` because we only

[jira] [Commented] (LUCENE-8471) Expose the number of bytes currently being flushed in IndexWriter

2018-08-29 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596380#comment-16596380 ] Nhat Nguyen commented on LUCENE-8471: - Can we make `flushBytes` in DocumentsWriterFlushControl a

[jira] [Commented] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

2018-08-24 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591605#comment-16591605 ] Nhat Nguyen commented on LUCENE-8458: - I pushed this to the master and backported to 7.5. [~simonw] 

[jira] [Comment Edited] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

2018-08-21 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587682#comment-16587682 ] Nhat Nguyen edited comment on LUCENE-8458 at 8/21/18 4:24 PM: -- [~simonw] I

[jira] [Commented] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

2018-08-20 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586488#comment-16586488 ] Nhat Nguyen commented on LUCENE-8458: - [~simonw] ok, I will go back to CodecReader. > Carry-over

[jira] [Commented] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

2018-08-20 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586131#comment-16586131 ] Nhat Nguyen commented on LUCENE-8458: - {quote} * Instead of `getLatestReader();` can we call

[jira] [Commented] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

2018-08-20 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586007#comment-16586007 ] Nhat Nguyen commented on LUCENE-8458: - [~simonw] I've updated the patch. Can you please have another

[jira] [Updated] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

2018-08-20 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8458: Attachment: LUCENE-8458.patch > Carry-over hard-deletes after merge may not adjust soft-delete

[jira] [Updated] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

2018-08-19 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8458: Description: Attached is a test that can trip PendingDeletetes assertion around 5%. The

[jira] [Updated] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

2018-08-19 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8458: Description: Attached is a test that can trip PendingDeletetes assertion around 5%. The

[jira] [Updated] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

2018-08-18 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8458: Attachment: test.patch > Carry-over hard-deletes after merge may not adjust soft-delete count >

[jira] [Created] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

2018-08-18 Thread Nhat Nguyen (JIRA)
Nhat Nguyen created LUCENE-8458: --- Summary: Carry-over hard-deletes after merge may not adjust soft-delete count Key: LUCENE-8458 URL: https://issues.apache.org/jira/browse/LUCENE-8458 Project: Lucene -

[jira] [Commented] (LUCENE-8442) testPendingDeleteDVGeneration fails with NoSuchFileException

2018-08-07 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571663#comment-16571663 ] Nhat Nguyen commented on LUCENE-8442: - Thanks [~jpountz]. > testPendingDeleteDVGeneration fails

[jira] [Created] (LUCENE-8442) testPendingDeleteDVGeneration fails with NoSuchFileException

2018-08-01 Thread Nhat Nguyen (JIRA)
Nhat Nguyen created LUCENE-8442: --- Summary: testPendingDeleteDVGeneration fails with NoSuchFileException Key: LUCENE-8442 URL: https://issues.apache.org/jira/browse/LUCENE-8442 Project: Lucene - Core

[jira] [Commented] (LUCENE-8414) CI fails TestIndexWriter#testSoftUpdateDocuments

2018-07-24 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554552#comment-16554552 ] Nhat Nguyen commented on LUCENE-8414: - Thanks [~simonw]. I committed and backported to 7x. > CI

[jira] [Updated] (LUCENE-8414) CI fails TestIndexWriter#testSoftUpdateDocuments

2018-07-18 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8414: Description: Elastic CI found the following issue. {noformat} [junit4] Suite:

[jira] [Commented] (LUCENE-8414) CI fails TestIndexWriter#testSoftUpdateDocuments

2018-07-18 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548719#comment-16548719 ] Nhat Nguyen commented on LUCENE-8414: - The problem is that SegmentInfos is accessed/updated under IW

[jira] [Assigned] (LUCENE-8414) CI fails TestIndexWriter#testSoftUpdateDocuments

2018-07-18 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen reassigned LUCENE-8414: --- Assignee: Simon Willnauer > CI fails TestIndexWriter#testSoftUpdateDocuments >

[jira] [Updated] (LUCENE-8414) CI fails TestIndexWriter#testSoftUpdateDocuments

2018-07-18 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8414: Attachment: LUCENE-8414-unlucky-schedule.patch > CI fails TestIndexWriter#testSoftUpdateDocuments

[jira] [Created] (LUCENE-8414) CI fails TestIndexWriter#testSoftUpdateDocuments

2018-07-18 Thread Nhat Nguyen (JIRA)
Nhat Nguyen created LUCENE-8414: --- Summary: CI fails TestIndexWriter#testSoftUpdateDocuments Key: LUCENE-8414 URL: https://issues.apache.org/jira/browse/LUCENE-8414 Project: Lucene - Core Issue

[jira] [Commented] (LUCENE-8410) Soft delete optimization never kicks in

2018-07-18 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547793#comment-16547793 ] Nhat Nguyen commented on LUCENE-8410: - +1. LGTM. > Soft delete optimization never kicks in >

[jira] [Commented] (LUCENE-8384) SoftDeleteCount assertion in SoftPendingDeletes violated

2018-07-04 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532856#comment-16532856 ] Nhat Nguyen commented on LUCENE-8384: - +1 LGTM. Thanks [~simonw] for digging. > SoftDeleteCount

[jira] [Updated] (LUCENE-8384) SoftDeleteCount assertion in SoftPendingDeletes violated

2018-07-04 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8384: Description: A spinoff from LUCENE-8381. If a soft-deletes docvalues was applied to

[jira] [Created] (LUCENE-8384) SoftDeleteCount assertion in SoftPendingDeletes violated

2018-07-04 Thread Nhat Nguyen (JIRA)
Nhat Nguyen created LUCENE-8384: --- Summary: SoftDeleteCount assertion in SoftPendingDeletes violated Key: LUCENE-8384 URL: https://issues.apache.org/jira/browse/LUCENE-8384 Project: Lucene - Core

[jira] [Updated] (LUCENE-8381) IW counts hard-deletes as soft-deletes in merges

2018-07-04 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8381: Description: If a document is soft-deleted, then hard-deleted, IW, however, accounts that

[jira] [Updated] (LUCENE-8381) IW counts hard-deletes as soft-deletes in merges

2018-07-04 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8381: Summary: IW counts hard-deletes as soft-deletes in merges (was: PendingSoftDeletes#onNewReader

[jira] [Commented] (LUCENE-8381) PendingSoftDeletes#onNewReader should adjust soft-delete count

2018-07-04 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532664#comment-16532664 ] Nhat Nguyen commented on LUCENE-8381: - [~simonw] I've updated the patch. Can you please have a look?

[jira] [Commented] (LUCENE-8381) PendingSoftDeletes#onNewReader should adjust soft-delete count

2018-07-03 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532192#comment-16532192 ] Nhat Nguyen commented on LUCENE-8381: - [~simonw] Thanks for looking and providing a solution for

[jira] [Updated] (LUCENE-8381) PendingSoftDeletes#onNewReader should adjust soft-delete count

2018-07-03 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8381: Attachment: LUCENE-8381-merge.patch > PendingSoftDeletes#onNewReader should adjust soft-delete

[jira] [Updated] (LUCENE-8381) PendingSoftDeletes#onNewReader should adjust soft-delete count

2018-07-03 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8381: Attachment: LUCENE-8381-inline.patch > PendingSoftDeletes#onNewReader should adjust soft-delete

[jira] [Commented] (LUCENE-8381) PendingSoftDeletes#onNewReader should adjust soft-delete count

2018-07-03 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531741#comment-16531741 ] Nhat Nguyen commented on LUCENE-8381: - [~simonw] Thanks for your quick feedback. I took another

[jira] [Updated] (LUCENE-8381) PendingSoftDeletes#onNewReader should adjust soft-delete count

2018-07-03 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8381: Attachment: merge-soft-hard-deletes.patch > PendingSoftDeletes#onNewReader should adjust

[jira] [Commented] (LUCENE-8381) PendingSoftDeletes#onNewReader should adjust soft-delete count

2018-07-03 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531518#comment-16531518 ] Nhat Nguyen commented on LUCENE-8381: - /cc [~simonw] > PendingSoftDeletes#onNewReader should adjust

[jira] [Created] (LUCENE-8381) PendingSoftDeletes#onNewReader should adjust

2018-07-03 Thread Nhat Nguyen (JIRA)
Nhat Nguyen created LUCENE-8381: --- Summary: PendingSoftDeletes#onNewReader should adjust Key: LUCENE-8381 URL: https://issues.apache.org/jira/browse/LUCENE-8381 Project: Lucene - Core Issue

[jira] [Updated] (LUCENE-8381) PendingSoftDeletes#onNewReader should adjust soft-delete count

2018-07-03 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8381: Summary: PendingSoftDeletes#onNewReader should adjust soft-delete count (was:

[jira] [Commented] (LUCENE-8164) IndexWriter silently accepts broken payload

2018-06-13 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511011#comment-16511011 ] Nhat Nguyen commented on LUCENE-8164: - Thanks [~rcmuir]  and [~simonw] > IndexWriter silently

[jira] [Commented] (LUCENE-8355) IW#writeSomeDocValuesUpdates might open a dropped segment

2018-06-13 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511009#comment-16511009 ] Nhat Nguyen commented on LUCENE-8355: - Thanks [~simonw] > IW#writeSomeDocValuesUpdates might open a

[jira] [Comment Edited] (LUCENE-8355) IW#writeSomeDocValuesUpdates might open a dropped segment

2018-06-12 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510516#comment-16510516 ] Nhat Nguyen edited comment on LUCENE-8355 at 6/13/18 2:04 AM: -- This test

[jira] [Commented] (LUCENE-8355) IW#writeSomeDocValuesUpdates might open a dropped segment

2018-06-12 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510519#comment-16510519 ] Nhat Nguyen commented on LUCENE-8355: - /cc [~simonw] > IW#writeSomeDocValuesUpdates might open a

[jira] [Created] (LUCENE-8355) IW#writeSomeDocValuesUpdates might open a dropped segment

2018-06-12 Thread Nhat Nguyen (JIRA)
Nhat Nguyen created LUCENE-8355: --- Summary: IW#writeSomeDocValuesUpdates might open a dropped segment Key: LUCENE-8355 URL: https://issues.apache.org/jira/browse/LUCENE-8355 Project: Lucene - Core

[jira] [Commented] (LUCENE-8041) All Fields.terms(fld) impls should be O(N) not O(log(N))

2018-06-11 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508636#comment-16508636 ] Nhat Nguyen commented on LUCENE-8041: - I submitted a simple patch that replaces TreeMap by HashMap

[jira] [Updated] (LUCENE-8041) All Fields.terms(fld) impls should be O(N) not O(log(N))

2018-06-11 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8041: Attachment: LUCENE-8041.patch > All Fields.terms(fld) impls should be O(N) not O(log(N)) >

[jira] [Commented] (LUCENE-8164) IndexWriter silently accepts broken payload

2018-06-07 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504689#comment-16504689 ] Nhat Nguyen commented on LUCENE-8164: - [~rcmuir] We are good now. The test throws an

[jira] [Updated] (LUCENE-8164) IndexWriter silently accepts broken payload

2018-06-07 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8164: Attachment: LUCENE-8164.patch > IndexWriter silently accepts broken payload >

[jira] [Commented] (LUCENE-8165) ban Arrays.copyOfRange with forbidden APIs

2018-06-07 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504656#comment-16504656 ] Nhat Nguyen commented on LUCENE-8165: - [~rcmuir] I will look at LUCENE-8164 and post the output. >

[jira] [Commented] (LUCENE-8165) ban Arrays.copyOfRange with forbidden APIs

2018-06-07 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504595#comment-16504595 ] Nhat Nguyen commented on LUCENE-8165: - Thanks everyone! > ban Arrays.copyOfRange with forbidden

[jira] [Commented] (LUCENE-8165) ban Arrays.copyOfRange with forbidden APIs

2018-06-05 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502419#comment-16502419 ] Nhat Nguyen commented on LUCENE-8165: - I've attached a new patch which removes both

[jira] [Updated] (LUCENE-8165) ban Arrays.copyOfRange with forbidden APIs

2018-06-05 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8165: Attachment: LUCENE-8165.patch > ban Arrays.copyOfRange with forbidden APIs >

[jira] [Commented] (LUCENE-8165) ban Arrays.copyOfRange with forbidden APIs

2018-06-04 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500497#comment-16500497 ] Nhat Nguyen commented on LUCENE-8165: - +1: {{copyOfSubArray}} to be more explicit about the fact

[jira] [Commented] (LUCENE-8165) ban Arrays.copyOfRange with forbidden APIs

2018-06-04 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500444#comment-16500444 ] Nhat Nguyen commented on LUCENE-8165: - [~rcmuir] and [~simonw] I've submitted a new patch which

[jira] [Updated] (LUCENE-8165) ban Arrays.copyOfRange with forbidden APIs

2018-06-04 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8165: Attachment: LUCENE-8165-copy-of.patch > ban Arrays.copyOfRange with forbidden APIs >

[jira] [Updated] (LUCENE-8165) ban Arrays.copyOfRange with forbidden APIs

2018-06-04 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8165: Attachment: LUCENE-8165_copy_of.patch > ban Arrays.copyOfRange with forbidden APIs >

[jira] [Updated] (LUCENE-8165) ban Arrays.copyOfRange with forbidden APIs

2018-06-04 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8165: Attachment: (was: LUCENE-8165-copy-of.patch) > ban Arrays.copyOfRange with forbidden APIs >

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-06-04 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500154#comment-16500154 ] Nhat Nguyen commented on LUCENE-8335: - Thanks everyone! > Do not allow changing soft-deletes field

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-06-02 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499210#comment-16499210 ] Nhat Nguyen commented on LUCENE-8335: - [~simonw] I submitted a new patch. Can you please have a look

[jira] [Updated] (LUCENE-8335) Do not allow changing soft-deletes field

2018-06-02 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8335: Attachment: LUCENE-8335.patch > Do not allow changing soft-deletes field >

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-06-02 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499035#comment-16499035 ] Nhat Nguyen commented on LUCENE-8335: - [~simonw] I am looking at this now. > Do not allow changing

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-06-01 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498147#comment-16498147 ] Nhat Nguyen commented on LUCENE-8335: - [~simonw] Thanks for reviewing. I've updated the new patch

[jira] [Updated] (LUCENE-8335) Do not allow changing soft-deletes field

2018-06-01 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8335: Attachment: LUCENE-8335.patch > Do not allow changing soft-deletes field >

[jira] [Commented] (LUCENE-8165) ban Arrays.copyOfRange with forbidden APIs

2018-05-31 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497476#comment-16497476 ] Nhat Nguyen commented on LUCENE-8165: - [~rcmuir] I continued your initial patch and completed the

[jira] [Updated] (LUCENE-8165) ban Arrays.copyOfRange with forbidden APIs

2018-05-31 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8165: Attachment: LUCENE-8165_copy_of_range.patch > ban Arrays.copyOfRange with forbidden APIs >

[jira] [Created] (LUCENE-8335) Do not allow changing soft-deletes field

2018-05-26 Thread Nhat Nguyen (JIRA)
Nhat Nguyen created LUCENE-8335: --- Summary: Do not allow changing soft-deletes field Key: LUCENE-8335 URL: https://issues.apache.org/jira/browse/LUCENE-8335 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-8144) Remove QueryCachingPolicy.ALWAYS_CACHE

2018-05-25 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490618#comment-16490618 ] Nhat Nguyen commented on LUCENE-8144: - Thanks everyone! > Remove QueryCachingPolicy.ALWAYS_CACHE >

[jira] [Updated] (LUCENE-8320) WindowFS#move should consider hard-link when transferring ownership

2018-05-24 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8320: Description: The attached test trips an assertion in `WindowFS#onClose`. (was: The attached test

[jira] [Commented] (LUCENE-8144) Remove QueryCachingPolicy.ALWAYS_CACHE

2018-05-24 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489263#comment-16489263 ] Nhat Nguyen commented on LUCENE-8144: - [~jpountz] I've updated the patch. > Remove

[jira] [Updated] (LUCENE-8144) Remove QueryCachingPolicy.ALWAYS_CACHE

2018-05-24 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8144: Attachment: LUCENE-8144.patch > Remove QueryCachingPolicy.ALWAYS_CACHE >

[jira] [Commented] (LUCENE-8144) Remove QueryCachingPolicy.ALWAYS_CACHE

2018-05-24 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489231#comment-16489231 ] Nhat Nguyen commented on LUCENE-8144: - I attached a patch that moves ALWAYS_CACHE to 

[jira] [Updated] (LUCENE-8144) Remove QueryCachingPolicy.ALWAYS_CACHE

2018-05-24 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8144: Attachment: LUCENE-8144.patch > Remove QueryCachingPolicy.ALWAYS_CACHE >

[jira] [Commented] (LUCENE-8328) ReadersAndUpdates#getLatestReader should execute under lock

2018-05-23 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487143#comment-16487143 ] Nhat Nguyen commented on LUCENE-8328: - Thanks [~simonw] > ReadersAndUpdates#getLatestReader should

[jira] [Commented] (LUCENE-8328) ReadersAndUpdates#getLatestReader should execute under lock

2018-05-22 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486519#comment-16486519 ] Nhat Nguyen commented on LUCENE-8328: - [~simonw] I've updated the test. >

[jira] [Updated] (LUCENE-8328) ReadersAndUpdates#getLatestReader should execute under lock

2018-05-22 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8328: Attachment: LUCENE-8328.patch > ReadersAndUpdates#getLatestReader should execute under lock >

[jira] [Commented] (LUCENE-8328) ReadersAndUpdates#getLatestReader should execute under lock

2018-05-22 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484618#comment-16484618 ] Nhat Nguyen commented on LUCENE-8328: - Sure. I will look at that test class. >

[jira] [Updated] (LUCENE-8328) ReadersAndUpdates#getLatestReader should execute under lock

2018-05-22 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8328: Attachment: (was: LUCENE-8328.patch) > ReadersAndUpdates#getLatestReader should execute under

[jira] [Commented] (LUCENE-8328) ReadersAndUpdates#getLatestReader should execute under lock

2018-05-22 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484572#comment-16484572 ] Nhat Nguyen commented on LUCENE-8328: - /cc [~simonw] > ReadersAndUpdates#getLatestReader should

[jira] [Updated] (LUCENE-8328) ReadersAndUpdates#getLatestReader should execute under lock

2018-05-22 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8328: Description: It's possible for a merge thread to acquire an index reader which is closed before

[jira] [Updated] (LUCENE-8328) ReadersAndUpdates#getLatestReader should execute under lock

2018-05-22 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-8328: Attachment: LUCENE-8328.patch > ReadersAndUpdates#getLatestReader should execute under lock >

  1   2   >