Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r245364034
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,601 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r243646386
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,542 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on the issue:
https://github.com/apache/lucene-solr/pull/525
I forgot to mention: precommit complains about unused imports.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r243649022
--- Diff:
lucene/test-framework/src/java/org/apache/lucene/index/BaseDocValuesFormatTestCase.java
---
@@ -1204,6 +1204,12 @@ public void
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r243647937
--- Diff: lucene/core/src/test/org/apache/lucene/index/TestDocValues.java
---
@@ -123,8 +124,72 @@ public void testNumericField() throws Exception
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r243644347
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java
---
@@ -0,0 +1,1430 @@
+/*
+ * Licensed
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r243644248
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java
---
@@ -0,0 +1,1430 @@
+/*
+ * Licensed
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r243642604
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java
---
@@ -0,0 +1,663 @@
+/*
+ * Licensed
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r243643855
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java
---
@@ -0,0 +1,1430 @@
+/*
+ * Licensed
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r243638367
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,542 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r243641644
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,542 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r243648602
--- Diff:
lucene/test-framework/src/java/org/apache/lucene/index/BaseDocValuesFormatTestCase.java
---
@@ -1204,6 +1204,12 @@ public void
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r243630309
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,542 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r243640446
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,542 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r243630434
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r243629404
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,542 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r243636154
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,542 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r243634870
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,542 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r243625997
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,542 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r243624209
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,542 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r243631028
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,542 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r243628701
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,542 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r242175311
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r242159267
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r242158001
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r242092902
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r241757056
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r241765829
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r241784900
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r241781712
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r241791577
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java
---
@@ -0,0 +1,1413 @@
+/*
+ * Licensed
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r241759363
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r241763714
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r241762452
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r241766560
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r241763587
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r241764037
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r241766876
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r241761075
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r241768318
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r241754841
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r241759598
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r241756515
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/525#discussion_r241754530
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene70/package-info.java ---
@@ -284,12 +284,12 @@
* Stores additional per-position
Github user jpountz commented on the issue:
https://github.com/apache/lucene-solr/pull/522
Sure!
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/521#discussion_r240294342
--- Diff: lucene/CHANGES.txt ---
@@ -268,6 +268,9 @@ Optimizations
can safe up to 80% of the heap used compared to the previous
implementation
Github user jpountz commented on the issue:
https://github.com/apache/lucene-solr/pull/522
For the record, DocIdSetBuilder needs to sort as well if the number of
collected docs is low, but it does it with a pretty fast radix sort
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/521#discussion_r240152127
--- Diff:
lucene/core/src/java/org/apache/lucene/index/NumericDocValuesFieldUpdates.java
---
@@ -53,14 +55,28 @@ BytesRef binaryValue
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/521#discussion_r240152341
--- Diff:
lucene/core/src/java/org/apache/lucene/index/NumericDocValuesFieldUpdates.java
---
@@ -53,14 +55,28 @@ BytesRef binaryValue
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/516#discussion_r239448053
--- Diff:
lucene/backward-codecs/src/java/org/apache/lucene/codecs/lucene70/Lucene70Codec.java
---
@@ -66,7 +67,7 @@ public PostingsFormat
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/516#discussion_r239408003
--- Diff:
lucene/backward-codecs/src/test/org/apache/lucene/index/TestBackwardsCompatibility.java
---
@@ -1587,6 +1590,76 @@ public void
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/516#discussion_r239407845
--- Diff:
lucene/backward-codecs/src/test/org/apache/lucene/index/TestBackwardsCompatibility.java
---
@@ -1587,6 +1590,76 @@ public void
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/513#discussion_r239127024
--- Diff:
lucene/core/src/java/org/apache/lucene/index/FieldUpdatesBuffer.java ---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/513#discussion_r239123489
--- Diff:
lucene/core/src/java/org/apache/lucene/index/FieldUpdatesBuffer.java ---
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/513#discussion_r239116677
--- Diff:
lucene/core/src/java/org/apache/lucene/index/FieldUpdatesBuffer.java ---
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/513#discussion_r239114521
--- Diff: lucene/core/src/java/org/apache/lucene/index/BufferedUpdates.java
---
@@ -288,15 +184,24 @@ void clear() {
deleteTerms.clear
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/513#discussion_r239121847
--- Diff:
lucene/core/src/java/org/apache/lucene/index/FieldUpdatesBuffer.java ---
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/513#discussion_r239115033
--- Diff:
lucene/core/src/java/org/apache/lucene/index/FieldUpdatesBuffer.java ---
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/513#discussion_r239122170
--- Diff:
lucene/core/src/java/org/apache/lucene/index/FieldUpdatesBuffer.java ---
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/513#discussion_r238792876
--- Diff:
lucene/core/src/java/org/apache/lucene/index/FieldUpdatesBuffer.java ---
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/513#discussion_r239014808
--- Diff:
lucene/core/src/java/org/apache/lucene/index/FieldUpdatesBuffer.java ---
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/511#discussion_r237388164
--- Diff: lucene/MIGRATE.txt ---
@@ -150,3 +150,11 @@ in order to support ToParent/ToChildBlockJoinQuery.
Normalization is now type-safe
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/511#discussion_r237388295
--- Diff: lucene/MIGRATE.txt ---
@@ -150,3 +150,11 @@ in order to support ToParent/ToChildBlockJoinQuery.
Normalization is now type-safe
Github user jpountz commented on the issue:
https://github.com/apache/lucene-solr/pull/510
Thanks @cbuescher, the change looks good. I'll merge it provided tests pass.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/503#discussion_r235314171
--- Diff: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ---
@@ -2607,7 +2607,9 @@ synchronized long
publishFrozenUpdates
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/502#discussion_r235312499
--- Diff: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ---
@@ -4398,42 +4429,41 @@ private int mergeMiddle(MergePolicy.OneMerge merge
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r234125357
--- Diff:
lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java ---
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the Apache
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r233506349
--- Diff:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ---
@@ -100,13 +109,156 @@ public CacheHelper getCoreCacheHelper
Github user jpountz commented on the issue:
https://github.com/apache/lucene-solr/pull/497
`ant precommit` is complaining about some missing javadocs, could you
address this? (the solution to some of these issues might be to make classes
private rather than adding docs
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r233043062
--- Diff:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ---
@@ -100,13 +109,157 @@ public CacheHelper getCoreCacheHelper
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r232738909
--- Diff:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ---
@@ -100,13 +109,157 @@ public CacheHelper getCoreCacheHelper
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r232735208
--- Diff:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ---
@@ -100,13 +109,157 @@ public CacheHelper getCoreCacheHelper
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r232740066
--- Diff:
lucene/core/src/test/org/apache/lucene/index/TestExitableDirectoryReader.java
---
@@ -152,13 +150,130 @@ public void
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r232738340
--- Diff:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ---
@@ -100,13 +109,157 @@ public CacheHelper getCoreCacheHelper
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/451#discussion_r218184521
--- Diff:
lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextBKDReader.java
---
@@ -53,15 +54,16 @@
final int version
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/451#discussion_r218197102
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/lucene60/Lucene60FieldInfosFormat.java
---
@@ -149,9 +149,14 @@ public FieldInfos read
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/451#discussion_r218199848
--- Diff: lucene/core/src/java/org/apache/lucene/util/bkd/BKDReader.java ---
@@ -52,10 +53,17 @@
/** Caller must pre-seek the provided {@link
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/446#discussion_r215343578
--- Diff: lucene/core/src/java/org/apache/lucene/search/BooleanWeight.java
---
@@ -40,28 +39,40 @@
/** The Similarity implementation
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/446#discussion_r215343681
--- Diff: lucene/core/src/java/org/apache/lucene/search/BooleanWeight.java
---
@@ -40,28 +39,40 @@
/** The Similarity implementation
Github user jpountz commented on the issue:
https://github.com/apache/lucene-solr/pull/367
Thank you @nyurik.
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h
Github user jpountz commented on the issue:
https://github.com/apache/lucene-solr/pull/345
> instead of directly returning the MatchesIterator
I asked for this change so that you always get a fresh new iterator, even
if you already iterated positions on the same field
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r180496635
--- Diff:
lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java
---
@@ -151,6 +152,17 @@ public Explanation explain
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r180494440
--- Diff: lucene/core/src/java/org/apache/lucene/search/Weight.java ---
@@ -69,6 +69,24 @@ protected Weight(Query query) {
*/
public
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r180492694
--- Diff:
lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java
---
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache
Github user jpountz commented on the issue:
https://github.com/apache/lucene-solr/pull/345
Can we also check that it returns null on non-matching documents?
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r179743866
--- Diff:
lucene/core/src/test/org/apache/lucene/search/TestMatchesIterator.java ---
@@ -0,0 +1,317 @@
+/*
+ * Licensed to the Apache Software
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r179744351
--- Diff: lucene/core/src/java/org/apache/lucene/search/Weight.java ---
@@ -69,6 +69,21 @@ protected Weight(Query query) {
*/
public
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r179741828
--- Diff:
lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r179742139
--- Diff:
lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r179737921
--- Diff:
lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r179737753
--- Diff: lucene/core/src/java/org/apache/lucene/search/Matches.java ---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r179742203
--- Diff:
lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r179688171
--- Diff:
lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r179439888
--- Diff: lucene/core/src/java/org/apache/lucene/search/Matches.java ---
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r179442642
--- Diff:
lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r179442549
--- Diff:
lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r179443149
--- Diff:
solr/core/src/java/org/apache/solr/update/DeleteByQueryWrapper.java ---
@@ -77,6 +78,11 @@ public void extractTerms(Set terms
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r179439647
--- Diff: lucene/core/src/java/org/apache/lucene/search/Matches.java ---
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r179442210
--- Diff:
lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache
Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/345#discussion_r179442909
--- Diff:
lucene/core/src/java/org/apache/lucene/search/MatchesIterator.java ---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software
1 - 100 of 129 matches
Mail list logo
