Github user jpountz commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/451#discussion_r218184521
--- Diff:
lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextBKDReader.java
---
@@ -53,15 +54,16 @@
final int version;
protected final int packedBytesLength;
- public SimpleTextBKDReader(IndexInput in, int numDims, int
maxPointsInLeafNode, int bytesPerDim, long[] leafBlockFPs, byte[]
splitPackedValues,
+ public SimpleTextBKDReader(IndexInput in, int numDataDims, int
numIndexDims, int maxPointsInLeafNode, int bytesPerDim, long[] leafBlockFPs,
byte[] splitPackedValues,
byte[] minPackedValue, byte[] maxPackedValue,
long pointCount, int docCount) throws IOException {
this.in = in;
- this.numDims = numDims;
+ this.numDataDims = numDataDims;
+ this.numIndexDims = numIndexDims;
this.maxPointsInLeafNode = maxPointsInLeafNode;
this.bytesPerDim = bytesPerDim;
// no version check here because callers of this API (SimpleText) have
no back compat:
- bytesPerIndexEntry = numDims == 1 ? bytesPerDim : bytesPerDim + 1;
- packedBytesLength = numDims * bytesPerDim;
+ bytesPerIndexEntry = numDataDims == 1 ? bytesPerDim : bytesPerDim + 1;
+ packedBytesLength = numDataDims * bytesPerDim;
--- End diff --
can we make it numIndexDims on the two above lines?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
