Github user tflobbe commented on the issue:
https://github.com/apache/lucene-solr/pull/429
Sorry @jefferyyuan, I forgot to mention the PR in the commit, so you'll
need to manually close it. Here is the commit:
0af269fb4975e404e07d6e512cfbbac206920672
Github user tflobbe commented on the pull request:
https://github.com/apache/lucene-solr/commit/6db3d9fdd0e955bf496ac7903d0093b16a7be593#commitcomment-30093036
Oh, I'm sorry! I typo'ed the commit message. I was referring to the
annotation `@BadApple` I removed from the code
Github user tflobbe commented on the issue:
https://github.com/apache/lucene-solr/pull/354
You should create a Solr Jira, and then rename this PR to include the Jira
code, that way it'll get visibility
Github user tflobbe commented on the issue:
https://github.com/apache/lucene-solr/pull/312
This was merged already but the committer but not closed. Could you close
@millerjeff0 ?
---
-
To unsubscribe, e-mail: dev
Github user tflobbe commented on the issue:
https://github.com/apache/lucene-solr/pull/350
I didn't look at the change, but you should create a Jira issue in
https://issues.apache.org/jira/projects/SOLR first. Then you can change the
title of the PR to include the Jira code to get
Github user tflobbe commented on the issue:
https://github.com/apache/lucene-solr/pull/342
LGTM, thanks for addressing my comments
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional
Github user tflobbe commented on the issue:
https://github.com/apache/lucene-solr/pull/342
> Perhaps this is better?
I wasn't really asking for any change, I don't like it much, but I know
that's how the related functionality is working. One option would be to cre
Github user tflobbe commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/342#discussion_r176834024
--- Diff:
solr/core/src/java/org/apache/solr/security/AuditLoggerPlugin.java ---
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software
Github user tflobbe commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/342#discussion_r176834866
--- Diff: solr/core/src/java/org/apache/solr/core/CoreContainer.java ---
@@ -328,6 +331,38 @@ private synchronized void
initializeAuthorizationPlugin
Github user tflobbe commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/342#discussion_r176739232
--- Diff: solr/core/src/java/org/apache/solr/core/CoreContainer.java ---
@@ -328,6 +331,38 @@ private synchronized void
initializeAuthorizationPlugin
Github user tflobbe commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/342#discussion_r176735905
--- Diff:
solr/core/src/java/org/apache/solr/security/SolrLogAuditLoggerPlugin.java ---
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache
Github user tflobbe commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/342#discussion_r176736293
--- Diff:
solr/core/src/java/org/apache/solr/security/AuditLoggerPlugin.java ---
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software
Github user tflobbe commented on the issue:
https://github.com/apache/lucene-solr/pull/281
This PR was already merged (SOLR-11692) but wasn't mentioned in the commit
message. Could you close @millerjeff0
Github user tflobbe commented on the issue:
https://github.com/apache/lucene-solr/pull/298
@tommymh Would you mind creating a [Jira
issue](https://issues.apache.org/jira/projects/SOLR) for visibility. You can
also rename this PR to include the Jira code, that way they'll be linked
Github user tflobbe commented on the issue:
https://github.com/apache/lucene-solr/pull/264
I believe this is the same as reported in SOLR-11620
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
Github user tflobbe commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/202#discussion_r137335651
--- Diff:
solr/core/src/test/org/apache/solr/response/TestCustomDocTransformer.java ---
@@ -68,6 +69,51 @@ public void testCustomTransformer() throws
Github user tflobbe commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/202#discussion_r137335160
--- Diff:
solr/core/src/test/org/apache/solr/response/TestCustomDocTransformer.java ---
@@ -68,6 +69,51 @@ public void testCustomTransformer() throws
Github user tflobbe commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/202#discussion_r137335378
--- Diff:
solr/core/src/test/org/apache/solr/response/TestCustomDocTransformer.java ---
@@ -125,4 +171,86 @@ public static String getAsString(String
Github user tflobbe commented on the issue:
https://github.com/apache/lucene-solr/pull/182
This PR can be closed, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user tflobbe closed the pull request at:
https://github.com/apache/lucene-solr/pull/196
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user tflobbe opened a pull request:
https://github.com/apache/lucene-solr/pull/196
SOLR-10233: Add support for different replica types
Code is not done yet (although getting close). Opening the PR to make it
easier to review.
You can merge this pull request into a Git
Github user tflobbe commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/169#discussion_r107959546
--- Diff: solr/core/src/java/org/apache/solr/handler/IndexFetcher.java ---
@@ -161,6 +163,52 @@
private Integer soTimeout
Github user tflobbe commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/169#discussion_r107954150
--- Diff: solr/core/src/java/org/apache/solr/handler/IndexFetcher.java ---
@@ -161,6 +163,52 @@
private Integer soTimeout
Github user tflobbe commented on the issue:
https://github.com/apache/lucene-solr/pull/53
This PR doesn't seem to be linked to any Jira. Is there one? If you include
the Jira issue id in the title of the PR it will automatically show in Jira
(e.g. https://issues.apache.org/jira
24 matches
Mail list logo
