> I found that passing -Ptests.timeoutSuite=500 doesn't have any effect
> that I can see; it didn't interrupt the tests.
It's exactly what I said - without the exclamation mark, this is the
default value of the timeout unless a class has an annotation specifying
other value (which all of Lucene
I found that passing -Ptests.timeoutSuite=500 doesn't have any effect
that I can see; it didn't interrupt the tests. I needed that trailing
exclamation mark for it to do the interrupt. Thanks for that tip. I
don't so much mind this for specific tests that might want to pick
their own timeout
Good to know the gradle task is using these files for help and keeping as
.txt too has its own benefits here.
- Shubham
On Fri, Feb 16, 2024 at 2:03 AM Dawid Weiss wrote:
> One observation though: there are some docs under the help folder (that
>> too as text files) and some under dev-docs. I
>
> One observation though: there are some docs under the help folder (that
> too as text files) and some under dev-docs. I personally feel all these
> should be organized into the dev-docs folder (as .md files for readability
> on github and IDEs), since that was the first place I went to look
I see. This makes more sense; it looks to me like it's fine to add this
info here in case anyone else ever requires it.
One observation though: there are some docs under the help folder (that too
as text files) and some under dev-docs. I personally feel all these should
be organized into the
There's actually quite a lot of docs related to Lucene tests (my remark was
meant at the randomizedtesting package) - see here:
https://github.com/apache/lucene/blob/main/help/tests.txt
The tests.timeoutSuite parameter could be added/ explained there too. I'm
not sure how much it's needed though
I think this information could sit well within the dev-docs in lucene i.e.
"randomized testing in lucene". This would make it more discoverable as
well and there is already a lack of proper docs as Dawid pointed?. We could
add some references to docs like randomized testing core concepts
Sorry, the docs are not the best, I know.
It's documented here -
https://github.com/randomizedtesting/randomizedtesting/blob/master/randomized-runner/src/main/java/com/carrotsearch/randomizedtesting/SysGlobals.java#L186-L197
So:
1) if you pass tests.timeoutSuite=1000 this changes the default
Oh; I didn't know that took precedence -- makes sense. Hopefully a
test subclass (like SolrTestCase) could override it as well.
On Mon, Feb 12, 2024 at 2:09 PM Dawid Weiss wrote:
>
>
> You can override the defaults using sysprops in your CI builds -
>
> -Ptests.timeoutSuite=1000!
>
> takes
You can override the defaults using sysprops in your CI builds -
-Ptests.timeoutSuite=1000!
takes precedence over any annotations (1 second).
Dawid
On Mon, Feb 12, 2024 at 7:53 PM David Smiley wrote:
> Looking at LuceneTestCase, I see the annotation from RandomizedTesting:
>
Looking at LuceneTestCase, I see the annotation from RandomizedTesting:
@TimeoutSuite(millis = 2 * TimeUnits.HOUR)
This matches my observations of some builds that timed out, perhaps
some flaky test hanging in Solr (that extends LuceneTestCase).
Looking at this annotation, there is further
12 matches
Mail list logo
