[GitHub] [lucene-solr] thomaswoeckinger edited a comment on issue #665: Fixes SOLR-13539

2019-09-01 Thread GitBox
thomaswoeckinger edited a comment on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-526961393 Test is failing also before this commit, in both build environments ant and eclipse on my development host, so i ignored it locally. Does not seem to

[GitHub] [lucene-solr] thomaswoeckinger edited a comment on issue #665: Fixes SOLR-13539

2019-07-01 Thread GitBox
thomaswoeckinger edited a comment on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-507243090 > I was able to clean up some of the failures locally by removing the second clause in the if-statement below. (This was added in this PR in

[GitHub] [lucene-solr] thomaswoeckinger edited a comment on issue #665: Fixes SOLR-13539

2019-07-01 Thread GitBox
thomaswoeckinger edited a comment on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-507243090 > I was able to clean up some of the failures locally by removing the second clause in the if-statement below. (This was added in this PR in

[GitHub] [lucene-solr] thomaswoeckinger edited a comment on issue #665: Fixes SOLR-13539

2019-07-01 Thread GitBox
thomaswoeckinger edited a comment on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-507243090 > I was able to clean up some of the failures locally by removing the second clause in the if-statement below. (This was added in this PR in

[GitHub] [lucene-solr] thomaswoeckinger edited a comment on issue #665: Fixes SOLR-13539

2019-06-29 Thread GitBox
thomaswoeckinger edited a comment on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-506257792 Already had time to review? All tests should pass now. This is an automated

[GitHub] [lucene-solr] thomaswoeckinger edited a comment on issue #665: Fixes SOLR-13539

2019-06-22 Thread GitBox
thomaswoeckinger edited a comment on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-504697943 > Hey Thomas, the code compiles and passes `precommit` now, which is a good step, but it looks like there are some test failures that this PR