Github user diegoceccarelli commented on the issue:
https://github.com/apache/lucene-solr/pull/202
Thanks @dsmiley and @michaelbraun, I updated the code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user michaelbraun commented on the issue:
https://github.com/apache/lucene-solr/pull/202
DocTransformer post-implementing Closeable has a close() method but it is
not annotated @Override - it should probably have
---
If your project is set up for it, you can reply to this
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/202
Maybe this should use Solr's `IOUtils.closeQuietly`? It's tempting to use
Lucene's `IOUtils.closeWhileHandlingException` since it'll save us from even
looping here, although that one doesn't
Github user diegoceccarelli commented on the issue:
https://github.com/apache/lucene-solr/pull/202
@m-khl I updated the patch, highlights:
1. I removed `prepare` and relied on the old `setContext()`;
2. now a DocTransformer implements Closeable and provides the method
Github user m-khl commented on the issue:
https://github.com/apache/lucene-solr/pull/202
Here is the overall note: Transformers has already setContext, thus they
can already initialize. Finish logic can be implemented with
SolrRequestInfo.addCloseHook(Closeable)
---
If your
