[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-07 Thread m-khl
Github user m-khl commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r120737742 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DocTransformer.java --- @@ -41,12 +41,26 @@ */ public abstract String

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-07 Thread m-khl
Github user m-khl commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r120736862 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DocTransformers.java --- @@ -88,4 +89,11 @@ public boolean needsSolrIndexSearcher() {

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-07 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r120700095 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DocTransformers.java --- @@ -88,4 +89,11 @@ public boolean

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-07 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r120699437 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DocTransformer.java --- @@ -93,6 +107,12 @@ public void setContext(

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-07 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r120699342 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DocTransformer.java --- @@ -41,12 +41,26 @@ */ public abstract

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-07 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r120698740 --- Diff: solr/core/src/java/org/apache/solr/response/DocsStreamer.java --- @@ -142,6 +142,11 @@ public boolean hasNext() { return

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-07 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r120698022 --- Diff: solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java --- @@ -296,13 +297,13 @@ public void

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-07 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r120697530 --- Diff: solr/contrib/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java --- @@ -187,8 +187,8 @@

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-03 Thread m-khl
Github user m-khl commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r119992969 --- Diff: solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java --- @@ -1210,7 +1211,7 @@ public SolrQueryRequest getRequest()

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-03 Thread m-khl
Github user m-khl commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r119993106 --- Diff: solr/core/src/java/org/apache/solr/response/DocsStreamer.java --- @@ -142,6 +142,11 @@ public boolean hasNext() { return

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-03 Thread m-khl
Github user m-khl commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r119993260 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DocTransformer.java --- @@ -41,12 +41,26 @@ */ public abstract String

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-03 Thread m-khl
Github user m-khl commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r119993013 --- Diff: solr/core/src/java/org/apache/solr/response/BinaryResponseWriter.java --- @@ -119,11 +120,15 @@ public boolean wantsAllFields() {

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-03 Thread m-khl
Github user m-khl commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r119992903 --- Diff: solr/contrib/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java --- @@ -187,8 +187,8 @@ public String

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-03 Thread m-khl
Github user m-khl commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r119992991 --- Diff: solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java --- @@ -296,13 +297,13 @@ public void process(ResponseBuilder

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-03 Thread m-khl
Github user m-khl commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r119993322 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DocTransformer.java --- @@ -93,6 +107,12 @@ public void setContext( ResultContext context

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-03 Thread m-khl
Github user m-khl commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r119993303 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DocTransformers.java --- @@ -88,4 +89,11 @@ public boolean needsSolrIndexSearcher() {

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-05-18 Thread diegoceccarelli
GitHub user diegoceccarelli opened a pull request: https://github.com/apache/lucene-solr/pull/202 SOLR-10703 Add prepare and finish in DocTrasformer This patch adds a prepare and a finish method to the interface of DocTransformer allowing a developer to perform actions before/after