Github user dsmiley closed the pull request at:
https://github.com/apache/lucene-solr/pull/384
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191673559
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilter.java
---
@@ -31,80 +33,106 @@
import
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191633254
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilter.java
---
@@ -31,80 +33,106 @@
import
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191594957
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilter.java
---
@@ -31,80 +33,106 @@
import
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191578308
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilter.java
---
@@ -31,80 +33,106 @@
import
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191574085
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilter.java
---
@@ -119,27 +147,19 @@ public
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191573460
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilter.java
---
@@ -31,80 +33,106 @@
import
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191572617
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilter.java
---
@@ -119,27 +147,19 @@ public boolean
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191571833
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilter.java
---
@@ -31,80 +33,106 @@
import
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191569855
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilter.java
---
@@ -119,27 +147,19 @@ public
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191569307
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilter.java
---
@@ -31,80 +33,106 @@
import
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191568572
--- Diff:
lucene/suggest/src/java/org/apache/lucene/search/suggest/document/NRTSuggesterBuilder.java
---
@@ -43,6 +44,9 @@
* in the output
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191566890
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilterFactory.java
---
@@ -0,0 +1,61 @@
+/*
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191549617
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilterFactory.java
---
@@ -0,0 +1,61 @@
+/*
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191546661
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilter.java
---
@@ -31,80 +33,106 @@
import
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191548433
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilter.java
---
@@ -31,80 +33,106 @@
import
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191551707
--- Diff:
lucene/suggest/src/java/org/apache/lucene/search/suggest/document/NRTSuggesterBuilder.java
---
@@ -43,6 +44,9 @@
* in the output
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191549169
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilter.java
---
@@ -119,27 +147,19 @@ public boolean
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191551615
--- Diff:
lucene/suggest/src/java/org/apache/lucene/search/suggest/document/NRTSuggesterBuilder.java
---
@@ -43,6 +44,9 @@
* in the output
GitHub user dsmiley opened a pull request:
https://github.com/apache/lucene-solr/pull/384
LUCENE-8332 move CompletionTokenStream to ConcatenateGraphFilter
See JIRA issue for overview comments.
You can merge this pull request into a Git repository by running:
$ git pull
20 matches
Mail list logo
