[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010022#comment-13010022
]
Simon Willnauer commented on LUCENE-2310:
-
Hey Chris,
good that you reactivate
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010027#comment-13010027
]
Chris Male commented on LUCENE-2310:
Thanks for taking a look at this Simon.
bq. Why
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010030#comment-13010030
]
Simon Willnauer commented on LUCENE-2310:
-
bq. I don't really understand what
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010032#comment-13010032
]
Chris Male commented on LUCENE-2310:
Yes Field would still compile if you removed the
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010035#comment-13010035
]
Simon Willnauer commented on LUCENE-2310:
-
{quote}
Yeah but not in 3x
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010036#comment-13010036
]
Chris Male commented on LUCENE-2310:
bq. So, what is the reason for doing this in 3.x
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12851794#action_12851794
]
Michael McCandless commented on LUCENE-2310:
I wonder if, like we're thinking
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12851812#action_12851812
]
Chris Male commented on LUCENE-2310:
+1
I think this is a great idea.
Having a clear
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12851819#action_12851819
]
Earwin Burrfoot commented on LUCENE-2310:
-
Yahoo! +1 for introducing barebones
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12851829#action_12851829
]
Shai Erera commented on LUCENE-2310:
+1 for this simplification. Can we just name it
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12851832#action_12851832
]
Chris Male commented on LUCENE-2310:
{quote}
Can we just name it Indexable, and omit
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12851839#action_12851839
]
Earwin Burrfoot commented on LUCENE-2310:
-
Can't we keep interfaces for indexing
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12851842#action_12851842
]
Shai Erera commented on LUCENE-2310:
Right Earwin - agreed.
I'd like to summarize a
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12851844#action_12851844
]
Chris Male commented on LUCENE-2310:
Earwin,
Yeah definitely we want to keep things
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12851849#action_12851849
]
Uwe Schindler commented on LUCENE-2310:
---
I am also +1 on the indexer interface.
I
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12851850#action_12851850
]
Chris Male commented on LUCENE-2310:
Hi Uwe,
I envisaged the Indexable providing
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12851856#action_12851856
]
Uwe Schindler commented on LUCENE-2310:
---
Yeah!
Reduce Fieldable, AbstractField and
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12847898#action_12847898
]
Uwe Schindler commented on LUCENE-2310:
---
I would make the iterator() unmodifiable
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12847914#action_12847914
]
Chris Male commented on LUCENE-2310:
The patch I just attached makes a test in
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12845771#action_12845771
]
Chris Male commented on LUCENE-2310:
Hi Shai,
{quote}
i like the idea of Document to
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12845936#action_12845936
]
Shai Erera commented on LUCENE-2310:
I'm sorry for the confusion - I got used to all
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12845939#action_12845939
]
Chris Male commented on LUCENE-2310:
{quote}
So overall we agree on the changes that
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12845968#action_12845968
]
Shai Erera commented on LUCENE-2310:
That was usually the approach. You provide new
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12845972#action_12845972
]
Chris Male commented on LUCENE-2310:
I recommend we keep it as a List since that
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12846002#action_12846002
]
Shai Erera commented on LUCENE-2310:
I agree. Then keeping both deprecated and new API
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12845702#action_12845702
]
Shai Erera commented on LUCENE-2310:
i like the idea of Document to implement
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12845118#action_12845118
]
Chris Male commented on LUCENE-2310:
Spent more time pondering how to deprecate
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12845122#action_12845122
]
Shai Erera commented on LUCENE-2310:
How about if getFields() will return an
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12845129#action_12845129
]
Chris Male commented on LUCENE-2310:
Hi Shai,
{quote}
How about if getFields() will
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12845130#action_12845130
]
Shai Erera commented on LUCENE-2310:
I can't think of why one would want to know how
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12845135#action_12845135
]
Chris Male commented on LUCENE-2310:
Haha, i whole heartedly agree with all your
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12845134#action_12845134
]
Chris Male commented on LUCENE-2310:
Haha, i whole heartedly agree with all your
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12844923#action_12844923
]
Uwe Schindler commented on LUCENE-2310:
---
You should also not be able to set the
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12844929#action_12844929
]
Chris Male commented on LUCENE-2310:
{quote}
You should also not be able to set the
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12844930#action_12844930
]
Tim Smith commented on LUCENE-2310:
---
Personally, i like keeping Fieldable, (or having
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12844931#action_12844931
]
Earwin Burrfoot commented on LUCENE-2310:
-
These settings will go to FieldType?
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12844933#action_12844933
]
Chris Male commented on LUCENE-2310:
I should note, to prevent confusion, that my
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12844932#action_12844932
]
Chris Male commented on LUCENE-2310:
Hi Tim,
Yeah I see what you are saying, but as
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12844945#action_12844945
]
Uwe Schindler commented on LUCENE-2310:
---
There is one problem in backwards:
If
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12844469#action_12844469
]
Chris Male commented on LUCENE-2310:
The challenge presented in this work is the
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12844178#action_12844178
]
Michael McCandless commented on LUCENE-2310:
+1
Reduce Fieldable,
41 matches
Mail list logo
