[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-04-05 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961050#comment-13961050 ] Uwe Schindler commented on LUCENE-2446: --- But we should take care of it, maybe open

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-04-05 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961051#comment-13961051 ] Robert Muir commented on LUCENE-2446: - It's part of the release workflow. Come on,

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-04-04 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960792#comment-13960792 ] Uwe Schindler commented on LUCENE-2446: --- Hi Robert, I think we should add a Lucene

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-04-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960798#comment-13960798 ] Robert Muir commented on LUCENE-2446: - Absolutely not! 4.8 is not released Add

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-04-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956167#comment-13956167 ] Shai Erera commented on LUCENE-2446: bq. You guys figure out the name for the method,

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-04-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956170#comment-13956170 ] Shai Erera commented on LUCENE-2446: +1 Add checksums to Lucene segment files

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-04-01 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956169#comment-13956169 ] Robert Muir commented on LUCENE-2446: - checkIntegrity is fine with me. We can also

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-04-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956189#comment-13956189 ] ASF subversion and git services commented on LUCENE-2446: - Commit

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-04-01 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956202#comment-13956202 ] Uwe Schindler commented on LUCENE-2446: --- Thanks Robert! {{checkIntegrity()}} is in

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-04-01 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956206#comment-13956206 ] Uwe Schindler commented on LUCENE-2446: --- One idea to make the whole thing more

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-04-01 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956218#comment-13956218 ] Robert Muir commented on LUCENE-2446: - I don't think that its true it only applies to

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-04-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956228#comment-13956228 ] ASF subversion and git services commented on LUCENE-2446: - Commit

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-04-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13957295#comment-13957295 ] ASF subversion and git services commented on LUCENE-2446: - Commit

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-03-31 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955022#comment-13955022 ] Shai Erera commented on LUCENE-2446: This looks really great! +1 Add checksums to

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-03-31 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955073#comment-13955073 ] Michael McCandless commented on LUCENE-2446: +1, this looks wonderful; it

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-03-31 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955080#comment-13955080 ] Simon Willnauer commented on LUCENE-2446: - this is awesome - robert do you think

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-03-31 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955092#comment-13955092 ] Michael McCandless commented on LUCENE-2446: I think the patch is quite solid

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-03-31 Thread Bert Sanders (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955103#comment-13955103 ] Bert Sanders commented on LUCENE-2446: -- Is CRC32 intrinsic available and the same on

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-03-31 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955111#comment-13955111 ] Robert Muir commented on LUCENE-2446: - java.util.zip.CRC32 has been used by lucene

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-03-31 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955129#comment-13955129 ] Simon Willnauer commented on LUCENE-2446: - I glanced at the patch again I think

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-03-31 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955138#comment-13955138 ] Uwe Schindler commented on LUCENE-2446: --- Great! I am not so happy about the method

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-03-31 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955141#comment-13955141 ] Uwe Schindler commented on LUCENE-2446: --- bq. Is CRC32 intrinsic available and the

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-03-31 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955142#comment-13955142 ] Erick Erickson commented on LUCENE-2446: bq: I am not so happy about the method

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-03-31 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955143#comment-13955143 ] Uwe Schindler commented on LUCENE-2446: --- Although its currently only doing file

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-03-31 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955154#comment-13955154 ] Robert Muir commented on LUCENE-2446: - I don't want to do this Uwe. I dont want all

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-03-31 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955162#comment-13955162 ] Uwe Schindler commented on LUCENE-2446: --- Robert, sorry if I throwed some unrelated

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-03-31 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955170#comment-13955170 ] Shai Erera commented on LUCENE-2446: I think {{checkIntegrity}} is too generic (i.e.

[jira] [Commented] (LUCENE-2446) Add checksums to Lucene segment files

2014-03-31 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955173#comment-13955173 ] Robert Muir commented on LUCENE-2446: - You guys figure out the name for the method, i