[jira] [Commented] (LUCENE-3762) Upgrade JUnit to 4.10, refactor state-machine of detecting setUp/tearDown call chaining.

2012-02-15 Thread Dawid Weiss (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208322#comment-13208322 ] Dawid Weiss commented on LUCENE-3762: - Good catch, Steve -- yes, I might have

[jira] [Commented] (LUCENE-3762) Upgrade JUnit to 4.10, refactor state-machine of detecting setUp/tearDown call chaining.

2012-02-14 Thread Dawid Weiss (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207628#comment-13207628 ] Dawid Weiss commented on LUCENE-3762: - I've committed to the trunk and I have a

[jira] [Commented] (LUCENE-3762) Upgrade JUnit to 4.10, refactor state-machine of detecting setUp/tearDown call chaining.

2012-02-14 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207656#comment-13207656 ] Robert Muir commented on LUCENE-3762: - +1 for 3.x too. Upgrade

[jira] [Commented] (LUCENE-3762) Upgrade JUnit to 4.10, refactor state-machine of detecting setUp/tearDown call chaining.

2012-02-14 Thread Steven Rowe (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208137#comment-13208137 ] Steven Rowe commented on LUCENE-3762: - Dawid, today I've seen the following test

[jira] [Commented] (LUCENE-3762) Upgrade JUnit to 4.10, refactor state-machine of detecting setUp/tearDown call chaining.

2012-02-10 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205380#comment-13205380 ] Robert Muir commented on LUCENE-3762: - about the assumes() etc from setup, in general

[jira] [Commented] (LUCENE-3762) Upgrade JUnit to 4.10, refactor state-machine of detecting setUp/tearDown call chaining.

2012-02-10 Thread Dawid Weiss (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205494#comment-13205494 ] Dawid Weiss commented on LUCENE-3762: - This already works on the branch I think, but

[jira] [Commented] (LUCENE-3762) Upgrade JUnit to 4.10, refactor state-machine of detecting setUp/tearDown call chaining.

2012-02-10 Thread Dawid Weiss (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205822#comment-13205822 ] Dawid Weiss commented on LUCENE-3762: - bq. Does this mean if we assumeTrue(message,

[jira] [Commented] (LUCENE-3762) Upgrade JUnit to 4.10, refactor state-machine of detecting setUp/tearDown call chaining.

2012-02-10 Thread Dawid Weiss (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205820#comment-13205820 ] Dawid Weiss commented on LUCENE-3762: - I checked assume/fail/error in combination

[jira] [Commented] (LUCENE-3762) Upgrade JUnit to 4.10, refactor state-machine of detecting setUp/tearDown call chaining.

2012-02-10 Thread Dawid Weiss (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205823#comment-13205823 ] Dawid Weiss commented on LUCENE-3762: - I plan to commit this in on Monday (so that

[jira] [Commented] (LUCENE-3762) Upgrade JUnit to 4.10, refactor state-machine of detecting setUp/tearDown call chaining.

2012-02-09 Thread Dawid Weiss (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204349#comment-13204349 ] Dawid Weiss commented on LUCENE-3762: - Just to clarify: I don't think the state

[jira] [Commented] (LUCENE-3762) Upgrade JUnit to 4.10, refactor state-machine of detecting setUp/tearDown call chaining.

2012-02-09 Thread Dawid Weiss (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204372#comment-13204372 ] Dawid Weiss commented on LUCENE-3762: - There are functional differences between

[jira] [Commented] (LUCENE-3762) Upgrade JUnit to 4.10, refactor state-machine of detecting setUp/tearDown call chaining.

2012-02-09 Thread Dawid Weiss (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204406#comment-13204406 ] Dawid Weiss commented on LUCENE-3762: - If we're changing JUnit perhaps it's worth

[jira] [Commented] (LUCENE-3762) Upgrade JUnit to 4.10, refactor state-machine of detecting setUp/tearDown call chaining.

2012-02-09 Thread Dawid Weiss (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204410#comment-13204410 ] Dawid Weiss commented on LUCENE-3762: - Didn't run the tests yet, doing it in the

[jira] [Commented] (LUCENE-3762) Upgrade JUnit to 4.10, refactor state-machine of detecting setUp/tearDown call chaining.

2012-02-09 Thread Dawid Weiss (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204419#comment-13204419 ] Dawid Weiss commented on LUCENE-3762: - All tests pass for me with this patch. I

[jira] [Commented] (LUCENE-3762) Upgrade JUnit to 4.10, refactor state-machine of detecting setUp/tearDown call chaining.

2012-02-08 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203931#comment-13203931 ] Robert Muir commented on LUCENE-3762: - looks great, lets upgrade! {quote} JUnit 4.10

[jira] [Commented] (LUCENE-3762) Upgrade JUnit to 4.10, refactor state-machine of detecting setUp/tearDown call chaining.

2012-02-08 Thread Dawid Weiss (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203961#comment-13203961 ] Dawid Weiss commented on LUCENE-3762: - I just committed a test case that verifies

[jira] [Commented] (LUCENE-3762) Upgrade JUnit to 4.10, refactor state-machine of detecting setUp/tearDown call chaining.

2012-02-08 Thread Dawid Weiss (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203970#comment-13203970 ] Dawid Weiss commented on LUCENE-3762: - Yes, it would be possible. Either at the

[jira] [Commented] (LUCENE-3762) Upgrade JUnit to 4.10, refactor state-machine of detecting setUp/tearDown call chaining.

2012-02-08 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203975#comment-13203975 ] Robert Muir commented on LUCENE-3762: - its definitely a separate issue... just