[
https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208322#comment-13208322
]
Dawid Weiss commented on LUCENE-3762:
-
Good catch, Steve -- yes, I might have
[
https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207628#comment-13207628
]
Dawid Weiss commented on LUCENE-3762:
-
I've committed to the trunk and I have a
[
https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207656#comment-13207656
]
Robert Muir commented on LUCENE-3762:
-
+1 for 3.x too.
Upgrade
[
https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208137#comment-13208137
]
Steven Rowe commented on LUCENE-3762:
-
Dawid, today I've seen the following test
[
https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205380#comment-13205380
]
Robert Muir commented on LUCENE-3762:
-
about the assumes() etc from setup, in general
[
https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205494#comment-13205494
]
Dawid Weiss commented on LUCENE-3762:
-
This already works on the branch I think, but
[
https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205822#comment-13205822
]
Dawid Weiss commented on LUCENE-3762:
-
bq. Does this mean if we assumeTrue(message,
[
https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205820#comment-13205820
]
Dawid Weiss commented on LUCENE-3762:
-
I checked assume/fail/error in combination
[
https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205823#comment-13205823
]
Dawid Weiss commented on LUCENE-3762:
-
I plan to commit this in on Monday (so that
[
https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204349#comment-13204349
]
Dawid Weiss commented on LUCENE-3762:
-
Just to clarify: I don't think the state
[
https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204372#comment-13204372
]
Dawid Weiss commented on LUCENE-3762:
-
There are functional differences between
[
https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204406#comment-13204406
]
Dawid Weiss commented on LUCENE-3762:
-
If we're changing JUnit perhaps it's worth
[
https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204410#comment-13204410
]
Dawid Weiss commented on LUCENE-3762:
-
Didn't run the tests yet, doing it in the
[
https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204419#comment-13204419
]
Dawid Weiss commented on LUCENE-3762:
-
All tests pass for me with this patch. I
[
https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203931#comment-13203931
]
Robert Muir commented on LUCENE-3762:
-
looks great, lets upgrade!
{quote}
JUnit 4.10
[
https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203961#comment-13203961
]
Dawid Weiss commented on LUCENE-3762:
-
I just committed a test case that verifies
[
https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203970#comment-13203970
]
Dawid Weiss commented on LUCENE-3762:
-
Yes, it would be possible. Either at the
[
https://issues.apache.org/jira/browse/LUCENE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203975#comment-13203975
]
Robert Muir commented on LUCENE-3762:
-
its definitely a separate issue... just
18 matches
Mail list logo