[
https://issues.apache.org/jira/browse/LUCENE-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885151#comment-13885151
]
Ahmet Arslan commented on LUCENE-5353:
--
Thanks for looking into this, Steve. It
[
https://issues.apache.org/jira/browse/LUCENE-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885715#comment-13885715
]
Simon Willnauer commented on LUCENE-5353:
-
can we maybe try to not add setters to
[
https://issues.apache.org/jira/browse/LUCENE-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885727#comment-13885727
]
Steve Rowe commented on LUCENE-5353:
bq. can we maybe try to not add setters to those
[
https://issues.apache.org/jira/browse/LUCENE-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885745#comment-13885745
]
Steve Rowe commented on LUCENE-5353:
Also, Simon, switching from setters to ctor args
[
https://issues.apache.org/jira/browse/LUCENE-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885762#comment-13885762
]
Simon Willnauer commented on LUCENE-5353:
-
bq. I agree in theory, but this class
[
https://issues.apache.org/jira/browse/LUCENE-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885775#comment-13885775
]
Steve Rowe commented on LUCENE-5353:
{quote}
bq. I agree in theory, but this class
[
https://issues.apache.org/jira/browse/LUCENE-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885790#comment-13885790
]
Simon Willnauer commented on LUCENE-5353:
-
bq. I disagree - I don't want to
[
https://issues.apache.org/jira/browse/LUCENE-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885802#comment-13885802
]
Steve Rowe commented on LUCENE-5353:
bq. I disagree here since a global cleanup is
[
https://issues.apache.org/jira/browse/LUCENE-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885803#comment-13885803
]
Simon Willnauer commented on LUCENE-5353:
-
yeah sorry I meant the FILLER_TOKEN
[
https://issues.apache.org/jira/browse/LUCENE-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885912#comment-13885912
]
Simon Willnauer commented on LUCENE-5353:
-
LGTM
ShingleFilter should have a way
[
https://issues.apache.org/jira/browse/LUCENE-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886000#comment-13886000
]
ASF subversion and git services commented on LUCENE-5353:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886038#comment-13886038
]
ASF subversion and git services commented on LUCENE-5353:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841643#comment-13841643
]
Michael McCandless commented on LUCENE-5353:
+1
ShingleFilter should have a
13 matches
Mail list logo
