[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941637#comment-13941637
]
ASF subversion and git services commented on LUCENE-5476:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941638#comment-13941638
]
ASF subversion and git services commented on LUCENE-5476:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941640#comment-13941640
]
ASF subversion and git services commented on LUCENE-5476:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13937580#comment-13937580
]
Gilad Barkai commented on LUCENE-5476:
--
About the scores (the only part I got to
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13937681#comment-13937681
]
Shai Erera commented on LUCENE-5476:
Rob, I reviewed the patch and I agree with Gilad
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13931510#comment-13931510
]
Rob Audenaerde commented on LUCENE-5476:
Hi all,
Making good progress, only I'm
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13931543#comment-13931543
]
Shai Erera commented on LUCENE-5476:
If it's not too much work for you, I think you
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930078#comment-13930078
]
Rob Audenaerde commented on LUCENE-5476:
Thanks again for the good points.
I
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930111#comment-13930111
]
Shai Erera commented on LUCENE-5476:
* Javadocs:
** From the class javadocs: _Note:
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930118#comment-13930118
]
Rob Audenaerde commented on LUCENE-5476:
Thanks Shai, I really appreciate all the
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930121#comment-13930121
]
Shai Erera commented on LUCENE-5476:
bq. Thanks Shai, I really appreciate all the
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925158#comment-13925158
]
Gilad Barkai commented on LUCENE-5476:
--
{quote}
The limit should also take under
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925160#comment-13925160
]
Shai Erera commented on LUCENE-5476:
bq. Asserting seems redundant, but is that not
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13924037#comment-13924037
]
Rob Audenaerde commented on LUCENE-5476:
{quote}
...Given our test framework,
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13924348#comment-13924348
]
Gilad Barkai commented on LUCENE-5476:
--
{quote}
Btw. Is there an easy way to
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13922234#comment-13922234
]
Shai Erera commented on LUCENE-5476:
Thanks Rob. Few comments:
* I don't think that
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13922293#comment-13922293
]
Rob Audenaerde commented on LUCENE-5476:
Thanks Shai,
I have fixed the points
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13922374#comment-13922374
]
Gilad Barkai commented on LUCENE-5476:
--
Hi Rob, patch looks great.
A few comments:
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13922411#comment-13922411
]
Rob Audenaerde commented on LUCENE-5476:
Thanks,
{quote}
when !sampleNeeded()
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13922884#comment-13922884
]
Shai Erera commented on LUCENE-5476:
bq. but any facet accumulation which would rely
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13920642#comment-13920642
]
Rob Audenaerde commented on LUCENE-5476:
Hi all, good points.
Actually, in my
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13920771#comment-13920771
]
Shai Erera commented on LUCENE-5476:
bq. Actually, in my application, I always do a
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13920822#comment-13920822
]
Rob Audenaerde commented on LUCENE-5476:
{quote}
How do you count the number of
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13920897#comment-13920897
]
Shai Erera commented on LUCENE-5476:
bq. Well, I do a search of course, but collect
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919160#comment-13919160
]
Rob Audenaerde commented on LUCENE-5476:
btw:
My use case is that I would like
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919207#comment-13919207
]
Shai Erera commented on LUCENE-5476:
Thanks Rob. Few comments:
* Typo in jdoc: to
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919240#comment-13919240
]
Shai Erera commented on LUCENE-5476:
Looks good Rob. I apologize for not mentioning
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919311#comment-13919311
]
Rob Audenaerde commented on LUCENE-5476:
I will add the documentation to the
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919348#comment-13919348
]
Robert Muir commented on LUCENE-5476:
-
-1 to adding this XOrShiftRandom to
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919380#comment-13919380
]
Gilad Barkai commented on LUCENE-5476:
--
Sorry if this was mentioned before and I
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919559#comment-13919559
]
Shai Erera commented on LUCENE-5476:
That's good point Gilad. I think once this gets
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917888#comment-13917888
]
Rob Audenaerde commented on LUCENE-5476:
More performance data:
Exact: 185 ms.
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917922#comment-13917922
]
Michael McCandless commented on LUCENE-5476:
Patch looks good, and those are
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918017#comment-13918017
]
Rob Audenaerde commented on LUCENE-5476:
Quick update:
I implemented the single
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918164#comment-13918164
]
Shai Erera commented on LUCENE-5476:
+1 for removing SamplingParams.
I'm OK if the
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917407#comment-13917407
]
Shai Erera commented on LUCENE-5476:
I reviewed createSample in the patch, and I
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917414#comment-13917414
]
Rob Audenaerde commented on LUCENE-5476:
Thanks all for the insight!
My
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917072#comment-13917072
]
Robert Muir commented on LUCENE-5476:
-
{quote}
Also, one thing that we did in the old
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917158#comment-13917158
]
Gilad Barkai commented on LUCENE-5476:
--
Great effort!
I wish to through in another
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917165#comment-13917165
]
Shai Erera commented on LUCENE-5476:
About the patch:
* SampledDocs should be static
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917189#comment-13917189
]
Michael McCandless commented on LUCENE-5476:
I don't think we need a sampling
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917304#comment-13917304
]
Shai Erera commented on LUCENE-5476:
I agree Mike. Rob wrote though in a previous
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915650#comment-13915650
]
Rob Audenaerde commented on LUCENE-5476:
I'm currently expermenting with this. To
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915729#comment-13915729
]
Michael McCandless commented on LUCENE-5476:
This looks great!
bq. To
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915762#comment-13915762
]
Shai Erera commented on LUCENE-5476:
This looks like a great start! I have few
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915796#comment-13915796
]
Rob Audenaerde commented on LUCENE-5476:
Thanks guys for the feedback (also on my
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914415#comment-13914415
]
Michael McCandless commented on LUCENE-5476:
+1 to bring it back.
I think we
47 matches
Mail list logo
