[jira] [Commented] (LUCENE-6507) Directory#makeLock is trappy

2015-05-28 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562625#comment-14562625 ] Uwe Schindler commented on LUCENE-6507: --- The naming of this method was always

[jira] [Commented] (LUCENE-6507) Directory#makeLock is trappy

2015-05-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562707#comment-14562707 ] Robert Muir commented on LUCENE-6507: - I disagree with the synopsis. The problem here

[jira] [Commented] (LUCENE-6507) Directory#makeLock is trappy

2015-05-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562733#comment-14562733 ] Robert Muir commented on LUCENE-6507: - Also, LockStressTest from our ant task is not

[jira] [Commented] (LUCENE-6507) Directory#makeLock is trappy

2015-05-28 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562643#comment-14562643 ] Simon Willnauer commented on LUCENE-6507: - yeah this seems to go into the right

[jira] [Commented] (LUCENE-6507) Directory#makeLock is trappy

2015-05-28 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562649#comment-14562649 ] Uwe Schindler commented on LUCENE-6507: --- Yeah. I would like the new behaviour,

[jira] [Commented] (LUCENE-6507) Directory#makeLock is trappy

2015-05-28 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562630#comment-14562630 ] Simon Willnauer commented on LUCENE-6507: - why don't we just hide the obtain call

[jira] [Commented] (LUCENE-6507) Directory#makeLock is trappy

2015-05-28 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562640#comment-14562640 ] Uwe Schindler commented on LUCENE-6507: --- Changing the behaviour of this already

[jira] [Commented] (LUCENE-6507) Directory#makeLock is trappy

2015-05-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562775#comment-14562775 ] Robert Muir commented on LUCENE-6507: - Its precisely the same issue Uwe. See Simon's

[jira] [Commented] (LUCENE-6507) Directory#makeLock is trappy

2015-05-28 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562786#comment-14562786 ] Uwe Schindler commented on LUCENE-6507: --- Robert, thats another bug not related to

[jira] [Commented] (LUCENE-6507) Directory#makeLock is trappy (it does not aquire lock, although its name implies) + NativeFSLock.close() has side effects

2015-05-28 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562794#comment-14562794 ] Uwe Schindler commented on LUCENE-6507: --- As you both don't want to split this

[jira] [Commented] (LUCENE-6507) Directory#makeLock is trappy (it does not aquire lock, although its name implies) + NativeFSLock.close() has side effects

2015-05-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562809#comment-14562809 ] Robert Muir commented on LUCENE-6507: - Well, I think we should try to simplify the

[jira] [Commented] (LUCENE-6507) Directory#makeLock is trappy (it does not aquire lock, although its name implies) + NativeFSLock.close() has side effects

2015-05-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562857#comment-14562857 ] Robert Muir commented on LUCENE-6507: - I still don't like that clearLockHeld calls

[jira] [Commented] (LUCENE-6507) Directory#makeLock is trappy

2015-05-28 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562760#comment-14562760 ] Uwe Schindler commented on LUCENE-6507: --- Hi Robert, I agree, but that is another

[jira] [Commented] (LUCENE-6507) Directory#makeLock is trappy

2015-05-28 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562783#comment-14562783 ] Simon Willnauer commented on LUCENE-6507: - I agree with rob that there is a bug

[jira] [Commented] (LUCENE-6507) Directory#makeLock is trappy

2015-05-28 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562769#comment-14562769 ] Uwe Schindler commented on LUCENE-6507: --- In any case, it would be nice to get a

[jira] [Commented] (LUCENE-6507) Directory#makeLock is trappy

2015-05-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562770#comment-14562770 ] Robert Muir commented on LUCENE-6507: - The main missing thing i see, hopefully it

[jira] [Commented] (LUCENE-6507) Directory#makeLock is trappy

2015-05-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562788#comment-14562788 ] Robert Muir commented on LUCENE-6507: - The separate process is not an issue. see the

[jira] [Commented] (LUCENE-6507) Directory#makeLock is trappy

2015-05-28 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562787#comment-14562787 ] Simon Willnauer commented on LUCENE-6507: - oh nevermind - this is only within the