[jira] [Commented] (LUCENE-6531) Make PhraseQuery immutable

2015-07-30 Thread Terry Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647690#comment-14647690 ] Terry Smith commented on LUCENE-6531: - [~jpountz] The PhraseQuery.Builder setter

[jira] [Commented] (LUCENE-6531) Make PhraseQuery immutable

2015-07-30 Thread Terry Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647701#comment-14647701 ] Terry Smith commented on LUCENE-6531: - Awesome, you rock! Make PhraseQuery

[jira] [Commented] (LUCENE-6531) Make PhraseQuery immutable

2015-07-30 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647699#comment-14647699 ] Adrien Grand commented on LUCENE-6531: -- Thanks Terry for catching this. This issue

[jira] [Commented] (LUCENE-6531) Make PhraseQuery immutable

2015-07-30 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647892#comment-14647892 ] Adrien Grand commented on LUCENE-6531: -- I fixed it through LUCENE-6707. Make

[jira] [Commented] (LUCENE-6531) Make PhraseQuery immutable

2015-07-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644164#comment-14644164 ] ASF subversion and git services commented on LUCENE-6531: - Commit

[jira] [Commented] (LUCENE-6531) Make PhraseQuery immutable

2015-07-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644173#comment-14644173 ] ASF subversion and git services commented on LUCENE-6531: - Commit

[jira] [Commented] (LUCENE-6531) Make PhraseQuery immutable

2015-06-16 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14587986#comment-14587986 ] Adrien Grand commented on LUCENE-6531: -- I agree with you it would make the API

[jira] [Commented] (LUCENE-6531) Make PhraseQuery immutable

2015-06-16 Thread Cao Manh Dat (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14588082#comment-14588082 ] Cao Manh Dat commented on LUCENE-6531: -- I agree that it will be nice if Lucene is

[jira] [Commented] (LUCENE-6531) Make PhraseQuery immutable

2015-06-16 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14587712#comment-14587712 ] Adrien Grand commented on LUCENE-6531: -- I'll commit shortly if there are no

[jira] [Commented] (LUCENE-6531) Make PhraseQuery immutable

2015-06-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14587802#comment-14587802 ] ASF subversion and git services commented on LUCENE-6531: - Commit

[jira] [Commented] (LUCENE-6531) Make PhraseQuery immutable

2015-06-16 Thread Cao Manh Dat (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14587906#comment-14587906 ] Cao Manh Dat commented on LUCENE-6531: -- [~jpountz] : It look like we can modify

[jira] [Commented] (LUCENE-6531) Make PhraseQuery immutable

2015-06-08 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14577463#comment-14577463 ] Adrien Grand commented on LUCENE-6531: -- OK, I'll work on a patch where the builder

[jira] [Commented] (LUCENE-6531) Make PhraseQuery immutable

2015-06-08 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14577466#comment-14577466 ] Michael McCandless commented on LUCENE-6531: +1 for a sane builder API.

[jira] [Commented] (LUCENE-6531) Make PhraseQuery immutable

2015-06-08 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14577396#comment-14577396 ] Robert Muir commented on LUCENE-6531: - I think TermAndPosition is very awkward. Can

[jira] [Commented] (LUCENE-6531) Make PhraseQuery immutable

2015-06-08 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14577414#comment-14577414 ] Adrien Grand commented on LUCENE-6531: -- bq. I think TermAndPosition is very awkward.

[jira] [Commented] (LUCENE-6531) Make PhraseQuery immutable

2015-06-08 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14577440#comment-14577440 ] Robert Muir commented on LUCENE-6531: - As mentioned above I really think it should

[jira] [Commented] (LUCENE-6531) Make PhraseQuery immutable

2015-06-08 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14577421#comment-14577421 ] Robert Muir commented on LUCENE-6531: - Right, I guess I feel there are even more

[jira] [Commented] (LUCENE-6531) Make PhraseQuery immutable

2015-06-08 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14577436#comment-14577436 ] Adrien Grand commented on LUCENE-6531: -- Thanks for the suggestions. So would you be