[
https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314132#comment-15314132
]
Michael McCandless commented on LUCENE-7307:
[~martijn.v.groningen] can this be closed now?
[
https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312275#comment-15312275
]
ASF subversion and git services commented on LUCENE-7307:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312276#comment-15312276
]
ASF subversion and git services commented on LUCENE-7307:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311914#comment-15311914
]
Adrien Grand commented on LUCENE-7307:
--
Thanks Martijn, +1
> Add getters to PointInSetQuery and
[
https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311882#comment-15311882
]
Martijn van Groningen commented on LUCENE-7307:
---
bq. I think the byte[] version was better
[
https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311847#comment-15311847
]
Adrien Grand commented on LUCENE-7307:
--
bq. Also I changed the return type from Collection
[
https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309960#comment-15309960
]
Adrien Grand commented on LUCENE-7307:
--
Maybe the collection should be a view rather than a copy?
[
https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309881#comment-15309881
]
Adrien Grand commented on LUCENE-7307:
--
Should we be defensive and copy the low/high points before
[
https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308721#comment-15308721
]
Michael McCandless commented on LUCENE-7307:
+1
> Add getters to PointInSetQuery and