[jira] [Commented] (LUCENE-7867) Remove deprecated Token class

2017-06-23 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060814#comment-16060814 ] Uwe Schindler commented on LUCENE-7867: --- Thanks! I agree with you, let's remove Tok

[jira] [Commented] (LUCENE-7867) Remove deprecated Token class

2017-06-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060609#comment-16060609 ] ASF subversion and git services commented on LUCENE-7867: - Commit

[jira] [Commented] (LUCENE-7867) Remove deprecated Token class

2017-06-22 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059220#comment-16059220 ] Robert Muir commented on LUCENE-7867: - This clones Token into solr sources without it

[jira] [Commented] (LUCENE-7867) Remove deprecated Token class

2017-06-22 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059012#comment-16059012 ] Adrien Grand commented on LUCENE-7867: -- Can you use {{BytesRef.deepCopyOf}} rather t

[jira] [Commented] (LUCENE-7867) Remove deprecated Token class

2017-06-14 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048787#comment-16048787 ] Alan Woodward commented on LUCENE-7867: --- I opened LUCENE-7877 to replace Prefix/Suf

[jira] [Commented] (LUCENE-7867) Remove deprecated Token class

2017-06-08 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042710#comment-16042710 ] Alan Woodward commented on LUCENE-7867: --- It's fairly fundamentally broken as an Att

[jira] [Commented] (LUCENE-7867) Remove deprecated Token class

2017-06-08 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042696#comment-16042696 ] Robert Muir commented on LUCENE-7867: - Why not just undeprecate token? This seems pre

[jira] [Commented] (LUCENE-7867) Remove deprecated Token class

2017-06-08 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042688#comment-16042688 ] Alan Woodward commented on LUCENE-7867: --- The tricky part for prefix/suffix/concaten

[jira] [Commented] (LUCENE-7867) Remove deprecated Token class

2017-06-07 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040801#comment-16040801 ] Uwe Schindler commented on LUCENE-7867: --- The main problem with this class is: All c

[jira] [Commented] (LUCENE-7867) Remove deprecated Token class

2017-06-07 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040794#comment-16040794 ] Uwe Schindler commented on LUCENE-7867: --- I think this one should use captureState o