[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121501#comment-16121501
]
Ignacio Vera commented on LUCENE-7918:
--
Thanks for the quick fix [~daddywri]! I am not too alarmed
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121483#comment-16121483
]
Karl Wright commented on LUCENE-7918:
-
[~ivera], you can always verify that the types of the two
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121469#comment-16121469
]
ASF subversion and git services commented on LUCENE-7918:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121468#comment-16121468
]
ASF subversion and git services commented on LUCENE-7918:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121465#comment-16121465
]
ASF subversion and git services commented on LUCENE-7918:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121463#comment-16121463
]
Ignacio Vera commented on LUCENE-7918:
--
Note one thing as well. If you remove that, the following
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121460#comment-16121460
]
Karl Wright commented on LUCENE-7918:
-
I agree; that code is incorrect and definitely should not be
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116433#comment-16116433
]
Karl Wright commented on LUCENE-7918:
-
Thanks again for the contribution!
Everything is now
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116431#comment-16116431
]
ASF subversion and git services commented on LUCENE-7918:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116429#comment-16116429
]
ASF subversion and git services commented on LUCENE-7918:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116427#comment-16116427
]
ASF subversion and git services commented on LUCENE-7918:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116233#comment-16116233
]
Karl Wright commented on LUCENE-7918:
-
Hi [~ivera], I think this looks pretty good actually. The new
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115691#comment-16115691
]
Karl Wright commented on LUCENE-7918:
-
Also, [~ivera], Steve Rowe just committed a fix for "ant
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115488#comment-16115488
]
Karl Wright commented on LUCENE-7918:
-
[~ivera], didn't pass documentation-lint. This is what it
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115482#comment-16115482
]
Karl Wright commented on LUCENE-7918:
-
I'm also seeing build warnings compiling this code, e.g.:
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115481#comment-16115481
]
Karl Wright commented on LUCENE-7918:
-
[~ivera], I've been looking at the build.xml code for the
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114386#comment-16114386
]
Karl Wright commented on LUCENE-7918:
-
[~ivera] I like the generics approach very much; I just want
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114380#comment-16114380
]
Karl Wright commented on LUCENE-7918:
-
[~ivera], there is no requirement in Lucene that all classes
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114212#comment-16114212
]
Karl Wright commented on LUCENE-7918:
-
Hi [~ivera],
A word of warning: There's a great deal of
19 matches
Mail list logo