[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808538#comment-16808538
]
ASF subversion and git services commented on LUCENE-7966:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359675#comment-16359675
]
Uwe Schindler commented on LUCENE-7966:
---
FYI: I added some build improvements in Solr that makes
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359674#comment-16359674
]
ASF subversion and git services commented on LUCENE-7966:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359673#comment-16359673
]
ASF subversion and git services commented on LUCENE-7966:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359668#comment-16359668
]
ASF subversion and git services commented on LUCENE-7966:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359667#comment-16359667
]
ASF subversion and git services commented on LUCENE-7966:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359666#comment-16359666
]
ASF subversion and git services commented on LUCENE-7966:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359665#comment-16359665
]
ASF subversion and git services commented on LUCENE-7966:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359627#comment-16359627
]
ASF subversion and git services commented on LUCENE-7966:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359626#comment-16359626
]
ASF subversion and git services commented on LUCENE-7966:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357578#comment-16357578
]
ASF subversion and git services commented on LUCENE-7966:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357259#comment-16357259
]
ASF subversion and git services commented on LUCENE-7966:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357261#comment-16357261
]
ASF subversion and git services commented on LUCENE-7966:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357258#comment-16357258
]
ASF subversion and git services commented on LUCENE-7966:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356806#comment-16356806
]
Uwe Schindler commented on LUCENE-7966:
---
I ran an extensive beasting on the backwards-codecs: No
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356772#comment-16356772
]
Uwe Schindler commented on LUCENE-7966:
---
I also checked the core stuff in a similar way by
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356766#comment-16356766
]
Uwe Schindler commented on LUCENE-7966:
---
FYI, after this patch:
{code:noformat}
bash-4.3$ pwd
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356755#comment-16356755
]
Uwe Schindler commented on LUCENE-7966:
---
Adrien: Right. But that's fixed now.
> build mr-jar and
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356753#comment-16356753
]
Uwe Schindler commented on LUCENE-7966:
---
A small change to patch: I removed the "public" from
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356745#comment-16356745
]
Adrien Grand commented on LUCENE-7966:
--
bq. IMHO, this would not have any impact on real-life codec,
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356740#comment-16356740
]
Uwe Schindler commented on LUCENE-7966:
---
Here is the patch: [^LUCENE-7966-7x-backwards.patch]
>
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356738#comment-16356738
]
Uwe Schindler commented on LUCENE-7966:
---
Hi Robert,
the failing codec is the only one that is in
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356707#comment-16356707
]
Uwe Schindler commented on LUCENE-7966:
---
Hi Robert,
I agree. My proposal that I am working on:
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356418#comment-16356418
]
Robert Muir commented on LUCENE-7966:
-
The issue with backporting to 7x is that we have to modify
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355854#comment-16355854
]
ASF subversion and git services commented on LUCENE-7966:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351783#comment-16351783
]
Uwe Schindler commented on LUCENE-7966:
---
I agree. Let's fix the remaining issue. The CHANGES.txt
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351780#comment-16351780
]
Robert Muir commented on LUCENE-7966:
-
yes we have to proceed with caution. the problem is the
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351778#comment-16351778
]
Uwe Schindler commented on LUCENE-7966:
---
Master may still have the same issue. So let's bake it
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351777#comment-16351777
]
ASF subversion and git services commented on LUCENE-7966:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351711#comment-16351711
]
Uwe Schindler commented on LUCENE-7966:
---
I opened LUCENE-8154 (TODOs for Java 9 minimum
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351692#comment-16351692
]
ASF subversion and git services commented on LUCENE-7966:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351313#comment-16351313
]
Uwe Schindler commented on LUCENE-7966:
---
I pushed the changes to master. I will wait a bit before I
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351312#comment-16351312
]
ASF subversion and git services commented on LUCENE-7966:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350482#comment-16350482
]
Michael McCandless commented on LUCENE-7966:
+1!
Thank you for the detailed tests
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348875#comment-16348875
]
Uwe Schindler commented on LUCENE-7966:
---
Here is the final patch with renamed classes:
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348866#comment-16348866
]
Uwe Schindler commented on LUCENE-7966:
---
Thanks [~jpountz]! In the meantime a did a small
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348526#comment-16348526
]
Adrien Grand commented on LUCENE-7966:
--
+1!
> build mr-jar and use some java 9 methods if available
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347613#comment-16347613
]
Uwe Schindler commented on LUCENE-7966:
---
FYI, here are my changes to [~mikemccand]'s lucenebench to
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347599#comment-16347599
]
Uwe Schindler commented on LUCENE-7966:
---
Hi,
I did some comparing benchmarks using Mike's benchmark
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345193#comment-16345193
]
Uwe Schindler commented on LUCENE-7966:
---
Here is latest patch:
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345192#comment-16345192
]
Uwe Schindler commented on LUCENE-7966:
---
I worked today and made the branch on github up to date:
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308486#comment-16308486
]
Uwe Schindler commented on LUCENE-7966:
---
Sorry for silence on this. I wanted to improve the patch
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187994#comment-16187994
]
Uwe Schindler commented on LUCENE-7966:
---
bq. I had a closer look at the branch and like the
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187782#comment-16187782
]
Adrien Grand commented on LUCENE-7966:
--
I had a closer look at the branch and like the patching
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183079#comment-16183079
]
Dawid Weiss commented on LUCENE-7966:
-
Right, thanks Uwe.
> build mr-jar and use some java 9 methods
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183010#comment-16183010
]
Uwe Schindler commented on LUCENE-7966:
---
[~dweiss]: The patched class files are actually easier to
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182649#comment-16182649
]
Dawid Weiss commented on LUCENE-7966:
-
I keep thinking: is this static replacement of those
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182509#comment-16182509
]
Adrien Grand commented on LUCENE-7966:
--
Now with Java 8
|| File || Time to compress without patch
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182501#comment-16182501
]
Adrien Grand commented on LUCENE-7966:
--
Sure, let me run that.
> build mr-jar and use some java 9
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182499#comment-16182499
]
Uwe Schindler commented on LUCENE-7966:
---
Thanks Adrien!
bq. Results are slightly less good than
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182467#comment-16182467
]
Adrien Grand commented on LUCENE-7966:
--
Here are the results:
|| File || Time to compress without
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182399#comment-16182399
]
Uwe Schindler commented on LUCENE-7966:
---
No problem!
> build mr-jar and use some java 9 methods if
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182348#comment-16182348
]
Adrien Grand commented on LUCENE-7966:
--
Sorry Uwe, I was on vacation while you pinged me and did not
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182276#comment-16182276
]
Uwe Schindler commented on LUCENE-7966:
---
Hi [~mikemccand],
I did some more testing and did not
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174510#comment-16174510
]
Uwe Schindler commented on LUCENE-7966:
---
No idea either!
> build mr-jar and use some java 9
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174500#comment-16174500
]
Michael McCandless commented on LUCENE-7966:
I retested w/ Uwe's patch:
{noformat}
java 8
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172047#comment-16172047
]
Michael McCandless commented on LUCENE-7966:
Thanks [~thetaphi]; I'll retest from your
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170407#comment-16170407
]
Robert Muir commented on LUCENE-7966:
-
thanks for the clarification. yes, that's no change from my
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170388#comment-16170388
]
Uwe Schindler commented on LUCENE-7966:
---
bq. Why exactly is this the case? with my patch maven
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170382#comment-16170382
]
Robert Muir commented on LUCENE-7966:
-
{quote}
WARNING: We cannot support Maven builds here, Maven
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170377#comment-16170377
]
Uwe Schindler commented on LUCENE-7966:
---
I implemented by latest idea based again on Robert's
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170077#comment-16170077
]
Michael McCandless commented on LUCENE-7966:
bq. Michael McCandless: A stupid question: Did
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170027#comment-16170027
]
Uwe Schindler commented on LUCENE-7966:
---
Here is the class remapper: https://paste.apache.org/NUOp
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169838#comment-16169838
]
Uwe Schindler commented on LUCENE-7966:
---
When thinking last night about the whole thing a bit more,
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169835#comment-16169835
]
Uwe Schindler commented on LUCENE-7966:
---
[~mikemccand]: A stupid question: Did you do the benchmark
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169827#comment-16169827
]
Michael McCandless commented on LUCENE-7966:
> Mike, is it possible the benchmark didn't warm
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169480#comment-16169480
]
Uwe Schindler commented on LUCENE-7966:
---
This is just my patch on top of Robert's:
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169476#comment-16169476
]
Uwe Schindler commented on LUCENE-7966:
---
Hi,
I took Robert's latest patch, committed it to my
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169324#comment-16169324
]
Robert Muir commented on LUCENE-7966:
-
Mike, is it possible the benchmark didn't warm up here (or
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169305#comment-16169305
]
Robert Muir commented on LUCENE-7966:
-
{quote}
does the patch even change code related to OrdinalMap?
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169293#comment-16169293
]
Michael McCandless commented on LUCENE-7966:
I tested performance on a large {{OrdinalMap}}:
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168265#comment-16168265
]
Robert Muir commented on LUCENE-7966:
-
Adrien, thanks for benchmarking!
> build mr-jar and use some
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167969#comment-16167969
]
Adrien Grand commented on LUCENE-7966:
--
I did some tests with the Calgary corpus that can be found
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165331#comment-16165331
]
Robert Muir commented on LUCENE-7966:
-
Adrien also mentioned the change to BytesRef.compareTo might
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165323#comment-16165323
]
Robert Muir commented on LUCENE-7966:
-
[~jpountz] Maybe you can experiment with the LZ4 change if you
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163942#comment-16163942
]
Robert Muir commented on LUCENE-7966:
-
I opened LUCENE-7968 for the suggester case failing here, this
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163472#comment-16163472
]
Dawid Weiss commented on LUCENE-7966:
-
I thought it's an intrinsic reaching all the way down to an
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162905#comment-16162905
]
Robert Muir commented on LUCENE-7966:
-
{quote}
There's another dimension to your list: the CPU
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162820#comment-16162820
]
Robert Muir commented on LUCENE-7966:
-
Dawid: i didn't really add new checks in the patch: I
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162704#comment-16162704
]
Dawid Weiss commented on LUCENE-7966:
-
I wholeheartedly agree -- it's fascinating stuff and thanks
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162696#comment-16162696
]
Uwe Schindler commented on LUCENE-7966:
---
bq. As for performance I wonder what the actual gain will
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162653#comment-16162653
]
Dawid Weiss commented on LUCENE-7966:
-
Uwe: I understand the reason for this patch. My point was just
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162647#comment-16162647
]
Uwe Schindler commented on LUCENE-7966:
---
bq. One thing that we lose here is the verbosity of
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162631#comment-16162631
]
Dawid Weiss commented on LUCENE-7966:
-
Overall, pretty neat and an uncharted territory (I didn't see
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162628#comment-16162628
]
Dawid Weiss commented on LUCENE-7966:
-
bq. +
Not if you {{fork=true}} because then the task is
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162581#comment-16162581
]
Uwe Schindler commented on LUCENE-7966:
---
Hi Robert,
this is wonderful. I am happy that our
86 matches
Mail list logo
