[jira] [Commented] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592418#comment-16592418 ] ASF subversion and git services commented on LUCENE-8458: - Commit

[jira] [Commented] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591605#comment-16591605 ] Nhat Nguyen commented on LUCENE-8458: - I pushed this to the master and backported to 7.5. [~simonw] 

[jira] [Commented] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591602#comment-16591602 ] ASF subversion and git services commented on LUCENE-8458: - Commit

[jira] [Commented] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591589#comment-16591589 ] ASF subversion and git services commented on LUCENE-8458: - Commit

[jira] [Commented] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588453#comment-16588453 ] Simon Willnauer commented on LUCENE-8458: - LGTM thanks for the extra iteration! > Carry-over

[jira] [Commented] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587989#comment-16587989 ] Lucene/Solr QA commented on LUCENE-8458: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587559#comment-16587559 ] Simon Willnauer commented on LUCENE-8458: - [~dnhatn] sorry for coming back to this again. I

[jira] [Commented] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587511#comment-16587511 ] Simon Willnauer commented on LUCENE-8458: - LGTM > Carry-over hard-deletes after merge may not

[jira] [Commented] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586488#comment-16586488 ] Nhat Nguyen commented on LUCENE-8458: - [~simonw] ok, I will go back to CodecReader. > Carry-over

[jira] [Commented] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586470#comment-16586470 ] Simon Willnauer commented on LUCENE-8458: - {quote} 2. If you pass a reader containing

[jira] [Commented] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586313#comment-16586313 ] Lucene/Solr QA commented on LUCENE-8458: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586131#comment-16586131 ] Nhat Nguyen commented on LUCENE-8458: - {quote} * Instead of `getLatestReader();` can we call

[jira] [Commented] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586093#comment-16586093 ] Simon Willnauer commented on LUCENE-8458: - here are some comments: * Instead of

[jira] [Commented] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586007#comment-16586007 ] Nhat Nguyen commented on LUCENE-8458: - [~simonw] I've updated the patch. Can you please have another

[jira] [Commented] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585550#comment-16585550 ] Simon Willnauer commented on LUCENE-8458: - Good catch! I do like the change to use SegmentReader

[jira] [Commented] (LUCENE-8458) Carry-over hard-deletes after merge may not adjust soft-delete count

[ https://issues.apache.org/jira/browse/LUCENE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585079#comment-16585079 ] Lucene/Solr QA commented on LUCENE-8458: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote