[
https://issues.apache.org/jira/browse/LUCENE-8796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866437#comment-16866437
]
ASF subversion and git services commented on LUCENE-8796:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866345#comment-16866345
]
ASF subversion and git services commented on LUCENE-8796:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855534#comment-16855534
]
Adrien Grand commented on LUCENE-8796:
--
Hmm it's disappointing it's not making things noticeably
[
https://issues.apache.org/jira/browse/LUCENE-8796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852876#comment-16852876
]
Luca Cavanna commented on LUCENE-8796:
--
I updated the PR and addressed all the comments, here are
[
https://issues.apache.org/jira/browse/LUCENE-8796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837979#comment-16837979
]
David Smiley commented on LUCENE-8796:
--
Luca, you should reference this JIRA issue in your PR title
[
https://issues.apache.org/jira/browse/LUCENE-8796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836467#comment-16836467
]
Luca Cavanna commented on LUCENE-8796:
--
I have updated the PR after applying Yonik's suggestion and
[
https://issues.apache.org/jira/browse/LUCENE-8796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835629#comment-16835629
]
Atri Sharma commented on LUCENE-8796:
-
bq. We could potentially reduce the number of comparisons (at
[
https://issues.apache.org/jira/browse/LUCENE-8796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835628#comment-16835628
]
Luca Cavanna commented on LUCENE-8796:
--
You are right [~ysee...@gmail.com] I will make that change
[
https://issues.apache.org/jira/browse/LUCENE-8796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835613#comment-16835613
]
Atri Sharma commented on LUCENE-8796:
-
+1, nice change!
A few thoughts:
1) We could potentially
[
https://issues.apache.org/jira/browse/LUCENE-8796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835597#comment-16835597
]
Yonik Seeley commented on LUCENE-8796:
--
Hmmm, that looks like it's searching the whole space each
[
https://issues.apache.org/jira/browse/LUCENE-8796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835542#comment-16835542
]
Luca Cavanna commented on LUCENE-8796:
--
I have made the change and played with luceneutil to run
11 matches
Mail list logo