[jira] [Commented] (LUCENE-8804) FieldType attribute map should not be modifiable after freeze

2019-05-20 Thread Vamshi Vijay Nakkirtha (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844189#comment-16844189 ] Vamshi Vijay Nakkirtha commented on LUCENE-8804: Looks clean. Thanks [~jpountz] (y) >

[jira] [Commented] (LUCENE-8804) FieldType attribute map should not be modifiable after freeze

2019-05-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844187#comment-16844187 ] ASF subversion and git services commented on LUCENE-8804: - Commit

[jira] [Commented] (LUCENE-8804) FieldType attribute map should not be modifiable after freeze

2019-05-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844185#comment-16844185 ] ASF subversion and git services commented on LUCENE-8804: - Commit

[jira] [Commented] (LUCENE-8804) FieldType attribute map should not be modifiable after freeze

2019-05-20 Thread Vamshi Vijay Nakkirtha (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844153#comment-16844153 ] Vamshi Vijay Nakkirtha commented on LUCENE-8804: thanks [~jpountz],  [~mikemccand] .

[jira] [Commented] (LUCENE-8804) FieldType attribute map should not be modifiable after freeze

2019-05-20 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844003#comment-16844003 ] Michael McCandless commented on LUCENE-8804: +1 to the issue and patch, great catch, thanks

[jira] [Commented] (LUCENE-8804) FieldType attribute map should not be modifiable after freeze

2019-05-20 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843979#comment-16843979 ] Adrien Grand commented on LUCENE-8804: -- This makes sense to me. [~mikemccand] Any objections? >

[jira] [Commented] (LUCENE-8804) FieldType attribute map should not be modifiable after freeze

2019-05-19 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843390#comment-16843390 ] Lucene/Solr QA commented on LUCENE-8804: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (LUCENE-8804) FieldType attribute map should not be modifiable after freeze

2019-05-18 Thread Vamshi Vijay Nakkirtha (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843119#comment-16843119 ] Vamshi Vijay Nakkirtha commented on LUCENE-8804: Attached patch.  Added unit tests and