[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597058#comment-16597058
]
mosh commented on SOLR-12519:
-
Would adding an fl to ChildDocTransformer be a part of this ticket, or is it a
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596640#comment-16596640
]
ASF subversion and git services commented on SOLR-12519:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596638#comment-16596638
]
ASF subversion and git services commented on SOLR-12519:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596383#comment-16596383
]
David Smiley commented on SOLR-12519:
-
This morning I spent some time carefully indenting the
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596376#comment-16596376
]
ASF subversion and git services commented on SOLR-12519:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596374#comment-16596374
]
ASF subversion and git services commented on SOLR-12519:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595903#comment-16595903
]
mosh commented on SOLR-12519:
-
{quote}The actual number of docs returned could be more than the limit but it
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595456#comment-16595456
]
David Smiley commented on SOLR-12519:
-
As I start to write out the notes on the change in semantics
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595001#comment-16595001
]
David Smiley commented on SOLR-12519:
-
The PR looks good; I'm glad we can support adding nested child
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593457#comment-16593457
]
mosh commented on SOLR-12519:
-
Hey, there was a nasty bug which showed up in the tests, but they now all seem
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593178#comment-16593178
]
mosh commented on SOLR-12519:
-
{quote}I think I like the check for the rootDocId needing to be in the parents
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590297#comment-16590297
]
David Smiley commented on SOLR-12519:
-
Next time I suggest pushing a new commit to the PR so that
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590216#comment-16590216
]
mosh commented on SOLR-12519:
-
{quote}
||Reason||Tests||
|Failed junit
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590156#comment-16590156
]
Lucene/Solr QA commented on SOLR-12519:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589744#comment-16589744
]
mosh commented on SOLR-12519:
-
{quote}Can you investigate [~moshebla]?{quote}
After further investigation it
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589179#comment-16589179
]
David Smiley commented on SOLR-12519:
-
To be clear, the current logic has the effect of index order
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589155#comment-16589155
]
Hoss Man commented on SOLR-12519:
-
bq. AFAIK Hoss Man you originally added the ChildDocTransformer and
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588972#comment-16588972
]
David Smiley commented on SOLR-12519:
-
I presume you hit this error when running a test in IntelliJ.
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588374#comment-16588374
]
mosh commented on SOLR-12519:
-
When I run the tests based off the latest master, I get this rather odd
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588364#comment-16588364
]
mosh commented on SOLR-12519:
-
{quote}found these failures in SolrJ{quote}
On it!
> Support Deeply Nested
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588354#comment-16588354
]
David Smiley commented on SOLR-12519:
-
Yetus thought the patch should be applied to the branch of the
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588215#comment-16588215
]
Lucene/Solr QA commented on SOLR-12519:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579839#comment-16579839
]
David Smiley commented on SOLR-12519:
-
bq. Should the "limit" feature be addressed in this ticket?
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579437#comment-16579437
]
mosh commented on SOLR-12519:
-
{quote}mosh I pushed a feature branch, as you can see. I took your PR, and
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575751#comment-16575751
]
David Smiley commented on SOLR-12519:
-
[~moshebla] I pushed a feature branch, as you can see. I took
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575749#comment-16575749
]
ASF subversion and git services commented on SOLR-12519:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565364#comment-16565364
]
David Smiley commented on SOLR-12519:
-
That sounds useful – definitely a separate issue. Feel free
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565139#comment-16565139
]
mosh commented on SOLR-12519:
-
I'm not sure whether this belongs here, but I have been toying with the
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561432#comment-16561432
]
David Smiley commented on SOLR-12519:
-
I see what you're saying... though some apps/use-cases won't
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561031#comment-16561031
]
mosh commented on SOLR-12519:
-
It has dawned upon me that we do not get matching children's descendant
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549116#comment-16549116
]
mosh commented on SOLR-12519:
-
{quote}See
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545208#comment-16545208
]
David Smiley commented on SOLR-12519:
-
You're correct that we might _inadvertently_ have a situation
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544538#comment-16544538
]
mosh commented on SOLR-12519:
-
{quote}Detecting if child doc X has an ancestor of doc X + N is a matter of
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543976#comment-16543976
]
David Smiley commented on SOLR-12519:
-
Oh I understand now. My suggestion to use
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541487#comment-16541487
]
mosh commented on SOLR-12519:
-
Thanks a lot [~dsmiley], I have uploaded a WIP [pull
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540412#comment-16540412
]
David Smiley commented on SOLR-12519:
-
I can see right away that the issue is that you are using the
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540285#comment-16540285
]
David Smiley commented on SOLR-12519:
-
Feel free to throw up a nocommit patch that just demonstrates
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540169#comment-16540169
]
mosh commented on SOLR-12519:
-
{quote}if you put a trailing '/' at the end of the input, then it's retained
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538769#comment-16538769
]
David Smiley commented on SOLR-12519:
-
If we want end-users (of an analytical sort, mind you) to
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538671#comment-16538671
]
David Smiley commented on SOLR-12519:
-
This needn't be seen as a bunch of extra work; although there
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538657#comment-16538657
]
David Smiley commented on SOLR-12519:
-
Judging from TestPathHierarchyTokenizer (e.g.
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538477#comment-16538477
]
mosh commented on SOLR-12519:
-
{quote}Ultimately we'll want to utilize PathHierarchyTokenizer in some
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537381#comment-16537381
]
David Smiley commented on SOLR-12519:
-
bq. my query is for all the children of "a:b", which contain
43 matches
Mail list logo
