[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604724#comment-16604724
]
ASF subversion and git services commented on SOLR-12625:
Commit 7
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604719#comment-16604719
]
ASF subversion and git services commented on SOLR-12625:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586763#comment-16586763
]
ASF subversion and git services commented on SOLR-12625:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586282#comment-16586282
]
ASF subversion and git services commented on SOLR-12625:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586278#comment-16586278
]
ASF subversion and git services commented on SOLR-12625:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584599#comment-16584599
]
Lucene/Solr QA commented on SOLR-12625:
---
| (/) *{color:green}+1 overall{color}* |
\
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584362#comment-16584362
]
Erick Erickson commented on SOLR-12625:
---
Final patch unless there are objections. T
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583188#comment-16583188
]
Lucene/Solr QA commented on SOLR-12625:
---
| (x) *{color:red}-1 overall{color}* |
\\
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582871#comment-16582871
]
Erick Erickson commented on SOLR-12625:
---
Latest version incorporating David's comme
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581324#comment-16581324
]
Erick Erickson commented on SOLR-12625:
---
[~dsmiley] Thanks! A lot of things moved a
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581158#comment-16581158
]
David Smiley commented on SOLR-12625:
-
Little review
* Overall I'm loving it
* Re
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16580708#comment-16580708
]
Erick Erickson commented on SOLR-12625:
---
Latest iteration, with unit tests (which i
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577764#comment-16577764
]
Erick Erickson commented on SOLR-12625:
---
Nikolay:
Thanks for pointing this out. I'
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575754#comment-16575754
]
David Smiley commented on SOLR-12625:
-
Sounds good. Looking forward to the next patc
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575481#comment-16575481
]
Erick Erickson commented on SOLR-12625:
---
{quote}Can you give a couple examples of w
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575213#comment-16575213
]
David Smiley commented on SOLR-12625:
-
{quote}1> making the code convert to native ty
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575035#comment-16575035
]
Erick Erickson commented on SOLR-12625:
---
{quote}Per chance TestChildDocTransformer?
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574303#comment-16574303
]
Erick Erickson commented on SOLR-12625:
---
OK, here's another cut. It's still a bit i
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574271#comment-16574271
]
David Smiley commented on SOLR-12625:
-
bq. docFetcher is in the SolrIndexSearcher and
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573982#comment-16573982
]
Erick Erickson commented on SOLR-12625:
---
Thanks for looking at this!
{quote}I think
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573893#comment-16573893
]
David Smiley commented on SOLR-12625:
-
Thanks for filing this Erick. I like some of
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572134#comment-16572134
]
Erick Erickson commented on SOLR-12625:
---
Here's a PoC, it has nocommits etc. [~dsmi
22 matches
Mail list logo
