[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862186#comment-16862186
]
Jason Gerlowski commented on SOLR-13331:
> Fixes missing for BinaryField, BoolField, UUIDField
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861909#comment-16861909
]
Jan Høydahl commented on SOLR-13331:
Thanks [~dawinter], [~thomas.woeckinger]. Do SOLR-13538 and
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861903#comment-16861903
]
Thomas Wöckinger commented on SOLR-13331:
-
Created new issue SOLR-13539
> Atomic Update
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861860#comment-16861860
]
Noble Paul commented on SOLR-13331:
---
[~dawinter] can you test this with {{branch_8x}} or {{branch_7_7}}
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861855#comment-16861855
]
DW commented on SOLR-13331:
---
Thanks for the update. New issue opened: SOLR-13538
> Atomic Update Multivalue
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861561#comment-16861561
]
Jan Høydahl commented on SOLR-13331:
Whoever will work on further improvements as discussed after
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861311#comment-16861311
]
DW commented on SOLR-13331:
---
[~janhoy] you mentioned in SOLR-13285 that this item here will address the
issue
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861058#comment-16861058
]
Jan Høydahl commented on SOLR-13331:
Yes, but since the partial solution is released in a product we
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861015#comment-16861015
]
Thomas Wöckinger commented on SOLR-13331:
-
The issue was closed to early, not all types where
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860972#comment-16860972
]
Jan Høydahl commented on SOLR-13331:
Since this is now released in 7.7.2, can we please close this
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860658#comment-16860658
]
Thomas Wöckinger commented on SOLR-13331:
-
Already fixed by this PR
> Atomic Update Multivalue
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846932#comment-16846932
]
Noble Paul commented on SOLR-13331:
---
bq. But the 200 or so other Solr contributors won't.
I think you
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846819#comment-16846819
]
Jason Gerlowski commented on SOLR-13331:
bq. It's not an abstraction. it is an optimization. We
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846379#comment-16846379
]
Noble Paul commented on SOLR-13331:
---
[~thomas.woeckinger] I'm assuming the changes need to be reviewed
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846375#comment-16846375
]
Noble Paul commented on SOLR-13331:
---
bq.but ignoring the "disease" (the broken BAUCS abstraction).
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845818#comment-16845818
]
Jason Gerlowski commented on SOLR-13331:
Also, I haven't forgotten about your PR Thomas. I'm
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845806#comment-16845806
]
Jason Gerlowski commented on SOLR-13331:
bq. We need to ensure that tests run with json+ javabin
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840777#comment-16840777
]
Noble Paul commented on SOLR-13331:
---
bq. I couldn't of said it better myself. Very concerning.
After
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840424#comment-16840424
]
David Smiley commented on SOLR-13331:
-
Jason said:
bq. This seems like a pretty fundamental
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837037#comment-16837037
]
Thomas Wöckinger commented on SOLR-13331:
-
Pushed again, binary values are now supported when
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834889#comment-16834889
]
Thomas Wöckinger commented on SOLR-13331:
-
PR for master created, i can do the same for 8.x and
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834821#comment-16834821
]
Jason Gerlowski commented on SOLR-13331:
Base things off of master, if you can. Generally
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834807#comment-16834807
]
Thomas Wöckinger commented on SOLR-13331:
-
I am finished with testing, found two other issues and
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833692#comment-16833692
]
Jason Gerlowski commented on SOLR-13331:
Yes, if that's how you prefer to package things up.
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833554#comment-16833554
]
Thomas Wöckinger commented on SOLR-13331:
-
I nearly finished refactoring and unit tests, is it
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831535#comment-16831535
]
Jason Gerlowski commented on SOLR-13331:
Hi Thomas, no need. I committed a fix for this, and
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831505#comment-16831505
]
Thomas Wöckinger commented on SOLR-13331:
-
I didn't had time for the issue the last few week, i
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816802#comment-16816802
]
ASF subversion and git services commented on SOLR-13331:
Commit
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809718#comment-16809718
]
ASF subversion and git services commented on SOLR-13331:
Commit
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809716#comment-16809716
]
ASF subversion and git services commented on SOLR-13331:
Commit
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809155#comment-16809155
]
Lucene/Solr QA commented on SOLR-13331:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808100#comment-16808100
]
Noble Paul commented on SOLR-13331:
---
bq.Any thoughts on using {{FieldType.toNativeType}} to correct
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808006#comment-16808006
]
Jason Gerlowski commented on SOLR-13331:
Hi Thomas. Thanks for putting in some real legwork on
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801319#comment-16801319
]
Lucene/Solr QA commented on SOLR-13331:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800763#comment-16800763
]
Thomas Wöckinger commented on SOLR-13331:
-
Additional tests result in problems with following
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798982#comment-16798982
]
Thomas Wöckinger commented on SOLR-13331:
-
Issue #13255 is related to this
> Atomic Update
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796085#comment-16796085
]
Thomas Wöckinger commented on SOLR-13331:
-
I can provide a patch for TextField, but i have to do
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795857#comment-16795857
]
Thomas Wöckinger commented on SOLR-13331:
-
The used field was a TextField. I think unit tests
[
https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795474#comment-16795474
]
Thomas Wöckinger commented on SOLR-13331:
-
The interesting lines of code are from 399 to 403 in
39 matches
Mail list logo
