[jira] [Commented] (SOLR-9912) SimpleFacets - support facet.excludeTerms parameter

2017-02-10 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860924#comment-15860924 ] ASF subversion and git services commented on SOLR-9912: --- Commit

[jira] [Commented] (SOLR-9912) SimpleFacets - support facet.excludeTerms parameter

2017-02-10 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860925#comment-15860925 ] ASF subversion and git services commented on SOLR-9912: --- Commit

[jira] [Commented] (SOLR-9912) SimpleFacets - support facet.excludeTerms parameter

2017-02-09 Thread Shawn Heisey (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860412#comment-15860412 ] Shawn Heisey commented on SOLR-9912: Hmm. The precommit target seems to NOT catch unused imports. I

[jira] [Commented] (SOLR-9912) SimpleFacets - support facet.excludeTerms parameter

2017-02-09 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860374#comment-15860374 ] Mike Drob commented on SOLR-9912: - minor nit: this commit and SOLR-9914 added two unsued imports to

[jira] [Commented] (SOLR-9912) SimpleFacets - support facet.excludeTerms parameter

2017-02-09 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859693#comment-15859693 ] ASF subversion and git services commented on SOLR-9912: --- Commit

[jira] [Commented] (SOLR-9912) SimpleFacets - support facet.excludeTerms parameter

2017-02-09 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859656#comment-15859656 ] ASF subversion and git services commented on SOLR-9912: --- Commit

[jira] [Commented] (SOLR-9912) SimpleFacets - support facet.excludeTerms parameter

2017-02-07 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856222#comment-15856222 ] David Smiley commented on SOLR-9912: Nicely concise :-) +1 to commit [~cpoerschke] > SimpleFacets -

[jira] [Commented] (SOLR-9912) SimpleFacets - support facet.excludeTerms parameter

2017-02-06 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854706#comment-15854706 ] David Smiley commented on SOLR-9912: Looking good. I like the use of {{Predicate.and}}. Might you

[jira] [Commented] (SOLR-9912) SimpleFacets - support facet.excludeTerms parameter

2017-02-02 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850353#comment-15850353 ] David Smiley commented on SOLR-9912: This looks good but the patch is incomplete; it doesn't contain

[jira] [Commented] (SOLR-9912) SimpleFacets - support facet.excludeTerms parameter

2017-02-01 Thread Christine Poerschke (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848299#comment-15848299 ] Christine Poerschke commented on SOLR-9912: --- Jonny and I have been collaborating on this. I think