[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13009599#comment-13009599
]
Michael McCandless commented on LUCENE-2881:
Patch looks great! Only a few
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13009610#comment-13009610
]
Simon Willnauer commented on LUCENE-2881:
-
bq. We still need a header (id +
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13009718#comment-13009718
]
Simon Willnauer commented on LUCENE-2881:
-
Committed to trunk - I will keep this
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13009340#comment-13009340
]
Michael McCandless commented on LUCENE-2881:
OK beast chewed on this for a
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13008892#comment-13008892
]
Simon Willnauer commented on LUCENE-2881:
-
bq. if we open a pre-4.0 SIS, make
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13008778#comment-13008778
]
Michael McCandless commented on LUCENE-2881:
Hmm, but: if we open a pre-4.0
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13008530#comment-13008530
]
Michael McCandless commented on LUCENE-2881:
Patch looks much better -- I
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13008550#comment-13008550
]
Simon Willnauer commented on LUCENE-2881:
-
{quote}
I think we should put header
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13008552#comment-13008552
]
Simon Willnauer commented on LUCENE-2881:
-
bq. Should we backport this to 3.x
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13008116#comment-13008116
]
Michael McCandless commented on LUCENE-2881:
bq. Mike would you be so kind
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001372#comment-13001372
]
Michael McCandless commented on LUCENE-2881:
bq. I had the same thought while
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001443#comment-13001443
]
Yonik Seeley commented on LUCENE-2881:
--
w.r.t. storing FielInfos in the segments
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001534#comment-13001534
]
Simon Willnauer commented on LUCENE-2881:
-
{quote}
Unfortunately, I'm still
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001009#comment-13001009
]
Michael McCandless commented on LUCENE-2881:
Unfortunately, I'm still seeing
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001010#comment-13001010
]
Michael McCandless commented on LUCENE-2881:
Also, I think we should
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001011#comment-13001011
]
Michael McCandless commented on LUCENE-2881:
This is a big patch! Some
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001214#comment-13001214
]
Michael Busch commented on LUCENE-2881:
---
bq. maybe, we should store the FieldInfos
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13000180#comment-13000180
]
Simon Willnauer commented on LUCENE-2881:
-
Thanks for the clarification, michael!
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13000185#comment-13000185
]
Michael Busch commented on LUCENE-2881:
---
bq. I don't see any problems in FieldInfo
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13000438#comment-13000438
]
Michael Busch commented on LUCENE-2881:
---
bq. Can't we sync globally on the
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13000581#comment-13000581
]
Simon Willnauer commented on LUCENE-2881:
-
For the record, robert reverted the
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1228#comment-1228
]
Michael McCandless commented on LUCENE-2881:
bq. I actually renamed it to
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13000153#comment-13000153
]
Michael Busch commented on LUCENE-2881:
---
I mentioned on dev that assigning the same
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12999809#comment-12999809
]
Michael McCandless commented on LUCENE-2881:
One question: we seem to have
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12999848#comment-12999848
]
Michael Busch commented on LUCENE-2881:
---
bq. One question: we seem to have lost
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12997129#comment-12997129
]
Simon Willnauer commented on LUCENE-2881:
-
bq. I fixed a bug in FieldInfos that
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12997252#comment-12997252
]
Michael Busch commented on LUCENE-2881:
---
bq. I think we should initialize the
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12992382#comment-12992382
]
Simon Willnauer commented on LUCENE-2881:
-
bq. All tests pass. I'll commit this
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12992476#comment-12992476
]
Simon Willnauer commented on LUCENE-2881:
-
I just integrated this patch to the
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12992524#comment-12992524
]
Michael Busch commented on LUCENE-2881:
---
Awesome, thanks for letting me know! I
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12992707#comment-12992707
]
Simon Willnauer commented on LUCENE-2881:
-
I actually have some intermitted
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12992038#comment-12992038
]
Simon Willnauer commented on LUCENE-2881:
-
Michael, this looks very good!
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12992156#comment-12992156
]
Simon Willnauer commented on LUCENE-2881:
-
{quote}
New patch that removes the
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12992175#comment-12992175
]
Michael Busch commented on LUCENE-2881:
---
Thanks for reviewing!
bq. I think you
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12992174#comment-12992174
]
Simon Willnauer commented on LUCENE-2881:
-
I gave the patch another glance - here
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12992340#comment-12992340
]
Michael Busch commented on LUCENE-2881:
---
bq. Maybe we can simply implement
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12985844#action_12985844
]
Simon Willnauer commented on LUCENE-2881:
-
bq. Yeah, I was going to do this in the
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12985852#action_12985852
]
Michael Busch commented on LUCENE-2881:
---
It would probably make sense to have a new
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12985853#action_12985853
]
Michael Busch commented on LUCENE-2881:
---
bq. i think we should do that on trunk and
[
https://issues.apache.org/jira/browse/LUCENE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12985959#action_12985959
]
Simon Willnauer commented on LUCENE-2881:
-
bq. Yeah I agree. Hmm maybe I can spend
40 matches
Mail list logo
