RE: lucene-solr:master: LUCENE-7581: don't allow updating a doc values field if it's used in the index sort

2016-12-09 Thread Uwe Schindler
Hi, > > +this.indexSortFields = Arrays.stream(sort.getSort()).map((s) -> > > s.getField()).collect(Collectors.toSet()); > > I'd use method references instead of Lambdas: > > Instead of: map((s) -> s.getField()) > Use: map(s::getField) Correction: map(SortField::getField) > This spares a

Re: lucene-solr:master: LUCENE-7581: don't allow updating a doc values field if it's used in the index sort

2016-12-09 Thread Michael McCandless
Thanks Uwe, I'll fix. Mike McCandless http://blog.mikemccandless.com On Fri, Dec 9, 2016 at 6:25 PM, Uwe Schindler wrote: > Hi, > >> +this.indexSortFields = Arrays.stream(sort.getSort()).map((s) -> >> s.getField()).collect(Collectors.toSet()); > > I'd use method

RE: lucene-solr:master: LUCENE-7581: don't allow updating a doc values field if it's used in the index sort

2016-12-09 Thread Uwe Schindler
Hi, > +this.indexSortFields = Arrays.stream(sort.getSort()).map((s) -> > s.getField()).collect(Collectors.toSet()); I'd use method references instead of Lambdas: Instead of: map((s) -> s.getField()) Use: map(s::getField) This spares a synthetic lambda$xxx method that clutters stack trace