I made a PR three days ago and linked it in the Jira.
https://github.com/apache/solr/pull/96/files
wunder
Walter Underwood
wun...@wunderwood.org
http://observer.wunderwood.org/ (my blog)
> On Mar 23, 2021, at 2:33 PM, Anshum Gupta wrote:
>
> Hi Walter,
>
> Can you please create a PR, as Ab
We should update the documentation to point to making PRs.
On Wed, Mar 24, 2021 at 10:30 AM Ishan Chattopadhyaya
wrote:
>
> I don't think asking contributors to do more work than required (as per
> documentation) is a good idea.
>
> On Wed, 24 Mar, 2021, 10:13 am Atri Sharma, wrote:
>>
>> I
I don't think asking contributors to do more work than required (as per
documentation) is a good idea.
On Wed, 24 Mar, 2021, 10:13 am Atri Sharma, wrote:
> I did share steps for your reference the last time we talked about this:
>
>
>
I did share steps for your reference the last time we talked about this:
https://markmail.org/message/2buvbboyoy7ip4v7?q=list:org%2Eapache%2Elucene%2Esolr-dev
On Wed, Mar 24, 2021 at 9:57 AM Walter Underwood wrote:
>
> If patches are hard for people, then the How to Contribute page needs to be
If patches are hard for people, then the How to Contribute page needs to be
rewritten to tell people to create PRs. I followed that page when doing this
work.
It should have specific instructions on how to make PRs, maybe branch naming,
etc. I make PRs all day at work, but I never use github
+1
I tried reviewing the patch and echoed AB's point of needing a PR. Happy to
do the review as soon as we have that.
On Wed, 24 Mar 2021, 03:04 Anshum Gupta, wrote:
> Hi Walter,
>
> Can you please create a PR, as Ab mentioned in the JIRA. That would make
> it much easier to review considering
Hi Walter,
Can you please create a PR, as Ab mentioned in the JIRA. That would make it
much easier to review considering the size of the patch. It will also be
easier to comment and iterate that way.
-Anshum
On Tue, Mar 23, 2021 at 2:24 PM Walter Underwood
wrote:
> The patch for SOLR-15056
