Re: Review Request 24220: Split clusterstate.json per collection and watch states selectively.

2014-09-03 Thread Mark Miller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24220/ --- (Updated Sept. 3, 2014, 6:52 p.m.) Review request for lucene. Changes

Re: Review Request 24220: Split clusterstate.json per collection and watch states selectively.

2014-09-03 Thread Mark Miller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24220/ --- (Updated Sept. 3, 2014, 8:30 p.m.) Review request for lucene. Changes

Re: Review Request 24220: Split clusterstate.json per collection and watch states selectively.

2014-09-03 Thread Noble Paul
The changes are not much from my patch , so , it looks fine On Wed, Sep 3, 2014 at 1:30 PM, Mark Miller markrmil...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24220/ Review request for lucene. By Mark Miller. *Updated

Re: Review Request 24220: Split clusterstate.json per collection and watch states selectively.

2014-09-03 Thread Mark Miller
Yeah, like I said, the main sticking points after we agreed on the architecture change and you pulled zkstatereader from clusterstate were the doc and some naming. I didn't change how anything was done. There is more I'd like to do in terms of refactoring, but I don't have the time short term

Re: Review Request 24220: Split clusterstate.json per collection and watch states selectively.

2014-09-02 Thread Mark Miller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24220/ --- (Updated Sept. 2, 2014, 5:28 p.m.) Review request for lucene. Repository:

Review Request 24220: Split clusterstate.json per collection and watch states selectively.

2014-08-03 Thread Mark Miller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24220/ --- Review request for lucene. Repository: lucene Description --- Split

Re: Review Request 24220: Split clusterstate.json per collection and watch states selectively.

2014-08-03 Thread Mark Miller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24220/ --- (Updated Aug. 4, 2014, 12:04 a.m.) Review request for lucene. Changes