[jira] [Commented] (SOLR-2597) XmlCharFilter

2011-06-16 Thread Mike Sokolov (JIRA)
we rely on Java 6 there? I agree that having a static parser is distasteful, but it's a performance optimization. It tends to be expensive to instantiate these parsers. I'm not clear on what the object lifecycle for the XmlCharFilter is exactly - Robert are you saying the factory is long

[jira] [Commented] (SOLR-2597) XmlCharFilter

2011-06-16 Thread Robert Muir (JIRA)
things up-front to configure themselves (parsing files etc) XmlCharFilter - Key: SOLR-2597 URL: https://issues.apache.org/jira/browse/SOLR-2597 Project: Solr Issue Type: Improvement Components: Schema and Analysis

[jira] [Updated] (SOLR-2597) XmlCharFilter

2011-06-16 Thread Mike Sokolov (JIRA)
in the factory rather than being maintained as a static in the reader class. XmlCharFilter - Key: SOLR-2597 URL: https://issues.apache.org/jira/browse/SOLR-2597 Project: Solr Issue Type: Improvement Components: Schema

Re: XmlCharFilter

2011-06-15 Thread Erick Erickson
XmlCharFilter, which uses the Woodstox XML parser (already used by Solr).  I think this could be useful for others, and it would be nice for me if it were committed here, so I'd like to contribute.  Should I open a JIRA for this?  Is there anybody that can spare the time to review?  It is basically one

Re: XmlCharFilter

2011-06-15 Thread Simon Willnauer
(understands XML entities defined in an internal or external DTD, for example).  So I wrote XmlCharFilter, which uses the Woodstox XML parser (already used by Solr).  I think this could be useful for others, and it would be nice for me if it were committed here, so I'd like to contribute.  Should I

Re: XmlCharFilter

2011-06-15 Thread Mike Sokolov
standard XML parsing (understands XML entities defined in an internal or external DTD, for example). So I wrote XmlCharFilter, which uses the Woodstox XML parser (already used by Solr). I think this could be useful for others, and it would be nice for me if it were committed here, so I'd like

[jira] [Created] (SOLR-2597) XmlCharFilter

2011-06-15 Thread Mike Sokolov (JIRA)
XmlCharFilter - Key: SOLR-2597 URL: https://issues.apache.org/jira/browse/SOLR-2597 Project: Solr Issue Type: Improvement Components: Schema and Analysis Affects Versions: 4.0 Reporter: Mike Sokolov

Re: [jira] [Created] (SOLR-2597) XmlCharFilter

2011-06-15 Thread Koji Sekiguchi
Did you mean Xml*Strip*CharFilter? koji -- http://www.rondhuit.com/en/ (11/06/15 22:12), Mike Sokolov (JIRA) wrote: XmlCharFilter - Key: SOLR-2597 URL: https://issues.apache.org/jira/browse/SOLR-2597 Project: Solr Issue

Re: [jira] [Created] (SOLR-2597) XmlCharFilter

2011-06-15 Thread Mike Sokolov
Perhaps that name would be more consistent with HTMLStripCharFilter, yes, but it wasn't the one I was using. Also - I mean to post a patch here, but left the important files on a machine which is inaccessible at the moment, so I will post this evening. -Mike On 06/15/2011 09:28 AM, Koji

[jira] [Updated] (SOLR-2597) XmlCharFilter

2011-06-15 Thread Mike Sokolov (JIRA)
-asl-xxx.jar. XmlCharFilter - Key: SOLR-2597 URL: https://issues.apache.org/jira/browse/SOLR-2597 Project: Solr Issue Type: Improvement Components: Schema and Analysis Affects Versions: 4.0 Reporter

[jira] [Commented] (SOLR-2597) XmlCharFilter

2011-06-15 Thread Hoss Man (JIRA)
on the mailing list, might want to consider naming this XmlStripCharFilter ... that was my first opinion, but reading the docs the include and exclude options definitely make it a bit more generic, so i'm leaning towards the opinion that XmlCharFilter is better. (there's an argument to be made that we

XmlCharFilter

2011-06-14 Thread Michael Sokolov
or external DTD, for example). So I wrote XmlCharFilter, which uses the Woodstox XML parser (already used by Solr). I think this could be useful for others, and it would be nice for me if it were committed here, so I'd like to contribute. Should I open a JIRA for this? Is there anybody that can