Re: nocommit committed in SolrCore.java

2010-10-25 Thread Michael McCandless
Meier-Allee 63, D-28213 Bremen > http://www.thetaphi.de > eMail: u...@thetaphi.de > > >> -Original Message- >> From: Michael McCandless [mailto:luc...@mikemccandless.com] >> Sent: Monday, October 25, 2010 11:19 AM >> To: dev@lucene.apache.org >> Subj

RE: nocommit committed in SolrCore.java

2010-10-25 Thread Uwe Schindler
ndless [mailto:luc...@mikemccandless.com] > Sent: Monday, October 25, 2010 11:19 AM > To: dev@lucene.apache.org > Subject: Re: nocommit committed in SolrCore.java > > On Mon, Oct 25, 2010 at 2:12 AM, Chris Hostetter > wrote: > > > > : Now we are nocommit-free on trunk &am

Re: nocommit committed in SolrCore.java

2010-10-25 Thread Michael McCandless
On Mon, Oct 25, 2010 at 2:12 AM, Chris Hostetter wrote: > > : Now we are nocommit-free on trunk & 3.x. > > FWIW: we can make hudson fail the build if "nocommit" is found anywhere in > the source. > > Just an idea if people are intersted. +1! I can do this easily w/ Python... but does hudson have

Re: nocommit committed in SolrCore.java

2010-10-24 Thread Chris Hostetter
: Now we are nocommit-free on trunk & 3.x. FWIW: we can make hudson fail the build if "nocommit" is found anywhere in the source. Just an idea if people are intersted. -Hoss - To unsubscribe, e-mail: dev-unsubscr...@lucene.a

Re: nocommit committed in SolrCore.java

2010-10-24 Thread Michael McCandless
Super, thanks! Now we are nocommit-free on trunk & 3.x. Mike On Sun, Oct 24, 2010 at 7:33 AM, Mark Miller wrote: > Removed - added it while working on solrcloud, then made an issue to > make the behavior change (and committed), but forgot to remove the > nocommit from the cloud patch before com

Re: nocommit committed in SolrCore.java

2010-10-24 Thread Mark Miller
Removed - added it while working on solrcloud, then made an issue to make the behavior change (and committed), but forgot to remove the nocommit from the cloud patch before committing. - Mark On 10/24/10 6:55 AM, Michael McCandless wrote: > Anyone know what's up with this one? > > solr/src/java/

nocommit committed in SolrCore.java

2010-10-24 Thread Michael McCandless
Anyone know what's up with this one? solr/src/java/org/apache/solr/core/SolrCore.java: // nocommit: why did solrconfig override core descriptor !? Can we remove it? Change to TODO? Mike - To unsubscribe, e-mail: dev-unsub