[jira] [Comment Edited] (SOLR-3582) Leader election zookeeper watcher is responding to con/discon notifications incorrectly.
[ https://issues.apache.org/jira/browse/SOLR-3582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402851#comment-13402851 ] Trym Møller edited comment on SOLR-3582 at 6/28/12 5:13 AM: Debugging the provided test shows this behaviour as well, that is, the Watch is kept even though, its notified about disConnection and syncConnection and the Watch will first stop after it has been notified about a node change. As Mark writes on the mailing list, there might be other ZooKeeper Watchers in Solr which might add new watchers on reconnect. If we agree about the ZooKeeper watcher behaviour, then I think that the provided bug fix solves the problem in the LeaderElector and it can be committed to svn independently of problems with other watchers. Are there other things I can do to show, that the provided solution is the right one? Best regards Trym was (Author: trym): Debugging the provided test shows this behaviour as well, that is, the Watch is kept even though, its notified about disConnection and syncConnection and the Watch will first stop after it has been notified about a node change. As Mark writes on the mailing list, there might be other ZooKeeper Watchers in Solr which might add new watchers on reconnect. If we agree about the ZooKeeper watcher behaviour, then I think that the provided bug fix solves the problem in the LeaderElector and it can be committed to svn independently of problems with other watchers. Are there other things I can do, to show that the solution is the right one? Best regards Trym Leader election zookeeper watcher is responding to con/discon notifications incorrectly. Key: SOLR-3582 URL: https://issues.apache.org/jira/browse/SOLR-3582 Project: Solr Issue Type: Bug Reporter: Mark Miller Assignee: Mark Miller Priority: Minor Fix For: 4.0, 5.0 As brought up by Trym R. Møller on the mailing list, we are responding to watcher events about connection/disconnection as if they were notifications about node changes. http://www.lucidimagination.com/search/document/e13ef390b882 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-3582) Leader election zookeeper watcher is responding to con/discon notifications incorrectly.
[ https://issues.apache.org/jira/browse/SOLR-3582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402851#comment-13402851 ] Trym Møller edited comment on SOLR-3582 at 6/28/12 5:12 AM: Debugging the provided test shows this behaviour as well, that is, the Watch is kept even though, its notified about disConnection and syncConnection and the Watch will first stop after it has been notified about a node change. As Mark writes on the mailing list, there might be other ZooKeeper Watchers in Solr which might add new watchers on reconnect. If we agree about the ZooKeeper watcher behaviour, then I think that the provided bug fix solves the problem in the LeaderElector and it can be committed to svn independently of problems with other watchers. Are there other things I can do, to show that the solution is the right one? Best regards Trym was (Author: trym): Debugging the provided test shows this behaviour as well, that is, the Watch is kept even though, its notified about disConnection and syncConnection and the Watch will first stop after it has been notified about a node change. As Mark writes on the mailing list, there might be other ZooKeeper Watchers in Solr which might add new watchers on reconnect. If we agree about the ZooKeeper watcher behaviour, then I think that the provided bug fix solves the problem in the LeaderElector and it can be committed to svn independently of problems with other watchers. Best regards Trym Leader election zookeeper watcher is responding to con/discon notifications incorrectly. Key: SOLR-3582 URL: https://issues.apache.org/jira/browse/SOLR-3582 Project: Solr Issue Type: Bug Reporter: Mark Miller Assignee: Mark Miller Priority: Minor Fix For: 4.0, 5.0 As brought up by Trym R. Møller on the mailing list, we are responding to watcher events about connection/disconnection as if they were notifications about node changes. http://www.lucidimagination.com/search/document/e13ef390b882 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402865#comment-13402865 ] Chris Male commented on LUCENE-4167: A follow up to this patch is to break out the operation specific makeXXXQuery/Filter into their own interfaces so the concrete Strategys can declare what operations they support. We would strip SpatialStrategy back to just having createFields and then each operation specific interface (say IntersectsStrategy) would extend it. If a concrete Strategy didnt care for any of the standard operations, then it could just implement SpatialStrategy and do what it likes. However those we have currently could implement IntersectsStrategy, and TwoDoubles could implement DisjointStrategy. I'll update the patch. Remove the use of SpatialOperation -- Key: LUCENE-4167 URL: https://issues.apache.org/jira/browse/LUCENE-4167 Project: Lucene - Java Issue Type: Bug Components: modules/spatial Reporter: Chris Male Attachments: LUCENE-4167.patch Looking at the code in TwoDoublesStrategy I noticed SpatialOperations.BBoxWithin vs isWithin which confused me. Looking over the other Strategys I see that really only isWithin and Intersects is supported. Only TwoDoublesStrategy supports IsDisjointTo. The remainder of SpatialOperations are not supported. I don't think we should use SpatialOperation as this stage since it is not clear what Operations are supported by what Strategys, many Operations are not supported, and the code for handling the Operations is usually the same. We can spin off the code for TwoDoublesStrategy's IsDisjointTo support into a different Strategy. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation
[
https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402867#comment-13402867
]
David Smiley commented on LUCENE-4167:
--
I looked at the patch. {{shrug}} Some things are marginally simpler but it
seems like a step back for supporting anything other than one spatial
operation. Please hold off for a few days before committing without more
consensus; I'd like to hear Ryan's point of view on this issue as it's a big
deal.
Remove the use of SpatialOperation
--
Key: LUCENE-4167
URL: https://issues.apache.org/jira/browse/LUCENE-4167
Project: Lucene - Java
Issue Type: Bug
Components: modules/spatial
Reporter: Chris Male
Attachments: LUCENE-4167.patch
Looking at the code in TwoDoublesStrategy I noticed
SpatialOperations.BBoxWithin vs isWithin which confused me. Looking over the
other Strategys I see that really only isWithin and Intersects is supported.
Only TwoDoublesStrategy supports IsDisjointTo. The remainder of
SpatialOperations are not supported.
I don't think we should use SpatialOperation as this stage since it is not
clear what Operations are supported by what Strategys, many Operations are
not supported, and the code for handling the Operations is usually the same.
We can spin off the code for TwoDoublesStrategy's IsDisjointTo support into a
different Strategy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402870#comment-13402870 ] Chris Male commented on LUCENE-4167: I don't see how it makes it harder to support more than one operation. If anything, it is making operations a 1st class citizen. Remove the use of SpatialOperation -- Key: LUCENE-4167 URL: https://issues.apache.org/jira/browse/LUCENE-4167 Project: Lucene - Java Issue Type: Bug Components: modules/spatial Reporter: Chris Male Attachments: LUCENE-4167.patch Looking at the code in TwoDoublesStrategy I noticed SpatialOperations.BBoxWithin vs isWithin which confused me. Looking over the other Strategys I see that really only isWithin and Intersects is supported. Only TwoDoublesStrategy supports IsDisjointTo. The remainder of SpatialOperations are not supported. I don't think we should use SpatialOperation as this stage since it is not clear what Operations are supported by what Strategys, many Operations are not supported, and the code for handling the Operations is usually the same. We can spin off the code for TwoDoublesStrategy's IsDisjointTo support into a different Strategy. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
