[JENKINS] Lucene-Solr-tests-only-trunk - Build # 10195 - Still Failing
Build: https://builds.apache.org/job/Lucene-Solr-tests-only-trunk/10195/ 1 tests failed. REGRESSION: org.apache.solr.cloud.CloudStateUpdateTest.testCoreRegistration Error Message: expected:2 but was:3 Stack Trace: junit.framework.AssertionFailedError: expected:2 but was:3 at org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:1526) at org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:1428) at org.apache.solr.cloud.CloudStateUpdateTest.testCoreRegistration(CloudStateUpdateTest.java:198) Build Log (for compile errors): [...truncated 7956 lines...] - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-2708) Allow customizable bean mapping for QueryResponse.getBeans(..)
[ https://issues.apache.org/jira/browse/SOLR-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Male updated SOLR-2708: - Attachment: SOLR-2708.patch Another patch doing more cleanup, particularly in the tests. I'm starting to get an idea of whats needed here. Allow customizable bean mapping for QueryResponse.getBeans(..) -- Key: SOLR-2708 URL: https://issues.apache.org/jira/browse/SOLR-2708 Project: Solr Issue Type: Improvement Components: clients - java Affects Versions: 1.4, 3.1 Reporter: Bozhidar Bozhanov Attachments: SOLR-2708.patch, SOLR-2708.patch The mechanism for getting beans is rather limited - only classes @Field-annotated fields. Imaging the following subprojects: - common - search And you want to reuse a class from common as a result from a solr search. You should either duplicate the structure or make common depend on solrj. Neither are desirable. So, my suggestion: - introduce a pluggable mechanism for bean resolution. Currently it is impossible - it uses private methods and private inner classes. (This will be useful for custom conversions, because the existing one fails in some cases where BeanUtils.copyProperties works.) - allow externalized (xml) configuration - allow detecting all fields, annotated or not (off by default) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-1768) NumericRange support for new query parser
[ https://issues.apache.org/jira/browse/LUCENE-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086181#comment-13086181 ] Uwe Schindler commented on LUCENE-1768: --- I have no problems with the patch, too. We have unfortunately no real backwards tests for contribs, but I see no major problems. I will commit this soon and record merges from trunk, so the commits are related by mergeprops. What changes are still missing from trunk that will never be backported? Adriano: Can you summarize all your changes in both issues into a changes.txt entry for both branches? NumericRange support for new query parser - Key: LUCENE-1768 URL: https://issues.apache.org/jira/browse/LUCENE-1768 Project: Lucene - Java Issue Type: New Feature Components: core/queryparser Affects Versions: 2.9 Reporter: Uwe Schindler Assignee: Uwe Schindler Labels: contrib, gsoc, gsoc2011, lucene-gsoc-11, mentor Fix For: 4.0 Attachments: TestNumericQueryParser-fix.patch, TestNumericQueryParser-fix.patch, TestNumericQueryParser-fix.patch, TestNumericQueryParser-fix.patch, week-7.patch, week-8.patch, week1.patch, week11-13_for_lucene_3x.patch, week2.patch, week3.patch, week4.patch, week5-6.patch It would be good to specify some type of schema for the query parser in future, to automatically create NumericRangeQuery for different numeric types? It would then be possible to index a numeric value (double,float,long,int) using NumericField and then the query parser knows, which type of field this is and so it correctly creates a NumericRangeQuery for strings like [1.567..*] or (1.787..19.5]. There is currently no way to extract if a field is numeric from the index, so the user will have to configure the FieldConfig objects in the ConfigHandler. But if this is done, it will not be that difficult to implement the rest. The only difference between the current handling of RangeQuery is then the instantiation of the correct Query type and conversion of the entered numeric values (simple Number.valueOf(...) cast of the user entered numbers). Evenerything else is identical, NumericRangeQuery also supports the MTQ rewrite modes (as it is a MTQ). Another thing is a change in Date semantics. There are some strange flags in the current parser that tells it how to handle dates. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3305) Kuromoji code donation - a new Japanese morphological analyzer
[ https://issues.apache.org/jira/browse/LUCENE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086186#comment-13086186 ] Simon Willnauer commented on LUCENE-3305: - FYI - I created an issue on legal to categorize the IPADIC license LEGAL-97 Kuromoji code donation - a new Japanese morphological analyzer -- Key: LUCENE-3305 URL: https://issues.apache.org/jira/browse/LUCENE-3305 Project: Lucene - Java Issue Type: New Feature Components: modules/analysis Reporter: Christian Moen Assignee: Simon Willnauer Attachments: Kuromoji short overview .pdf, ip-clearance-Kuromoji.xml, kuromoji-0.7.6-asf.tar.gz, kuromoji-0.7.6.tar.gz, kuromoji-solr-0.5.3-asf.tar.gz, kuromoji-solr-0.5.3.tar.gz Atilika Inc. (アティリカ株式会社) would like to donate the Kuromoji Japanese morphological analyzer to the Apache Software Foundation in the hope that it will be useful to Lucene and Solr users in Japan and elsewhere. The project was started in 2010 since we couldn't find any high-quality, actively maintained and easy-to-use Java-based Japanese morphological analyzers, and these become many of our design goals for Kuromoji. Kuromoji also has a segmentation mode that is particularly useful for search, which we hope will interest Lucene and Solr users. Compound-nouns, such as 関西国際空港 (Kansai International Airport) and 日本経済新聞 (Nikkei Newspaper), are segmented as one token with most analyzers. As a result, a search for 空港 (airport) or 新聞 (newspaper) will not give you a for in these words. Kuromoji can segment these words into 関西 国際 空港 and 日本 経済 新聞, which is generally what you would want for search and you'll get a hit. We also wanted to make sure the technology has a license that makes it compatible with other Apache Software Foundation software to maximize its usefulness. Kuromoji has an Apache License 2.0 and all code is currently owned by Atilika Inc. The software has been developed by my good friend and ex-colleague Masaru Hasegawa and myself. Kuromoji uses the so-called IPADIC for its dictionary/statistical model and its license terms are described in NOTICE.txt. I'll upload code distributions and their corresponding hashes and I'd very much like to start the code grant process. I'm also happy to provide patches to integrate Kuromoji into the codebase, if you prefer that. Please advise on how you'd like me to proceed with this. Thank you. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
more granular updateRequestProcessorChain
Hello, I need to implement some tricky copyField like in http://wiki.apache.org/solr/UpdateRequestProcessor. But I need to take the SolrInputDocument field and put it into Lucene document myself by my own UpdateRequestProcessor. Unfortunately there is no room to do that because the creating Lucene document and its' indexing it is the single method: org.apache.solr.update.processor.RunUpdateProcessor.processAdd(AddUpdateCommand) { cmd.doc = DocumentBuilder.toDocument(cmd.getSolrInputDocument(), req.getSchema()); updateHandler.addDoc(cmd); super.processAdd(cmd); } I was surprised because the Chain-of-responsibility and Command pattern are made for such usages. I propose to separate the current RunUpdateProcessor onto BuildLuceneDocumentProcessor and UpdateHandlerProcessor that allow users to inject their own routines in the main flow. Right now I had to copy-paste RunUpdateProcessor to get my purpose. WDYT? -- Sincerely yours Mikhail (Mike) Khludnev Developer Grid Dynamics Skype: mkhludnev mkhlud...@griddynamics.com
Re: [JENKINS] Lucene-Solr-tests-only-trunk - Build # 10193 - Still Failing
I'll investigate this test failure. On 17 August 2011 04:31, Robert Muir rcm...@gmail.com wrote: This test fails if NUM_ORD 2, which is the case when a -Dtests.multiplier 1 is used. I temporarily wired NUM_ORD to 2, and reopened/put a comment on https://issues.apache.org/jira/browse/LUCENE-3354 On Tue, Aug 16, 2011 at 10:01 PM, Apache Jenkins Server jenk...@builds.apache.org wrote: Build: https://builds.apache.org/job/Lucene-Solr-tests-only-trunk/10193/ 1 tests failed. FAILED: org.apache.lucene.search.TestFieldCache.test Error Message: Expected value gm镩Ǫᥨ¢ 뢕J[㍤˩൘Σ͆eﳖꤧ忌㐓ӳs䚮ǟ݁ґwЩ焃̣(uبޘ雡{ڍ躷廛(JҨ鍧遼ﳖ砏ԙ羀α㱧햞疎̦ٛﳺ̕n誢̷º;Ԟँ̟ۛހ㒯Ԁ협E۶络kʺ먨ˋ켿؇Ty洔Ҕ⮄鈷֤䆡掌槛ŗᏓ盜鎴ģP繯؉雏唪 for doc 0 and ord 0, but was ڬﮎ՚ᆩʛ웍ে瞊ؘسȣ澏掤ŻⓉªW嵆⁊ӌ颽ɧɉīÓ59݂d뫇זόѭ 筋踠⫔戇呾平Խ0ҭd$꒼ Stack Trace: junit.framework.AssertionFailedError: Expected value gm镩Ǫᥨ¢ 뢕J[㍤˩൘Σ͆eﳖꤧ忌㐓ӳs䚮ǟ݁ґwЩ焃̣(uبޘ雡{ڍ躷廛(JҨ鍧遼ﳖ砏ԙ羀α㱧햞疎̦ٛﳺ̕n誢̷º;Ԟँ̟ۛހ㒯Ԁ협E۶络kʺ먨ˋ켿؇Ty洔Ҕ⮄鈷֤䆡掌槛ŗᏓ盜鎴ģP繯؉雏唪 for doc 0 and ord 0, but was ڬﮎ՚ᆩʛ웍ে瞊ؘسȣ澏掤ŻⓉªW嵆⁊ӌ颽ɧɉīÓ59݂d뫇זόѭ 筋踠⫔戇呾平Խ0ҭd$꒼ at org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:1526) at org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:1428) 筋踠⫔戇呾平Խ0ҭd$꒼ at org.apache.lucene.search.TestFieldCache.test(TestFieldCache.java:246) Build Log (for compile errors): [...truncated 1217 lines...] -- lucidimagination.com -- Met vriendelijke groet, Martijn van Groningen
[jira] [Commented] (LUCENE-3354) Extend FieldCache architecture to multiple Values
[ https://issues.apache.org/jira/browse/LUCENE-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086197#comment-13086197 ] Martijn van Groningen commented on LUCENE-3354: --- I committed a fix. Test pass now on my local box with -Dtests.multiplier=3. If build is successful on Jenkins we can close this issue. Extend FieldCache architecture to multiple Values - Key: LUCENE-3354 URL: https://issues.apache.org/jira/browse/LUCENE-3354 Project: Lucene - Java Issue Type: Improvement Reporter: Bill Bell Fix For: 4.0 Attachments: LUCENE-3354.patch, LUCENE-3354.patch I would consider this a bug. It appears lots of people are working around this limitation, why don't we just change the underlying data structures to natively support multiValued fields in the FieldCache architecture? Then functions() will work properly, and we can do things like easily geodist() on a multiValued field. Thoughts? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2700) transaction logging
[ https://issues.apache.org/jira/browse/SOLR-2700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086207#comment-13086207 ] Noble Paul commented on SOLR-2700: -- Realtime get can be a separate issue altogether. These are two distinct features transaction logging --- Key: SOLR-2700 URL: https://issues.apache.org/jira/browse/SOLR-2700 Project: Solr Issue Type: New Feature Reporter: Yonik Seeley Attachments: SOLR-2700.patch, SOLR-2700.patch, SOLR-2700.patch A transaction log is needed for durability of updates, for a more performant realtime-get, and for replaying updates to recovering peers. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[JENKINS] Solr-trunk - Build # 1601 - Failure
Build: https://builds.apache.org/job/Solr-trunk/1601/ 1 tests failed. REGRESSION: org.apache.solr.update.AutoCommitTest.testSoftAndHardCommitMaxTime Error Message: expected:2 but was:3 Stack Trace: junit.framework.AssertionFailedError: expected:2 but was:3 at org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:1526) at org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:1428) at org.apache.solr.update.AutoCommitTest.__CLR2_6_396rfj913je(AutoCommitTest.java:438) at org.apache.solr.update.AutoCommitTest.testSoftAndHardCommitMaxTime(AutoCommitTest.java:366) Build Log (for compile errors): [...truncated 27375 lines...] - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3354) Extend FieldCache architecture to multiple Values
[ https://issues.apache.org/jira/browse/LUCENE-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086251#comment-13086251 ] Robert Muir commented on LUCENE-3354: - Thanks Martijn: any idea how we can speed this test up? for our 'ant test' runs with multiplier=3, this takes a significant amount of time (over 15 minutes!), more than all the other tests combined. Before the commit my builds were taking about 9 minutes, log here: http://sierranevada.servebeer.com/ {noformat} [junit] Testsuite: org.apache.lucene.search.TestFieldCache [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 1,062.362 sec {noformat} Extend FieldCache architecture to multiple Values - Key: LUCENE-3354 URL: https://issues.apache.org/jira/browse/LUCENE-3354 Project: Lucene - Java Issue Type: Improvement Reporter: Bill Bell Fix For: 4.0 Attachments: LUCENE-3354.patch, LUCENE-3354.patch I would consider this a bug. It appears lots of people are working around this limitation, why don't we just change the underlying data structures to natively support multiValued fields in the FieldCache architecture? Then functions() will work properly, and we can do things like easily geodist() on a multiValued field. Thoughts? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-3354) Extend FieldCache architecture to multiple Values
[ https://issues.apache.org/jira/browse/LUCENE-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-3354: Attachment: LUCENE-3354_testspeed.patch attached is a patch that seems to help for me, it doesn't create such long unicode strings in the test. Is there some reason why the test would want very long strings? Extend FieldCache architecture to multiple Values - Key: LUCENE-3354 URL: https://issues.apache.org/jira/browse/LUCENE-3354 Project: Lucene - Java Issue Type: Improvement Reporter: Bill Bell Fix For: 4.0 Attachments: LUCENE-3354.patch, LUCENE-3354.patch, LUCENE-3354_testspeed.patch I would consider this a bug. It appears lots of people are working around this limitation, why don't we just change the underlying data structures to natively support multiValued fields in the FieldCache architecture? Then functions() will work properly, and we can do things like easily geodist() on a multiValued field. Thoughts? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3360) Move FieldCache to IndexReader
[ https://issues.apache.org/jira/browse/LUCENE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086258#comment-13086258 ] Michael McCandless commented on LUCENE-3360: I actually prefer the name AtomicFieldCache, since this matches other places (eg. AtomicReaderContext), and because it's not necessarily a segment (SlowMultiReaderWrapper returns an instance). The name SegmentFieldCacheImpl seems OK, but can't this class be package private? I love the name InsaneFieldCache! For the new IR.getFieldCache() instead of a generic UOE can we throw something like MR.fields() throws? Ie the exc message should explain that you should use the SlowMRWrapper instead. I'm nervous about how the [deprecated] FC makes a new SlowMRWrapper() for each getXXX call -- I think this class uses this as the getFieldCacheKey? Won't this mean each lookup will build a new cache entry? (Hmm... but then why don't tests fail... I think we have at least one test verifying same instance is returned for 2 calls in a row). Move FieldCache to IndexReader -- Key: LUCENE-3360 URL: https://issues.apache.org/jira/browse/LUCENE-3360 Project: Lucene - Java Issue Type: Improvement Reporter: Martijn van Groningen Fix For: 3.4, 4.0 Attachments: LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch Move the static FieldCache.DEFAULT field instance to atomic IndexReaders, so that FieldCache insanity caused by the WeakHashMap no longer occurs. * Add a new method to IndexReader that by default throws an UOE: {code}public FieldCache getFieldCache(){code} * The SegmentReader implements this method and returns its own internal FieldCache implementation. This implementation just uses a HashMapEntryT,Object to store entries. * The SlowMultiReaderWrapper implements this method as well and basically behaves the same as the current FieldCacheImpl. This issue won't solve the insanity that comes from inconsistent usage of a single field (for example retrieve both int[] and DocTermIndex for the same field). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3377) TermOrdsIterator#lookup throws ArrayIndexOutOfBoundsException
[ https://issues.apache.org/jira/browse/LUCENE-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086259#comment-13086259 ] Michael McCandless commented on LUCENE-3377: I think we should record which IR instance the DTO.TermOrdsIterator was created on, and then don't reuse the passed instance if it came from a different IR? Actually we should probably just hold onto compare the IR.getCoreCacheKey(). TermOrdsIterator#lookup throws ArrayIndexOutOfBoundsException - Key: LUCENE-3377 URL: https://issues.apache.org/jira/browse/LUCENE-3377 Project: Lucene - Java Issue Type: Bug Affects Versions: 4.0 Reporter: Martijn van Groningen Priority: Minor TermOrdsIterator's lookup method can throw an ArrayIndexOutOfBoundsException if reuse argument is reused acros segments. Example collector: {code} private DocTermOrds.TermOrdsIterator reuse = null; public void collect(int doc) throws IOException { ... reuse = docTermOrds.lookup(doc, reuse); ... } public void setNextReader(IndexReader.AtomicReaderContext context) throws IOException { docTermOrds = FieldCache.DEFAULT.getDocTermOrds(context.reader, field); } {code} If reuse argument is always null exception doesn't occur. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3360) Move FieldCache to IndexReader
[ https://issues.apache.org/jira/browse/LUCENE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086260#comment-13086260 ] Robert Muir commented on LUCENE-3360: - {quote} For the new IR.getFieldCache() instead of a generic UOE can we throw something like MR.fields() throws? Ie the exc message should explain that you should use the SlowMRWrapper instead. {quote} Yeah, can we force the user to make their own SlowMultiReaderWrapper? I don't think we should ever create such things, even for deprecated stuff in 4.0 In 4.0 we just change the API and make you create it yourself. Move FieldCache to IndexReader -- Key: LUCENE-3360 URL: https://issues.apache.org/jira/browse/LUCENE-3360 Project: Lucene - Java Issue Type: Improvement Reporter: Martijn van Groningen Fix For: 3.4, 4.0 Attachments: LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch Move the static FieldCache.DEFAULT field instance to atomic IndexReaders, so that FieldCache insanity caused by the WeakHashMap no longer occurs. * Add a new method to IndexReader that by default throws an UOE: {code}public FieldCache getFieldCache(){code} * The SegmentReader implements this method and returns its own internal FieldCache implementation. This implementation just uses a HashMapEntryT,Object to store entries. * The SlowMultiReaderWrapper implements this method as well and basically behaves the same as the current FieldCacheImpl. This issue won't solve the insanity that comes from inconsistent usage of a single field (for example retrieve both int[] and DocTermIndex for the same field). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3354) Extend FieldCache architecture to multiple Values
[ https://issues.apache.org/jira/browse/LUCENE-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086266#comment-13086266 ] Martijn van Groningen commented on LUCENE-3354: --- I don't think there is any reason for generating long unicode strings. Only the cache behavior needs to be tested. Extend FieldCache architecture to multiple Values - Key: LUCENE-3354 URL: https://issues.apache.org/jira/browse/LUCENE-3354 Project: Lucene - Java Issue Type: Improvement Reporter: Bill Bell Fix For: 4.0 Attachments: LUCENE-3354.patch, LUCENE-3354.patch, LUCENE-3354_testspeed.patch I would consider this a bug. It appears lots of people are working around this limitation, why don't we just change the underlying data structures to natively support multiValued fields in the FieldCache architecture? Then functions() will work properly, and we can do things like easily geodist() on a multiValued field. Thoughts? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3377) TermOrdsIterator#lookup throws ArrayIndexOutOfBoundsException
[ https://issues.apache.org/jira/browse/LUCENE-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086269#comment-13086269 ] Martijn van Groningen commented on LUCENE-3377: --- bq. Actually we should probably just hold onto compare the IR.getCoreCacheKey(). Seems like a good idea to me. TermOrdsIterator#lookup throws ArrayIndexOutOfBoundsException - Key: LUCENE-3377 URL: https://issues.apache.org/jira/browse/LUCENE-3377 Project: Lucene - Java Issue Type: Bug Affects Versions: 4.0 Reporter: Martijn van Groningen Priority: Minor TermOrdsIterator's lookup method can throw an ArrayIndexOutOfBoundsException if reuse argument is reused acros segments. Example collector: {code} private DocTermOrds.TermOrdsIterator reuse = null; public void collect(int doc) throws IOException { ... reuse = docTermOrds.lookup(doc, reuse); ... } public void setNextReader(IndexReader.AtomicReaderContext context) throws IOException { docTermOrds = FieldCache.DEFAULT.getDocTermOrds(context.reader, field); } {code} If reuse argument is always null exception doesn't occur. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3354) Extend FieldCache architecture to multiple Values
[ https://issues.apache.org/jira/browse/LUCENE-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086271#comment-13086271 ] Robert Muir commented on LUCENE-3354: - OK, thanks. I bet this was probably slowing things down for simpletext or something stupid :) Extend FieldCache architecture to multiple Values - Key: LUCENE-3354 URL: https://issues.apache.org/jira/browse/LUCENE-3354 Project: Lucene - Java Issue Type: Improvement Reporter: Bill Bell Fix For: 4.0 Attachments: LUCENE-3354.patch, LUCENE-3354.patch, LUCENE-3354_testspeed.patch I would consider this a bug. It appears lots of people are working around this limitation, why don't we just change the underlying data structures to natively support multiValued fields in the FieldCache architecture? Then functions() will work properly, and we can do things like easily geodist() on a multiValued field. Thoughts? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3360) Move FieldCache to IndexReader
[ https://issues.apache.org/jira/browse/LUCENE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086276#comment-13086276 ] Michael McCandless commented on LUCENE-3360: bq. In 4.0 we just change the API and make you create it yourself. +1 Move FieldCache to IndexReader -- Key: LUCENE-3360 URL: https://issues.apache.org/jira/browse/LUCENE-3360 Project: Lucene - Java Issue Type: Improvement Reporter: Martijn van Groningen Fix For: 3.4, 4.0 Attachments: LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch Move the static FieldCache.DEFAULT field instance to atomic IndexReaders, so that FieldCache insanity caused by the WeakHashMap no longer occurs. * Add a new method to IndexReader that by default throws an UOE: {code}public FieldCache getFieldCache(){code} * The SegmentReader implements this method and returns its own internal FieldCache implementation. This implementation just uses a HashMapEntryT,Object to store entries. * The SlowMultiReaderWrapper implements this method as well and basically behaves the same as the current FieldCacheImpl. This issue won't solve the insanity that comes from inconsistent usage of a single field (for example retrieve both int[] and DocTermIndex for the same field). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3360) Move FieldCache to IndexReader
[ https://issues.apache.org/jira/browse/LUCENE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086275#comment-13086275 ] Michael McCandless commented on LUCENE-3360: bq. In 4.0 we just change the API and make you create it yourself. Move FieldCache to IndexReader -- Key: LUCENE-3360 URL: https://issues.apache.org/jira/browse/LUCENE-3360 Project: Lucene - Java Issue Type: Improvement Reporter: Martijn van Groningen Fix For: 3.4, 4.0 Attachments: LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch Move the static FieldCache.DEFAULT field instance to atomic IndexReaders, so that FieldCache insanity caused by the WeakHashMap no longer occurs. * Add a new method to IndexReader that by default throws an UOE: {code}public FieldCache getFieldCache(){code} * The SegmentReader implements this method and returns its own internal FieldCache implementation. This implementation just uses a HashMapEntryT,Object to store entries. * The SlowMultiReaderWrapper implements this method as well and basically behaves the same as the current FieldCacheImpl. This issue won't solve the insanity that comes from inconsistent usage of a single field (for example retrieve both int[] and DocTermIndex for the same field). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3360) Move FieldCache to IndexReader
[ https://issues.apache.org/jira/browse/LUCENE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086278#comment-13086278 ] Martijn van Groningen commented on LUCENE-3360: --- {quote} I actually prefer the name AtomicFieldCache, since this matches other places (eg. AtomicReaderContext), and because it's not necessarily a segment (SlowMultiReaderWrapper returns an instance). {quote} For naming consistency I agree with you there. I will make the SegmentFieldCacheImpl package private. I kept it in the patch it public, b/c FieldCacheImpl was public too. {quote} I'm nervous about how the [deprecated] FC makes a new SlowMRWrapper() for each getXXX call – I think this class uses this as the getFieldCacheKey? Won't this mean each lookup will build a new cache entry? (Hmm... but then why don't tests fail... I think we have at least one test verifying same instance is returned for 2 calls in a row). {quote} The current FielCache api requires a reader to be specified. That specified reader is used as key. bq. I love the name InsaneFieldCache! I love the name too :) bq. In 4.0 we just change the API and make you create it yourself. So remove [deprecated] FieldCache completely? When back porting to 3x we obviously need to keep FieldCache classes... Move FieldCache to IndexReader -- Key: LUCENE-3360 URL: https://issues.apache.org/jira/browse/LUCENE-3360 Project: Lucene - Java Issue Type: Improvement Reporter: Martijn van Groningen Fix For: 3.4, 4.0 Attachments: LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch Move the static FieldCache.DEFAULT field instance to atomic IndexReaders, so that FieldCache insanity caused by the WeakHashMap no longer occurs. * Add a new method to IndexReader that by default throws an UOE: {code}public FieldCache getFieldCache(){code} * The SegmentReader implements this method and returns its own internal FieldCache implementation. This implementation just uses a HashMapEntryT,Object to store entries. * The SlowMultiReaderWrapper implements this method as well and basically behaves the same as the current FieldCacheImpl. This issue won't solve the insanity that comes from inconsistent usage of a single field (for example retrieve both int[] and DocTermIndex for the same field). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (LUCENE-3378) Some contribs depend on core tests to be compiled and fail when ant clean was done before
Some contribs depend on core tests to be compiled and fail when ant clean was done before - Key: LUCENE-3378 URL: https://issues.apache.org/jira/browse/LUCENE-3378 Project: Lucene - Java Issue Type: Bug Components: general/test Affects Versions: 3.4, 4.0 Reporter: Uwe Schindler If you do ant clean on the root level of Lucene and then go to e.g. contrib/queryparser (3.x only) or contrib/misc (3.x and trunk) and call ant test, the build of tests fails: - contrib/queryparser's ExtendedableQPTests extend a core TestQueryParser (3.x only, in module this works, of course) - contrib/misc/TestIndexSplitter uses a core class to build its index To find the root cause: We should first remove the core tests from contrib classpath, so the issue gets visible even without ant clean before. Then we can fix this. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2700) transaction logging
[ https://issues.apache.org/jira/browse/SOLR-2700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086280#comment-13086280 ] Mark Miller commented on SOLR-2700: --- bq. Realtime get can be a separate issue altogether. Realtime get is a separate JIRA issue - see SOLR-2656. However, it obviously goes very much with this issue if you do a little back reading - you don't want to have to reopen a reader each time for realtime get - you want to pull from the transaction log when you can instead. transaction logging --- Key: SOLR-2700 URL: https://issues.apache.org/jira/browse/SOLR-2700 Project: Solr Issue Type: New Feature Reporter: Yonik Seeley Attachments: SOLR-2700.patch, SOLR-2700.patch, SOLR-2700.patch A transaction log is needed for durability of updates, for a more performant realtime-get, and for replaying updates to recovering peers. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-1768) NumericRange support for new query parser
[ https://issues.apache.org/jira/browse/LUCENE-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086283#comment-13086283 ] Uwe Schindler commented on LUCENE-1768: --- In 3.x we depend on Java 5, I found two interface @Override in your patch, that are not detected by Java6's javac (it's a bug there). NumericRange support for new query parser - Key: LUCENE-1768 URL: https://issues.apache.org/jira/browse/LUCENE-1768 Project: Lucene - Java Issue Type: New Feature Components: core/queryparser Affects Versions: 2.9 Reporter: Uwe Schindler Assignee: Uwe Schindler Labels: contrib, gsoc, gsoc2011, lucene-gsoc-11, mentor Fix For: 4.0 Attachments: TestNumericQueryParser-fix.patch, TestNumericQueryParser-fix.patch, TestNumericQueryParser-fix.patch, TestNumericQueryParser-fix.patch, week-7.patch, week-8.patch, week1.patch, week11-13_for_lucene_3x.patch, week2.patch, week3.patch, week4.patch, week5-6.patch It would be good to specify some type of schema for the query parser in future, to automatically create NumericRangeQuery for different numeric types? It would then be possible to index a numeric value (double,float,long,int) using NumericField and then the query parser knows, which type of field this is and so it correctly creates a NumericRangeQuery for strings like [1.567..*] or (1.787..19.5]. There is currently no way to extract if a field is numeric from the index, so the user will have to configure the FieldConfig objects in the ConfigHandler. But if this is done, it will not be that difficult to implement the rest. The only difference between the current handling of RangeQuery is then the instantiation of the correct Query type and conversion of the entered numeric values (simple Number.valueOf(...) cast of the user entered numbers). Evenerything else is identical, NumericRangeQuery also supports the MTQ rewrite modes (as it is a MTQ). Another thing is a change in Date semantics. There are some strange flags in the current parser that tells it how to handle dates. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-1768) NumericRange support for new query parser
[ https://issues.apache.org/jira/browse/LUCENE-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-1768: -- Attachment: week11-13_for_lucene_3x.patch Attached a patch that fixes the interface @Override, including all merge-props needed. NumericRange support for new query parser - Key: LUCENE-1768 URL: https://issues.apache.org/jira/browse/LUCENE-1768 Project: Lucene - Java Issue Type: New Feature Components: core/queryparser Affects Versions: 2.9 Reporter: Uwe Schindler Assignee: Uwe Schindler Labels: contrib, gsoc, gsoc2011, lucene-gsoc-11, mentor Fix For: 4.0 Attachments: TestNumericQueryParser-fix.patch, TestNumericQueryParser-fix.patch, TestNumericQueryParser-fix.patch, TestNumericQueryParser-fix.patch, week-7.patch, week-8.patch, week1.patch, week11-13_for_lucene_3x.patch, week11-13_for_lucene_3x.patch, week2.patch, week3.patch, week4.patch, week5-6.patch It would be good to specify some type of schema for the query parser in future, to automatically create NumericRangeQuery for different numeric types? It would then be possible to index a numeric value (double,float,long,int) using NumericField and then the query parser knows, which type of field this is and so it correctly creates a NumericRangeQuery for strings like [1.567..*] or (1.787..19.5]. There is currently no way to extract if a field is numeric from the index, so the user will have to configure the FieldConfig objects in the ConfigHandler. But if this is done, it will not be that difficult to implement the rest. The only difference between the current handling of RangeQuery is then the instantiation of the correct Query type and conversion of the entered numeric values (simple Number.valueOf(...) cast of the user entered numbers). Evenerything else is identical, NumericRangeQuery also supports the MTQ rewrite modes (as it is a MTQ). Another thing is a change in Date semantics. There are some strange flags in the current parser that tells it how to handle dates. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3378) Some contribs depend on core tests to be compiled and fail when ant clean was done before
[ https://issues.apache.org/jira/browse/LUCENE-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086289#comment-13086289 ] Robert Muir commented on LUCENE-3378: - I agree, in some of these cases, we might be able to refactor helper methods and such into tests-framework, which would be cleaner. we shouldn't necessarily do this in all cases, but at least clean up the obvious ones Some contribs depend on core tests to be compiled and fail when ant clean was done before - Key: LUCENE-3378 URL: https://issues.apache.org/jira/browse/LUCENE-3378 Project: Lucene - Java Issue Type: Bug Components: general/test Affects Versions: 3.4, 4.0 Reporter: Uwe Schindler If you do ant clean on the root level of Lucene and then go to e.g. contrib/queryparser (3.x only) or contrib/misc (3.x and trunk) and call ant test, the build of tests fails: - contrib/queryparser's ExtendedableQPTests extend a core TestQueryParser (3.x only, in module this works, of course) - contrib/misc/TestIndexSplitter uses a core class to build its index To find the root cause: We should first remove the core tests from contrib classpath, so the issue gets visible even without ant clean before. Then we can fix this. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3360) Move FieldCache to IndexReader
[ https://issues.apache.org/jira/browse/LUCENE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086291#comment-13086291 ] Michael McCandless commented on LUCENE-3360: bq. The current FielCache api requires a reader to be specified. That specified reader is used as key. Ahh I see -- the SlowMRWrapper's FC impl uses the in (wrapped IndexReader, from FilterIndexReader) as the key. So we should only see one cache entry created. Phew! bq. When back porting to 3x we obviously need to keep FieldCache classes... True... so maybe do this patch in 2 steps? First, for 3.x. Then, merge to trunk, remove deprecated FC and fix all usages? Move FieldCache to IndexReader -- Key: LUCENE-3360 URL: https://issues.apache.org/jira/browse/LUCENE-3360 Project: Lucene - Java Issue Type: Improvement Reporter: Martijn van Groningen Fix For: 3.4, 4.0 Attachments: LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch Move the static FieldCache.DEFAULT field instance to atomic IndexReaders, so that FieldCache insanity caused by the WeakHashMap no longer occurs. * Add a new method to IndexReader that by default throws an UOE: {code}public FieldCache getFieldCache(){code} * The SegmentReader implements this method and returns its own internal FieldCache implementation. This implementation just uses a HashMapEntryT,Object to store entries. * The SlowMultiReaderWrapper implements this method as well and basically behaves the same as the current FieldCacheImpl. This issue won't solve the insanity that comes from inconsistent usage of a single field (for example retrieve both int[] and DocTermIndex for the same field). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3360) Move FieldCache to IndexReader
[ https://issues.apache.org/jira/browse/LUCENE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086295#comment-13086295 ] Uwe Schindler commented on LUCENE-3360: --- Thanks, for taking care! I am a little bit over-crowded with summer-holidays :-) Move FieldCache to IndexReader -- Key: LUCENE-3360 URL: https://issues.apache.org/jira/browse/LUCENE-3360 Project: Lucene - Java Issue Type: Improvement Reporter: Martijn van Groningen Fix For: 3.4, 4.0 Attachments: LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch Move the static FieldCache.DEFAULT field instance to atomic IndexReaders, so that FieldCache insanity caused by the WeakHashMap no longer occurs. * Add a new method to IndexReader that by default throws an UOE: {code}public FieldCache getFieldCache(){code} * The SegmentReader implements this method and returns its own internal FieldCache implementation. This implementation just uses a HashMapEntryT,Object to store entries. * The SlowMultiReaderWrapper implements this method as well and basically behaves the same as the current FieldCacheImpl. This issue won't solve the insanity that comes from inconsistent usage of a single field (for example retrieve both int[] and DocTermIndex for the same field). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3271) Move 'good' contrib/queries classes to Queries module
[ https://issues.apache.org/jira/browse/LUCENE-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086296#comment-13086296 ] Robert Muir commented on LUCENE-3271: - In order to fix LUCENE-3378, I need to do part of this patch (move the FieldCacheRewriteMethod tests). I'll apply this locally to a separate checkout and then update the patch and instructions (as I figure you are close to committing) Move 'good' contrib/queries classes to Queries module - Key: LUCENE-3271 URL: https://issues.apache.org/jira/browse/LUCENE-3271 Project: Lucene - Java Issue Type: Improvement Reporter: Chris Male Attachments: LUCENE-3271-MLT.patch, LUCENE-3271-MLT.patch, LUCENE-3271-good-queries.patch, LUCENE-3271-regex.patch With the Queries module now filled with the FunctionQuery stuff, we should look at closing down contrib/queries. While not a huge contrib, it contains a number of pretty useful classes and some that should go elsewhere. Heres my proposed plan: - similar.* - suggest module - regex.* - queries module - BooleanFilter - queries module under .filters package - BoostingQuery - queries module - ChainedFilter - queries module under .filters package - DuplicateFilter - queries module under .filters package - FieldCacheRewriteMethod - This doesn't belong in this contrib or the queries module. I think we should push it to contrib/misc for the time being. It seems to have quite a few constraints on when its useful. If indeed CONSTANT_SCORE_AUTO rewrite is better, then I dont see a purpose for it. - FilterClause - class inside BooleanFilter - FuzzyLikeThisQuery - suggest module. This class seems a mess with its Similarity hardcoded. With all that said, it does seem to do what it claims and with some cleanup, it could be good. - TermsFilter - queries module under .filters package - SlowCollated* - They can stay in the module till we have a better place to nuke them. One of the implications of the above moves, is that the xml-query-parser, which supports many of the queries, will need to have a dependency on the queries module. But that seems unavoidable at this stage. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3271) Move 'good' contrib/queries classes to Queries module
[ https://issues.apache.org/jira/browse/LUCENE-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086300#comment-13086300 ] Chris Male commented on LUCENE-3271: Okay! I'll be committing this in about 12hrs or so. Move 'good' contrib/queries classes to Queries module - Key: LUCENE-3271 URL: https://issues.apache.org/jira/browse/LUCENE-3271 Project: Lucene - Java Issue Type: Improvement Reporter: Chris Male Attachments: LUCENE-3271-MLT.patch, LUCENE-3271-MLT.patch, LUCENE-3271-good-queries.patch, LUCENE-3271-regex.patch With the Queries module now filled with the FunctionQuery stuff, we should look at closing down contrib/queries. While not a huge contrib, it contains a number of pretty useful classes and some that should go elsewhere. Heres my proposed plan: - similar.* - suggest module - regex.* - queries module - BooleanFilter - queries module under .filters package - BoostingQuery - queries module - ChainedFilter - queries module under .filters package - DuplicateFilter - queries module under .filters package - FieldCacheRewriteMethod - This doesn't belong in this contrib or the queries module. I think we should push it to contrib/misc for the time being. It seems to have quite a few constraints on when its useful. If indeed CONSTANT_SCORE_AUTO rewrite is better, then I dont see a purpose for it. - FilterClause - class inside BooleanFilter - FuzzyLikeThisQuery - suggest module. This class seems a mess with its Similarity hardcoded. With all that said, it does seem to do what it claims and with some cleanup, it could be good. - TermsFilter - queries module under .filters package - SlowCollated* - They can stay in the module till we have a better place to nuke them. One of the implications of the above moves, is that the xml-query-parser, which supports many of the queries, will need to have a dependency on the queries module. But that seems unavoidable at this stage. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-3378) Some contribs depend on core tests to be compiled and fail when ant clean was done before
[ https://issues.apache.org/jira/browse/LUCENE-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-3378: Attachment: LUCENE-3378.patch patch for trunk Some contribs depend on core tests to be compiled and fail when ant clean was done before - Key: LUCENE-3378 URL: https://issues.apache.org/jira/browse/LUCENE-3378 Project: Lucene - Java Issue Type: Bug Components: general/test Affects Versions: 3.4, 4.0 Reporter: Uwe Schindler Attachments: LUCENE-3378.patch If you do ant clean on the root level of Lucene and then go to e.g. contrib/queryparser (3.x only) or contrib/misc (3.x and trunk) and call ant test, the build of tests fails: - contrib/queryparser's ExtendedableQPTests extend a core TestQueryParser (3.x only, in module this works, of course) - contrib/misc/TestIndexSplitter uses a core class to build its index To find the root cause: We should first remove the core tests from contrib classpath, so the issue gets visible even without ant clean before. Then we can fix this. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3378) Some contribs depend on core tests to be compiled and fail when ant clean was done before
[ https://issues.apache.org/jira/browse/LUCENE-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086302#comment-13086302 ] Robert Muir commented on LUCENE-3378: - Here's the explanation (since patch will not apply as it contains svn moves): # disabled the lucene src/test from contrib classpath # moved the fieldcacherewritemethod and tests to core src/test, as discussed in LUCENE-3271 # moved the europarl data file to tests-framework, because some contribs use it # moved that createDocument() method from TestIndexWriterReader to DocHelper if there are no objections I would like to commit soon. Some contribs depend on core tests to be compiled and fail when ant clean was done before - Key: LUCENE-3378 URL: https://issues.apache.org/jira/browse/LUCENE-3378 Project: Lucene - Java Issue Type: Bug Components: general/test Affects Versions: 3.4, 4.0 Reporter: Uwe Schindler Attachments: LUCENE-3378.patch If you do ant clean on the root level of Lucene and then go to e.g. contrib/queryparser (3.x only) or contrib/misc (3.x and trunk) and call ant test, the build of tests fails: - contrib/queryparser's ExtendedableQPTests extend a core TestQueryParser (3.x only, in module this works, of course) - contrib/misc/TestIndexSplitter uses a core class to build its index To find the root cause: We should first remove the core tests from contrib classpath, so the issue gets visible even without ant clean before. Then we can fix this. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3378) Some contribs depend on core tests to be compiled and fail when ant clean was done before
[ https://issues.apache.org/jira/browse/LUCENE-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086310#comment-13086310 ] Uwe Schindler commented on LUCENE-3378: --- Patch for trunk looks fine! Thanks! The stupid 3.x-extends-TestQueryParser problem is more challenging :( Some contribs depend on core tests to be compiled and fail when ant clean was done before - Key: LUCENE-3378 URL: https://issues.apache.org/jira/browse/LUCENE-3378 Project: Lucene - Java Issue Type: Bug Components: general/test Affects Versions: 3.4, 4.0 Reporter: Uwe Schindler Attachments: LUCENE-3378.patch If you do ant clean on the root level of Lucene and then go to e.g. contrib/queryparser (3.x only) or contrib/misc (3.x and trunk) and call ant test, the build of tests fails: - contrib/queryparser's ExtendedableQPTests extend a core TestQueryParser (3.x only, in module this works, of course) - contrib/misc/TestIndexSplitter uses a core class to build its index To find the root cause: We should first remove the core tests from contrib classpath, so the issue gets visible even without ant clean before. Then we can fix this. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-3271) Move 'good' contrib/queries classes to Queries module
[ https://issues.apache.org/jira/browse/LUCENE-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-3271: Attachment: LUCENE-3271-good-queries.patch updated patch... i think it might be identical to the old one actually! but here are the revised instructions: {noformat} svn move lucene/contrib/queries/src/java/org/apache/lucene/search/BooleanFilter.java modules/queries/src/java/org/apache/lucene/queries/ svn move lucene/contrib/queries/src/test/org/apache/lucene/search/BooleanFilterTest.java modules/queries/src/test/org/apache/lucene/queries/ svn move lucene/contrib/queries/src/java/org/apache/lucene/search/FilterClause.java modules/queries/src/java/org/apache/lucene/queries/ svn move lucene/contrib/queries/src/java/org/apache/lucene/search/TermsFilter.java modules/queries/src/java/org/apache/lucene/queries/ svn move lucene/contrib/queries/src/test/org/apache/lucene/search/TermsFilterTest.java modules/queries/src/test/org/apache/lucene/queries/ svn move lucene/contrib/queries/src/java/org/apache/lucene/search/BoostingQuery.java modules/queries/src/java/org/apache/lucene/queries/ svn move lucene/contrib/queries/src/java/org/apache/lucene/search/ChainedFilter.java modules/queries/src/java/org/apache/lucene/queries/ svn move lucene/contrib/queries/src/java/org/apache/lucene/search/DuplicateFilter.java modules/queries/src/java/org/apache/lucene/queries/ svn move lucene/contrib/queries/src/test/org/apache/lucene/search/BoostingQueryTest.java modules/queries/src/test/org/apache/lucene/queries/ svn move lucene/contrib/queries/src/test/org/apache/lucene/search/ChainedFilterTest.java modules/queries/src/test/org/apache/lucene/queries/ svn move lucene/contrib/queries/src/test/org/apache/lucene/search/DuplicateFilterTest.java modules/queries/src/test/org/apache/lucene/queries/ {noformat} Move 'good' contrib/queries classes to Queries module - Key: LUCENE-3271 URL: https://issues.apache.org/jira/browse/LUCENE-3271 Project: Lucene - Java Issue Type: Improvement Reporter: Chris Male Attachments: LUCENE-3271-MLT.patch, LUCENE-3271-MLT.patch, LUCENE-3271-good-queries.patch, LUCENE-3271-good-queries.patch, LUCENE-3271-regex.patch With the Queries module now filled with the FunctionQuery stuff, we should look at closing down contrib/queries. While not a huge contrib, it contains a number of pretty useful classes and some that should go elsewhere. Heres my proposed plan: - similar.* - suggest module - regex.* - queries module - BooleanFilter - queries module under .filters package - BoostingQuery - queries module - ChainedFilter - queries module under .filters package - DuplicateFilter - queries module under .filters package - FieldCacheRewriteMethod - This doesn't belong in this contrib or the queries module. I think we should push it to contrib/misc for the time being. It seems to have quite a few constraints on when its useful. If indeed CONSTANT_SCORE_AUTO rewrite is better, then I dont see a purpose for it. - FilterClause - class inside BooleanFilter - FuzzyLikeThisQuery - suggest module. This class seems a mess with its Similarity hardcoded. With all that said, it does seem to do what it claims and with some cleanup, it could be good. - TermsFilter - queries module under .filters package - SlowCollated* - They can stay in the module till we have a better place to nuke them. One of the implications of the above moves, is that the xml-query-parser, which supports many of the queries, will need to have a dependency on the queries module. But that seems unavoidable at this stage. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3378) Some contribs depend on core tests to be compiled and fail when ant clean was done before
[ https://issues.apache.org/jira/browse/LUCENE-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086320#comment-13086320 ] Robert Muir commented on LUCENE-3378: - I agree, so the issue is still open for 3.x What i did was merge back the applicable improvements from the trunk patch, but the contrib classpath still contains src/test for now. I'll try to look at the queryparser tests, in general maybe we can cleanup here, i've noticed a lot of duplication in the tests before. hopefully we can clean up the tests a bit and fix the build at the same time... Some contribs depend on core tests to be compiled and fail when ant clean was done before - Key: LUCENE-3378 URL: https://issues.apache.org/jira/browse/LUCENE-3378 Project: Lucene - Java Issue Type: Bug Components: general/test Affects Versions: 3.4, 4.0 Reporter: Uwe Schindler Attachments: LUCENE-3378.patch If you do ant clean on the root level of Lucene and then go to e.g. contrib/queryparser (3.x only) or contrib/misc (3.x and trunk) and call ant test, the build of tests fails: - contrib/queryparser's ExtendedableQPTests extend a core TestQueryParser (3.x only, in module this works, of course) - contrib/misc/TestIndexSplitter uses a core class to build its index To find the root cause: We should first remove the core tests from contrib classpath, so the issue gets visible even without ant clean before. Then we can fix this. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3378) Some contribs depend on core tests to be compiled and fail when ant clean was done before
[ https://issues.apache.org/jira/browse/LUCENE-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086336#comment-13086336 ] Robert Muir commented on LUCENE-3378: - analyzers was broken too, i moved VocabularyAssert to tests-framework (trunk too) Some contribs depend on core tests to be compiled and fail when ant clean was done before - Key: LUCENE-3378 URL: https://issues.apache.org/jira/browse/LUCENE-3378 Project: Lucene - Java Issue Type: Bug Components: general/test Affects Versions: 3.4, 4.0 Reporter: Uwe Schindler Attachments: LUCENE-3378.patch If you do ant clean on the root level of Lucene and then go to e.g. contrib/queryparser (3.x only) or contrib/misc (3.x and trunk) and call ant test, the build of tests fails: - contrib/queryparser's ExtendedableQPTests extend a core TestQueryParser (3.x only, in module this works, of course) - contrib/misc/TestIndexSplitter uses a core class to build its index To find the root cause: We should first remove the core tests from contrib classpath, so the issue gets visible even without ant clean before. Then we can fix this. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-2714) JsonLoader does not handle null fields
JsonLoader does not handle null fields -- Key: SOLR-2714 URL: https://issues.apache.org/jira/browse/SOLR-2714 Project: Solr Issue Type: Bug Affects Versions: 3.3 Reporter: Trygve Laugstøl The parser in JsonLoader does not handle null fields when adding a document over http+json. Given this document: {code} [{ timestamp:2011-08-17T14:11:49.201Z, correlationId:N44YFGSQNC, logType:event, short:Invalidating session: 4zy6cvdtmvu1erlay0sn6rhz, long:null }] {code} I'm getting a response code=400 and the error message should finish doc first in the logs. It seems that JsonLoader is missing case for JSONParser.NULL in the parser even switch. * https://svn.apache.org/repos/asf/lucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/JsonLoader.java * https://svn.apache.org/repos/asf/labs/noggit/src/main/java/org/apache/noggit/JSONParser.java -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-3379) jre crashes in ArrayUtil mergeSort
[ https://issues.apache.org/jira/browse/LUCENE-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-3379: Attachment: hs_err_pid4624.log jre crashes in ArrayUtil mergeSort -- Key: LUCENE-3379 URL: https://issues.apache.org/jira/browse/LUCENE-3379 Project: Lucene - Java Issue Type: Bug Environment: 1.6.0_24 Reporter: Robert Muir Attachments: hs_err_pid4624.log while running the analyzers test, i got a JRE crash with 1.6.0_24 in {noformat} Current CompileTask: C2: 54 org.apache.lucene.util.SorterTemplate.merge(I)V (151 bytes) {noformat} {noformat} [junit] # [junit] # A fatal error has been detected by the Java Runtime Environment: [junit] # [junit] # SIGSEGV (0xb) at pc=0x7f768cc2f0ec, pid=4624, tid=140147041961728 [junit] # [junit] # JRE version: 6.0_24-b07 [junit] # Java VM: Java HotSpot(TM) 64-Bit Server VM (19.1-b02 mixed mode linux-amd64 compressed oops) [junit] # Problematic frame: [junit] # V [libjvm.so+0x3eb0ec] [junit] # [junit] # An error report file with more information is saved as: [junit] # /home/rmuir/workspace/lucene-trunk/modules/analysis/build/common/test/8/hs_err_pid4624.log [junit] # [junit] # If you would like to submit a bug report, please visit: [junit] # http://java.sun.com/webapps/bugreport/crash.jsp [junit] # {noformat} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (LUCENE-3379) jre crashes in ArrayUtil mergeSort
jre crashes in ArrayUtil mergeSort -- Key: LUCENE-3379 URL: https://issues.apache.org/jira/browse/LUCENE-3379 Project: Lucene - Java Issue Type: Bug Environment: 1.6.0_24 Reporter: Robert Muir Attachments: hs_err_pid4624.log while running the analyzers test, i got a JRE crash with 1.6.0_24 in {noformat} Current CompileTask: C2: 54 org.apache.lucene.util.SorterTemplate.merge(I)V (151 bytes) {noformat} {noformat} [junit] # [junit] # A fatal error has been detected by the Java Runtime Environment: [junit] # [junit] # SIGSEGV (0xb) at pc=0x7f768cc2f0ec, pid=4624, tid=140147041961728 [junit] # [junit] # JRE version: 6.0_24-b07 [junit] # Java VM: Java HotSpot(TM) 64-Bit Server VM (19.1-b02 mixed mode linux-amd64 compressed oops) [junit] # Problematic frame: [junit] # V [libjvm.so+0x3eb0ec] [junit] # [junit] # An error report file with more information is saved as: [junit] # /home/rmuir/workspace/lucene-trunk/modules/analysis/build/common/test/8/hs_err_pid4624.log [junit] # [junit] # If you would like to submit a bug report, please visit: [junit] # http://java.sun.com/webapps/bugreport/crash.jsp [junit] # {noformat} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2714) JsonLoader does not handle null fields
[ https://issues.apache.org/jira/browse/SOLR-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086360#comment-13086360 ] Yonik Seeley commented on SOLR-2714: Hmmm, while the JSON loader never advertised the ability to handle null values, there's probably no reason not to do so. I guess we should just drop null values. JsonLoader does not handle null fields -- Key: SOLR-2714 URL: https://issues.apache.org/jira/browse/SOLR-2714 Project: Solr Issue Type: Bug Affects Versions: 3.3 Reporter: Trygve Laugstøl The parser in JsonLoader does not handle null fields when adding a document over http+json. Given this document: {code} [{ timestamp:2011-08-17T14:11:49.201Z, correlationId:N44YFGSQNC, logType:event, short:Invalidating session: 4zy6cvdtmvu1erlay0sn6rhz, long:null }] {code} I'm getting a response code=400 and the error message should finish doc first in the logs. It seems that JsonLoader is missing case for JSONParser.NULL in the parser even switch. * https://svn.apache.org/repos/asf/lucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/JsonLoader.java * https://svn.apache.org/repos/asf/labs/noggit/src/main/java/org/apache/noggit/JSONParser.java -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3379) jre crashes in ArrayUtil mergeSort
[ https://issues.apache.org/jira/browse/LUCENE-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086371#comment-13086371 ] Robert Muir commented on LUCENE-3379: - looks like here is the offending test method: {noformat} testcase classname=org.apache.lucene.analysis.wikipedia.WikipediaTokenizerTest name=testStopWord time=0.0010 error message=Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit. type=junit.framework.AssertionFailedErrorjunit.framework.AssertionFailedError: Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit. at java.lang.Thread.run(Thread.java:662) /error {noformat} jre crashes in ArrayUtil mergeSort -- Key: LUCENE-3379 URL: https://issues.apache.org/jira/browse/LUCENE-3379 Project: Lucene - Java Issue Type: Bug Environment: 1.6.0_24 Reporter: Robert Muir Attachments: hs_err_pid4624.log while running the analyzers test, i got a JRE crash with 1.6.0_24 in {noformat} Current CompileTask: C2: 54 org.apache.lucene.util.SorterTemplate.merge(I)V (151 bytes) {noformat} {noformat} [junit] # [junit] # A fatal error has been detected by the Java Runtime Environment: [junit] # [junit] # SIGSEGV (0xb) at pc=0x7f768cc2f0ec, pid=4624, tid=140147041961728 [junit] # [junit] # JRE version: 6.0_24-b07 [junit] # Java VM: Java HotSpot(TM) 64-Bit Server VM (19.1-b02 mixed mode linux-amd64 compressed oops) [junit] # Problematic frame: [junit] # V [libjvm.so+0x3eb0ec] [junit] # [junit] # An error report file with more information is saved as: [junit] # /home/rmuir/workspace/lucene-trunk/modules/analysis/build/common/test/8/hs_err_pid4624.log [junit] # [junit] # If you would like to submit a bug report, please visit: [junit] # http://java.sun.com/webapps/bugreport/crash.jsp [junit] # {noformat} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-3379) jre crashes in ArrayUtil mergeSort
[ https://issues.apache.org/jira/browse/LUCENE-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-3379: Attachment: hs_err_pid25327.log Here's one from _26, with more information in the stacktrace: {noformat} Stack: [0x7f8534fd2000,0x7f85350d3000], sp=0x7f85350ce9c0, free space=1010k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) V [libjvm.so+0x4ac378] IndexSetIterator::advance_and_next()+0x58 V [libjvm.so+0x4a4e03] PhaseIFG::SquareUp()+0x143 V [libjvm.so+0x334930] PhaseChaitin::Register_Allocate()+0x760 V [libjvm.so+0x3a20ff] Compile::Code_Gen()+0x35f V [libjvm.so+0x39de56] Compile::Compile(ciEnv*, C2Compiler*, ciMethod*, int, bool, bool)+0x8f6 V [libjvm.so+0x320d2e] C2Compiler::compile_method(ciEnv*, ciMethod*, int)+0x9e V [libjvm.so+0x3a862a] CompileBroker::invoke_compiler_on_method(CompileTask*)+0x2ca V [libjvm.so+0x3a7f15] CompileBroker::compiler_thread_loop()+0x355 V [libjvm.so+0x81fbe9] compiler_thread_entry(JavaThread*, Thread*)+0x9 V [libjvm.so+0x8190f1] JavaThread::run()+0x121 V [libjvm.so+0x710adf] java_start(Thread*)+0x13f Current CompileTask: C2: 9130 70 org.apache.lucene.util.SorterTemplate.merge(I)V (151 bytes) {noformat} jre crashes in ArrayUtil mergeSort -- Key: LUCENE-3379 URL: https://issues.apache.org/jira/browse/LUCENE-3379 Project: Lucene - Java Issue Type: Bug Environment: 1.6.0_24 Reporter: Robert Muir Attachments: hs_err_pid25327.log, hs_err_pid4624.log while running the analyzers test, i got a JRE crash with 1.6.0_24 in {noformat} Current CompileTask: C2: 54 org.apache.lucene.util.SorterTemplate.merge(I)V (151 bytes) {noformat} {noformat} [junit] # [junit] # A fatal error has been detected by the Java Runtime Environment: [junit] # [junit] # SIGSEGV (0xb) at pc=0x7f768cc2f0ec, pid=4624, tid=140147041961728 [junit] # [junit] # JRE version: 6.0_24-b07 [junit] # Java VM: Java HotSpot(TM) 64-Bit Server VM (19.1-b02 mixed mode linux-amd64 compressed oops) [junit] # Problematic frame: [junit] # V [libjvm.so+0x3eb0ec] [junit] # [junit] # An error report file with more information is saved as: [junit] # /home/rmuir/workspace/lucene-trunk/modules/analysis/build/common/test/8/hs_err_pid4624.log [junit] # [junit] # If you would like to submit a bug report, please visit: [junit] # http://java.sun.com/webapps/bugreport/crash.jsp [junit] # {noformat} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3379) jre crashes in ArrayUtil mergeSort
[ https://issues.apache.org/jira/browse/LUCENE-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086437#comment-13086437 ] Robert Muir commented on LUCENE-3379: - i sucked in all ubuntu upgrades and rebooted, now i can't reproduce anymore (which is good as it wont annoy me hopefully). I'll keep the issue open a while in case someone else hits this. jre crashes in ArrayUtil mergeSort -- Key: LUCENE-3379 URL: https://issues.apache.org/jira/browse/LUCENE-3379 Project: Lucene - Java Issue Type: Bug Environment: 1.6.0_24 Reporter: Robert Muir Attachments: hs_err_pid25327.log, hs_err_pid4624.log while running the analyzers test, i got a JRE crash with 1.6.0_24 in {noformat} Current CompileTask: C2: 54 org.apache.lucene.util.SorterTemplate.merge(I)V (151 bytes) {noformat} {noformat} [junit] # [junit] # A fatal error has been detected by the Java Runtime Environment: [junit] # [junit] # SIGSEGV (0xb) at pc=0x7f768cc2f0ec, pid=4624, tid=140147041961728 [junit] # [junit] # JRE version: 6.0_24-b07 [junit] # Java VM: Java HotSpot(TM) 64-Bit Server VM (19.1-b02 mixed mode linux-amd64 compressed oops) [junit] # Problematic frame: [junit] # V [libjvm.so+0x3eb0ec] [junit] # [junit] # An error report file with more information is saved as: [junit] # /home/rmuir/workspace/lucene-trunk/modules/analysis/build/common/test/8/hs_err_pid4624.log [junit] # [junit] # If you would like to submit a bug report, please visit: [junit] # http://java.sun.com/webapps/bugreport/crash.jsp [junit] # {noformat} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[JENKINS-MAVEN] Lucene-Solr-Maven-3.x #220: POMs out of sync
Build: https://builds.apache.org/job/Lucene-Solr-Maven-3.x/220/ 5 tests failed. REGRESSION: org.apache.lucene.index.TestNRTThreads.testNRTThreads Error Message: europarl.lines.txt.gz (No such file or directory) Stack Trace: java.io.FileNotFoundException: europarl.lines.txt.gz (No such file or directory) at java.io.FileInputStream.open(Native Method) at java.io.FileInputStream.init(FileInputStream.java:137) at java.io.FileInputStream.init(FileInputStream.java:96) at org.apache.lucene.util.LineFileDocs.open(LineFileDocs.java:66) at org.apache.lucene.util.LineFileDocs.init(LineFileDocs.java:48) at org.apache.lucene.util.LineFileDocs.init(LineFileDocs.java:52) at org.apache.lucene.index.TestNRTThreads.testNRTThreads(TestNRTThreads.java:72) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) at org.junit.rules.TestWatchman$1.evaluate(TestWatchman.java:48) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76) at org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:1339) at org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:1241) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31) at org.junit.runners.ParentRunner.run(ParentRunner.java:236) at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:35) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:146) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:97) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103) at $Proxy0.invoke(Unknown Source) at org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:145) at org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcess(SurefireStarter.java:87) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:69) REGRESSION: org.apache.lucene.index.TestOptimizeForever.test Error Message: europarl.lines.txt.gz (No such file or directory) Stack Trace: java.io.FileNotFoundException: europarl.lines.txt.gz (No such file or directory) at java.io.FileInputStream.open(Native Method) at java.io.FileInputStream.init(FileInputStream.java:137) at java.io.FileInputStream.init(FileInputStream.java:96) at org.apache.lucene.util.LineFileDocs.open(LineFileDocs.java:66) at org.apache.lucene.util.LineFileDocs.init(LineFileDocs.java:48) at org.apache.lucene.util.LineFileDocs.init(LineFileDocs.java:52) at org.apache.lucene.index.TestOptimizeForever.test(TestOptimizeForever.java:64) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) at
[jira] [Updated] (LUCENE-3378) Some contribs depend on core tests to be compiled and fail when ant clean was done before
[ https://issues.apache.org/jira/browse/LUCENE-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-3378: Attachment: LUCENE-3378_qp.patch ok this fixes branch_3x. I refactored TestQueryParser into a QueryParserTestBase, and extended it by the core TestQP and this ExtendableQP. Really we should clean this up more for a bunch of the other QPs, but this is a start and fixes the build. Some contribs depend on core tests to be compiled and fail when ant clean was done before - Key: LUCENE-3378 URL: https://issues.apache.org/jira/browse/LUCENE-3378 Project: Lucene - Java Issue Type: Bug Components: general/test Affects Versions: 3.4, 4.0 Reporter: Uwe Schindler Attachments: LUCENE-3378.patch, LUCENE-3378_qp.patch If you do ant clean on the root level of Lucene and then go to e.g. contrib/queryparser (3.x only) or contrib/misc (3.x and trunk) and call ant test, the build of tests fails: - contrib/queryparser's ExtendedableQPTests extend a core TestQueryParser (3.x only, in module this works, of course) - contrib/misc/TestIndexSplitter uses a core class to build its index To find the root cause: We should first remove the core tests from contrib classpath, so the issue gets visible even without ant clean before. Then we can fix this. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3378) Some contribs depend on core tests to be compiled and fail when ant clean was done before
[ https://issues.apache.org/jira/browse/LUCENE-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086489#comment-13086489 ] Uwe Schindler commented on LUCENE-3378: --- I think thats fine as a start. This would not work in test-framework in trunk, but there we dont have that problem, as all QParsers live in one module. So the abstract base class can live there. Some contribs depend on core tests to be compiled and fail when ant clean was done before - Key: LUCENE-3378 URL: https://issues.apache.org/jira/browse/LUCENE-3378 Project: Lucene - Java Issue Type: Bug Components: general/test Affects Versions: 3.4, 4.0 Reporter: Uwe Schindler Attachments: LUCENE-3378.patch, LUCENE-3378_qp.patch If you do ant clean on the root level of Lucene and then go to e.g. contrib/queryparser (3.x only) or contrib/misc (3.x and trunk) and call ant test, the build of tests fails: - contrib/queryparser's ExtendedableQPTests extend a core TestQueryParser (3.x only, in module this works, of course) - contrib/misc/TestIndexSplitter uses a core class to build its index To find the root cause: We should first remove the core tests from contrib classpath, so the issue gets visible even without ant clean before. Then we can fix this. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2715) TestJMXSolrIntegration fails
[ https://issues.apache.org/jira/browse/SOLR-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086492#comment-13086492 ] Robert Muir commented on SOLR-2715: --- {noformat} [junit] Testsuite: org.apache.solr.core.TestJmxIntegration [junit] Testcase: testJmxOnCoreReload(org.apache.solr.core.TestJmxIntegration): FAILED [junit] Number of registered MBeans is not the same as info registry size expected:56 but was:50 [junit] junit.framework.AssertionFailedError: Number of registered MBeans is not the same as info registry size expected:56 but was:50 [junit] at org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:1339) [junit] at org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:1241) [junit] at org.apache.solr.core.TestJmxIntegration.testJmxOnCoreReload(TestJmxIntegration.java:137) [junit] [junit] [junit] Tests run: 3, Failures: 1, Errors: 0, Time elapsed: 2.158 sec [junit] [junit] - Standard Error - [junit] NOTE: reproduce with: ant test -Dtestcase=TestJmxIntegration -Dtestmethod=testJmxOnCoreReload -Dtests.seed=-4e5812346ffee146:-268851c422fba7f6:-55d2921d6d3e0d8d [junit] NOTE: test params are: locale=ms, timezone=America/Recife [junit] NOTE: all tests run in this JVM: [junit] [MinimalSchemaTest, SolrInfoMBeanTest, TestArabicFilters, TestBrazilianStemFilterFactory, TestDelimitedPayloadTokenFilterFactory, TestGermanMinimalStemFilterFactory, TestGreekStemFilterFactory, TestHyphenatedWordsFilter, TestIndonesianStemFilterFactory, TestReversedWildcardFilterFactory, TestShingleFilterFactory, TestThaiWordFilterFactory, RequestHandlersTest, TestJmxIntegration] [junit] NOTE: Linux 2.6.38-10-generic amd64/Sun Microsystems Inc. 1.6.0_24 (64-bit)/cpus=8,threads=1,free=249053128,total=350289920 [junit] - --- [junit] TEST org.apache.solr.core.TestJmxIntegration FAILED {noformat} TestJMXSolrIntegration fails Key: SOLR-2715 URL: https://issues.apache.org/jira/browse/SOLR-2715 Project: Solr Issue Type: Bug Affects Versions: 3.4 Reporter: Robert Muir Running the tests, this test fails (in a non-reproducible way). There might be some sort of timing issue here. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-2715) TestJMXSolrIntegration fails
TestJMXSolrIntegration fails Key: SOLR-2715 URL: https://issues.apache.org/jira/browse/SOLR-2715 Project: Solr Issue Type: Bug Affects Versions: 3.4 Reporter: Robert Muir Running the tests, this test fails (in a non-reproducible way). There might be some sort of timing issue here. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3360) Move FieldCache to IndexReader
[ https://issues.apache.org/jira/browse/LUCENE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086494#comment-13086494 ] Martijn van Groningen commented on LUCENE-3360: --- bq. True... so maybe do this patch in 2 steps? First, for 3.x. Then, merge to trunk, remove deprecated FC and fix all usages? Proposal: Get everything to work with the current deprecated FieldCache. Port to working code to 3x. Remove deprecated FieldCache from trunk and move its inner classes (like DocTermsIndex) to search.cache. FieldCache has also some static *_PARSER fields that are used in the *ValuesCreator classes. I think these fields should move to *ValuesCreator classes as private fields. Besides the tests these fields are only used in *ValuesCreator classes. Move FieldCache to IndexReader -- Key: LUCENE-3360 URL: https://issues.apache.org/jira/browse/LUCENE-3360 Project: Lucene - Java Issue Type: Improvement Reporter: Martijn van Groningen Fix For: 3.4, 4.0 Attachments: LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch Move the static FieldCache.DEFAULT field instance to atomic IndexReaders, so that FieldCache insanity caused by the WeakHashMap no longer occurs. * Add a new method to IndexReader that by default throws an UOE: {code}public FieldCache getFieldCache(){code} * The SegmentReader implements this method and returns its own internal FieldCache implementation. This implementation just uses a HashMapEntryT,Object to store entries. * The SlowMultiReaderWrapper implements this method as well and basically behaves the same as the current FieldCacheImpl. This issue won't solve the insanity that comes from inconsistent usage of a single field (for example retrieve both int[] and DocTermIndex for the same field). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3360) Move FieldCache to IndexReader
[ https://issues.apache.org/jira/browse/LUCENE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086497#comment-13086497 ] Uwe Schindler commented on LUCENE-3360: --- bq. FieldCache has also some static *_PARSER fields that are used in the *ValuesCreator classes. I think these fields should move to *ValuesCreator classes as private fields. Besides the tests these fields are only used in *ValuesCreator classes. They should only be public available... If ValueCreate classes are package private then its not good. The parsers are oftenh used when the field type is know before. E.g. to circumvent problems where the autodetection of old-style toString() numeric fields vs. NumericField is needed. So I always specify the NF parser explicitely on FieldCache.getLong(IR, Parser). Or is this no longer the case? Move FieldCache to IndexReader -- Key: LUCENE-3360 URL: https://issues.apache.org/jira/browse/LUCENE-3360 Project: Lucene - Java Issue Type: Improvement Reporter: Martijn van Groningen Fix For: 3.4, 4.0 Attachments: LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch Move the static FieldCache.DEFAULT field instance to atomic IndexReaders, so that FieldCache insanity caused by the WeakHashMap no longer occurs. * Add a new method to IndexReader that by default throws an UOE: {code}public FieldCache getFieldCache(){code} * The SegmentReader implements this method and returns its own internal FieldCache implementation. This implementation just uses a HashMapEntryT,Object to store entries. * The SlowMultiReaderWrapper implements this method as well and basically behaves the same as the current FieldCacheImpl. This issue won't solve the insanity that comes from inconsistent usage of a single field (for example retrieve both int[] and DocTermIndex for the same field). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2715) TestJMXSolrIntegration fails
[ https://issues.apache.org/jira/browse/SOLR-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086500#comment-13086500 ] Mark Miller commented on SOLR-2715: --- I see this too - I think I put a pause in there once before to make it go away - but now I have this faster computer and I still see it sometimes. If I remember right, something from jmx is asyncly taking too long and the test assumes its not async. TestJMXSolrIntegration fails Key: SOLR-2715 URL: https://issues.apache.org/jira/browse/SOLR-2715 Project: Solr Issue Type: Bug Affects Versions: 3.4 Reporter: Robert Muir Running the tests, this test fails (in a non-reproducible way). There might be some sort of timing issue here. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Resolved] (LUCENE-3378) Some contribs depend on core tests to be compiled and fail when ant clean was done before
[ https://issues.apache.org/jira/browse/LUCENE-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-3378. - Resolution: Fixed Fix Version/s: 4.0 3.4 All done... its good you brought this up Uwe, in fact the ExtendableQPTest was not overriding the correct method, so really it wasnt being tested (we were just running the core QP tests again) Some contribs depend on core tests to be compiled and fail when ant clean was done before - Key: LUCENE-3378 URL: https://issues.apache.org/jira/browse/LUCENE-3378 Project: Lucene - Java Issue Type: Bug Components: general/test Affects Versions: 3.4, 4.0 Reporter: Uwe Schindler Fix For: 3.4, 4.0 Attachments: LUCENE-3378.patch, LUCENE-3378_qp.patch If you do ant clean on the root level of Lucene and then go to e.g. contrib/queryparser (3.x only) or contrib/misc (3.x and trunk) and call ant test, the build of tests fails: - contrib/queryparser's ExtendedableQPTests extend a core TestQueryParser (3.x only, in module this works, of course) - contrib/misc/TestIndexSplitter uses a core class to build its index To find the root cause: We should first remove the core tests from contrib classpath, so the issue gets visible even without ant clean before. Then we can fix this. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[JENKINS-MAVEN] Lucene-Solr-Maven-trunk #220: POMs out of sync
Build: https://builds.apache.org/job/Lucene-Solr-Maven-trunk/220/ 8 tests failed. FAILED: org.apache.lucene.index.TestFlushByRamOrCountsPolicy.org.apache.lucene.index.TestFlushByRamOrCountsPolicy Error Message: europarl.lines.txt.gz (No such file or directory) Stack Trace: java.io.FileNotFoundException: europarl.lines.txt.gz (No such file or directory) at java.io.FileInputStream.open(Native Method) at java.io.FileInputStream.init(FileInputStream.java:137) at java.io.FileInputStream.init(FileInputStream.java:96) at org.apache.lucene.util.LineFileDocs.open(LineFileDocs.java:66) at org.apache.lucene.util.LineFileDocs.init(LineFileDocs.java:48) at org.apache.lucene.util.LineFileDocs.init(LineFileDocs.java:52) at org.apache.lucene.index.TestFlushByRamOrCountsPolicy.beforeClass(TestFlushByRamOrCountsPolicy.java:42) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:27) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31) at org.junit.runners.ParentRunner.run(ParentRunner.java:236) at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:35) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:146) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:97) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103) at $Proxy0.invoke(Unknown Source) at org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:145) at org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcess(SurefireStarter.java:87) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:69) FAILED: org.apache.lucene.index.TestFlushByRamOrCountsPolicy.org.apache.lucene.index.TestFlushByRamOrCountsPolicy Error Message: null Stack Trace: java.lang.NullPointerException at org.apache.lucene.index.TestFlushByRamOrCountsPolicy.afterClass(TestFlushByRamOrCountsPolicy.java:47) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:37) at org.junit.runners.ParentRunner.run(ParentRunner.java:236) at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:35) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:146) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:97) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103) at $Proxy0.invoke(Unknown Source) at org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:145) at org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcess(SurefireStarter.java:87) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:69) REGRESSION: org.apache.lucene.index.TestNRTThreads.testNRTThreads Error Message: europarl.lines.txt.gz
[jira] [Updated] (LUCENE-2308) Separately specify a field's type
[ https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikola Tankovic updated LUCENE-2308: Attachment: LUCENE-2308-merge-2.patch Further merging. Test pass, except for few wierd fails in Solr, please check. Next stop: fixing docs. Separately specify a field's type - Key: LUCENE-2308 URL: https://issues.apache.org/jira/browse/LUCENE-2308 Project: Lucene - Java Issue Type: Improvement Components: core/index Reporter: Michael McCandless Assignee: Michael McCandless Labels: gsoc2011, lucene-gsoc-11, mentor Fix For: 4.0 Attachments: LUCENE-2308-10.patch, LUCENE-2308-11.patch, LUCENE-2308-12.patch, LUCENE-2308-13.patch, LUCENE-2308-14.patch, LUCENE-2308-15.patch, LUCENE-2308-16.patch, LUCENE-2308-17.patch, LUCENE-2308-18.patch, LUCENE-2308-19.patch, LUCENE-2308-2.patch, LUCENE-2308-20.patch, LUCENE-2308-21.patch, LUCENE-2308-3.patch, LUCENE-2308-4.patch, LUCENE-2308-5.patch, LUCENE-2308-6.patch, LUCENE-2308-7.patch, LUCENE-2308-8.patch, LUCENE-2308-9.patch, LUCENE-2308-ltc.patch, LUCENE-2308-merge-1.patch, LUCENE-2308-merge-2.patch, LUCENE-2308.branchdiffs, LUCENE-2308.branchdiffs.moved, LUCENE-2308.patch, LUCENE-2308.patch This came up from dicussions on IRC. I'm summarizing here... Today when you make a Field to add to a document you can set things index or not, stored or not, analyzed or not, details like omitTfAP, omitNorms, index term vectors (separately controlling offsets/positions), etc. I think we should factor these out into a new class (FieldType?). Then you could re-use this FieldType instance across multiple fields. The Field instance would still hold the actual value. We could then do per-field analyzers by adding a setAnalyzer on the FieldType, instead of the separate PerFieldAnalzyerWrapper (likewise for per-field codecs (with flex), where we now have PerFieldCodecWrapper). This would NOT be a schema! It's just refactoring what we already specify today. EG it's not serialized into the index. This has been discussed before, and I know Michael Busch opened a more ambitious (I think?) issue. I think this is a good first baby step. We could consider a hierarchy of FIeldType (NumericFieldType, etc.) but maybe hold off on that for starters... -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-3360) Move FieldCache to IndexReader
[ https://issues.apache.org/jira/browse/LUCENE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-3360: -- Attachment: LUCENE-3360.patch Add new version of patch. * Renamed SegmentFieldCache to AtomicFieldCache. * SegementFieldCacheImpl is now package protected. This class has been moved to lucene.index package. * Added TestSegmentFieldCacheImpl test. Move FieldCache to IndexReader -- Key: LUCENE-3360 URL: https://issues.apache.org/jira/browse/LUCENE-3360 Project: Lucene - Java Issue Type: Improvement Reporter: Martijn van Groningen Fix For: 3.4, 4.0 Attachments: LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch Move the static FieldCache.DEFAULT field instance to atomic IndexReaders, so that FieldCache insanity caused by the WeakHashMap no longer occurs. * Add a new method to IndexReader that by default throws an UOE: {code}public FieldCache getFieldCache(){code} * The SegmentReader implements this method and returns its own internal FieldCache implementation. This implementation just uses a HashMapEntryT,Object to store entries. * The SlowMultiReaderWrapper implements this method as well and basically behaves the same as the current FieldCacheImpl. This issue won't solve the insanity that comes from inconsistent usage of a single field (for example retrieve both int[] and DocTermIndex for the same field). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Issue Comment Edited] (LUCENE-3360) Move FieldCache to IndexReader
[ https://issues.apache.org/jira/browse/LUCENE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086571#comment-13086571 ] Martijn van Groningen edited comment on LUCENE-3360 at 8/17/11 8:33 PM: Added a new version of patch. * Renamed SegmentFieldCache to AtomicFieldCache. * SegementFieldCacheImpl is now package protected. This class has been moved to lucene.index package. * Added TestSegmentFieldCacheImpl test. was (Author: martijn.v.groningen): Add new version of patch. * Renamed SegmentFieldCache to AtomicFieldCache. * SegementFieldCacheImpl is now package protected. This class has been moved to lucene.index package. * Added TestSegmentFieldCacheImpl test. Move FieldCache to IndexReader -- Key: LUCENE-3360 URL: https://issues.apache.org/jira/browse/LUCENE-3360 Project: Lucene - Java Issue Type: Improvement Reporter: Martijn van Groningen Fix For: 3.4, 4.0 Attachments: LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch Move the static FieldCache.DEFAULT field instance to atomic IndexReaders, so that FieldCache insanity caused by the WeakHashMap no longer occurs. * Add a new method to IndexReader that by default throws an UOE: {code}public FieldCache getFieldCache(){code} * The SegmentReader implements this method and returns its own internal FieldCache implementation. This implementation just uses a HashMapEntryT,Object to store entries. * The SlowMultiReaderWrapper implements this method as well and basically behaves the same as the current FieldCacheImpl. This issue won't solve the insanity that comes from inconsistent usage of a single field (for example retrieve both int[] and DocTermIndex for the same field). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3360) Move FieldCache to IndexReader
[ https://issues.apache.org/jira/browse/LUCENE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086570#comment-13086570 ] Martijn van Groningen commented on LUCENE-3360: --- bq. E.g. to circumvent problems where the autodetection of old-style toString() numeric fields vs. NumericField is needed. You mean this problem in LongValuesCreator#fillLongValues: {code} if( parser == null ) { try { parser = FieldCache.DEFAULT_LONG_PARSER; fillLongValues( vals, reader, field ); return; } catch (NumberFormatException ne) { vals.parserHashCode = null; // wipe the previous one parser = FieldCache.NUMERIC_UTILS_LONG_PARSER; fillLongValues( vals, reader, field ); return; } } {code} Anyway we can make these *_PARSER fields publicly available. Would the search.cache.parsers package be a good location? Move FieldCache to IndexReader -- Key: LUCENE-3360 URL: https://issues.apache.org/jira/browse/LUCENE-3360 Project: Lucene - Java Issue Type: Improvement Reporter: Martijn van Groningen Fix For: 3.4, 4.0 Attachments: LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch Move the static FieldCache.DEFAULT field instance to atomic IndexReaders, so that FieldCache insanity caused by the WeakHashMap no longer occurs. * Add a new method to IndexReader that by default throws an UOE: {code}public FieldCache getFieldCache(){code} * The SegmentReader implements this method and returns its own internal FieldCache implementation. This implementation just uses a HashMapEntryT,Object to store entries. * The SlowMultiReaderWrapper implements this method as well and basically behaves the same as the current FieldCacheImpl. This issue won't solve the insanity that comes from inconsistent usage of a single field (for example retrieve both int[] and DocTermIndex for the same field). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2588) Make Velocity an optional dependency in SolrCore
[ https://issues.apache.org/jira/browse/SOLR-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086573#comment-13086573 ] Erik Hatcher commented on SOLR-2588: David - I'm going to tackle this one by simply moving VrW back to a contrib module. Easy enough, and makes sense in light of the unneeded core hard dependency. Make Velocity an optional dependency in SolrCore Key: SOLR-2588 URL: https://issues.apache.org/jira/browse/SOLR-2588 Project: Solr Issue Type: Wish Affects Versions: 3.2 Reporter: Gunnar Wagenknecht Assignee: Erik Hatcher Priority: Minor Fix For: 3.4, 4.0 Attachments: SOLR-2588_Don_t_fail_if_velocity_libs_not_present_.patch In 1.4. it was fine to run Solr without Velocity on the classpath. However, in 3.2. SolrCore won't load because of a hard reference to the Velocity response writer in a static initializer. {noformat} ... ERROR org.apache.solr.core.CoreContainer - java.lang.NoClassDefFoundError: org/apache/velocity/context/Context at org.apache.solr.core.SolrCore.clinit(SolrCore.java:1447) at org.apache.solr.core.CoreContainer.create(CoreContainer.java:463) at org.apache.solr.core.CoreContainer.load(CoreContainer.java:316) at org.apache.solr.core.CoreContainer.load(CoreContainer.java:207) {noformat} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Assigned] (SOLR-2588) Make Velocity an optional dependency in SolrCore
[ https://issues.apache.org/jira/browse/SOLR-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Hatcher reassigned SOLR-2588: -- Assignee: Erik Hatcher (was: David Smiley) Make Velocity an optional dependency in SolrCore Key: SOLR-2588 URL: https://issues.apache.org/jira/browse/SOLR-2588 Project: Solr Issue Type: Wish Affects Versions: 3.2 Reporter: Gunnar Wagenknecht Assignee: Erik Hatcher Priority: Minor Fix For: 3.4, 4.0 Attachments: SOLR-2588_Don_t_fail_if_velocity_libs_not_present_.patch In 1.4. it was fine to run Solr without Velocity on the classpath. However, in 3.2. SolrCore won't load because of a hard reference to the Velocity response writer in a static initializer. {noformat} ... ERROR org.apache.solr.core.CoreContainer - java.lang.NoClassDefFoundError: org/apache/velocity/context/Context at org.apache.solr.core.SolrCore.clinit(SolrCore.java:1447) at org.apache.solr.core.CoreContainer.create(CoreContainer.java:463) at org.apache.solr.core.CoreContainer.load(CoreContainer.java:316) at org.apache.solr.core.CoreContainer.load(CoreContainer.java:207) {noformat} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3360) Move FieldCache to IndexReader
[ https://issues.apache.org/jira/browse/LUCENE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086580#comment-13086580 ] Uwe Schindler commented on LUCENE-3360: --- bq. You mean this problem in LongValuesCreator#fillLongValues: Yes, same for the other types! Move FieldCache to IndexReader -- Key: LUCENE-3360 URL: https://issues.apache.org/jira/browse/LUCENE-3360 Project: Lucene - Java Issue Type: Improvement Reporter: Martijn van Groningen Fix For: 3.4, 4.0 Attachments: LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch Move the static FieldCache.DEFAULT field instance to atomic IndexReaders, so that FieldCache insanity caused by the WeakHashMap no longer occurs. * Add a new method to IndexReader that by default throws an UOE: {code}public FieldCache getFieldCache(){code} * The SegmentReader implements this method and returns its own internal FieldCache implementation. This implementation just uses a HashMapEntryT,Object to store entries. * The SlowMultiReaderWrapper implements this method as well and basically behaves the same as the current FieldCacheImpl. This issue won't solve the insanity that comes from inconsistent usage of a single field (for example retrieve both int[] and DocTermIndex for the same field). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Resolved] (LUCENE-3330) revise Scorer visitor API
[ https://issues.apache.org/jira/browse/LUCENE-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-3330. - Resolution: Fixed Assignee: Robert Muir revise Scorer visitor API - Key: LUCENE-3330 URL: https://issues.apache.org/jira/browse/LUCENE-3330 Project: Lucene - Java Issue Type: Improvement Reporter: Robert Muir Assignee: Robert Muir Fix For: 4.0 Attachments: LUCENE-3330.patch Currently there is an (expert) API in scorer to allow you to take a scorer, and visit its children etc (e.g. booleanquery). I think we should improve this, so its general to all queries. The current issues are: * the current api is hardcoded for booleanquery's Occurs, but we should support other types of children (e.g. disjunctionmax) * it can be difficult to use the API, because of the amount of generics and the visitor callback API. * the current API enforces a DFS traversal when you might prefer BFS instead. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
Solr QueryResultKey hashCode() and equals()
Hi there, Hopefully I'm not misunderstanding the situation but after playing around with cache warming in Solr I found that the order of the Query objects within the filters list makes a difference to the equals() and hashCode() methods. Query query = new TermQuery(new Term(field1, value1)); Query filter1 = new TermQuery(new Term(field2, value2)); Query filter2 = new TermQuery(new Term(field3, value3)); ListQuery filters1 = new ArrayListQuery(); filters1.add(filter1); filters1.add(filter2); ListQuery filters2 = new ArrayListQuery(); filters2.add(filter2); filters2.add(filter1); QueryResultKey key1 = new QueryResultKey(query, filters1, null, 0); QueryResultKey key2 = new QueryResultKey(query, filters2, null, 0); // Both the following assertions fail assert key1.equals(key2); assert key1.hashCode() == key2.hashCode(); I found that it resulted in a cache miss for two queries that have the same results just because the filters had a different ordering. Am I missing something or is there an opportunity to improve the chance of matching cache entries?
[JENKINS] Lucene-Solr-tests-only-trunk-java7 - Build # 260 - Failure
Build: https://builds.apache.org/job/Lucene-Solr-tests-only-trunk-java7/260/ 3 tests failed. REGRESSION: org.apache.solr.update.AutoCommitTest.testSoftAndHardCommitMaxTime Error Message: expected:2 but was:3 Stack Trace: junit.framework.AssertionFailedError: expected:2 but was:3 at org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:1526) at org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:1428) at org.apache.solr.update.AutoCommitTest.testSoftAndHardCommitMaxTime(AutoCommitTest.java:438) FAILED: init.org.apache.solr.client.solrj.response.FacetFieldTest Error Message: org.apache.solr.client.solrj.response.FacetFieldTest Stack Trace: java.lang.ClassNotFoundException: org.apache.solr.client.solrj.response.FacetFieldTest at java.net.URLClassLoader$1.run(URLClassLoader.java:366) at java.net.URLClassLoader$1.run(URLClassLoader.java:355) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:354) at java.lang.ClassLoader.loadClass(ClassLoader.java:423) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308) at java.lang.ClassLoader.loadClass(ClassLoader.java:356) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:186) FAILED: init.org.apache.solr.common.util.FileUtilsTest Error Message: org.apache.solr.common.util.FileUtilsTest Stack Trace: java.lang.ClassNotFoundException: org.apache.solr.common.util.FileUtilsTest at java.net.URLClassLoader$1.run(URLClassLoader.java:366) at java.net.URLClassLoader$1.run(URLClassLoader.java:355) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:354) at java.lang.ClassLoader.loadClass(ClassLoader.java:423) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308) at java.lang.ClassLoader.loadClass(ClassLoader.java:356) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:186) Build Log (for compile errors): [...truncated 11145 lines...] - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3374) move nrtcachingdir to core in 4.0
[ https://issues.apache.org/jira/browse/LUCENE-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086609#comment-13086609 ] Robert Muir commented on LUCENE-3374: - I ran them again and got a fail: {noformat} [junit] Testsuite: org.apache.lucene.index.TestCrash [junit] Testcase: testWriterAfterCrash(org.apache.lucene.index.TestCrash): FAILED [junit] (null) [junit] junit.framework.AssertionFailedError [junit] at org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:1535) [junit] at org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:1437) [junit] at org.apache.lucene.store.NRTCachingDirectory.deleteFile(NRTCachingDirectory.java:158) [junit] at org.apache.lucene.store.MockDirectoryWrapper.deleteFile(MockDirectoryWrapper.java:336) [junit] at org.apache.lucene.store.MockDirectoryWrapper.deleteFile(MockDirectoryWrapper.java:294) [junit] at org.apache.lucene.index.IndexFileDeleter.deleteFile(IndexFileDeleter.java:572) [junit] at org.apache.lucene.index.IndexFileDeleter.init(IndexFileDeleter.java:273) [junit] at org.apache.lucene.index.IndexWriter.init(IndexWriter.java:906) [junit] at org.apache.lucene.index.TestCrash.initIndex(TestCrash.java:39) [junit] at org.apache.lucene.index.TestCrash.testWriterAfterCrash(TestCrash.java:85) [junit] [junit] [junit] Tests run: 7, Failures: 1, Errors: 0, Time elapsed: 6.618 sec [junit] [junit] - Standard Error - [junit] NOTE: reproduce with: ant test -Dtestcase=TestCrash -Dtestmethod=testWriterAfterCrash -Dtests.seed=3196b05b20cf6a20:6f1b3eaa7f0f71ee:557c08ae3c634d12 [junit] NOTE: test params are: codec=RandomCodecProvider: {id=MockVariableIntBlock(baseBlockSize=68), content=Pulsing(freqCutoff=16)}, locale=de_CH, timezone=Asia/Jakarta [junit] NOTE: all tests run in this JVM: [junit] [TestAssertions, TestCharTermAttributeImpl, TestAtomicUpdate, TestByteSlices, TestCodecs, TestCrash] [junit] NOTE: Linux 2.6.38-10-generic amd64/Sun Microsystems Inc. 1.6.0_24 (64-bit)/cpus=8,threads=1,free=248890808,total=349569024 [junit] - --- [junit] TEST org.apache.lucene.index.TestCrash FAILED {noformat} So I cannot commit this patch just yet, I'll look into this fail later this evening. move nrtcachingdir to core in 4.0 - Key: LUCENE-3374 URL: https://issues.apache.org/jira/browse/LUCENE-3374 Project: Lucene - Java Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-3374.patch in 4.0 with the IOContext changes this implementation is clean and I think we should move it to core and use it in our tests etc. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2654) lockType/ not used consistently in all places Directory objects are instantiated
[ https://issues.apache.org/jira/browse/SOLR-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086618#comment-13086618 ] Mark Miller commented on SOLR-2654: --- This makes one change in lucene that I could break out into it's own issue, but it's rather small - so I will collect any opinions here for now: I take the ensureOpen check out of IndexWriter on getDirectory. Anyone object? I don't know why we care if the IndexWriter is still open if we want to grab which Directory it used. You can hack around it, but I don't see why we don't just remove the check. Thoughts? lockType/ not used consistently in all places Directory objects are instantiated -- Key: SOLR-2654 URL: https://issues.apache.org/jira/browse/SOLR-2654 Project: Solr Issue Type: Bug Reporter: Hoss Man Assignee: Mark Miller Fix For: 3.4, 4.0 Attachments: SOLR-2654.patch, SOLR-2654.patch, SOLR-2654.patch, SOLR-2654.patch, SOLR-2654.patch, SOLR-2654.patch, SOLR-2654.patch, SOLR-2698.patch nipunb noted on the mailing list then when configuring solr to use an alternate lockType/ (ie: simple) the stats for the SolrIndexSearcher list NativeFSLockFactory being used by the Directory. The problem seems to be that SolrIndexConfig is not consulted when constructing Directory objects used for IndexReader (it's only used by SolrIndexWriter) I don't _think_ this is a problem in most cases since the IndexReaders should all be readOnly in the core solr code) but plugins could attempt to use them in other ways. In general it seems like a really bad bug waiting to happen. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-1768) NumericRange support for new query parser
[ https://issues.apache.org/jira/browse/LUCENE-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086636#comment-13086636 ] Adriano Crestani commented on LUCENE-1768: -- {quote} Adriano: Can you summarize all your changes in both issues into a changes.txt entry for both branches? {quote} Hi Uwe, yes, I can do it, I will need to review the entire code again (3x and trunk). I plan to do this during the weekend. But if you want, commit Vinicius's code and I commit the changes to changes.txt later ;) NumericRange support for new query parser - Key: LUCENE-1768 URL: https://issues.apache.org/jira/browse/LUCENE-1768 Project: Lucene - Java Issue Type: New Feature Components: core/queryparser Affects Versions: 2.9 Reporter: Uwe Schindler Assignee: Uwe Schindler Labels: contrib, gsoc, gsoc2011, lucene-gsoc-11, mentor Fix For: 4.0 Attachments: TestNumericQueryParser-fix.patch, TestNumericQueryParser-fix.patch, TestNumericQueryParser-fix.patch, TestNumericQueryParser-fix.patch, week-7.patch, week-8.patch, week1.patch, week11-13_for_lucene_3x.patch, week11-13_for_lucene_3x.patch, week2.patch, week3.patch, week4.patch, week5-6.patch It would be good to specify some type of schema for the query parser in future, to automatically create NumericRangeQuery for different numeric types? It would then be possible to index a numeric value (double,float,long,int) using NumericField and then the query parser knows, which type of field this is and so it correctly creates a NumericRangeQuery for strings like [1.567..*] or (1.787..19.5]. There is currently no way to extract if a field is numeric from the index, so the user will have to configure the FieldConfig objects in the ConfigHandler. But if this is done, it will not be that difficult to implement the rest. The only difference between the current handling of RangeQuery is then the instantiation of the correct Query type and conversion of the entered numeric values (simple Number.valueOf(...) cast of the user entered numbers). Evenerything else is identical, NumericRangeQuery also supports the MTQ rewrite modes (as it is a MTQ). Another thing is a change in Date semantics. There are some strange flags in the current parser that tells it how to handle dates. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-1768) NumericRange support for new query parser
[ https://issues.apache.org/jira/browse/LUCENE-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086637#comment-13086637 ] Uwe Schindler commented on LUCENE-1768: --- OK. Of course, also Vinicius can help :-) NumericRange support for new query parser - Key: LUCENE-1768 URL: https://issues.apache.org/jira/browse/LUCENE-1768 Project: Lucene - Java Issue Type: New Feature Components: core/queryparser Affects Versions: 2.9 Reporter: Uwe Schindler Assignee: Uwe Schindler Labels: contrib, gsoc, gsoc2011, lucene-gsoc-11, mentor Fix For: 4.0 Attachments: TestNumericQueryParser-fix.patch, TestNumericQueryParser-fix.patch, TestNumericQueryParser-fix.patch, TestNumericQueryParser-fix.patch, week-7.patch, week-8.patch, week1.patch, week11-13_for_lucene_3x.patch, week11-13_for_lucene_3x.patch, week2.patch, week3.patch, week4.patch, week5-6.patch It would be good to specify some type of schema for the query parser in future, to automatically create NumericRangeQuery for different numeric types? It would then be possible to index a numeric value (double,float,long,int) using NumericField and then the query parser knows, which type of field this is and so it correctly creates a NumericRangeQuery for strings like [1.567..*] or (1.787..19.5]. There is currently no way to extract if a field is numeric from the index, so the user will have to configure the FieldConfig objects in the ConfigHandler. But if this is done, it will not be that difficult to implement the rest. The only difference between the current handling of RangeQuery is then the instantiation of the correct Query type and conversion of the entered numeric values (simple Number.valueOf(...) cast of the user entered numbers). Evenerything else is identical, NumericRangeQuery also supports the MTQ rewrite modes (as it is a MTQ). Another thing is a change in Date semantics. There are some strange flags in the current parser that tells it how to handle dates. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-2654) lockType/ not used consistently in all places Directory objects are instantiated
[ https://issues.apache.org/jira/browse/SOLR-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-2654: -- Attachment: SOLR-2654.patch Another, more cleaned up, patch. lockType/ not used consistently in all places Directory objects are instantiated -- Key: SOLR-2654 URL: https://issues.apache.org/jira/browse/SOLR-2654 Project: Solr Issue Type: Bug Reporter: Hoss Man Assignee: Mark Miller Fix For: 3.4, 4.0 Attachments: SOLR-2654.patch, SOLR-2654.patch, SOLR-2654.patch, SOLR-2654.patch, SOLR-2654.patch, SOLR-2654.patch, SOLR-2654.patch, SOLR-2654.patch, SOLR-2698.patch nipunb noted on the mailing list then when configuring solr to use an alternate lockType/ (ie: simple) the stats for the SolrIndexSearcher list NativeFSLockFactory being used by the Directory. The problem seems to be that SolrIndexConfig is not consulted when constructing Directory objects used for IndexReader (it's only used by SolrIndexWriter) I don't _think_ this is a problem in most cases since the IndexReaders should all be readOnly in the core solr code) but plugins could attempt to use them in other ways. In general it seems like a really bad bug waiting to happen. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2308) Separately specify a field's type
[ https://issues.apache.org/jira/browse/LUCENE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086656#comment-13086656 ] Michael McCandless commented on LUCENE-2308: Great progress! I'll commit shortly! But, strangely, I see TestStressNRT failing: spooky! Separately specify a field's type - Key: LUCENE-2308 URL: https://issues.apache.org/jira/browse/LUCENE-2308 Project: Lucene - Java Issue Type: Improvement Components: core/index Reporter: Michael McCandless Assignee: Michael McCandless Labels: gsoc2011, lucene-gsoc-11, mentor Fix For: 4.0 Attachments: LUCENE-2308-10.patch, LUCENE-2308-11.patch, LUCENE-2308-12.patch, LUCENE-2308-13.patch, LUCENE-2308-14.patch, LUCENE-2308-15.patch, LUCENE-2308-16.patch, LUCENE-2308-17.patch, LUCENE-2308-18.patch, LUCENE-2308-19.patch, LUCENE-2308-2.patch, LUCENE-2308-20.patch, LUCENE-2308-21.patch, LUCENE-2308-3.patch, LUCENE-2308-4.patch, LUCENE-2308-5.patch, LUCENE-2308-6.patch, LUCENE-2308-7.patch, LUCENE-2308-8.patch, LUCENE-2308-9.patch, LUCENE-2308-ltc.patch, LUCENE-2308-merge-1.patch, LUCENE-2308-merge-2.patch, LUCENE-2308.branchdiffs, LUCENE-2308.branchdiffs.moved, LUCENE-2308.patch, LUCENE-2308.patch This came up from dicussions on IRC. I'm summarizing here... Today when you make a Field to add to a document you can set things index or not, stored or not, analyzed or not, details like omitTfAP, omitNorms, index term vectors (separately controlling offsets/positions), etc. I think we should factor these out into a new class (FieldType?). Then you could re-use this FieldType instance across multiple fields. The Field instance would still hold the actual value. We could then do per-field analyzers by adding a setAnalyzer on the FieldType, instead of the separate PerFieldAnalzyerWrapper (likewise for per-field codecs (with flex), where we now have PerFieldCodecWrapper). This would NOT be a schema! It's just refactoring what we already specify today. EG it's not serialized into the index. This has been discussed before, and I know Michael Busch opened a more ambitious (I think?) issue. I think this is a good first baby step. We could consider a hierarchy of FIeldType (NumericFieldType, etc.) but maybe hold off on that for starters... -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
Re: Solr QueryResultKey hashCode() and equals()
: with cache warming in Solr I found that the order of the Query objects : within the filters list makes a difference to the equals() and hashCode() : methods. ... : I found that it resulted in a cache miss for two queries that have the same : results just because the filters had a different ordering. Am I missing : something or is there an opportunity to improve the chance of matching cache : entries? I haven't dug into the code, but i suspect you are probably correct. Please open an issue drawing attention to this, but off the top of my head I'm not sure if there is a practical solution inside Solr -- Query classes aren't Comparable, so we can't do anythin simple like sort the List when executing the query or building the cache key. -Hoss - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-2716) QueryResultKey hashCode() and equals() is dependent on filter order
QueryResultKey hashCode() and equals() is dependent on filter order --- Key: SOLR-2716 URL: https://issues.apache.org/jira/browse/SOLR-2716 Project: Solr Issue Type: Improvement Components: search Affects Versions: 3.3 Reporter: Neil Prosser Priority: Minor The hashCode() and equals() methods of a QueryResultKey are dependent on the order of the filters meaning that potentially identical result sets are missed when cached. {{Query query = new TermQuery(new Term(field1, value1)); Query filter1 = new TermQuery(new Term(field2, value2)); Query filter2 = new TermQuery(new Term(field3, value3)); ListQuery filters1 = new ArrayListQuery(); filters1.add(filter1); filters1.add(filter2); ListQuery filters2 = new ArrayListQuery(); filters2.add(filter2); filters2.add(filter1); QueryResultKey key1 = new QueryResultKey(query, filters1, null, 0); QueryResultKey key2 = new QueryResultKey(query, filters2, null, 0); // Both the following assertions fail assert key1.equals(key2); assert key1.hashCode() == key2.hashCode();}} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-2716) QueryResultKey hashCode() and equals() is dependent on filter order
[ https://issues.apache.org/jira/browse/SOLR-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neil Prosser updated SOLR-2716: --- Description: The hashCode() and equals() methods of a QueryResultKey are dependent on the order of the filters meaning that potentially identical result sets are missed when cached. Query query = new TermQuery(new Term(field1, value1)); Query filter1 = new TermQuery(new Term(field2, value2)); Query filter2 = new TermQuery(new Term(field3, value3)); ListQuery filters1 = new ArrayListQuery(); filters1.add(filter1); filters1.add(filter2); ListQuery filters2 = new ArrayListQuery(); filters2.add(filter2); filters2.add(filter1); QueryResultKey key1 = new QueryResultKey(query, filters1, null, 0); QueryResultKey key2 = new QueryResultKey(query, filters2, null, 0); // Both the following assertions fail assert key1.equals(key2); assert key1.hashCode() == key2.hashCode(); was: The hashCode() and equals() methods of a QueryResultKey are dependent on the order of the filters meaning that potentially identical result sets are missed when cached. {{Query query = new TermQuery(new Term(field1, value1)); Query filter1 = new TermQuery(new Term(field2, value2)); Query filter2 = new TermQuery(new Term(field3, value3)); ListQuery filters1 = new ArrayListQuery(); filters1.add(filter1); filters1.add(filter2); ListQuery filters2 = new ArrayListQuery(); filters2.add(filter2); filters2.add(filter1); QueryResultKey key1 = new QueryResultKey(query, filters1, null, 0); QueryResultKey key2 = new QueryResultKey(query, filters2, null, 0); // Both the following assertions fail assert key1.equals(key2); assert key1.hashCode() == key2.hashCode();}} QueryResultKey hashCode() and equals() is dependent on filter order --- Key: SOLR-2716 URL: https://issues.apache.org/jira/browse/SOLR-2716 Project: Solr Issue Type: Improvement Components: search Affects Versions: 3.3 Reporter: Neil Prosser Priority: Minor The hashCode() and equals() methods of a QueryResultKey are dependent on the order of the filters meaning that potentially identical result sets are missed when cached. Query query = new TermQuery(new Term(field1, value1)); Query filter1 = new TermQuery(new Term(field2, value2)); Query filter2 = new TermQuery(new Term(field3, value3)); ListQuery filters1 = new ArrayListQuery(); filters1.add(filter1); filters1.add(filter2); ListQuery filters2 = new ArrayListQuery(); filters2.add(filter2); filters2.add(filter1); QueryResultKey key1 = new QueryResultKey(query, filters1, null, 0); QueryResultKey key2 = new QueryResultKey(query, filters2, null, 0); // Both the following assertions fail assert key1.equals(key2); assert key1.hashCode() == key2.hashCode(); -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
Re: Solr QueryResultKey hashCode() and equals()
I've opened SOLR-2716 (https://issues.apache.org/jira/browse/SOLR-2716). Would it be possible to use a custom class or List implementation which generates a hash code in such a way that the order they are combined makes no difference? The change only really needs to effect whether a key is selected from the cache rather than altering the order of the filters. On 17 August 2011 23:52, Chris Hostetter hossman_luc...@fucit.org wrote: : with cache warming in Solr I found that the order of the Query objects : within the filters list makes a difference to the equals() and hashCode() : methods. ... : I found that it resulted in a cache miss for two queries that have the same : results just because the filters had a different ordering. Am I missing : something or is there an opportunity to improve the chance of matching cache : entries? I haven't dug into the code, but i suspect you are probably correct. Please open an issue drawing attention to this, but off the top of my head I'm not sure if there is a practical solution inside Solr -- Query classes aren't Comparable, so we can't do anythin simple like sort the List when executing the query or building the cache key. -Hoss - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
Re: Solr QueryResultKey hashCode() and equals()
: Would it be possible to use a custom class or List implementation which : generates a hash code in such a way that the order they are combined makes : no difference? The change only really needs to effect whether a key is : selected from the cache rather than altering the order of the filters. possible ... but hashCode isn't enough to ensure that you get a recognised cache hit, equality is what really matters (hence my comment about sorting the List to ensure a consistent order) Of course, it may be that somthing as simple as changeing hte cache key to use a Set instead of a List would solve this (of the top of my head i can't think of any way that owuld cause a problem) Wanna take a crack at a patch and attach it to the issue? -Hoss - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2654) lockType/ not used consistently in all places Directory objects are instantiated
[ https://issues.apache.org/jira/browse/SOLR-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086709#comment-13086709 ] Robert Muir commented on SOLR-2654: --- {quote} I take the ensureOpen check out of IndexWriter on getDirectory. Anyone object? I don't know why we care if the IndexWriter is still open if we want to grab which Directory it used. You can hack around it, but I don't see why we don't just remove the check. Thoughts? {quote} +1... its just a getter for the Dir, no reason to ensure its open. you might just want to do instanceof or something. In any case, the Directory *itself* not indexwriter should be calling ensureOpen before doing things that require an open dir. Maybe we could spin off a separate issue to make a test for this, i know its inconsistent everywhere. lockType/ not used consistently in all places Directory objects are instantiated -- Key: SOLR-2654 URL: https://issues.apache.org/jira/browse/SOLR-2654 Project: Solr Issue Type: Bug Reporter: Hoss Man Assignee: Mark Miller Fix For: 3.4, 4.0 Attachments: SOLR-2654.patch, SOLR-2654.patch, SOLR-2654.patch, SOLR-2654.patch, SOLR-2654.patch, SOLR-2654.patch, SOLR-2654.patch, SOLR-2654.patch, SOLR-2698.patch nipunb noted on the mailing list then when configuring solr to use an alternate lockType/ (ie: simple) the stats for the SolrIndexSearcher list NativeFSLockFactory being used by the Directory. The problem seems to be that SolrIndexConfig is not consulted when constructing Directory objects used for IndexReader (it's only used by SolrIndexWriter) I don't _think_ this is a problem in most cases since the IndexReaders should all be readOnly in the core solr code) but plugins could attempt to use them in other ways. In general it seems like a really bad bug waiting to happen. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-3374) move nrtcachingdir to core in 4.0
[ https://issues.apache.org/jira/browse/LUCENE-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-3374: Attachment: LUCENE-3374.patch updated patch: I fixed TestCrash, because this crazy test does evil things that violate the assert (the assert itself looks good and I think we want it enabled). So I added expert 'maybeWrap' booleans so that crazy tests like this can intentionally not use NRTCachingDir. But, there are more problems in other tests (FNFEs). I wired the boolean with a nocommit to true in the patch so that these occur every time. might be a real bug in here... move nrtcachingdir to core in 4.0 - Key: LUCENE-3374 URL: https://issues.apache.org/jira/browse/LUCENE-3374 Project: Lucene - Java Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-3374.patch, LUCENE-3374.patch in 4.0 with the IOContext changes this implementation is clean and I think we should move it to core and use it in our tests etc. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-2588) Make Velocity an optional dependency in SolrCore
[ https://issues.apache.org/jira/browse/SOLR-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Hatcher updated SOLR-2588: --- Attachment: SOLR-2588.patch Here's a patch that moves VelocityResponseWriter back to contrib/velocity and adjusts the example configuration to include it explicitly such that /browse still works. What other loose ends are there? Maybe something with Maven (POMs and such)? Make Velocity an optional dependency in SolrCore Key: SOLR-2588 URL: https://issues.apache.org/jira/browse/SOLR-2588 Project: Solr Issue Type: Wish Affects Versions: 3.2 Reporter: Gunnar Wagenknecht Assignee: Erik Hatcher Priority: Minor Fix For: 3.4, 4.0 Attachments: SOLR-2588.patch, SOLR-2588_Don_t_fail_if_velocity_libs_not_present_.patch In 1.4. it was fine to run Solr without Velocity on the classpath. However, in 3.2. SolrCore won't load because of a hard reference to the Velocity response writer in a static initializer. {noformat} ... ERROR org.apache.solr.core.CoreContainer - java.lang.NoClassDefFoundError: org/apache/velocity/context/Context at org.apache.solr.core.SolrCore.clinit(SolrCore.java:1447) at org.apache.solr.core.CoreContainer.create(CoreContainer.java:463) at org.apache.solr.core.CoreContainer.load(CoreContainer.java:316) at org.apache.solr.core.CoreContainer.load(CoreContainer.java:207) {noformat} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-3374) move nrtcachingdir to core in 4.0
[ https://issues.apache.org/jira/browse/LUCENE-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-3374: Attachment: LUCENE-3374.patch patch fixing the fails. This directory was *seriously screwed* if you use compound file format. There's one fail left in TestFSDir, havent looked yet, might be a false one. But we should backport this compound file stuff to 3.x ... maybe make a standalone test for it there. move nrtcachingdir to core in 4.0 - Key: LUCENE-3374 URL: https://issues.apache.org/jira/browse/LUCENE-3374 Project: Lucene - Java Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-3374.patch, LUCENE-3374.patch, LUCENE-3374.patch in 4.0 with the IOContext changes this implementation is clean and I think we should move it to core and use it in our tests etc. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-3374) move nrtcachingdir to core in 4.0
[ https://issues.apache.org/jira/browse/LUCENE-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-3374: Attachment: LUCENE-3374.patch ok, all tests pass. The last bugs were stupid (see my comments in the patch), but these are also bugs in FileSwitchDirectory. I'm gonna open a separate issue to turn on FileSwitchDirectory in tests and lets fix this stuff there too. move nrtcachingdir to core in 4.0 - Key: LUCENE-3374 URL: https://issues.apache.org/jira/browse/LUCENE-3374 Project: Lucene - Java Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-3374.patch, LUCENE-3374.patch, LUCENE-3374.patch, LUCENE-3374.patch in 4.0 with the IOContext changes this implementation is clean and I think we should move it to core and use it in our tests etc. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (LUCENE-3380) enable FileSwitchDirectory randomly in tests and fix compound-file/NoSuchDirectoryException bugs
enable FileSwitchDirectory randomly in tests and fix compound-file/NoSuchDirectoryException bugs Key: LUCENE-3380 URL: https://issues.apache.org/jira/browse/LUCENE-3380 Project: Lucene - Java Issue Type: Bug Reporter: Robert Muir Fix For: 3.4, 4.0 Looks like FileSwitchDirectory has the same bugs in it as LUCENE-3374. We should randomly enable this guy in tests and flush them all out the same way. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3271) Move 'good' contrib/queries classes to Queries module
[ https://issues.apache.org/jira/browse/LUCENE-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086753#comment-13086753 ] Chris Male commented on LUCENE-3271: Committed revision 1158997. Moving on to deal with the remaining contents. Move 'good' contrib/queries classes to Queries module - Key: LUCENE-3271 URL: https://issues.apache.org/jira/browse/LUCENE-3271 Project: Lucene - Java Issue Type: Improvement Reporter: Chris Male Attachments: LUCENE-3271-MLT.patch, LUCENE-3271-MLT.patch, LUCENE-3271-good-queries.patch, LUCENE-3271-good-queries.patch, LUCENE-3271-regex.patch With the Queries module now filled with the FunctionQuery stuff, we should look at closing down contrib/queries. While not a huge contrib, it contains a number of pretty useful classes and some that should go elsewhere. Heres my proposed plan: - similar.* - suggest module - regex.* - queries module - BooleanFilter - queries module under .filters package - BoostingQuery - queries module - ChainedFilter - queries module under .filters package - DuplicateFilter - queries module under .filters package - FieldCacheRewriteMethod - This doesn't belong in this contrib or the queries module. I think we should push it to contrib/misc for the time being. It seems to have quite a few constraints on when its useful. If indeed CONSTANT_SCORE_AUTO rewrite is better, then I dont see a purpose for it. - FilterClause - class inside BooleanFilter - FuzzyLikeThisQuery - suggest module. This class seems a mess with its Similarity hardcoded. With all that said, it does seem to do what it claims and with some cleanup, it could be good. - TermsFilter - queries module under .filters package - SlowCollated* - They can stay in the module till we have a better place to nuke them. One of the implications of the above moves, is that the xml-query-parser, which supports many of the queries, will need to have a dependency on the queries module. But that seems unavoidable at this stage. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-1431) CommComponent abstracted
[ https://issues.apache.org/jira/browse/SOLR-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086754#comment-13086754 ] Jason Rutherglen commented on SOLR-1431: Can we look at backporting this one to 3.x, given 4.x is a little ways off? CommComponent abstracted Key: SOLR-1431 URL: https://issues.apache.org/jira/browse/SOLR-1431 Project: Solr Issue Type: Improvement Components: search Affects Versions: 4.0 Reporter: Jason Rutherglen Assignee: Noble Paul Fix For: 4.0 Attachments: SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch We'll abstract CommComponent in this issue. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2565) Prevent IW#close and cut over to IW#commit
[ https://issues.apache.org/jira/browse/SOLR-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086755#comment-13086755 ] Jason Rutherglen commented on SOLR-2565: Can this one be backported to 3.x? It would probably be fairly useful for people to use now? Prevent IW#close and cut over to IW#commit -- Key: SOLR-2565 URL: https://issues.apache.org/jira/browse/SOLR-2565 Project: Solr Issue Type: Improvement Components: update Affects Versions: 4.0 Reporter: Simon Willnauer Assignee: Mark Miller Fix For: 4.0 Attachments: SOLR-2565.patch, SOLR-2565.patch, SOLR-2565.patch Spinnoff from SOLR-2193. We already have a branch to work on this issue here https://svn.apache.org/repos/asf/lucene/dev/branches/solr2193 The main goal here is to prevent solr from closing the IW and use IW#commit instead. AFAIK the main issues here are: The update handler needs an overhaul. A few goals I think we might want to look at: 1. Expose the SolrIndexWriter in the api or add the proper abstractions to get done what we now do with special casing: 2. Stop closing the IndexWriter and start using commit (still lazy IW init though). 3. Drop iwAccess, iwCommit locks and sync mostly at the Lucene level. 4. Address the current issues we face because multiple original/'reloaded' cores can have a different IndexWriter on the same index. Eventually this is a preparation for NRT support in Solr which I will create a followup issue for. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3286) Move XML QueryParser to queryparser module
[ https://issues.apache.org/jira/browse/LUCENE-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086758#comment-13086758 ] Chris Male commented on LUCENE-3286: Moved demo code into demo contrib. Committed revision 1159002. Move XML QueryParser to queryparser module -- Key: LUCENE-3286 URL: https://issues.apache.org/jira/browse/LUCENE-3286 Project: Lucene - Java Issue Type: Sub-task Components: modules/queryparser Reporter: Chris Male Attachments: LUCENE-3286.patch The XML QueryParser will be ported across to queryparser module. As part of this work, we'll move the QP's demo into the demo module. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3286) Move XML QueryParser to queryparser module
[ https://issues.apache.org/jira/browse/LUCENE-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086774#comment-13086774 ] Chris Male commented on LUCENE-3286: Command for patch: {code} svn move --parents lucene/contrib/xml-query-parser/docs/* modules/queryparser/docs/xml/ svn move lucene/contrib/xml-query-parser/README.htm modules/queryparser/docs/xml/README.htm svn move --parents lucene/contrib/xml-query-parser/src/java/org/apache/lucene/xmlparser/* modules/queryparser/src/java/org/apache/lucene/queryparser/xml/ svn move --parents lucene/contrib/xml-query-parser/src/test/org/apache/lucene/xmlparser/* modules/queryparser/src/test/org/apache/lucene/queryparser/xml/ svn move lucene/contrib/xml-query-parser/dtddocbuild.xml modules/queryparser/xmldtddocbuild.xml svn move --parents lucene/contrib/xml-query-parser/LuceneContribQuery.dtd modules/queryparser/src/resources/org/apache/lucene/queryparser/xml/LuceneContribQuery.dtd svn move lucene/contrib/xml-query-parser/LuceneCoreQuery.dtd modules/queryparser/src/resources/org/apache/lucene/queryparser/xml/LuceneCoreQuery.dtd svn delete lucene/contrib/xml-query-parser svn delete dev-tools/idea/lucene/contrib/xml-query-parser svn delete dev-tools/maven/lucene/contrib/xml-query-parser {code} Move XML QueryParser to queryparser module -- Key: LUCENE-3286 URL: https://issues.apache.org/jira/browse/LUCENE-3286 Project: Lucene - Java Issue Type: Sub-task Components: modules/queryparser Reporter: Chris Male Attachments: LUCENE-3286-core.patch, LUCENE-3286.patch The XML QueryParser will be ported across to queryparser module. As part of this work, we'll move the QP's demo into the demo module. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-3286) Move XML QueryParser to queryparser module
[ https://issues.apache.org/jira/browse/LUCENE-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Male updated LUCENE-3286: --- Attachment: LUCENE-3286-core.patch New patch which moves the actual parser into the queryparser module. There is currently a dependency problem related to the FuzzyLikeThisQuery which I'm about to move in another issue. Things are untested at this stage. Will move further forward soon. Move XML QueryParser to queryparser module -- Key: LUCENE-3286 URL: https://issues.apache.org/jira/browse/LUCENE-3286 Project: Lucene - Java Issue Type: Sub-task Components: modules/queryparser Reporter: Chris Male Attachments: LUCENE-3286-core.patch, LUCENE-3286.patch The XML QueryParser will be ported across to queryparser module. As part of this work, we'll move the QP's demo into the demo module. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org