[jira] [Commented] (LUCENE-6785) Consider merging Query.rewrite() into Query.createWeight()

2015-10-01 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939628#comment-14939628 ] Alan Woodward commented on LUCENE-6785: --- The API isn't as tidy, but I think you're right that this

[jira] [Commented] (SOLR-8110) Start enforcing field naming recomendations in next X.0 release?

2015-10-01 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939513#comment-14939513 ] Alan Woodward commented on SOLR-8110: - +1 We should log a warning for each dodgy fieldname in

[jira] [Commented] (SOLR-8360) ExternalFileField.getValueSource uses req.datadir but this.schema

2015-12-07 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045185#comment-15045185 ] Alan Woodward commented on SOLR-8360: - The data directory should always be the same, so I think your

[jira] [Commented] (LUCENE-6919) Change the Scorer API to expose an iterator instead of extending DocIdSetIterator

2015-12-08 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047403#comment-15047403 ] Alan Woodward commented on LUCENE-6919: --- I think now that scoring has moved back out of Spans into

[jira] [Created] (LUCENE-6916) BaseDirectoryTestCase should use try-with-resources for its Directories

2015-12-02 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-6916: - Summary: BaseDirectoryTestCase should use try-with-resources for its Directories Key: LUCENE-6916 URL: https://issues.apache.org/jira/browse/LUCENE-6916 Project:

[jira] [Commented] (LUCENE-6916) BaseDirectoryTestCase should use try-with-resources for its Directories

2015-12-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035909#comment-15035909 ] Alan Woodward commented on LUCENE-6916: --- It's FileSystem leaks rather than file leaks for me, but

[jira] [Updated] (LUCENE-6916) BaseDirectoryTestCase should use try-with-resources for its Directories

2015-12-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-6916: -- Attachment: LUCENE-6916.patch Patch. I've only wrapped Directory usage with

[jira] [Commented] (SOLR-8308) Core gets inaccessible after RENAME operation with special characters

2015-12-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035491#comment-15035491 ] Alan Woodward commented on SOLR-8308: - Hi Erik, could you move the name checks to a separate

[jira] [Resolved] (SOLR-8357) UpdateLog.RecentUpdates should implement Closeable

2015-12-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved SOLR-8357. - Resolution: Fixed Fix Version/s: 5.5 > UpdateLog.RecentUpdates should implement Closeable >

[jira] [Commented] (SOLR-6915) SaslZkACLProvider and Kerberos Test Using MiniKdc

2015-11-25 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026468#comment-15026468 ] Alan Woodward commented on SOLR-6915: - This is still failing fairly frequently on Jenkins runs,

[jira] [Commented] (SOLR-8336) CoreDescriptor instance directory should be a Path, not a String

2015-11-30 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15032094#comment-15032094 ] Alan Woodward commented on SOLR-8336: - Hm, that looks as though something hasn't been rebuilt - are you

[jira] [Commented] (SOLR-8336) CoreDescriptor instance directory should be a Path, not a String

2015-11-30 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15032127#comment-15032127 ] Alan Woodward commented on SOLR-8336: - No worries, thanks for checking! > CoreDescriptor instance

[jira] [Commented] (SOLR-7940) [CollectionAPI] Frequent Cluster Status timeout

2015-12-01 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033373#comment-15033373 ] Alan Woodward commented on SOLR-7940: - I think this has been fixed by SOLR-7636? > [CollectionAPI]

[jira] [Commented] (LUCENE-6900) Grouping sortWithinGroup should use Sort.RELEVANCE to indicate that, not null

2015-11-30 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15031796#comment-15031796 ] Alan Woodward commented on LUCENE-6900: --- Just noticed that this has an entry in the Solr

[jira] [Resolved] (SOLR-8336) CoreDescriptor instance directory should be a Path, not a String

2015-11-30 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved SOLR-8336. - Resolution: Fixed Fix Version/s: 5.5 Trunk > CoreDescriptor instance

[jira] [Updated] (SOLR-8357) UpdateLog.RecentUpdates should implement Closeable

2015-12-01 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated SOLR-8357: Attachment: SOLR-8357.patch Patch, also with a small bit of refactoring to make construction

[jira] [Created] (SOLR-8357) UpdateLog.RecentUpdates should implement Closeable

2015-12-01 Thread Alan Woodward (JIRA)
Alan Woodward created SOLR-8357: --- Summary: UpdateLog.RecentUpdates should implement Closeable Key: SOLR-8357 URL: https://issues.apache.org/jira/browse/SOLR-8357 Project: Solr Issue Type:

[jira] [Commented] (SOLR-8302) SolrResourceLoader should take a Path to its instance directory, rather than a String

2015-11-18 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010648#comment-15010648 ] Alan Woodward commented on SOLR-8302: - Yes, I think deprecation is probably the way forward. This will

[jira] [Updated] (SOLR-8302) SolrResourceLoader should take a Path to its instance directory, rather than a String

2015-11-18 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated SOLR-8302: Attachment: SOLR-8302.patch Updated patch with deprecations. > SolrResourceLoader should take a

[jira] [Commented] (SOLR-8260) Use NIO2 APIs in core discovery

2015-11-18 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010636#comment-15010636 ] Alan Woodward commented on SOLR-8260: - Passing the exception itself to the logger generally ends up

[jira] [Resolved] (SOLR-8302) SolrResourceLoader should take a Path to its instance directory, rather than a String

2015-11-20 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved SOLR-8302. - Resolution: Fixed Fix Version/s: Trunk 5.4 Thanks for the review Shawn

[jira] [Created] (SOLR-8323) Add CollectionWatcher API to ZkStateReader

2015-11-20 Thread Alan Woodward (JIRA)
Alan Woodward created SOLR-8323: --- Summary: Add CollectionWatcher API to ZkStateReader Key: SOLR-8323 URL: https://issues.apache.org/jira/browse/SOLR-8323 Project: Solr Issue Type: Improvement

[jira] [Updated] (SOLR-8323) Add CollectionWatcher API to ZkStateReader

2015-11-20 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated SOLR-8323: Attachment: SOLR-8323.patch Patch outlining the basic idea. This adds two new interfaces,

[jira] [Commented] (SOLR-8315) Remove default core checks in the dispatch filter

2015-11-19 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013769#comment-15013769 ] Alan Woodward commented on SOLR-8315: - There's no default core any more, so that can be nuked. >

[jira] [Commented] (SOLR-8323) Add CollectionWatcher API to ZkStateReader

2015-11-23 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021785#comment-15021785 ] Alan Woodward commented on SOLR-8323: - bq. Someone should remove stateformat=1 for Solr 6 in an ideal

[jira] [Resolved] (SOLR-8194) Improve error reporting UpdateRequest

2015-11-23 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved SOLR-8194. - Resolution: Fixed Thanks Markus! > Improve error reporting UpdateRequest >

[jira] [Updated] (SOLR-8194) Improve error reporting UpdateRequest

2015-11-23 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated SOLR-8194: Attachment: SOLR-8194.patch Patch adding Objects.requireNonNull() checks to the various

[jira] [Updated] (SOLR-8336) CoreDescriptor instance directory should be a Path, not a String

2015-11-24 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated SOLR-8336: Attachment: SOLR-8336.patch Patch. This also moves all core-creation logic out of CoreAdminHandler

[jira] [Created] (SOLR-8336) CoreDescriptor instance directory should be a Path, not a String

2015-11-24 Thread Alan Woodward (JIRA)
Alan Woodward created SOLR-8336: --- Summary: CoreDescriptor instance directory should be a Path, not a String Key: SOLR-8336 URL: https://issues.apache.org/jira/browse/SOLR-8336 Project: Solr

[jira] [Resolved] (SOLR-9140) Replace some state polling with CollectionStateWatchers

2016-06-03 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved SOLR-9140. - Resolution: Fixed Fix Version/s: 6.1 > Replace some state polling with

[jira] [Commented] (SOLR-9081) Make SolrTestCaseJ4.beforeClass() / .afterClass() public so it works with Mockito

2016-06-03 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314434#comment-15314434 ] Alan Woodward commented on SOLR-9081: - D'oh, thanks Hoss. > Make SolrTestCaseJ4.beforeClass() /

[jira] [Reopened] (SOLR-9181) ZkStateReaderTest failure

2016-06-03 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward reopened SOLR-9181: - I'm seeing a whole bunch of failures after this, and can reproduce via beasting locally - digging

[jira] [Commented] (SOLR-9181) ZkStateReaderTest failure

2016-06-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322310#comment-15322310 ] Alan Woodward commented on SOLR-9181: - Given that we're still finding timing-related bugs in this code,

[jira] [Resolved] (SOLR-9189) explosion of timeout related failures in jenkins the past few days

2016-06-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved SOLR-9189. - Resolution: Fixed The flaky commits have been reverted, so this should be fine for 6.x >

[jira] [Commented] (SOLR-9176) Legacy Faceting Term Enum Method Regression

2016-06-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322315#comment-15322315 ] Alan Woodward commented on SOLR-9176: - Echoing Tomás, can you add some specific tests for

[jira] [Updated] (SOLR-9181) ZkStateReaderTest failure

2016-06-08 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated SOLR-9181: Attachment: SOLR-9181.patch Here's an attempt to clean this up a bit. Notifications are now fired

[jira] [Updated] (SOLR-9181) ZkStateReaderTest failure

2016-06-07 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated SOLR-9181: Attachment: SOLR-9181.patch Turns out that ZkStateReaderTest is very helpful for finding bugs and

[jira] [Commented] (SOLR-9189) explosion of timeout related failures in jenkins the past few days

2016-06-07 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15318140#comment-15318140 ] Alan Woodward commented on SOLR-9189: - Yup, this is my fault, sorry. Am at buzzwords with some flaky

[jira] [Reopened] (SOLR-9140) Replace some state polling with CollectionStateWatchers

2016-06-06 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward reopened SOLR-9140: - This is causing a bunch of test failures because there are still some notifications that aren't being

[jira] [Commented] (SOLR-9176) Legacy Faceting Term Enum Method Regression

2016-06-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322803#comment-15322803 ] Alan Woodward commented on SOLR-9176: - bq. This looks to me like something that would be nice to fix

[jira] [Commented] (SOLR-9181) ZkStateReaderTest failure

2016-06-04 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315442#comment-15315442 ] Alan Woodward commented on SOLR-9181: - Reverting this while I work out what's broken. >

[jira] [Resolved] (SOLR-9181) ZkStateReaderTest failure

2016-06-03 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved SOLR-9181. - Resolution: Fixed Fix Version/s: 6.1 > ZkStateReaderTest failure >

[jira] [Resolved] (SOLR-9176) Legacy Faceting Term Enum Method Regression

2016-06-10 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved SOLR-9176. - Resolution: Fixed Fix Version/s: 6.1 Thanks all! > Legacy Faceting Term Enum Method

[jira] [Commented] (SOLR-9187) Support dates and booleans in /export handler, support boolean DocValues fields

2016-06-11 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326073#comment-15326073 ] Alan Woodward commented on SOLR-9187: - I think that code was always there, it's just been moved into

[jira] [Commented] (SOLR-9205) Parse schema in LukeResponse

2016-06-13 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326947#comment-15326947 ] Alan Woodward commented on SOLR-9205: - Hi Fengtan, This looks like a good idea, thanks! Two comments:

[jira] [Resolved] (SOLR-9081) Make SolrTestCaseJ4.beforeClass() / .afterClass() public so it works with Mockito

2016-06-03 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved SOLR-9081. - Resolution: Fixed Fix Version/s: 6.1 Thanks Georg! > Make SolrTestCaseJ4.beforeClass() /

[jira] [Assigned] (SOLR-9081) Make SolrTestCaseJ4.beforeClass() / .afterClass() public so it works with Mockito

2016-06-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward reassigned SOLR-9081: --- Assignee: Alan Woodward > Make SolrTestCaseJ4.beforeClass() / .afterClass() public so it

[jira] [Commented] (SOLR-9081) Make SolrTestCaseJ4.beforeClass() / .afterClass() public so it works with Mockito

2016-06-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312188#comment-15312188 ] Alan Woodward commented on SOLR-9081: - Thanks Georg, this looks like a no-brainer to me. > Make

[jira] [Created] (SOLR-9181) ZkStateReaderTest failure

2016-06-02 Thread Alan Woodward (JIRA)
Alan Woodward created SOLR-9181: --- Summary: ZkStateReaderTest failure Key: SOLR-9181 URL: https://issues.apache.org/jira/browse/SOLR-9181 Project: Solr Issue Type: Bug Reporter:

[jira] [Commented] (SOLR-9181) ZkStateReaderTest failure

2016-06-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1531#comment-1531 ] Alan Woodward commented on SOLR-9181: - This is a test bug, I think. There's a race when a collection

[jira] [Updated] (SOLR-9081) Make SolrTestCaseJ4.beforeClass() / .afterClass() public so it works with Mockito

2016-06-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated SOLR-9081: Attachment: SOLR-9081.patch Lots of subclasses already have a public beforeClass() or afterClass(),

[jira] [Updated] (SOLR-9181) ZkStateReaderTest failure

2016-06-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated SOLR-9181: Attachment: SOLR-9181.patch Patch. This also uncovered a couple of bugs in the collection state

[jira] [Updated] (SOLR-9140) Replace some state polling with CollectionStateWatchers

2016-06-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated SOLR-9140: Attachment: SOLR-9140.patch Updated patch. This also seems to fix the occasional failures in

[jira] [Resolved] (LUCENE-7236) TestSpanCollection.testOrQuery() failure: Missing term field:w3

2016-06-01 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-7236. --- Resolution: Fixed Fix Version/s: 6.1 > TestSpanCollection.testOrQuery() failure:

[jira] [Commented] (LUCENE-7236) TestSpanCollection.testOrQuery() failure: Missing term field:w3

2016-06-01 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15310927#comment-15310927 ] Alan Woodward commented on LUCENE-7236: --- This is a test bug - it's assuming that index docs are in

[jira] [Assigned] (LUCENE-7236) TestSpanCollection.testOrQuery() failure: Missing term field:w3

2016-06-01 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward reassigned LUCENE-7236: - Assignee: Alan Woodward > TestSpanCollection.testOrQuery() failure: Missing term

[jira] [Assigned] (SOLR-9176) Legacy Faceting Term Enum Method Regression

2016-06-01 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward reassigned SOLR-9176: --- Assignee: Alan Woodward > Legacy Faceting Term Enum Method Regression >

[jira] [Commented] (SOLR-9176) Legacy Faceting Term Enum Method Regression

2016-06-01 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15310952#comment-15310952 ] Alan Woodward commented on SOLR-9176: - Patch looks good, I'm running tests now. I think we could also

[jira] [Commented] (SOLR-9176) Legacy Faceting Term Enum Method Regression

2016-06-01 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15310961#comment-15310961 ] Alan Woodward commented on SOLR-9176: - Hm, testRandomFaceting fails with this patch: ant test

[jira] [Commented] (SOLR-9231) SolrInputDocument no-args constructor removed without notice

2016-06-20 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340172#comment-15340172 ] Alan Woodward commented on SOLR-9231: - Does cls.getConstructor(String[].class) work? >

[jira] [Commented] (LUCENE-7340) MemoryIndex.toString is broken if you enable payloads

2016-06-16 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333959#comment-15333959 ] Alan Woodward commented on LUCENE-7340: --- The payload query tests in the queries module should give

[jira] [Commented] (LUCENE-6975) Add dimensional "equals" query to match docs containing precisely a given value

2016-01-18 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105093#comment-15105093 ] Alan Woodward commented on LUCENE-6975: --- bq. But what to use for Dim values? FloatValue wouldn't be

[jira] [Created] (LUCENE-6981) SpanQuery.getTermContexts() static helper methods should be public

2016-01-18 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-6981: - Summary: SpanQuery.getTermContexts() static helper methods should be public Key: LUCENE-6981 URL: https://issues.apache.org/jira/browse/LUCENE-6981 Project: Lucene

[jira] [Updated] (LUCENE-6981) SpanQuery.getTermContexts() static helper methods should be public

2016-01-18 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-6981: -- Attachment: LUCENE-6981.patch Patch. Makes the two static methods on SpanQuery public, and

[jira] [Resolved] (SOLR-8548) CorePropertiesLocator does NOT follow symlinks anymore

2016-01-18 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved SOLR-8548. - Resolution: Fixed Fix Version/s: 5.5 Thanks Aaron. I set the search depth to 256, which

[jira] [Assigned] (SOLR-8548) CorePropertiesLocator does NOT follow symlinks anymore

2016-01-14 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward reassigned SOLR-8548: --- Assignee: Alan Woodward > CorePropertiesLocator does NOT follow symlinks anymore >

[jira] [Commented] (SOLR-8548) CorePropertiesLocator does NOT follow symlinks anymore

2016-01-14 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098274#comment-15098274 ] Alan Woodward commented on SOLR-8548: - ack, thanks for picking this up Aaron. > CorePropertiesLocator

[jira] [Commented] (SOLR-8548) CorePropertiesLocator does NOT follow symlinks anymore

2016-01-14 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098286#comment-15098286 ] Alan Woodward commented on SOLR-8548: - Is there any reason to set maxDepth to 2? It was

[jira] [Resolved] (LUCENE-7360) Remove Explanation.toHtml()

2016-06-29 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-7360. --- Resolution: Fixed Assignee: Alan Woodward Fix Version/s: 6.2

[jira] [Commented] (SOLR-8712) Variable solr.core.instanceDir no longer resolved

2016-02-23 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158641#comment-15158641 ] Alan Woodward commented on SOLR-8712: - Yes, we need to add instanceDir back into the list of

[jira] [Assigned] (SOLR-8712) Variable solr.core.instanceDir no longer resolved

2016-02-23 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward reassigned SOLR-8712: --- Assignee: Alan Woodward > Variable solr.core.instanceDir no longer resolved >

[jira] [Updated] (SOLR-8712) Variable solr.core.instanceDir no longer resolved

2016-02-23 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated SOLR-8712: Attachment: SOLR-8712.patch Patch fixing the issue, plus test. > Variable solr.core.instanceDir no

[jira] [Created] (SOLR-8758) Add SolrCloudTestCase base class

2016-02-29 Thread Alan Woodward (JIRA)
Alan Woodward created SOLR-8758: --- Summary: Add SolrCloudTestCase base class Key: SOLR-8758 URL: https://issues.apache.org/jira/browse/SOLR-8758 Project: Solr Issue Type: Improvement

[jira] [Updated] (SOLR-8323) Add CollectionWatcher API to ZkStateReader

2016-02-29 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated SOLR-8323: Attachment: SOLR-8323.patch Updated patch, using the SolrCloudTestCase from SOLR-8758. This has

[jira] [Updated] (SOLR-8758) Add SolrCloudTestCase base class

2016-02-29 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated SOLR-8758: Attachment: SOLR-8758.patch Here's a patch. The base class uses a MiniSolrCloudCluster, and exposes

[jira] [Resolved] (SOLR-8758) Add SolrCloudTestCase base class

2016-02-29 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved SOLR-8758. - Resolution: Fixed Fix Version/s: 6.0 Thanks for the review gents. > Add SolrCloudTestCase

[jira] [Commented] (SOLR-8758) Add SolrCloudTestCase base class

2016-02-29 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15172234#comment-15172234 ] Alan Woodward commented on SOLR-8758: - Yes, once this is committed we can start cutting over the tests

[jira] [Resolved] (SOLR-8712) Variable solr.core.instanceDir no longer resolved

2016-02-27 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved SOLR-8712. - Resolution: Fixed Fix Version/s: 5.5.1 master Fixed - thanks for raising

[jira] [Commented] (LUCENE-6975) Add dimensional "equals" query to match docs containing precisely a given value

2016-01-21 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110318#comment-15110318 ] Alan Woodward commented on LUCENE-6975: --- +1, nice! Regarding Robert's point about having to think

[jira] [Created] (LUCENE-6992) Add sugar methods to allow creating a MemoryIndex from a Document or set of IndexableFields

2016-01-25 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-6992: - Summary: Add sugar methods to allow creating a MemoryIndex from a Document or set of IndexableFields Key: LUCENE-6992 URL: https://issues.apache.org/jira/browse/LUCENE-6992

[jira] [Updated] (LUCENE-6992) Add sugar methods to allow creating a MemoryIndex from a Document or set of IndexableFields

2016-01-25 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-6992: -- Attachment: LUCENE-6992.patch Patch. I initially automatically froze the index created by the

[jira] [Resolved] (LUCENE-6988) IndexableField.tokenStream() doesn't need to throw IOException

2016-01-25 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-6988. --- Resolution: Fixed Fix Version/s: Trunk 5.5 >

[jira] [Resolved] (LUCENE-6992) Add sugar methods to allow creating a MemoryIndex from a Document or set of IndexableFields

2016-01-26 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-6992. --- Resolution: Fixed Thanks for the review, David! > Add sugar methods to allow creating a

[jira] [Created] (LUCENE-6984) MultiTermQuery mutability can cause assertion failures in BooleanQuery

2016-01-20 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-6984: - Summary: MultiTermQuery mutability can cause assertion failures in BooleanQuery Key: LUCENE-6984 URL: https://issues.apache.org/jira/browse/LUCENE-6984 Project:

[jira] [Commented] (LUCENE-6984) MultiTermQuery mutability can cause assertion failures in BooleanQuery

2016-01-20 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108283#comment-15108283 ] Alan Woodward commented on LUCENE-6984: --- I found this through the highlighting code in luwak, where

[jira] [Updated] (LUCENE-6984) MultiTermQuery mutability can cause assertion failures in BooleanQuery

2016-01-20 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-6984: -- Attachment: LUCENE-6984.patch Here's a patch that changes SpanMTQWrapper to have its own

[jira] [Resolved] (LUCENE-6981) SpanQuery.getTermContexts() static helper methods should be public

2016-01-20 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-6981. --- Resolution: Fixed Fix Version/s: 5.5 > SpanQuery.getTermContexts() static helper

[jira] [Resolved] (LUCENE-6984) MultiTermQuery mutability can cause assertion failures in BooleanQuery

2016-01-20 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-6984. --- Resolution: Fixed Fix Version/s: Trunk 5.5 Thanks for the review

[jira] [Created] (LUCENE-6988) IndexableField.tokenStream() doesn't need to throw IOException

2016-01-22 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-6988: - Summary: IndexableField.tokenStream() doesn't need to throw IOException Key: LUCENE-6988 URL: https://issues.apache.org/jira/browse/LUCENE-6988 Project: Lucene -

[jira] [Updated] (LUCENE-6988) IndexableField.tokenStream() doesn't need to throw IOException

2016-01-22 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-6988: -- Attachment: LUCENE-6988.patch Patch. > IndexableField.tokenStream() doesn't need to throw

[jira] [Commented] (LUCENE-7021) buildAndPushRelease.py should ensure you have no unpushed git changes

2016-02-11 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143111#comment-15143111 ] Alan Woodward commented on LUCENE-7021: --- The output of {{git status}} should tell you if you're

[jira] [Updated] (SOLR-8811) Deleting inactive replicas doesn't work in non-legacy cloud mode

2016-03-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated SOLR-8811: Attachment: SOLR-8811.patch Here's a patch illustrating the problem.

[jira] [Created] (SOLR-8811) Deleting inactive replicas doesn't work in non-legacy cloud mode

2016-03-09 Thread Alan Woodward (JIRA)
Alan Woodward created SOLR-8811: --- Summary: Deleting inactive replicas doesn't work in non-legacy cloud mode Key: SOLR-8811 URL: https://issues.apache.org/jira/browse/SOLR-8811 Project: Solr

[jira] [Commented] (LUCENE-7091) Add doc values support to MemoryIndex

2016-03-10 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188994#comment-15188994 ] Alan Woodward commented on LUCENE-7091: --- +1, nice! Is there any reason for DocValuesHolder to be

[jira] [Commented] (SOLR-8765) Enforce required parameters in SolrJ Collection APIs

2016-03-10 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188937#comment-15188937 ] Alan Woodward commented on SOLR-8765: - Everywhere that was actually using the validator had exactly the

[jira] [Resolved] (SOLR-8765) Enforce required parameters in SolrJ Collection APIs

2016-03-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved SOLR-8765. - Resolution: Fixed Assignee: Alan Woodward Fix Version/s: (was: 6.0)

[jira] [Commented] (SOLR-8782) Improve SolrJ Collections async API

2016-03-19 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200482#comment-15200482 ] Alan Woodward commented on SOLR-8782: - Yes, it's a bit of a pain. It's because the return type of all

[jira] [Commented] (LUCENE-7087) Change MemoryIndex#fromDocument(...) helpers to accept Iterable as document

2016-03-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187125#comment-15187125 ] Alan Woodward commented on LUCENE-7087: --- +1 > Change MemoryIndex#fromDocument(...) helpers to

[jira] [Commented] (SOLR-8837) Duplicate leader elector node detection is broken

2016-03-13 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192317#comment-15192317 ] Alan Woodward commented on SOLR-8837: - We can fix this by fixing the duplicate-detection logic, but I'm

[jira] [Created] (SOLR-8837) Duplicate leader elector node detection is broken

2016-03-13 Thread Alan Woodward (JIRA)
Alan Woodward created SOLR-8837: --- Summary: Duplicate leader elector node detection is broken Key: SOLR-8837 URL: https://issues.apache.org/jira/browse/SOLR-8837 Project: Solr Issue Type: Bug

<    5   6   7   8   9   10   11   12   13   14   >