mikemccand commented on a change in pull request #854: Shared PQ Based Early
Termination for Concurrent Search
URL: https://github.com/apache/lucene-solr/pull/854#discussion_r323174839
##
File path: lucene/core/src/java/org/apache/lucene/search/Collector.java
##
@@ -77,4 +
iverase commented on a change in pull request #874: LUCENE-8976: Use exact
distance between point and bounding rectangle in FloatPointNearestNeighbor
URL: https://github.com/apache/lucene-solr/pull/874#discussion_r323177602
##
File path:
lucene/sandbox/src/java/org/apache/lucene/do
iverase commented on a change in pull request #874: LUCENE-8976: Use exact
distance between point and bounding rectangle in FloatPointNearestNeighbor
URL: https://github.com/apache/lucene-solr/pull/874#discussion_r323177766
##
File path:
lucene/sandbox/src/java/org/apache/lucene/do
iverase commented on issue #874: LUCENE-8976: Use exact distance between point
and bounding rectangle in FloatPointNearestNeighbor
URL: https://github.com/apache/lucene-solr/pull/874#issuecomment-530329820
In my test this approach looks faster than the previous approach, in
particular for
jimczi commented on issue #854: Shared PQ Based Early Termination for
Concurrent Search
URL: https://github.com/apache/lucene-solr/pull/854#issuecomment-530342313
> Is this proposal to continue collecting the full N per slice (thread work
unit), until some/all of them have a full (top N) P
atris commented on issue #854: Shared PQ Based Early Termination for Concurrent
Search
URL: https://github.com/apache/lucene-solr/pull/854#issuecomment-530343716
> > Is this proposal to continue collecting the full N per slice (thread
work unit), until some/all of them have a full (top N)
jimczi commented on issue #854: Shared PQ Based Early Termination for
Concurrent Search
URL: https://github.com/apache/lucene-solr/pull/854#issuecomment-530345711
I think that you need to ensure that the slice publishing the new min score
is full, otherwise the min score cannot be the glob
atris commented on issue #854: Shared PQ Based Early Termination for Concurrent
Search
URL: https://github.com/apache/lucene-solr/pull/854#issuecomment-530349367
> I think that you need to ensure that the slice publishing the new min
score is full, otherwise the min score cannot be the glo
jimczi commented on issue #854: Shared PQ Based Early Termination for
Concurrent Search
URL: https://github.com/apache/lucene-solr/pull/854#issuecomment-530373796
I am not sure that synchronization would be an issue in this model since the
update of the global min score should be quick, we
atris commented on issue #854: Shared PQ Based Early Termination for Concurrent
Search
URL: https://github.com/apache/lucene-solr/pull/854#issuecomment-530380308
> I am not sure that synchronization would be an issue in this model since
the update of the global min score should be quick, w
jimczi commented on issue #854: Shared PQ Based Early Termination for
Concurrent Search
URL: https://github.com/apache/lucene-solr/pull/854#issuecomment-530398602
> Thanks for offering. I have a skeletal PR in flight for this approach that
I plan to publish tomorrow -- maybe we can iterate
msokolov merged pull request #862: LUCENE-8971: Enable constructing
JapaneseTokenizer with custom dictio…
URL: https://github.com/apache/lucene-solr/pull/862
This is an automated message from the Apache Git Service.
To respo
atris commented on issue #854: Shared PQ Based Early Termination for Concurrent
Search
URL: https://github.com/apache/lucene-solr/pull/854#issuecomment-530418576
> I think it would be simpler to keep the maximum minimum score on each
slice. Each time a slice publish a new minimum score
msokolov commented on issue #862: LUCENE-8971: Enable constructing
JapaneseTokenizer with custom dictio…
URL: https://github.com/apache/lucene-solr/pull/862#issuecomment-530426989
Also back-ported to 8x branch - this was a clean cherry-pick, so I didn't
post a PR.
jimczi commented on issue #854: Shared PQ Based Early Termination for
Concurrent Search
URL: https://github.com/apache/lucene-solr/pull/854#issuecomment-530443453
> Which contract would that be? I believe that today, the contract that we
call updateMinCompetitiveScore only when the PQ is f
jimczi commented on issue #862: LUCENE-8971: Enable constructing
JapaneseTokenizer with custom dictio…
URL: https://github.com/apache/lucene-solr/pull/862#issuecomment-530445644
Can we wait that we agreed on the full plan before backporting to 8x branch
? I don't see the full picture of t
atris commented on issue #854: Shared PQ Based Early Termination for Concurrent
Search
URL: https://github.com/apache/lucene-solr/pull/854#issuecomment-530453877
> We need to ensure that the minimum score of the slice can be set as the
maximum minimum score for all slices, however if t
msokolov commented on issue #862: LUCENE-8971: Enable constructing
JapaneseTokenizer with custom dictio…
URL: https://github.com/apache/lucene-solr/pull/862#issuecomment-530481447
Jim, I'm sorry - there was no comment for several days, so I assumed it was
OK to push. Let's discuss, and if
msokolov commented on issue #862: LUCENE-8971: Enable constructing
JapaneseTokenizer with custom dictio…
URL: https://github.com/apache/lucene-solr/pull/862#issuecomment-530482206
But to answer your question a little more fully: the way this works is, you
use DictionaryBuilder, in the same
jimczi commented on issue #862: LUCENE-8971: Enable constructing
JapaneseTokenizer with custom dictio…
URL: https://github.com/apache/lucene-solr/pull/862#issuecomment-530492308
> Jim, I'm sorry - there was no comment for several days, so I assumed it
was OK to push
No problem.
msokolov commented on issue #862: LUCENE-8971: Enable constructing
JapaneseTokenizer with custom dictio…
URL: https://github.com/apache/lucene-solr/pull/862#issuecomment-530494478
> Should it be marked experimental then ? The fact that we ship a single
dictionary within the jar also ensure
jimczi commented on issue #854: Shared PQ Based Early Termination for
Concurrent Search
URL: https://github.com/apache/lucene-solr/pull/854#issuecomment-530504547
I think we're talking of different approaches, hence the confusion. It is
correct that we can start setting the minimum score w
atris commented on issue #854: Shared PQ Based Early Termination for Concurrent
Search
URL: https://github.com/apache/lucene-solr/pull/854#issuecomment-530509226
> I think we're talking of different approaches, hence the confusion. It is
correct that we can start setting the minimum score
jimczi commented on issue #854: Shared PQ Based Early Termination for
Concurrent Search
URL: https://github.com/apache/lucene-solr/pull/854#issuecomment-530515005
> RE: synchronization, what are your thoughts on using a global shared array
where each collector publishes its bottom value vs
mikemccand commented on issue #854: Shared PQ Based Early Termination for
Concurrent Search
URL: https://github.com/apache/lucene-solr/pull/854#issuecomment-530549495
I agree the "maximum minimum" score (for all local PQs that are full) is
compelling as it'd require minimum synchronization
msokolov commented on issue #854: Shared PQ Based Early Termination for
Concurrent Search
URL: https://github.com/apache/lucene-solr/pull/854#issuecomment-530575471
There is also the option of something in between. To avoid thread
contention, could we just make uncoordinated read/write of
mocobeta commented on issue #862: LUCENE-8971: Enable constructing
JapaneseTokenizer with custom dictio…
URL: https://github.com/apache/lucene-solr/pull/862#issuecomment-530614095
As far as LUCENE-8816 ("Decouple Kuromoji's morphological analyser and its
dictionary") and related or sub iss
mocobeta edited a comment on issue #862: LUCENE-8971: Enable constructing
JapaneseTokenizer with custom dictio…
URL: https://github.com/apache/lucene-solr/pull/862#issuecomment-530614095
As far as LUCENE-8816 ("Decouple Kuromoji's morphological analyser and its
dictionary") and related or
mocobeta commented on issue #862: LUCENE-8971: Enable constructing
JapaneseTokenizer with custom dictio…
URL: https://github.com/apache/lucene-solr/pull/862#issuecomment-530624903
Just to be clear, to my understanding, this change has no effects on Solr or
Elasticsearch built on Lucene 8.x
yipen9 opened a new pull request #875: merge master
URL: https://github.com/apache/lucene-solr/pull/875
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Please provide a short description of the
atris commented on issue #854: Shared PQ Based Early Termination for Concurrent
Search
URL: https://github.com/apache/lucene-solr/pull/854#issuecomment-530675406
> There is also the option of something in between. To avoid thread
contention, could we just make uncoordinated read/write of a
iverase merged pull request #874: LUCENE-8976: Use exact distance between point
and bounding rectangle in FloatPointNearestNeighbor
URL: https://github.com/apache/lucene-solr/pull/874
This is an automated message from the Ap
atris commented on issue #854: Shared PQ Based Early Termination for Concurrent
Search
URL: https://github.com/apache/lucene-solr/pull/854#issuecomment-530678743
> > RE: synchronization, what are your thoughts on using a global shared
array where each collector publishes its bottom value v
thomaswoeckinger commented on issue #855: SOLR-13739: Improve performance on
huge schema updates
URL: https://github.com/apache/lucene-solr/pull/855#issuecomment-530695879
@dsmiley ready to merge?
This is an automated message
atris opened a new pull request #876: Use The Passed In Threshold Value in
doConcurrentSearchWithThreshold
URL: https://github.com/apache/lucene-solr/pull/876
This is an automated message from the Apache Git Service.
To resp
jimczi commented on issue #854: Shared PQ Based Early Termination for
Concurrent Search
URL: https://github.com/apache/lucene-solr/pull/854#issuecomment-530794180
> I was thinking of a class similar to HitsThresholdChecker, allowing shared
state, since, as you rightly said, the size of cri
atris opened a new pull request #877: LUCENE-8978: Maximal Bottom Score Based
Early Termination
URL: https://github.com/apache/lucene-solr/pull/877
This commit introduces a mechanism for early termination where,
for indices sorted by relevance, hits are collected in per thread
queue.
atris commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early
Termination
URL: https://github.com/apache/lucene-solr/pull/877#issuecomment-530818867
cc @jimczi
I have not implemented the logic for Paging collector yet -- can do it in a
separate PR if this looks fine
ctargett commented on issue #843: SOLR-13714: Correct refguide regarding
shardHandlerFactory solrconfig…
URL: https://github.com/apache/lucene-solr/pull/843#issuecomment-530944197
+1, thanks for fixing this.
This is an automa
ctargett merged pull request #843: SOLR-13714: Correct refguide regarding
shardHandlerFactory solrconfig…
URL: https://github.com/apache/lucene-solr/pull/843
This is an automated message from the Apache Git Service.
To respo
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared
storage support in SolrCloud
URL: https://github.com/apache/lucene-solr/pull/864#discussion_r323984413
##
File path:
solr/core/src/java/org/apache/solr/cloud/autoscaling/IndexSizeTrigger.java
##
@@ -
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared
storage support in SolrCloud
URL: https://github.com/apache/lucene-solr/pull/864#discussion_r323981156
##
File path:
solr/core/src/java/org/apache/solr/store/blob/process/CorePullTask.java
##
@@ -0,0
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared
storage support in SolrCloud
URL: https://github.com/apache/lucene-solr/pull/864#discussion_r323974231
##
File path:
solr/core/src/java/org/apache/solr/store/blob/provider/BlobStorageProvider.java
##
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared
storage support in SolrCloud
URL: https://github.com/apache/lucene-solr/pull/864#discussion_r323972376
##
File path:
solr/core/src/java/org/apache/solr/store/blob/client/S3StorageClient.java
##
@@ -0
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared
storage support in SolrCloud
URL: https://github.com/apache/lucene-solr/pull/864#discussion_r323974906
##
File path:
solr/core/src/java/org/apache/solr/store/blob/provider/BlobStorageProvider.java
##
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared
storage support in SolrCloud
URL: https://github.com/apache/lucene-solr/pull/864#discussion_r323973484
##
File path:
solr/core/src/java/org/apache/solr/store/blob/process/CorePullTracker.java
##
@@ -
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared
storage support in SolrCloud
URL: https://github.com/apache/lucene-solr/pull/864#discussion_r323967328
##
File path:
solr/core/src/java/org/apache/solr/handler/admin/RequestApplyUpdatesOp.java
##
@@
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared
storage support in SolrCloud
URL: https://github.com/apache/lucene-solr/pull/864#discussion_r323982385
##
File path:
solr/core/src/java/org/apache/solr/store/blob/process/CorePullTask.java
##
@@ -0,0
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared
storage support in SolrCloud
URL: https://github.com/apache/lucene-solr/pull/864#discussion_r324023752
##
File path:
solr/core/src/java/org/apache/solr/store/shared/SharedStoreManager.java
##
@@ -0,0
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared
storage support in SolrCloud
URL: https://github.com/apache/lucene-solr/pull/864#discussion_r324026158
##
File path:
solr/core/src/java/org/apache/solr/store/blob/client/BlobCoreMetadata.java
##
@@ -
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared
storage support in SolrCloud
URL: https://github.com/apache/lucene-solr/pull/864#discussion_r323982385
##
File path:
solr/core/src/java/org/apache/solr/store/blob/process/CorePullTask.java
##
@@ -0,0
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared
storage support in SolrCloud
URL: https://github.com/apache/lucene-solr/pull/864#discussion_r323982385
##
File path:
solr/core/src/java/org/apache/solr/store/blob/process/CorePullTask.java
##
@@ -0,0
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared
storage support in SolrCloud
URL: https://github.com/apache/lucene-solr/pull/864#discussion_r324027378
##
File path:
solr/core/src/java/org/apache/solr/store/blob/client/BlobCoreMetadataBuilder.java
#
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared
storage support in SolrCloud
URL: https://github.com/apache/lucene-solr/pull/864#discussion_r324030543
##
File path:
solr/core/src/java/org/apache/solr/store/blob/client/LocalStorageClient.java
##
@@
atris commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early
Termination
URL: https://github.com/apache/lucene-solr/pull/877#issuecomment-531142523
I ran luceneutil with concurrent mode and wikimedium2m -- no degradation to
QPS and some tasks show a reduction of around 30%
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324097168
##
File path:
lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java
##
@@
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324098325
##
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##
jpountz commented on a change in pull request #868: LUCENE-8975: Code Cleanup:
Use entryset for map iteration wherever possible.
URL: https://github.com/apache/lucene-solr/pull/868#discussion_r324101947
##
File path: lucene/CHANGES.txt
##
@@ -65,6 +65,8 @@ Other
* LUCEN
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324103214
##
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##
@
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324103471
##
File path:
lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java
##
@@
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324105474
##
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324105474
##
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324116784
##
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##
@
atris commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early
Termination
URL: https://github.com/apache/lucene-solr/pull/877#issuecomment-531174857
@jimczi Thanks for the comments -- updated the PR. Please let me know your
thoughts
-
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324130644
##
File path:
lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java
##
@@
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324130957
##
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324129841
##
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324130344
##
File path:
lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java
##
@@
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324130518
##
File path:
lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java
##
@@
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324125480
##
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324122789
##
File path:
lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java
##
@@
KoenDG commented on a change in pull request #868: LUCENE-8975: Code Cleanup:
Use entryset for map iteration wherever possible.
URL: https://github.com/apache/lucene-solr/pull/868#discussion_r324133535
##
File path: lucene/CHANGES.txt
##
@@ -65,6 +65,8 @@ Other
* LUCENE
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324141301
##
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##
@
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324141173
##
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##
@
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324145887
##
File path:
lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java
##
@@
iverase commented on issue #770: LUCENE-8746: Component2D topology library that
works on encoded space
URL: https://github.com/apache/lucene-solr/pull/770#issuecomment-531219042
Closing this PR. I am opening a new one with narrow scope
--
iverase closed pull request #770: LUCENE-8746: Component2D topology library
that works on encoded space
URL: https://github.com/apache/lucene-solr/pull/770
This is an automated message from the Apache Git Service.
To respond
jpountz commented on a change in pull request #865: LUCENE-8973: XYRectangle2D
should work on float space
URL: https://github.com/apache/lucene-solr/pull/865#discussion_r324172772
##
File path: lucene/sandbox/src/java/org/apache/lucene/geo/XYRectangle2D.java
##
@@ -16,42 +
jpountz commented on issue #875: merge master
URL: https://github.com/apache/lucene-solr/pull/875#issuecomment-531221639
Probably open by mistake.
This is an automated message from the Apache Git Service.
To respond to the mes
jpountz closed pull request #875: merge master
URL: https://github.com/apache/lucene-solr/pull/875
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
atris commented on issue #815: LUCENE-8213: Introduce Asynchronous Caching in
LRUQueryCache
URL: https://github.com/apache/lucene-solr/pull/815#issuecomment-531221868
Any further thoughts on this one?
This is an automated mes
jpountz merged pull request #868: LUCENE-8975: Code Cleanup: Use entryset for
map iteration wherever possible.
URL: https://github.com/apache/lucene-solr/pull/868
This is an automated message from the Apache Git Service.
To
atris commented on issue #876: Use The Passed In Threshold Value in
doConcurrentSearchWithThreshold
URL: https://github.com/apache/lucene-solr/pull/876#issuecomment-531226956
Can we merge this one? This is a simple fix to an existing test method.
---
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324162028
##
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##
@
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324161934
##
File path:
lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java
##
@@
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324146082
##
File path:
lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java
##
@@
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324146126
##
File path:
lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java
##
@@
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324181290
##
File path:
lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java
##
@@
atris commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early
Termination
URL: https://github.com/apache/lucene-solr/pull/877#issuecomment-531228068
@jimczi Updated, please see.
One thing we could do is cache the bottom docID (doc + docBase) in
BottomValueChecker, but
msokolov commented on issue #876: Use The Passed In Threshold Value in
doConcurrentSearchWithThreshold
URL: https://github.com/apache/lucene-solr/pull/876#issuecomment-531229416
I'll commit it. As I looked at this I couldn't help noticing a little
spelling nit; we have {{thresHold}} but "t
atris commented on issue #876: Use The Passed In Threshold Value in
doConcurrentSearchWithThreshold
URL: https://github.com/apache/lucene-solr/pull/876#issuecomment-531230646
Thanks, missed the camel casing, fixed now
This is
msokolov merged pull request #876: Use The Passed In Threshold Value in
doConcurrentSearchWithThreshold
URL: https://github.com/apache/lucene-solr/pull/876
This is an automated message from the Apache Git Service.
To respond
msokolov commented on issue #876: Use The Passed In Threshold Value in
doConcurrentSearchWithThreshold
URL: https://github.com/apache/lucene-solr/pull/876#issuecomment-531233209
thanks! merged
This is an automated message fro
atris commented on issue #876: Use The Passed In Threshold Value in
doConcurrentSearchWithThreshold
URL: https://github.com/apache/lucene-solr/pull/876#issuecomment-531233493
Thanks!
This is an automated message from the Apac
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324216889
##
File path:
lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java
##
@@
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324218620
##
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324218422
##
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom
Score Based Early Termination
URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324221245
##
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##
@
atris commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early
Termination
URL: https://github.com/apache/lucene-solr/pull/877#issuecomment-531261223
@jimczi Updated
This is an automated message from the Apache
jimczi commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early
Termination
URL: https://github.com/apache/lucene-solr/pull/877#issuecomment-531266829
Can you run another benchmark now that we propagate the global min score to
the scorer ?
---
301 - 400 of 3240 matches
Mail list logo
