[GitHub] lucene-solr pull request:

2016-01-04 Thread janhoy
Github user janhoy commented on the pull request: https://github.com/apache/lucene-solr/commit/c4bbf9cc5e8b1869d40cd7f619e40c8a4864d531#commitcomment-15254841 In solr/bin/solr: In solr/bin/solr on line 53: You are right. Opened https://issues.apache.org/jira/browse/SOLR-8486

[GitHub] lucene-solr pull request: LUCENE-7041 Upgrade to Apache Tika 1.12

2016-02-23 Thread janhoy
Github user janhoy commented on the pull request: https://github.com/apache/lucene-solr/pull/10#issuecomment-187617872 Hi, you should also manually upgrade relevant Tika dependencies. See lucene-solr/solr/contrib/extraction/ivy.xml When you compare changes between 1.7

[GitHub] lucene-solr issue #140: [SOLR-9997] Enable configuring SolrHttpClientBuilder...

2017-01-25 Thread janhoy
Github user janhoy commented on the issue: https://github.com/apache/lucene-solr/pull/140 I like it even better :) Let's add a comment to solr.in.sh that you can **either** specify `SOLR_AUTHENTICATION_CLIENT_BUILDER` or `SOLR_AUTH_TYPE`, and perhaps give a reference to the RefGuide

[GitHub] lucene-solr issue #140: [SOLR-9997] Enable configuring SolrHttpClientBuilder...

2017-01-20 Thread janhoy
Github user janhoy commented on the issue: https://github.com/apache/lucene-solr/pull/140 I like the --use-basic-auth convenience, or should we defailt to basic if no builder is specified (like it kind of is today)? --- If your project is set up for it, you can reply to this email

[GitHub] lucene-solr pull request #140: [SOLR-9997] Enable configuring SolrHttpClient...

2017-01-19 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/140#discussion_r96840773 --- Diff: solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientUtil.java --- @@ -111,28 +112,46 @@ // cannot be established within x ms

[GitHub] lucene-solr issue #34: Move hdfs stuff out into a new contrib

2016-08-31 Thread janhoy
Github user janhoy commented on the issue: https://github.com/apache/lucene-solr/pull/34 I think we should continue the work towards factoring out HDFS as a separate module. We can get rid of old versions of `commons-*` dependencies that the hadoop jars require as well, ref https

[GitHub] lucene-solr pull request #91: SOLR-9526: Next iteration on data driven schem...

2016-10-07 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/91 SOLR-9526: Next iteration on data driven schema, _str copyField Added support for a default typeMapping. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] lucene-solr pull request #103: SOLR-6994: Implement Windows version of bin/p...

2016-10-26 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/103 SOLR-6994: Implement Windows version of bin/post Very much work in progress You can merge this pull request into a Git repository by running: $ git pull https://github.com/cominvent/lucene

[GitHub] lucene-solr pull request #95: SOLR-9481: Authentication and Authorization pl...

2016-10-13 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/95 SOLR-9481: Authentication and Authorization plugins support for non-cloud Adds ability to use Auth/Autz plugins in standalone non-cloud mode. * Place `security.json` in $SOLR_HOME * Solr

[GitHub] lucene-solr issue #95: SOLR-9481: Authentication and Authorization plugins s...

2016-10-13 Thread janhoy
Github user janhoy commented on the issue: https://github.com/apache/lucene-solr/pull/95 Fixed an endless loop on edit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] lucene-solr pull request #95: SOLR-9481: Authentication and Authorization pl...

2017-07-06 Thread janhoy
Github user janhoy closed the pull request at: https://github.com/apache/lucene-solr/pull/95 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] lucene-solr issue #103: SOLR-6994: Implement Windows version of bin/post

2017-05-09 Thread janhoy
Github user janhoy commented on the issue: https://github.com/apache/lucene-solr/pull/103 Hmm, completely forgot that I worked on this :) This is more than just a post.cmd, it is a refactor of post CLI into a Java program to be used both by post and post.cmd. Feel free

[GitHub] lucene-solr issue #91: SOLR-9526: Next iteration on data driven schema, _str...

2017-06-20 Thread janhoy
Github user janhoy commented on the issue: https://github.com/apache/lucene-solr/pull/91 Pull request updated to current master. Please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] lucene-solr issue #278: SOLR-11508: core.properties should be stored $solr.d...

2017-11-29 Thread janhoy
Github user janhoy commented on the issue: https://github.com/apache/lucene-solr/pull/278 Looks good to me --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h

[GitHub] lucene-solr pull request #373: SOLR-7767: New Zookeeper cluster view, first ...

2018-05-08 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/373 SOLR-7767: New Zookeeper cluster view, first cut Still needs some buttons for showing details and refresh and probably some cleanup You can merge this pull request into a Git repository

[GitHub] lucene-solr issue #403: SOLR-12193 Move some log messages to TRACE level

2018-06-13 Thread janhoy
Github user janhoy commented on the issue: https://github.com/apache/lucene-solr/pull/403 Thanks. Can you please also add an entry to CHANGES.txt file with a short description and your name in parenthesis? You can place the entry in the 7.5.0 section of the file, under "Other ch

[GitHub] lucene-solr pull request #400: Put example query on its own line. Also fixes...

2018-06-11 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/400 Put example query on its own line. Also fixes bug where asterisks did not show You can merge this pull request into a Git repository by running: $ git pull https://github.com/cominvent

[GitHub] lucene-solr pull request #401: Autoscaling Suggestions API page typo

2018-06-11 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/401 Autoscaling Suggestions API page typo The suggestions api is on `/api/cluster/autoscaling/suggestions` and not `/api/cluster/autoscaling/suggestion` You can merge this pull request into a Git

[GitHub] lucene-solr pull request #315: Remove debug comment on top of doc file

2018-01-30 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/315 Remove debug comment on top of doc file @ctargett Think this line should not have been in the docs :-) https://lucene.apache.org/solr/guide/7_2/stream-source-reference.html You can

[GitHub] lucene-solr pull request #373: SOLR-7767: New Zookeeper cluster view, first ...

2018-08-15 Thread janhoy
Github user janhoy closed the pull request at: https://github.com/apache/lucene-solr/pull/373 --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #360: SOLR-8207 Admin UI Nodes tab

2018-08-15 Thread janhoy
Github user janhoy closed the pull request at: https://github.com/apache/lucene-solr/pull/360 --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #91: SOLR-9526: Next iteration on data driven schem...

2018-08-15 Thread janhoy
Github user janhoy closed the pull request at: https://github.com/apache/lucene-solr/pull/91 --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #342: SOLR-12120: New AuditLoggerPlugin type allowi...

2018-08-10 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/342#discussion_r209195654 --- Diff: solr/core/src/java/org/apache/solr/security/AuditEvent.java --- @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] lucene-solr pull request #342: SOLR-12120: New AuditLoggerPlugin type allowi...

2018-08-17 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/342#discussion_r210951310 --- Diff: solr/core/src/java/org/apache/solr/security/AuditEvent.java --- @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] lucene-solr pull request #441: SOLR-11690: Improve documentation about DIH p...

2018-08-29 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/441 SOLR-11690: Improve documentation about DIH password encryption Only refguide doc change You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] lucene-solr pull request #336: SOLR-11774 langid.map.individual broken

2018-03-15 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/336 SOLR-11774 langid.map.individual broken Some failing tests. It is `langid.map.individual` that is broken, independent from `keepOrig` setting. You can merge this pull request into a Git

[GitHub] lucene-solr pull request #353: SOLR-12194: Deprecate SolrRequest#setBasicAut...

2018-04-06 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/353 SOLR-12194: Deprecate SolrRequest#setBasicAuthCredentials First step Still need to modify `BasicAuthIntegrationTest` and document in ref-guide, but that could also be done in separate

[GitHub] lucene-solr pull request #351: SOLR-9640 Support PKI authentication in stand...

2018-04-04 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/351 SOLR-9640 Support PKI authentication in standalone mode Generating PR for easier review You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] lucene-solr pull request #360: SOLR-8207 Admin UI Nodes tab

2018-04-23 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/360 SOLR-8207 Admin UI Nodes tab New nodes tab You can merge this pull request into a Git repository by running: $ git pull https://github.com/cominvent/lucene-solr solr8207-ui-nodes-tab

[GitHub] lucene-solr issue #342: SOLR-12120: New AuditLoggerPlugin type allowing cust...

2018-03-24 Thread janhoy
Github user janhoy commented on the issue: https://github.com/apache/lucene-solr/pull/342 Pushed another commit simplifying the if checks into `auditIfConfigured()`. --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] lucene-solr pull request #342: SOLR-12120: New AuditLoggerPlugin type allowi...

2018-03-24 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/342#discussion_r176922456 --- Diff: solr/core/src/java/org/apache/solr/core/CoreContainer.java --- @@ -328,6 +331,38 @@ private synchronized void initializeAuthorizationPlugin

[GitHub] lucene-solr pull request #341: SOLR-12131: ExternalRoleRuleBasedAuthorizatio...

2018-03-20 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/341 SOLR-12131: ExternalRoleRuleBasedAuthorizationPlugin ...which gets user's roles from request You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] lucene-solr pull request #342: SOLR-12120: New AuditLoggerPlugin type allowi...

2018-03-23 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/342 SOLR-12120: New AuditLoggerPlugin type allowing custom Audit logger plugin You can merge this pull request into a Git repository by running: $ git pull https://github.com/cominvent

[GitHub] lucene-solr pull request #343: SOLR-12121: JWT Token authentication plugin

2018-03-23 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/343 SOLR-12121: JWT Token authentication plugin First version. Still some TODO and NOCOMMIT. Lacks some end-to-end tests etc. You can merge this pull request into a Git repository by running

[GitHub] lucene-solr pull request #342: SOLR-12120: New AuditLoggerPlugin type allowi...

2018-03-23 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/342#discussion_r176802032 --- Diff: solr/core/src/java/org/apache/solr/security/SolrLogAuditLoggerPlugin.java --- @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software

[GitHub] lucene-solr pull request #342: SOLR-12120: New AuditLoggerPlugin type allowi...

2018-03-23 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/342#discussion_r176802406 --- Diff: solr/core/src/java/org/apache/solr/security/AuditLoggerPlugin.java --- @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software

[GitHub] lucene-solr pull request #342: SOLR-12120: New AuditLoggerPlugin type allowi...

2018-03-23 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/342#discussion_r176802667 --- Diff: solr/core/src/java/org/apache/solr/core/CoreContainer.java --- @@ -328,6 +331,38 @@ private synchronized void initializeAuthorizationPlugin

[GitHub] lucene-solr issue #342: SOLR-12120: New AuditLoggerPlugin type allowing cust...

2018-03-23 Thread janhoy
Github user janhoy commented on the issue: https://github.com/apache/lucene-solr/pull/342 > I wish we wouldn't have to do all those if (cores.getAuditLoggerPlugin() != null) Perhaps this is better? if (auditEnabled()) { ... } > are you intenti

[GitHub] lucene-solr issue #342: SOLR-12120: New AuditLoggerPlugin type allowing cust...

2018-03-23 Thread janhoy
Github user janhoy commented on the issue: https://github.com/apache/lucene-solr/pull/342 Pushed changes to the PR, addressing most of the comments. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org

[GitHub] lucene-solr issue #421: SOLR-7557: Fix parsing of child documents using quer...

2018-10-26 Thread janhoy
Github user janhoy commented on the issue: https://github.com/apache/lucene-solr/pull/421 Committed. You may close this PR (forgot to add the magic words in the commit msg) --- - To unsubscribe, e-mail: dev

[GitHub] lucene-solr issue #421: SOLR-7557: Fix parsing of child documents using quer...

2018-10-26 Thread janhoy
Github user janhoy commented on the issue: https://github.com/apache/lucene-solr/pull/421 Probably the easiest :) Thanks --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e

[GitHub] lucene-solr issue #421: SOLR-7557: Fix parsing of child documents using quer...

2018-10-26 Thread janhoy
Github user janhoy commented on the issue: https://github.com/apache/lucene-solr/pull/421 Great. What's the reason for adding another child document to the test? Please do the following changes * Move the test to `SolrExampleStreamingBinaryTest` (don't need to test

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-04 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r222759868 --- Diff: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java --- @@ -52,11 +80,73 @@ public abstract boolean doAuthenticate

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-04 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r222759422 --- Diff: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java --- @@ -52,11 +80,73 @@ public abstract boolean doAuthenticate

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-04 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r222759139 --- Diff: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java --- @@ -20,16 +20,44 @@ import javax.servlet.ServletRequest

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-04 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r222761151 --- Diff: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java --- @@ -52,11 +80,73 @@ public abstract boolean doAuthenticate

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-04 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r222761691 --- Diff: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java --- @@ -52,11 +80,73 @@ public abstract boolean doAuthenticate

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-04 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r222757598 --- Diff: solr/core/src/java/org/apache/solr/core/SolrInfoBean.java --- @@ -34,7 +34,7 @@ * Category of Solr component. */ enum

[GitHub] lucene-solr pull request #465: SOLR-7896: Add a login page to Admin UI, with...

2018-10-09 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/465 SOLR-7896: Add a login page to Admin UI, with initial support for Basic Auth First cut for basic auth You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] lucene-solr pull request #461: SOLR-12814: Metrics history causing "HttpPars...

2018-10-02 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/461 SOLR-12814: Metrics history causing "HttpParser URI is too large" >8192 when many collections. The fix was to change from `GET` to `POST` You can merge this pull reque

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-10 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r224121448 --- Diff: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java --- @@ -52,11 +80,73 @@ public abstract boolean doAuthenticate

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-10 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r224121574 --- Diff: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java --- @@ -52,11 +80,73 @@ public abstract boolean doAuthenticate

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-04 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r222657709 --- Diff: solr/core/src/java/org/apache/solr/core/CoreContainer.java --- @@ -798,6 +798,12 @@ private void reloadSecurityProperties

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-04 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r222658500 --- Diff: solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java --- @@ -420,4 +425,68 @@ public static void ensureRunningJettys(int

[GitHub] lucene-solr pull request #465: SOLR-7896: Add a login page to Admin UI, with...

2018-10-09 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/465#discussion_r223859201 --- Diff: solr/webapp/web/WEB-INF/web.xml --- @@ -33,7 +33,7 @@ --> excludePatterns - /partials/.+,/libs/.+,/

[GitHub] lucene-solr pull request #465: SOLR-7896: Add a login page to Admin UI, with...

2018-10-09 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/465#discussion_r223857445 --- Diff: solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java --- @@ -342,18 +342,6 @@ public void doFilter(ServletRequest _request

[GitHub] lucene-solr pull request #465: SOLR-7896: Add a login page to Admin UI, with...

2018-10-09 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/465#discussion_r223863279 --- Diff: solr/webapp/web/js/angular/app.js --- @@ -365,12 +370,62 @@ solrAdminApp.config([ $rootScope.exceptions[rejection.config.url

[GitHub] lucene-solr pull request #465: SOLR-7896: Add a login page to Admin UI, with...

2018-10-09 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/465#discussion_r223860727 --- Diff: solr/webapp/web/index.html --- @@ -61,9 +62,11 @@ + --- End diff -- Used for base64 encoding

[GitHub] lucene-solr pull request #465: SOLR-7896: Add a login page to Admin UI, with...

2018-10-09 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/465#discussion_r223860298 --- Diff: solr/webapp/web/css/angular/login.css --- @@ -0,0 +1,103 @@ +/* + +Licensed to the Apache Software Foundation (ASF) under one

[GitHub] lucene-solr pull request #465: SOLR-7896: Add a login page to Admin UI, with...

2018-10-09 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/465#discussion_r223855611 --- Diff: solr/core/src/java/org/apache/solr/security/BasicAuthPlugin.java --- @@ -180,8 +193,16 @@ public boolean getBlockUnknown(){ return

[GitHub] lucene-solr pull request #465: SOLR-7896: Add a login page to Admin UI, with...

2018-10-09 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/465#discussion_r223866955 --- Diff: solr/webapp/web/partials/login.html --- @@ -0,0 +1,80 @@ + + + + +Basic Authentication

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-09-20 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/457 SOLR-12791: Add Metrics reporting for AuthenticationPlugin First partial patch You can merge this pull request into a Git repository by running: $ git pull https://github.com/cominvent

[GitHub] lucene-solr pull request #458: SOLR-12799: Allow Authentication Plugins to i...

2018-09-24 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/458 SOLR-12799: Allow Authentication Plugins to intercept internode requests on a per-request basis Framework support for per-request decision on whether to secure inter-node requests You can

[GitHub] lucene-solr issue #305: SOLR-11853: Make check for used tool "service" compa...

2018-09-23 Thread janhoy
Github user janhoy commented on the issue: https://github.com/apache/lucene-solr/pull/305 If `--help` works on all platforms, why not just switch? I checked with docker in ubuntu, centos and they both support --help

[GitHub] lucene-solr pull request #506: SOLR-13014: URI Too Long with large streaming...

2018-12-10 Thread janhoy
Github user janhoy closed the pull request at: https://github.com/apache/lucene-solr/pull/506 --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #458: SOLR-12799: Allow Authentication Plugins to i...

2018-12-13 Thread janhoy
Github user janhoy closed the pull request at: https://github.com/apache/lucene-solr/pull/458 --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #343: SOLR-12121: JWT Token authentication plugin

2018-12-13 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/343#discussion_r241401404 --- Diff: solr/core/src/java/org/apache/solr/security/JWTPrincipal.java --- @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] lucene-solr pull request #343: SOLR-12121: JWT Token authentication plugin

2018-12-13 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/343#discussion_r241403119 --- Diff: solr/core/src/test/org/apache/solr/security/JWTAuthPluginIntegrationTest.java --- @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #343: SOLR-12121: JWT Token authentication plugin

2018-12-13 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/343#discussion_r241402568 --- Diff: solr/core/src/java/org/apache/solr/security/JWTPrincipalWithUserRoles.java --- @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #343: SOLR-12121: JWT Token authentication plugin

2018-12-13 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/343#discussion_r241403280 --- Diff: solr/core/src/test/org/apache/solr/security/JWTAuthPluginIntegrationTest.java --- @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #465: SOLR-7896: Add a login page to Admin UI, with...

2018-12-12 Thread janhoy
Github user janhoy closed the pull request at: https://github.com/apache/lucene-solr/pull/465 --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #518: SOLR-13025: SchemaSimilarityFactory fallback ...

2018-12-12 Thread janhoy
Github user janhoy closed the pull request at: https://github.com/apache/lucene-solr/pull/518 --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #342: SOLR-12120: New AuditLoggerPlugin type allowi...

2018-12-21 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/342#discussion_r243532741 --- Diff: solr/core/src/java/org/apache/solr/security/AuditEvent.java --- @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] lucene-solr pull request #343: SOLR-12121: JWT Token authentication plugin

2018-12-21 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/343#discussion_r243600574 --- Diff: solr/core/src/test/org/apache/solr/security/JWTAuthPluginIntegrationTest.java --- @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #458: SOLR-12799: Allow Authentication Plugins to i...

2018-12-11 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/458#discussion_r240523872 --- Diff: solr/core/src/java/org/apache/solr/security/BasicAuthPlugin.java --- @@ -181,7 +217,54 @@ public boolean getBlockUnknown

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-12-12 Thread janhoy
Github user janhoy closed the pull request at: https://github.com/apache/lucene-solr/pull/457 --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #343: SOLR-12121: JWT Token authentication plugin

2018-12-14 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/343#discussion_r241698617 --- Diff: solr/core/src/test/org/apache/solr/security/JWTAuthPluginIntegrationTest.java --- @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #458: SOLR-12799: Allow Authentication Plugins to i...

2018-12-12 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/458#discussion_r240997747 --- Diff: solr/core/src/test/org/apache/solr/security/BasicAuthIntegrationTest.java --- @@ -232,6 +229,17 @@ public void testBasicAuth() throws

[GitHub] lucene-solr pull request #518: SOLR-13025: SchemaSimilarityFactory fallback ...

2018-12-07 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/518 SOLR-13025: SchemaSimilarityFactory fallback to LegacyBM25Similarity See https://issues.apache.org/jira/browse/SOLR-13025 You can merge this pull request into a Git repository by running

[GitHub] lucene-solr pull request #506: SOLR-13014: URI Too Long with large streaming...

2018-11-24 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/506 SOLR-13014: URI Too Long with large streaming expressions in SolrJ You can merge this pull request into a Git repository by running: $ git pull https://github.com/cominvent/lucene-solr

[GitHub] lucene-solr pull request #458: SOLR-12799: Allow Authentication Plugins to i...

2018-12-10 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/458#discussion_r240236834 --- Diff: solr/core/src/test/org/apache/solr/security/BasicAuthIntegrationTest.java --- @@ -232,6 +229,17 @@ public void testBasicAuth() throws

[GitHub] lucene-solr pull request #458: SOLR-12799: Allow Authentication Plugins to i...

2018-12-10 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/458#discussion_r240234930 --- Diff: solr/core/src/java/org/apache/solr/security/BasicAuthPlugin.java --- @@ -172,6 +192,22 @@ public void closeRequest() { Map

[GitHub] lucene-solr pull request #458: SOLR-12799: Allow Authentication Plugins to i...

2018-12-10 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/458#discussion_r240235679 --- Diff: solr/core/src/java/org/apache/solr/security/BasicAuthPlugin.java --- @@ -181,7 +217,54 @@ public boolean getBlockUnknown

[GitHub] lucene-solr issue #458: SOLR-12799: Allow Authentication Plugins to intercep...

2018-12-19 Thread janhoy
Github user janhoy commented on the issue: https://github.com/apache/lucene-solr/pull/458 @bbl232 If you're using BasicAuthPlugin then, yes, this feature may help you. Feel free to build 8.0.0-SNAPSHOT and test. Backporting should be easy