[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-08 Thread sigram
Github user sigram commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r223286109 --- Diff: solr/core/src/java/org/apache/solr/core/SolrInfoBean.java --- @@ -34,7 +34,7 @@ * Category of Solr component. */ enum

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-08 Thread sigram
Github user sigram commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r223286527 --- Diff: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java --- @@ -52,11 +80,73 @@ public abstract boolean doAuthenticate

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-08 Thread sigram
Github user sigram commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r223288246 --- Diff: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java --- @@ -52,11 +80,73 @@ public abstract boolean doAuthenticate

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-08 Thread sigram
Github user sigram commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r223290128 --- Diff: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java --- @@ -52,11 +80,73 @@ public abstract boolean doAuthenticate

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-04 Thread sigram
Github user sigram commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r222587616 --- Diff: solr/core/src/java/org/apache/solr/core/CoreContainer.java --- @@ -798,6 +798,12 @@ private void reloadSecurityProperties

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-04 Thread sigram
Github user sigram commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r222593938 --- Diff: solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java --- @@ -420,4 +425,68 @@ public static void ensureRunningJettys(int

[GitHub] lucene-solr issue #394: Synchronized disruption

2018-06-05 Thread sigram
Github user sigram commented on the issue: https://github.com/apache/lucene-solr/pull/394 FWIW, Solr supports a ScheduledTrigger and there's a default configuration called `.scheduled_maintenance` that executes `solr.InactiveShardPlanAction`. The functionality in your patch cou

[GitHub] lucene-solr issue #394: Synchronized disruption

2018-06-05 Thread sigram
Github user sigram commented on the issue: https://github.com/apache/lucene-solr/pull/394 Oh, I see - triggers execute ONLY on the current Overseer leader node - you would need some sort of fan-out call to each node in that action, and a handler to actually execute System.gc() on the

[GitHub] lucene-solr pull request #119: SOLR-4735 Improve Solr metrics

2016-11-24 Thread sigram
GitHub user sigram opened a pull request: https://github.com/apache/lucene-solr/pull/119 SOLR-4735 Improve Solr metrics Branch created from the patch in Jira by Kelvin Wong. Changes include: * using shared instances of `MetricRegistry` per core. * unit test

[GitHub] lucene-solr pull request #119: SOLR-4735 Improve Solr metrics

2016-11-29 Thread sigram
Github user sigram closed the pull request at: https://github.com/apache/lucene-solr/pull/119 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] lucene-solr issue #119: SOLR-4735 Improve Solr metrics

2016-11-29 Thread sigram
Github user sigram commented on the issue: https://github.com/apache/lucene-solr/pull/119 This work will be merged and continued in the `features/metrics` branch at ASF. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] lucene-solr pull request #120: SOLR-4735 Improve Solr metrics reporting

2016-11-29 Thread sigram
GitHub user sigram opened a pull request: https://github.com/apache/lucene-solr/pull/120 SOLR-4735 Improve Solr metrics reporting You can merge this pull request into a Git repository by running: $ git pull https://github.com/sigram/lucene-solr jira/solr-4735 Alternatively