[jira] [Resolved] (LUCENE-8975) Code Cleanup: Use entryset for map iteration wherever possible.

2019-09-13 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8975. -- Fix Version/s: 8.3 Resolution: Fixed > Code Cleanup: Use entryset for map iteration

[jira] [Commented] (LUCENE-8939) Shared Hit Count Early Termination

2019-09-13 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929307#comment-16929307 ] Adrien Grand commented on LUCENE-8939: -- Thanks [~mikemccand] I had lost track of this, I agree it

[jira] [Resolved] (LUCENE-8939) Shared Hit Count Early Termination

2019-09-13 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8939. -- Fix Version/s: 8.3 Resolution: Fixed > Shared Hit Count Early Termination >

[jira] [Commented] (LUCENE-8970) TopFieldCollector(s) Should Prepopulate Sentinel Objects

2019-09-13 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929154#comment-16929154 ] Adrien Grand commented on LUCENE-8970: -- Maybe we can try to do a quick hack to see how much it

[jira] [Resolved] (LUCENE-7521) Simplify PackedInts

2019-09-11 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-7521. -- Fix Version/s: master (9.0) Resolution: Fixed > Simplify PackedInts >

[jira] [Commented] (LUCENE-8961) CheckIndex: pre-exorcise document id salvage

2019-09-09 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926078#comment-16926078 ] Adrien Grand commented on LUCENE-8961: -- Agreed it is awkward. When I said "on top of CheckIndex", I

[jira] [Commented] (LUCENE-8917) Remove the "Direct" doc-value format

2019-09-05 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923711#comment-16923711 ] Adrien Grand commented on LUCENE-8917: -- Thanks Hoss, I shouldn't have neglected to test Solr... >

[jira] [Resolved] (LUCENE-8956) QueryRescorer sort optimization

2019-09-05 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8956. -- Resolution: Fixed Merged, thanks. > QueryRescorer sort optimization >

[jira] [Reopened] (LUCENE-8956) QueryRescorer sort optimization

2019-09-05 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand reopened LUCENE-8956: -- I had to revert this change due to test failures such as {noformat} 13:40:13[junit4] Suite:

[jira] [Resolved] (LUCENE-8905) TopDocsCollector Should Have Better Error Handling For Illegal Arguments

2019-09-05 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8905. -- Fix Version/s: master (9.0) Resolution: Fixed > TopDocsCollector Should Have Better

[jira] [Commented] (LUCENE-8920) Reduce size of FSTs due to use of direct-addressing encoding

2019-09-05 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923446#comment-16923446 ] Adrien Grand commented on LUCENE-8920: -- This is a cool idea. > Reduce size of FSTs due to use of

[jira] [Resolved] (LUCENE-8917) Remove the "Direct" doc-value format

2019-09-05 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8917. -- Fix Version/s: master (9.0) Resolution: Fixed > Remove the "Direct" doc-value format >

[jira] [Commented] (LUCENE-7521) Simplify PackedInts

2019-09-05 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923212#comment-16923212 ] Adrien Grand commented on LUCENE-7521: -- I'd like to move forward on this. Hopefully since we last

[jira] [Resolved] (LUCENE-8942) Tighten Up LRUQueryCache's Methods

2019-09-05 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8942. -- Fix Version/s: 8.3 Resolution: Fixed > Tighten Up LRUQueryCache's Methods >

[jira] [Commented] (LUCENE-8932) Allow BKDReader packedIndex to be off heap

2019-09-05 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923137#comment-16923137 ] Adrien Grand commented on LUCENE-8932: -- I was hoping LUCENE-8833 would land and we could build on

[jira] [Updated] (LUCENE-8956) QueryRescorer sort optimization

2019-09-05 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8956: - Fix Version/s: 8.3 Resolution: Fixed Status: Resolved (was: Patch Available)

[jira] [Commented] (LUCENE-8910) upgrade to icu 62.1must be completed

2019-09-05 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923106#comment-16923106 ] Adrien Grand commented on LUCENE-8910: -- Thank you [~matmarie]! > upgrade to icu 62.1must be

[jira] [Resolved] (LUCENE-8910) upgrade to icu 62.1must be completed

2019-09-05 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8910. -- Fix Version/s: 8.3 Resolution: Fixed > upgrade to icu 62.1must be completed >

[jira] [Commented] (LUCENE-8963) Allow Collectors To "Publish" If They Can Be Used In Concurrent Search

2019-09-04 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922304#comment-16922304 ] Adrien Grand commented on LUCENE-8963: -- I don't think this would solve any problem? Collectors can

[jira] [Updated] (LUCENE-8150) Remove references to segments.gen.

2019-09-04 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8150: - Fix Version/s: master (9.0) Resolution: Fixed Status: Resolved (was: Patch

[jira] [Commented] (LUCENE-8860) LatLonShapeBoundingBoxQuery could make more decisions on inner nodes

2019-09-02 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920960#comment-16920960 ] Adrien Grand commented on LUCENE-8860: -- Why is it a problem? If the query polygon fully contains

[jira] [Commented] (LUCENE-8961) CheckIndex: pre-exorcise document id salvage

2019-09-02 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920958#comment-16920958 ] Adrien Grand commented on LUCENE-8961: -- This feels too unsafe to me for CheckIndex. For instance,

[jira] [Commented] (LUCENE-8956) QueryRescorer sort optimization

2019-09-02 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920853#comment-16920853 ] Adrien Grand commented on LUCENE-8956: -- I was thinking that we could verify that we have the right

[jira] [Commented] (LUCENE-8403) Support 'filtered' term vectors - don't require all terms to be present

2019-09-02 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920659#comment-16920659 ] Adrien Grand commented on LUCENE-8403: -- bq. mucking with the higher level features to use a

[jira] [Commented] (LUCENE-8956) QueryRescorer sort optimization

2019-08-22 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913694#comment-16913694 ] Adrien Grand commented on LUCENE-8956: -- The changes in src/java look good to me. Maybe we could

[jira] [Commented] (LUCENE-8860) LatLonShapeBoundingBoxQuery could make more decisions on inner nodes

2019-08-20 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911753#comment-16911753 ] Adrien Grand commented on LUCENE-8860: -- I suspect that the confusion is that we don't use

[jira] [Commented] (LUCENE-8950) FieldComparators Should Not Maintain Implicit PQs

2019-08-14 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907090#comment-16907090 ] Adrien Grand commented on LUCENE-8950: -- OK I got confused with the notion of deprecation, which

[jira] [Commented] (LUCENE-8947) Indexing fails with "too many tokens for field" when using custom term frequencies

2019-08-14 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907086#comment-16907086 ] Adrien Grand commented on LUCENE-8947: -- Changing it to a long might be challenging for norms, since

[jira] [Commented] (LUCENE-8950) FieldComparators Should Not Maintain Implicit PQs

2019-08-14 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907069#comment-16907069 ] Adrien Grand commented on LUCENE-8950: -- This looks like a duplicate of LUCENE-8878? I think all of

[jira] [Commented] (LUCENE-8935) BooleanQuery with no scoring clauses cannot skip documents when running TOP_SCORES mode

2019-07-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893786#comment-16893786 ] Adrien Grand commented on LUCENE-8935: -- Woops indeed you are right. +1 to the attached patch! >

[jira] [Commented] (LUCENE-8935) BooleanQuery with no scoring clauses cannot skip documents when running TOP_SCORES mode

2019-07-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893690#comment-16893690 ] Adrien Grand commented on LUCENE-8935: -- The approach works for me. I'm wondering that if we put

[jira] [Resolved] (LUCENE-8915) Document that RateLimiter's limits may be updated over time

2019-07-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8915. -- Resolution: Fixed Fix Version/s: 8.3 Thanks [~atris] > Document that RateLimiter's

[jira] [Updated] (LUCENE-8915) Document that RateLimiter's limits may be updated over time

2019-07-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8915: - Summary: Document that RateLimiter's limits may be updated over time (was: Allow RateLimiter

[jira] [Commented] (LUCENE-8933) JapaneseTokenizer creates Token objects with corrupt offsets

2019-07-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893662#comment-16893662 ] Adrien Grand commented on LUCENE-8933: -- Should we go further and check that the concatenation of

[jira] [Commented] (LUCENE-8927) Cut Over To Set.copyOf and Set.Of From Collections.unmodifiableSet

2019-07-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893477#comment-16893477 ] Adrien Grand commented on LUCENE-8927: -- Thanks for fixing [~ichattopadhyaya]! > Cut Over To

[jira] [Resolved] (LUCENE-8927) Cut Over To Set.copyOf and Set.Of From Collections.unmodifiableSet

2019-07-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8927. -- Resolution: Fixed Fix Version/s: master (9.0) > Cut Over To Set.copyOf and Set.Of From

[jira] [Resolved] (LUCENE-8931) TestTopFieldCollectorEarlyTermination Should Use CheckHits

2019-07-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8931. -- Resolution: Fixed Fix Version/s: 8.3 > TestTopFieldCollectorEarlyTermination Should

[jira] [Resolved] (LUCENE-8922) Speed up retrieval of top hits of DisjunctionMaxQuery

2019-07-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8922. -- Resolution: Fixed Fix Version/s: 8.3 > Speed up retrieval of top hits of

[jira] [Commented] (LUCENE-8933) JapaneseTokenizer creates Token objects with corrupt offsets

2019-07-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892644#comment-16892644 ] Adrien Grand commented on LUCENE-8933: -- Ah, thanks for digging [~tomoko] and [~danmuzi]. I

[jira] [Commented] (LUCENE-8932) Allow BKDReader packedIndex to be off heap

2019-07-24 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892193#comment-16892193 ] Adrien Grand commented on LUCENE-8932: -- This is interesting! It doesn't seem to affect performance

[jira] [Created] (LUCENE-8933) JapaneseTokenizer creates Token objects with corrupt offsets

2019-07-24 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8933: Summary: JapaneseTokenizer creates Token objects with corrupt offsets Key: LUCENE-8933 URL: https://issues.apache.org/jira/browse/LUCENE-8933 Project: Lucene - Core

[jira] [Commented] (LUCENE-8929) Early Terminating CollectorManager

2019-07-23 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890753#comment-16890753 ] Adrien Grand commented on LUCENE-8929: -- Hmm I am confused now, I don't think you can spread the top

[jira] [Commented] (LUCENE-8929) Early Terminating CollectorManager

2019-07-23 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890746#comment-16890746 ] Adrien Grand commented on LUCENE-8929: -- OK, so if I understand correctly you are still collecting

[jira] [Commented] (LUCENE-8929) Early Terminating CollectorManager

2019-07-23 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890732#comment-16890732 ] Adrien Grand commented on LUCENE-8929: -- What collector do you have in mind? Is it

[jira] [Commented] (LUCENE-8921) IndexSearcher.termStatistics should not require TermStates but docFreq and totalTermFreq

2019-07-19 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1614#comment-1614 ] Adrien Grand commented on LUCENE-8921: -- +1 > IndexSearcher.termStatistics should not require

[jira] [Commented] (LUCENE-8920) Reduce size of FSTs due to use of direct-addressing encoding

2019-07-19 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1612#comment-1612 ] Adrien Grand commented on LUCENE-8920: -- This sounds good Mike. I'm making it a blocker for 8.3

[jira] [Updated] (LUCENE-8920) Reduce size of FSTs due to use of direct-addressing encoding

2019-07-19 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8920: - Priority: Blocker (was: Major) > Reduce size of FSTs due to use of direct-addressing encoding

[jira] [Updated] (LUCENE-8920) Reduce size of FSTs due to use of direct-addressing encoding

2019-07-19 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8920: - Fix Version/s: 8.3 > Reduce size of FSTs due to use of direct-addressing encoding >

[jira] [Commented] (LUCENE-8928) BKDWriter could make splitting decisions based on the actual range of values

2019-07-19 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888722#comment-16888722 ] Adrien Grand commented on LUCENE-8928: -- I played with this idea a bit at

[jira] [Created] (LUCENE-8928) BKDWriter could make splitting decisions based on the actual range of values

2019-07-19 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8928: Summary: BKDWriter could make splitting decisions based on the actual range of values Key: LUCENE-8928 URL: https://issues.apache.org/jira/browse/LUCENE-8928

[jira] [Commented] (LUCENE-8924) Remove Fields Order Checks from CheckIndex?

2019-07-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887300#comment-16887300 ] Adrien Grand commented on LUCENE-8924: -- We rely on the order for merging, see "MultiFields". >

[jira] [Commented] (LUCENE-8909) Deprecate getFieldNames from IndexWriter

2019-07-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887291#comment-16887291 ] Adrien Grand commented on LUCENE-8909: -- +1 > Deprecate getFieldNames from IndexWriter >

[jira] [Commented] (LUCENE-8908) Specified default value not returned for query() when doc doesn't match

2019-07-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887290#comment-16887290 ] Adrien Grand commented on LUCENE-8908: -- +1 > Specified default value not returned for query() when

[jira] [Commented] (LUCENE-8922) Speed up retrieval of top hits of DisjunctionMaxQuery

2019-07-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886944#comment-16886944 ] Adrien Grand commented on LUCENE-8922: -- Here is a patch. It uses the first clause that has a score

[jira] [Commented] (LUCENE-8923) Release procedure does not add new version in CHANGES.txt in master

2019-07-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886941#comment-16886941 ] Adrien Grand commented on LUCENE-8923: -- +1 Even if some changes are missing I think we'd benefit

[jira] [Created] (LUCENE-8922) Speed up retrieval of top hits of DisjunctionMaxQuery

2019-07-17 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8922: Summary: Speed up retrieval of top hits of DisjunctionMaxQuery Key: LUCENE-8922 URL: https://issues.apache.org/jira/browse/LUCENE-8922 Project: Lucene - Core

[jira] [Commented] (LUCENE-8883) CHANGES.txt: Auto add issue categories on new releases

2019-07-16 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886114#comment-16886114 ] Adrien Grand commented on LUCENE-8883: -- I have a slight preference for having "Optimizations" as

[jira] [Commented] (LUCENE-8884) Add Directory wrapper to track per-query IO counters

2019-07-16 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886043#comment-16886043 ] Adrien Grand commented on LUCENE-8884: -- I'm not seeing any attachement on this JIRA, did you forget

[jira] [Resolved] (LUCENE-8810) Flattening of nested disjunctions does not take into account number of clause limitation of builder

2019-07-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8810. -- Resolution: Fixed Fix Version/s: (was: 8.1.1) 8.2 > Flattening

[jira] [Created] (LUCENE-8917) Remove the "Direct" doc-value format

2019-07-15 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8917: Summary: Remove the "Direct" doc-value format Key: LUCENE-8917 URL: https://issues.apache.org/jira/browse/LUCENE-8917 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-07-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884944#comment-16884944 ] Adrien Grand commented on LUCENE-8811: -- Thanks! I'll revert this change from 8.x and 8.2 in the

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-07-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884932#comment-16884932 ] Adrien Grand commented on LUCENE-8811: -- [~atris] If the patch you are thinking of is the one on

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-07-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884904#comment-16884904 ] Adrien Grand commented on LUCENE-8811: -- I was reviewing the changelog for 8.2, this change looks a

[jira] [Resolved] (LUCENE-8311) Leverage impacts for phrase queries

2019-07-11 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8311. -- Resolution: Fixed Fix Version/s: 8.2 > Leverage impacts for phrase queries >

[jira] [Commented] (LUCENE-8909) Deprecate getFieldNames from IndexWriter

2019-07-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882325#comment-16882325 ] Adrien Grand commented on LUCENE-8909: -- +1 > Deprecate getFieldNames from IndexWriter >

[jira] [Resolved] (LUCENE-8875) Should TopScoreDocCollector Always Populate Sentinel Values?

2019-07-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8875. -- Resolution: Fixed Fix Version/s: 8.2 > Should TopScoreDocCollector Always Populate

[jira] [Commented] (LUCENE-8907) Provide backward compatibility for loading analysis factories

2019-07-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882074#comment-16882074 ] Adrien Grand commented on LUCENE-8907: -- I have a slight preference for reverting on 8.x and have

[jira] [Commented] (LUCENE-8907) Provide backward compatibility for loading analysis factories

2019-07-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881982#comment-16881982 ] Adrien Grand commented on LUCENE-8907: -- I don't like 2, it feels too breaking to me for a minor

[jira] [Commented] (LUCENE-8311) Leverage impacts for phrase queries

2019-07-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881967#comment-16881967 ] Adrien Grand commented on LUCENE-8311: -- This made exact phrase queries 3x faster in the nightly

[jira] [Commented] (LUCENE-8883) CHANGES.txt: Auto add issue categories on new releases

2019-07-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881541#comment-16881541 ] Adrien Grand commented on LUCENE-8883: -- I did grep "^[A-Z]" CHANGES.txt | sort | uniq -c | sort

[jira] [Commented] (LUCENE-8069) Allow index sorting by field length

2019-07-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881491#comment-16881491 ] Adrien Grand commented on LUCENE-8069: -- I didn't measure the indexing rate, I can do that next.

[jira] [Resolved] (LUCENE-8900) Simplify MultiSorter

2019-07-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8900. -- Resolution: Fixed Fix Version/s: 8.2 Thanks [~danmuzi]. > Simplify MultiSorter >

[jira] [Commented] (LUCENE-8883) CHANGES.txt: Auto add issue categories on new releases

2019-07-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880981#comment-16880981 ] Adrien Grand commented on LUCENE-8883: -- I just looked at the section names that we used at least 10

[jira] [Commented] (LUCENE-4312) Index format to store position length per position

2019-07-08 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880606#comment-16880606 ] Adrien Grand commented on LUCENE-4312: -- bq. the complexity of query execution would be driven by

[jira] [Commented] (LUCENE-4312) Index format to store position length per position

2019-07-08 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880422#comment-16880422 ] Adrien Grand commented on LUCENE-4312: -- Recording position lengths in the index is the easy part of

[jira] [Commented] (LUCENE-8860) LatLonShapeBoundingBoxQuery could make more decisions on inner nodes

2019-07-05 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879116#comment-16879116 ] Adrien Grand commented on LUCENE-8860: -- I made the issue about box queries, but that would actually

[jira] [Commented] (SOLR-12368) in-place DV updates should no longer have to jump through hoops if field does not yet exist

2019-07-04 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878866#comment-16878866 ] Adrien Grand commented on SOLR-12368: - I'm not familiar enough with how Solr routes updates to doc

[jira] [Commented] (LUCENE-8311) Leverage impacts for phrase queries

2019-07-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877919#comment-16877919 ] Adrien Grand commented on LUCENE-8311: -- I opened https://github.com/apache/lucene-solr/pull/760.

[jira] [Commented] (LUCENE-8762) Lucene50PostingsReader should specialize reading docs+freqs with impacts

2019-07-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877916#comment-16877916 ] Adrien Grand commented on LUCENE-8762: -- I proposed to change the specialization for

[jira] [Commented] (LUCENE-8311) Leverage impacts for phrase queries

2019-07-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877849#comment-16877849 ] Adrien Grand commented on LUCENE-8311: -- It turns out that part of the reason why the patch is

[jira] [Commented] (LUCENE-8899) Implementation of MultiTermQuery for ORed Queries

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877185#comment-16877185 ] Adrien Grand commented on LUCENE-8899: -- This sounds very similar to what TermInSetQuery is doing,

[jira] [Commented] (LUCENE-8900) Simplify MultiSorter

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877183#comment-16877183 ] Adrien Grand commented on LUCENE-8900: -- Thanks [~danmuzi], I will apply your first suggestion.

[jira] [Commented] (LUCENE-8901) Load frequencies lazily for postings and impacts

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877164#comment-16877164 ] Adrien Grand commented on LUCENE-8901: -- Thanks [~mayyas]! > Load frequencies lazily for postings

[jira] [Updated] (LUCENE-8901) Load frequencies lazily for postings and impacts

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8901: - Fix Version/s: 8.2 > Load frequencies lazily for postings and impacts >

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877157#comment-16877157 ] Adrien Grand commented on LUCENE-8857: -- Double checking, have you run all Solr tests or only

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877155#comment-16877155 ] Adrien Grand commented on LUCENE-8857: -- Thanks [~atris] I'll look into merging now. MIGRATE is

[jira] [Reopened] (LUCENE-8069) Allow index sorting by field length

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand reopened LUCENE-8069: -- I've had this idea come back to my mind several times since I opened it. Sorting by norm brings

[jira] [Updated] (LUCENE-8900) Simplify MultiSorter

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8900: - Attachment: LUCENE-8900.patch Status: Open (was: Open) Here is a patch, it does two

[jira] [Created] (LUCENE-8900) Simplify MultiSorter

2019-07-02 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8900: Summary: Simplify MultiSorter Key: LUCENE-8900 URL: https://issues.apache.org/jira/browse/LUCENE-8900 Project: Lucene - Core Issue Type: Improvement

[jira] [Commented] (LUCENE-8892) Missing closing parens in string representation of MultiBoolFunction

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876712#comment-16876712 ] Adrien Grand commented on LUCENE-8892: -- [~munendrasn] I resolved and gave you permission. It should

[jira] [Updated] (LUCENE-8892) Missing closing parens in string representation of MultiBoolFunction

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8892: - Resolution: Fixed Fix Version/s: 8.2 Status: Resolved (was: Patch Available)

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876705#comment-16876705 ] Adrien Grand commented on LUCENE-8857: -- We need to have all changes in the same pull request,

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876698#comment-16876698 ] Adrien Grand commented on LUCENE-8857: -- [~atris] Thanks for looking into the grouping failure. I'm

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876689#comment-16876689 ] Adrien Grand commented on LUCENE-8757: -- This change as been reverted from 8.x due to the fact that

[jira] [Updated] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8757: - Fix Version/s: (was: 8.2) > Better Segment To Thread Mapping Algorithm >

[jira] [Created] (LUCENE-8898) TestRamUsageEstimator.testMap failures

2019-07-01 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8898: Summary: TestRamUsageEstimator.testMap failures Key: LUCENE-8898 URL: https://issues.apache.org/jira/browse/LUCENE-8898 Project: Lucene - Core Issue Type:

[jira] [Updated] (LUCENE-8898) TestRamUsageEstimator.testMap failures

2019-07-01 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8898: - Issue Type: Bug (was: Improvement) > TestRamUsageEstimator.testMap failures >

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-01 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876248#comment-16876248 ] Adrien Grand commented on LUCENE-8857: -- [~atris] Can you look into those failures? I had understood

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-01 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876242#comment-16876242 ] Adrien Grand commented on LUCENE-8857: -- Thanks [~munendrasn] I'm reverting now. > Refactor

[jira] [Resolved] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-01 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8857. -- Resolution: Fixed Fix Version/s: master (9.0) > Refactor TopDocs#Merge To Take In

  1   2   3   4   5   6   7   8   9   10   >