[jira] [Commented] (LUCENE-4667) Change TestRandomChains to replace the list of broken classes by a list of broken constructors
[ https://issues.apache.org/jira/browse/LUCENE-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13548457#comment-13548457 ] Uwe Schindler commented on LUCENE-4667: --- Looks fine. I would prfer to use IdentityHashMap instead of HashMap, so it is consistent with the remaining logic. Classes and Constructors should be compared with identity. I would also make all constructors in the Map with the ALWAYS predicate to be not added to the array lists from the beginning. Change TestRandomChains to replace the list of broken classes by a list of broken constructors -- Key: LUCENE-4667 URL: https://issues.apache.org/jira/browse/LUCENE-4667 Project: Lucene - Core Issue Type: Task Reporter: Adrien Grand Priority: Minor Attachments: LUCENE-4667.patch Some classes are currently in the list of bad apples although only one constructor is broken. For example, LimitTokenCountFilter has an option to consume the whole stream. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4667) Change TestRandomChains to replace the list of broken classes by a list of broken constructors
[ https://issues.apache.org/jira/browse/LUCENE-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13548505#comment-13548505 ] Adrien Grand commented on LUCENE-4667: -- The test failed when I used an IdentityHashMap. Did I miss something or can't constructors be compared using ==? Change TestRandomChains to replace the list of broken classes by a list of broken constructors -- Key: LUCENE-4667 URL: https://issues.apache.org/jira/browse/LUCENE-4667 Project: Lucene - Core Issue Type: Task Reporter: Adrien Grand Priority: Minor Attachments: LUCENE-4667.patch Some classes are currently in the list of bad apples although only one constructor is broken. For example, LimitTokenCountFilter has an option to consume the whole stream. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4667) Change TestRandomChains to replace the list of broken classes by a list of broken constructors
[ https://issues.apache.org/jira/browse/LUCENE-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13548518#comment-13548518 ] Uwe Schindler commented on LUCENE-4667: --- Maybe that's the case! Sorry. I was expecting that constructors are singletons like classes. HashMap is fine then. In my opinion, I think maybe the whole Predicate approach is too much detailed? I would just match on the constructor itsself and would disallow it completeley (without looking into actual parameters). Just exclude the constructor in the beforeClass() method when populating the lists. If you want to keep the predicate approach, i would exclude all broken construcors with the ALWAYS predicate in beforeClass(), so it never tries to use the constructor at all (because its no longer in the list). Change TestRandomChains to replace the list of broken classes by a list of broken constructors -- Key: LUCENE-4667 URL: https://issues.apache.org/jira/browse/LUCENE-4667 Project: Lucene - Core Issue Type: Task Reporter: Adrien Grand Priority: Minor Attachments: LUCENE-4667.patch, LUCENE-4667.patch Some classes are currently in the list of bad apples although only one constructor is broken. For example, LimitTokenCountFilter has an option to consume the whole stream. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4667) Change TestRandomChains to replace the list of broken classes by a list of broken constructors
[ https://issues.apache.org/jira/browse/LUCENE-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13548630#comment-13548630 ] Commit Tag Bot commented on LUCENE-4667: [trunk commit] Adrien Grand http://svn.apache.org/viewvc?view=revisionrevision=1430931 LUCENE-4667: Change the broken components list from class-based to constructor-based. TestRandomChains now tests LimitTokenCountFilter and checks that offsets generated with TrimFilter and TypeTokenFilter are correct. Change TestRandomChains to replace the list of broken classes by a list of broken constructors -- Key: LUCENE-4667 URL: https://issues.apache.org/jira/browse/LUCENE-4667 Project: Lucene - Core Issue Type: Task Reporter: Adrien Grand Assignee: Adrien Grand Priority: Minor Attachments: LUCENE-4667.patch, LUCENE-4667.patch, LUCENE-4667.patch Some classes are currently in the list of bad apples although only one constructor is broken. For example, LimitTokenCountFilter has an option to consume the whole stream. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4667) Change TestRandomChains to replace the list of broken classes by a list of broken constructors
[ https://issues.apache.org/jira/browse/LUCENE-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13548640#comment-13548640 ] Robert Muir commented on LUCENE-4667: - We could also use this to stop some false fails from all the subclasses of FilteringTokenFilter (LengthFilter, TypeFilter, etc) that currently cause failures due to https://issues.apache.org/jira/browse/LUCENE-4065, when enablePositionIncrements=false Change TestRandomChains to replace the list of broken classes by a list of broken constructors -- Key: LUCENE-4667 URL: https://issues.apache.org/jira/browse/LUCENE-4667 Project: Lucene - Core Issue Type: Task Reporter: Adrien Grand Assignee: Adrien Grand Priority: Minor Attachments: LUCENE-4667.patch, LUCENE-4667.patch, LUCENE-4667.patch Some classes are currently in the list of bad apples although only one constructor is broken. For example, LimitTokenCountFilter has an option to consume the whole stream. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4667) Change TestRandomChains to replace the list of broken classes by a list of broken constructors
[ https://issues.apache.org/jira/browse/LUCENE-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13548643#comment-13548643 ] Commit Tag Bot commented on LUCENE-4667: [branch_4x commit] Adrien Grand http://svn.apache.org/viewvc?view=revisionrevision=1430934 LUCENE-4667: Change the broken components list from class-based to constructor-based (merged from r1430931). TestRandomChains now tests LimitTokenCountFilter and checks that offsets generated with TrimFilter and TypeTokenFilter are correct. Change TestRandomChains to replace the list of broken classes by a list of broken constructors -- Key: LUCENE-4667 URL: https://issues.apache.org/jira/browse/LUCENE-4667 Project: Lucene - Core Issue Type: Task Reporter: Adrien Grand Assignee: Adrien Grand Priority: Minor Attachments: LUCENE-4667.patch, LUCENE-4667.patch, LUCENE-4667.patch Some classes are currently in the list of bad apples although only one constructor is broken. For example, LimitTokenCountFilter has an option to consume the whole stream. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4667) Change TestRandomChains to replace the list of broken classes by a list of broken constructors
[ https://issues.apache.org/jira/browse/LUCENE-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13548680#comment-13548680 ] Uwe Schindler commented on LUCENE-4667: --- Thanks Adrien! Change TestRandomChains to replace the list of broken classes by a list of broken constructors -- Key: LUCENE-4667 URL: https://issues.apache.org/jira/browse/LUCENE-4667 Project: Lucene - Core Issue Type: Task Reporter: Adrien Grand Assignee: Adrien Grand Priority: Minor Attachments: LUCENE-4667.patch, LUCENE-4667.patch, LUCENE-4667.patch Some classes are currently in the list of bad apples although only one constructor is broken. For example, LimitTokenCountFilter has an option to consume the whole stream. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4667) Change TestRandomChains to replace the list of broken classes by a list of broken constructors
[ https://issues.apache.org/jira/browse/LUCENE-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13547511#comment-13547511 ] Robert Muir commented on LUCENE-4667: - +1 Change TestRandomChains to replace the list of broken classes by a list of broken constructors -- Key: LUCENE-4667 URL: https://issues.apache.org/jira/browse/LUCENE-4667 Project: Lucene - Core Issue Type: Task Reporter: Adrien Grand Priority: Minor Some classes are currently in the list of bad apples although only one constructor is broken. For example, LimitTokenCountFilter has an option to consume the whole stream. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
