[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField
[
https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957156#comment-15957156
]
ASF subversion and git services commented on LUCENE-7738:
-
Commit 2bdb3c7d1e738bbcfffa45bf47639446b0734f0f in lucene-solr's branch
refs/heads/branch_6_5 from [~nknize]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2bdb3c7 ]
LUCENE-7738: Fix min/max verification bug in InetAddressRange to correctly
compare IPv4 and IPv6. Update tests.
> Add new InetAddressRangeField
> -
>
> Key: LUCENE-7738
> URL: https://issues.apache.org/jira/browse/LUCENE-7738
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Nicholas Knize
> Attachments: LUCENE-7738.patch, LUCENE-7738.patch
>
>
> This issue adda a new {{InetAddressRangeField}} for indexing and querying
> InetAddress ranges.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField
[
https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957153#comment-15957153
]
ASF subversion and git services commented on LUCENE-7738:
-
Commit 6eb00543bc969d375b43ed20bedcbdb60bc8f22a in lucene-solr's branch
refs/heads/branch_6x from [~nknize]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6eb0054 ]
LUCENE-7738: Fix min/max verification bug in InetAddressRange to correctly
compare IPv4 and IPv6. Update tests.
> Add new InetAddressRangeField
> -
>
> Key: LUCENE-7738
> URL: https://issues.apache.org/jira/browse/LUCENE-7738
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Nicholas Knize
> Attachments: LUCENE-7738.patch, LUCENE-7738.patch
>
>
> This issue adda a new {{InetAddressRangeField}} for indexing and querying
> InetAddress ranges.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField
[
https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957148#comment-15957148
]
ASF subversion and git services commented on LUCENE-7738:
-
Commit ef8126e5eab7aec9c8775c2e08bd6c2bb1ef690f in lucene-solr's branch
refs/heads/master from [~nknize]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ef8126e ]
LUCENE-7738: Fix min/max verification bug in InetAddressRange to correctly
compare IPv4 and IPv6. Update tests.
> Add new InetAddressRangeField
> -
>
> Key: LUCENE-7738
> URL: https://issues.apache.org/jira/browse/LUCENE-7738
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Nicholas Knize
> Attachments: LUCENE-7738.patch, LUCENE-7738.patch
>
>
> This issue adda a new {{InetAddressRangeField}} for indexing and querying
> InetAddress ranges.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField
[
https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931235#comment-15931235
]
Erick Erickson commented on LUCENE-7738:
This has been committed, can it be closed?
> Add new InetAddressRangeField
> -
>
> Key: LUCENE-7738
> URL: https://issues.apache.org/jira/browse/LUCENE-7738
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Nicholas Knize
> Attachments: LUCENE-7738.patch, LUCENE-7738.patch
>
>
> This issue adda a new {{InetAddressRangeField}} for indexing and querying
> InetAddress ranges.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField
[
https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906383#comment-15906383
]
Nicholas Knize commented on LUCENE-7738:
I opened LUCENE-7740 to refactor class names and move {{InetAddressRange}} from
{{sandbox}} to {{misc}}. All other {{*Range}} fields will be refactored to core.
> Add new InetAddressRangeField
> -
>
> Key: LUCENE-7738
> URL: https://issues.apache.org/jira/browse/LUCENE-7738
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Nicholas Knize
> Attachments: LUCENE-7738.patch, LUCENE-7738.patch
>
>
> This issue adda a new {{InetAddressRangeField}} for indexing and querying
> InetAddress ranges.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField
[
https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906384#comment-15906384
]
Adrien Grand commented on LUCENE-7738:
--
Actually can you remove the {{e.printStackTrace()}} call in the test and
rethrow the exception instead? (potentially wrapper in a RuntimeException if it
makes things easier)
> Add new InetAddressRangeField
> -
>
> Key: LUCENE-7738
> URL: https://issues.apache.org/jira/browse/LUCENE-7738
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Nicholas Knize
> Attachments: LUCENE-7738.patch, LUCENE-7738.patch
>
>
> This issue adda a new {{InetAddressRangeField}} for indexing and querying
> InetAddress ranges.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField
[
https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906385#comment-15906385
]
Nicholas Knize commented on LUCENE-7738:
+1
> Add new InetAddressRangeField
> -
>
> Key: LUCENE-7738
> URL: https://issues.apache.org/jira/browse/LUCENE-7738
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Nicholas Knize
> Attachments: LUCENE-7738.patch, LUCENE-7738.patch
>
>
> This issue adda a new {{InetAddressRangeField}} for indexing and querying
> InetAddress ranges.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField
[
https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906380#comment-15906380
]
ASF subversion and git services commented on LUCENE-7738:
-
Commit 13f020f5899118bfba41b845deb728c1c131ff46 in lucene-solr's branch
refs/heads/branch_6x from [~nknize]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=13f020f ]
LUCENE-7738: Add new InetAddressRangeField for indexing and querying
InetAddress ranges.
> Add new InetAddressRangeField
> -
>
> Key: LUCENE-7738
> URL: https://issues.apache.org/jira/browse/LUCENE-7738
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Nicholas Knize
> Attachments: LUCENE-7738.patch, LUCENE-7738.patch
>
>
> This issue adda a new {{InetAddressRangeField}} for indexing and querying
> InetAddress ranges.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField
[
https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906379#comment-15906379
]
Adrien Grand commented on LUCENE-7738:
--
+1 to the patch
+1 to removing the "Field" suffix from range fields
+1 on graduating those fields from sandbox, I was initially thinking core would
be a good fit (LUCENE-7314) but misc works for me too
> Add new InetAddressRangeField
> -
>
> Key: LUCENE-7738
> URL: https://issues.apache.org/jira/browse/LUCENE-7738
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Nicholas Knize
> Attachments: LUCENE-7738.patch, LUCENE-7738.patch
>
>
> This issue adda a new {{InetAddressRangeField}} for indexing and querying
> InetAddress ranges.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField
[
https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906378#comment-15906378
]
ASF subversion and git services commented on LUCENE-7738:
-
Commit 1745b0338e822db43f292f7ad495789b21c6634a in lucene-solr's branch
refs/heads/master from [~nknize]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1745b03 ]
LUCENE-7738: Add new InetAddressRangeField for indexing and querying
InetAddress ranges.
> Add new InetAddressRangeField
> -
>
> Key: LUCENE-7738
> URL: https://issues.apache.org/jira/browse/LUCENE-7738
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Nicholas Knize
> Attachments: LUCENE-7738.patch, LUCENE-7738.patch
>
>
> This issue adda a new {{InetAddressRangeField}} for indexing and querying
> InetAddress ranges.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField
[
https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906343#comment-15906343
]
David Smiley commented on LUCENE-7738:
--
RE naming; some consistency is good. So if the non-range variant doesn't have
'Field' then don't put it on the range variant. But vice-versa is also true --
consistency being most important. I care little wether both should have (or
not have) a "Field" suffix. There seems to be a lot of variation across
Lucene, unfortunately.
bq. I can open a separate issue to "Graduate Range Fields from sandbox" that
will refactor the range field class names and move them to the appropriate
module?
+1
> Add new InetAddressRangeField
> -
>
> Key: LUCENE-7738
> URL: https://issues.apache.org/jira/browse/LUCENE-7738
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Nicholas Knize
> Attachments: LUCENE-7738.patch, LUCENE-7738.patch
>
>
> This issue adda a new {{InetAddressRangeField}} for indexing and querying
> InetAddress ranges.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField
[
https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906274#comment-15906274
]
Nicholas Knize commented on LUCENE-7738:
Thanks [~dsmiley]!
I have no problem putting both {{InetAddressRangeField}} and
{{InetAddressPoint}} in the misc module. Seems like a sound justification to me.
I also think I'm going to refactor all range field classes to remove {{Field}}
from the class name. It seems more natural (to me) to have {{Point}} and
{{Range}} counterparts (e.g., {{DoublePoint}}, {{DoubleRange}},
{{InetAddressPoint}}, {{InetAddressRange}})? (and less typing is always a
bonus) What do you think? (or does anyone care? - I know naming is often an
exercise in bikeshedding)
If no one objects I can open a separate issue to "Graduate Range Fields from
sandbox" that will refactor the range field class names and move them to the
appropriate module? What does everyone think?
> Add new InetAddressRangeField
> -
>
> Key: LUCENE-7738
> URL: https://issues.apache.org/jira/browse/LUCENE-7738
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Nicholas Knize
> Attachments: LUCENE-7738.patch, LUCENE-7738.patch
>
>
> This issue adda a new {{InetAddressRangeField}} for indexing and querying
> InetAddress ranges.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField
[
https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906029#comment-15906029
]
David Smiley commented on LUCENE-7738:
--
This is very nice and especially well documented; nice job Nick!
What do you think about putting this in Lucene's "misc" module? IP range
search seems fairly fringe -- useful to some folks surely. And
InetAddressPoint (currently in sandbox) should probably be co-located with
InetAddressRangeField; no?
> Add new InetAddressRangeField
> -
>
> Key: LUCENE-7738
> URL: https://issues.apache.org/jira/browse/LUCENE-7738
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Nicholas Knize
> Attachments: LUCENE-7738.patch, LUCENE-7738.patch
>
>
> This issue adda a new {{InetAddressRangeField}} for indexing and querying
> InetAddress ranges.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField
[
https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905838#comment-15905838
]
Adrien Grand commented on LUCENE-7738:
--
+1 Could you just create ipv4 addresses in the test from a byte[4] rather than
from a String? (like you do for ipv6 addresses)
> Add new InetAddressRangeField
> -
>
> Key: LUCENE-7738
> URL: https://issues.apache.org/jira/browse/LUCENE-7738
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Nicholas Knize
> Attachments: LUCENE-7738.patch
>
>
> This issue adda a new {{InetAddressRangeField}} for indexing and querying
> InetAddress ranges.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
