[jira] [Commented] (LUCENE-8242) Rename IndexSearcher.createNormalizedWeight()
[ https://issues.apache.org/jira/browse/LUCENE-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430667#comment-16430667 ] ASF subversion and git services commented on LUCENE-8242: - Commit e30264b31400a147507aabd121b1152020b8aa6d in lucene-solr's branch refs/heads/master from [~romseygeek] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e30264b ] LUCENE-8242: Remove IndexSearcher.createNormalizedWeight > Rename IndexSearcher.createNormalizedWeight() > - > > Key: LUCENE-8242 > URL: https://issues.apache.org/jira/browse/LUCENE-8242 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward >Priority: Major > Attachments: LUCENE-8242.patch > > > We don't have Weight normalization since LUCENE-7368, so this method name is > just plain wrong. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8242) Rename IndexSearcher.createNormalizedWeight()
[ https://issues.apache.org/jira/browse/LUCENE-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430666#comment-16430666 ] ASF subversion and git services commented on LUCENE-8242: - Commit 798d3510341fa08e766776433d4f403a28f2d314 in lucene-solr's branch refs/heads/master from [~romseygeek] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=798d351 ] LUCENE-8242: Deprecate createNormalizedWeight > Rename IndexSearcher.createNormalizedWeight() > - > > Key: LUCENE-8242 > URL: https://issues.apache.org/jira/browse/LUCENE-8242 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward >Priority: Major > Attachments: LUCENE-8242.patch > > > We don't have Weight normalization since LUCENE-7368, so this method name is > just plain wrong. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8242) Rename IndexSearcher.createNormalizedWeight()
[ https://issues.apache.org/jira/browse/LUCENE-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430665#comment-16430665 ] ASF subversion and git services commented on LUCENE-8242: - Commit 211e0ec84ac2b2d3de0ba666da1d80c1242da1b8 in lucene-solr's branch refs/heads/branch_7x from [~romseygeek] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=211e0ec ] LUCENE-8242: Deprecate createNormalizedWeight > Rename IndexSearcher.createNormalizedWeight() > - > > Key: LUCENE-8242 > URL: https://issues.apache.org/jira/browse/LUCENE-8242 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward >Priority: Major > Attachments: LUCENE-8242.patch > > > We don't have Weight normalization since LUCENE-7368, so this method name is > just plain wrong. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8242) Rename IndexSearcher.createNormalizedWeight()
[
https://issues.apache.org/jira/browse/LUCENE-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430517#comment-16430517
]
Adrien Grand commented on LUCENE-8242:
--
+1 Maybe say that {{boost}} should be {{1}} in the {{@deprecated}} javadocs and
add an entry to {{lucene/MIGRATE.txt}}?
> Rename IndexSearcher.createNormalizedWeight()
> -
>
> Key: LUCENE-8242
> URL: https://issues.apache.org/jira/browse/LUCENE-8242
> Project: Lucene - Core
> Issue Type: Improvement
>Reporter: Alan Woodward
>Assignee: Alan Woodward
>Priority: Major
> Attachments: LUCENE-8242.patch
>
>
> We don't have Weight normalization since LUCENE-7368, so this method name is
> just plain wrong.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8242) Rename IndexSearcher.createNormalizedWeight()
[ https://issues.apache.org/jira/browse/LUCENE-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429476#comment-16429476 ] Alan Woodward commented on LUCENE-8242: --- Here's a patch deprecating the method, and removing all uses of it. > Rename IndexSearcher.createNormalizedWeight() > - > > Key: LUCENE-8242 > URL: https://issues.apache.org/jira/browse/LUCENE-8242 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward >Priority: Major > Attachments: LUCENE-8242.patch > > > We don't have Weight normalization since LUCENE-7368, so this method name is > just plain wrong. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8242) Rename IndexSearcher.createNormalizedWeight()
[ https://issues.apache.org/jira/browse/LUCENE-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429322#comment-16429322 ] Robert Muir commented on LUCENE-8242: - Please remove it, I see zero advantage in renaming it. > Rename IndexSearcher.createNormalizedWeight() > - > > Key: LUCENE-8242 > URL: https://issues.apache.org/jira/browse/LUCENE-8242 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward >Priority: Major > > We don't have Weight normalization since LUCENE-7368, so this method name is > just plain wrong. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8242) Rename IndexSearcher.createNormalizedWeight()
[ https://issues.apache.org/jira/browse/LUCENE-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428236#comment-16428236 ] Adrien Grand commented on LUCENE-8242: -- Or maybe remove it entirely and expect callers to rewrite before calling createWeight with a boost of 1? > Rename IndexSearcher.createNormalizedWeight() > - > > Key: LUCENE-8242 > URL: https://issues.apache.org/jira/browse/LUCENE-8242 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward >Priority: Major > > We don't have Weight normalization since LUCENE-7368, so this method name is > just plain wrong. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8242) Rename IndexSearcher.createNormalizedWeight()
[
https://issues.apache.org/jira/browse/LUCENE-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428210#comment-16428210
]
Alan Woodward commented on LUCENE-8242:
---
We have two createWeight() functions in IndexSearcher:
{code}
public Weight createNormalizedWeight(Query query, ScoreMode scoreMode) throws
IOException
public Weight createWeight(Query query, ScoreMode scoreMode, float boost)
throws IOException
{code}
The first rewrites, and then delegates to the second with a boost of 1. I
think we should rename it to 'rewriteAndCreateWeight', as that's what it
actually does.
> Rename IndexSearcher.createNormalizedWeight()
> -
>
> Key: LUCENE-8242
> URL: https://issues.apache.org/jira/browse/LUCENE-8242
> Project: Lucene - Core
> Issue Type: Improvement
>Reporter: Alan Woodward
>Assignee: Alan Woodward
>Priority: Major
>
> We don't have Weight normalization since LUCENE-7368, so this method name is
> just plain wrong.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
