[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667956#comment-15667956
]
Ishan Chattopadhyaya commented on SOLR-9506:
Can we resolve this issue, since it seems it was
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667801#comment-15667801
]
Ishan Chattopadhyaya commented on SOLR-9506:
I see.. I saw it was unresolved, and I thought it
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667795#comment-15667795
]
Noble Paul commented on SOLR-9506:
--
Ishan , i guess this is already fixed in 6.3. so, we may need to open
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601820#comment-15601820
]
ASF subversion and git services commented on SOLR-9506:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601675#comment-15601675
]
ASF subversion and git services commented on SOLR-9506:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15599826#comment-15599826
]
Pushkar Raste commented on SOLR-9506:
-
Yeah, I looked into it. I will try that approach, if I can get
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15596148#comment-15596148
]
Pushkar Raste commented on SOLR-9506:
-
Don't use patch for parallalized computation. Parallel streams
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589649#comment-15589649
]
Pushkar Raste commented on SOLR-9506:
-
[~noble.paul] and [~yo...@apache.org] I was able to put together
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586530#comment-15586530
]
Keith Laban commented on SOLR-9506:
---
How expensive would it be to check numDocs (#4 in yoniks comment
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586419#comment-15586419
]
ASF subversion and git services commented on SOLR-9506:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585918#comment-15585918
]
Yonik Seeley commented on SOLR-9506:
Please do.
> cache IndexFingerprint for each segment
>
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585801#comment-15585801
]
Noble Paul commented on SOLR-9506:
--
If the above case fails, let's revert the commit and revisit the
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585781#comment-15585781
]
ASF subversion and git services commented on SOLR-9506:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585759#comment-15585759
]
Yonik Seeley commented on SOLR-9506:
The above manual test only exhibited this bad behavior after the
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585756#comment-15585756
]
Yonik Seeley commented on SOLR-9506:
Not sure I understand... are you suggesting a workaround in
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585736#comment-15585736
]
Pushkar Raste commented on SOLR-9506:
-
There is lot of confusion going on here. Would above test fail
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585709#comment-15585709
]
Yonik Seeley commented on SOLR-9506:
Pretty simple to try out:
{code}
bin/solr start -e techproducts
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585707#comment-15585707
]
Pushkar Raste commented on SOLR-9506:
-
I think what Yonik is implying is that, if for some reason,
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585700#comment-15585700
]
Yonik Seeley commented on SOLR-9506:
Yep.
> cache IndexFingerprint for each segment
>
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585694#comment-15585694
]
Keith Laban commented on SOLR-9506:
---
Are you implying that if you add a document. commit it, compute the
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585693#comment-15585693
]
Keith Laban commented on SOLR-9506:
---
Are you implying that if you add a document. commit it, compute the
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585688#comment-15585688
]
Pushkar Raste commented on SOLR-9506:
-
i.e. we really need fix IndexFingerprint computation, whether or
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585683#comment-15585683
]
Yonik Seeley commented on SOLR-9506:
"Right... the core cache key does not change, even if there are
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585677#comment-15585677
]
Pushkar Raste commented on SOLR-9506:
-
I don't see why caching indexfingerprint per segment and using
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585635#comment-15585635
]
Yonik Seeley commented on SOLR-9506:
Hmmm, why was this committed?
See my comments regarding deleted
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585612#comment-15585612
]
Pushkar Raste commented on SOLR-9506:
-
I did not upload the patch with parallelStream. In
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585570#comment-15585570
]
Noble Paul commented on SOLR-9506:
--
which test. I did not find?
> cache IndexFingerprint for each segment
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585553#comment-15585553
]
ASF subversion and git services commented on SOLR-9506:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15556139#comment-15556139
]
Pushkar Raste commented on SOLR-9506:
-
I computed hash w/o regard to deleted docs and cached it. All
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15556132#comment-15556132
]
Pushkar Raste commented on SOLR-9506:
-
I also found some weird behavior. If I use {{parallelStream}} to
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552125#comment-15552125
]
Pushkar Raste commented on SOLR-9506:
-
Updated patch, added a scenario in {{PeerSyncTest}} about
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15548767#comment-15548767
]
Yonik Seeley commented on SOLR-9506:
A few random points after browsing this issue...
bq. We can not
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15548510#comment-15548510
]
Noble Paul commented on SOLR-9506:
--
https://github.com/apache/lucene-solr/pull/84
> cache
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532555#comment-15532555
]
Pushkar Raste commented on SOLR-9506:
-
Discussed with [~noble.paul]
We should cache fingerprint for a
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15531954#comment-15531954
]
Noble Paul commented on SOLR-9506:
--
Few quick points
{code:java}
// Map is not concurrent, but since
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523631#comment-15523631
]
Noble Paul commented on SOLR-9506:
--
the cumulative numDocs will be same anyway
I guess it can be
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523564#comment-15523564
]
Pushkar Raste commented on SOLR-9506:
-
I think what [~ichattopadhyaya] is hinting at, is that if
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523566#comment-15523566
]
Pushkar Raste commented on SOLR-9506:
-
Adding [~ysee...@gmail.com] in the loop
> cache
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523490#comment-15523490
]
Noble Paul commented on SOLR-9506:
--
no. segments don't change
> cache IndexFingerprint for each segment
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523485#comment-15523485
]
Ishan Chattopadhyaya commented on SOLR-9506:
We should keep in mind that previously written
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523273#comment-15523273
]
Pushkar Raste commented on SOLR-9506:
-
In short you are suggesting that when we cache fingerprint for
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523257#comment-15523257
]
Noble Paul commented on SOLR-9506:
--
[~praste] I've attached a sample program which computes versionsHash
[
https://issues.apache.org/jira/browse/SOLR-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521130#comment-15521130
]
Pushkar Raste commented on SOLR-9506:
-
POC/Initial commit -
43 matches
Mail list logo
