[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461598#comment-13461598
]
Lance Norskog commented on LUCENE-2510:
---
bq. We should open new issues for:
*
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429393#comment-13429393
]
Steven Rowe commented on LUCENE-2510:
-
Solr tests have been failing under Maven on
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269534#comment-13269534
]
Robert Muir commented on LUCENE-2510:
-
I dont think back compat is really important?
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269536#comment-13269536
]
Robert Muir commented on LUCENE-2510:
-
I think the interfaces are also unnecessary.
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269539#comment-13269539
]
Chris Male commented on LUCENE-2510:
{quote}
TokenizerFactory
TokenFilterFactory
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269540#comment-13269540
]
Robert Muir commented on LUCENE-2510:
-
Yes. practically, all of the impls 'extend
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269541#comment-13269541
]
Chris Male commented on LUCENE-2510:
Okay, good idea.
migrate solr
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269551#comment-13269551
]
Robert Muir commented on LUCENE-2510:
-
re: what is the purpose of the newInstance
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269598#comment-13269598
]
Chris Male commented on LUCENE-2510:
{quote}
I think we should revisit this. I don't
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269610#comment-13269610
]
Robert Muir commented on LUCENE-2510:
-
{quote}
I don't really know much about
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269636#comment-13269636
]
Robert Muir commented on LUCENE-2510:
-
{quote}
How would we support Factories loading
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269642#comment-13269642
]
Chris Male commented on LUCENE-2510:
That would be of a huge benefit, I definitely
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269659#comment-13269659
]
Chris Male commented on LUCENE-2510:
We're actually going to need this sooner rather
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269666#comment-13269666
]
Robert Muir commented on LUCENE-2510:
-
I will try to convince Uwe to look at the
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269783#comment-13269783
]
Ryan McKinley commented on LUCENE-2510:
---
On trunk (1335132) I am getting this error
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269789#comment-13269789
]
Steven Rowe commented on LUCENE-2510:
-
Ryan, compilation succeeds for me (at svn
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269849#comment-13269849
]
Ryan McKinley commented on LUCENE-2510:
---
my bad -- i was running ant compile from
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270179#comment-13270179
]
Robert Muir commented on LUCENE-2510:
-
I dont like the type-unsafety here... shouldnt
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270184#comment-13270184
]
Chris Male commented on LUCENE-2510:
I agree but I don't know anything about this
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270185#comment-13270185
]
Chris Male commented on LUCENE-2510:
Looking at the usage of this functionality in
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13268413#comment-13268413
]
Steven Rowe commented on LUCENE-2510:
-
Chris, before the changes made here, solrj did
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13268424#comment-13268424
]
Yonik Seeley commented on LUCENE-2510:
--
bq. before the changes made here, solrj did
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13268565#comment-13268565
]
Ryan McKinley commented on LUCENE-2510:
---
The only reason solrj has that dependency
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13268825#comment-13268825
]
Chris Male commented on LUCENE-2510:
Ah sorry guys, I went to a lot of effort to
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13268827#comment-13268827
]
Chris Male commented on LUCENE-2510:
Tests pass so I've moved it into solr-core to
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13268830#comment-13268830
]
Ryan McKinley commented on LUCENE-2510:
---
bq. I don't see why that would hurt OSGI
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13268841#comment-13268841
]
Chris Male commented on LUCENE-2510:
bq. Shouldn't SolrResourceLoader depend on
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266280#comment-13266280
]
Chris Male commented on LUCENE-2510:
Actually I think I've been a little naive with
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13264666#comment-13264666
]
Chris Male commented on LUCENE-2510:
Need to also fix the relationship between the
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255261#comment-13255261
]
Chris Male commented on LUCENE-2510:
Err... patch is broke, will fix.
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255262#comment-13255262
]
Chris Male commented on LUCENE-2510:
Actually it works, just needed to rebuild
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252172#comment-13252172
]
Robert Muir commented on LUCENE-2510:
-
Hmm looking at this ResourceLoader, what is
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252179#comment-13252179
]
Chris Male commented on LUCENE-2510:
bq. what is the purpose of the newInstance
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252191#comment-13252191
]
Robert Muir commented on LUCENE-2510:
-
{quote}
With all that said, its only used in 3
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252194#comment-13252194
]
Chris Male commented on LUCENE-2510:
bq. I guess my main problem with it is the
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966896#action_12966896
]
Chris Male commented on LUCENE-2510:
Heres a few things I think we should do as part
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12881685#action_12881685
]
Chris Male commented on LUCENE-2510:
+1 to this idea.
From my perspective the only
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12881692#action_12881692
]
Robert Muir commented on LUCENE-2510:
-
Chris, yes I think at a glance this is where I
[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12881694#action_12881694
]
Chris Male commented on LUCENE-2510:
I think if we consolidate how to load resources,
39 matches
Mail list logo
