[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13646468#comment-13646468
]
Alexey Kudinov commented on LUCENE-3842:
I tried building the analyzing suggester
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13646511#comment-13646511
]
Michael McCandless commented on LUCENE-3842:
The building process is
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13646543#comment-13646543
]
Alexey Kudinov commented on LUCENE-3842:
Setting maxGraphExpansions to some value
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13646559#comment-13646559
]
Michael McCandless commented on LUCENE-3842:
bq. I'm using the wordnet
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13646574#comment-13646574
]
Alexey Kudinov commented on LUCENE-3842:
I opened an issue for NPE - LUCENE-4971
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13646610#comment-13646610
]
Michael McCandless commented on LUCENE-3842:
Thank you Alexey!
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13610728#comment-13610728
]
Commit Tag Bot commented on LUCENE-3842:
[branch_4x commit] Michael McCandless
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13610730#comment-13610730
]
Commit Tag Bot commented on LUCENE-3842:
[branch_4x commit] Michael McCandless
To: dev@lucene.apache.org
Subject: [jira] [Commented] (LUCENE-3842) Analyzing Suggester
[ https://issues.apache.org/jira/browse/LUCENE-
3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
tabpanelfocusedCommentId=13610728#comment-13610728 ]
Commit Tag Bot commented
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13494793#comment-13494793
]
David Smiley commented on LUCENE-3842:
--
That TokenStreamToAutomaton is cool Mike! I
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469608#comment-13469608
]
Sudarshan Gaikaiwari commented on LUCENE-3842:
--
+1. This is awesome. It
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469612#comment-13469612
]
Michael McCandless commented on LUCENE-3842:
Thanks Sudarshan! It's actually
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13465767#comment-13465767
]
Robert Muir commented on LUCENE-3842:
-
in TStoA:
{code}
if (pos == -1 posInc == 0) {
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13465778#comment-13465778
]
Michael McCandless commented on LUCENE-3842:
Thanks Rob, good feedback ...
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13465865#comment-13465865
]
Robert Muir commented on LUCENE-3842:
-
Can we split Analyzer into indexAnalyzer and
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13465934#comment-13465934
]
Robert Muir commented on LUCENE-3842:
-
+1 thanks Mike. lets get it in!
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13457552#comment-13457552
]
Robert Muir commented on LUCENE-3842:
-
{quote}
I think it would be better/cleaner to
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13457556#comment-13457556
]
Robert Muir commented on LUCENE-3842:
-
and as far as exactFirst: lets just keep it
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13457562#comment-13457562
]
Robert Muir commented on LUCENE-3842:
-
Sorry mike, I'm still catching up and sadly
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13456728#comment-13456728
]
Bill Bell commented on LUCENE-3842:
---
A common Suggester use case is to boost the
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13456732#comment-13456732
]
Robert Muir commented on LUCENE-3842:
-
Bill can you start a different thread for
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13456443#comment-13456443
]
Michael McCandless commented on LUCENE-3842:
OK I created branch:
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13456468#comment-13456468
]
Robert Muir commented on LUCENE-3842:
-
Thanks for resurrecting this from the dead! I
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13456477#comment-13456477
]
Robert Muir commented on LUCENE-3842:
-
+1 for that. lets keep this as simple as
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13404537#comment-13404537
]
Sudarshan Gaikaiwari commented on LUCENE-3842:
--
bq. maybe we can tie-break
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13287369#comment-13287369
]
Michael McCandless commented on LUCENE-3842:
Hi Sudarshan, thanks for raising
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13286249#comment-13286249
]
Sudarshan Gaikaiwari commented on LUCENE-3842:
--
Hi Michael,
Thanks a lot
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278166#comment-13278166
]
Sudarshan Gaikaiwari commented on LUCENE-3842:
--
I was not able to apply the
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278267#comment-13278267
]
Michael McCandless commented on LUCENE-3842:
Hi Sudarshan, sorry that was my
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13275895#comment-13275895
]
Robert Muir commented on LUCENE-3842:
-
Nice catch on the exactFirst dup problem!
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13276326#comment-13276326
]
Robert Muir commented on LUCENE-3842:
-
When running the benchmark
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13274068#comment-13274068
]
Michael McCandless commented on LUCENE-3842:
OK, when I pass false for
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273419#comment-13273419
]
Robert Muir commented on LUCENE-3842:
-
testStandard is also bogus: it has 2 asserts.
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272413#comment-13272413
]
Robert Muir commented on LUCENE-3842:
-
i see the problem. it actually happens on the
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229584#comment-13229584
]
Robert Muir commented on LUCENE-3842:
-
I also don't think we really need this generic
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221844#comment-13221844
]
Michael McCandless commented on LUCENE-3842:
Once posLength is in, I think a
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221929#comment-13221929
]
Dawid Weiss commented on LUCENE-3842:
-
bq. Patch with a static utility method to
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221930#comment-13221930
]
Robert Muir commented on LUCENE-3842:
-
{quote}
I've always wanted to see what Brics
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221932#comment-13221932
]
Robert Muir commented on LUCENE-3842:
-
{quote}
I looked at the patch but I don't
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221934#comment-13221934
]
Dawid Weiss commented on LUCENE-3842:
-
Ok, get it, thanks. I wonder if it's always
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221935#comment-13221935
]
Dawid Weiss commented on LUCENE-3842:
-
It also occurred to me that it would be
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221936#comment-13221936
]
Robert Muir commented on LUCENE-3842:
-
Dawid: hmm, well the transitions in brics are
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221940#comment-13221940
]
Dawid Weiss commented on LUCENE-3842:
-
Yep, sure you could (I admit I haven't looked
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221691#comment-13221691
]
Robert Muir commented on LUCENE-3842:
-
also just so i dont forget, we should allow
[
https://issues.apache.org/jira/browse/LUCENE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221748#comment-13221748
]
Michael McCandless commented on LUCENE-3842:
VERY cool :)
45 matches
Mail list logo
