[jira] [Commented] (LUCENE-4065) FilteringTokenFilter should never corrupt the tokenstream graph

2018-02-22 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373774#comment-16373774 ] Steve Rowe commented on LUCENE-4065: bq. But your testcase argues that this should be 4 positions (1

[jira] [Commented] (LUCENE-4065) FilteringTokenFilter should never corrupt the tokenstream graph

2018-02-22 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373757#comment-16373757 ] Robert Muir commented on LUCENE-4065: - Yeah, i mean we should split it up. Its probably more

[jira] [Commented] (LUCENE-4065) FilteringTokenFilter should never corrupt the tokenstream graph

2018-02-22 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373746#comment-16373746 ] Steve Rowe commented on LUCENE-4065: bq. i think its totally separate from the whole idea of giving

[jira] [Commented] (LUCENE-4065) FilteringTokenFilter should never corrupt the tokenstream graph

2018-02-22 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373727#comment-16373727 ] Robert Muir commented on LUCENE-4065: - Well, i think thats a separate, "new" issue, related to

[jira] [Commented] (LUCENE-4065) FilteringTokenFilter should never corrupt the tokenstream graph

2018-02-22 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373703#comment-16373703 ] Steve Rowe commented on LUCENE-4065: Based on [Jim Ferenczi's comment on

[jira] [Commented] (LUCENE-4065) FilteringTokenFilter should never corrupt the tokenstream graph

2018-02-21 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372072#comment-16372072 ] Robert Muir commented on LUCENE-4065: - Yeah, you've got it. I really prefer your {{enableGaps}} name.

[jira] [Commented] (LUCENE-4065) FilteringTokenFilter should never corrupt the tokenstream graph

2018-02-21 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372046#comment-16372046 ] Steve Rowe commented on LUCENE-4065: [~rcmuir] commented over on

[jira] [Commented] (LUCENE-4065) FilteringTokenFilter should never corrupt the tokenstream graph

2016-09-02 Thread Eduard Dudar (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15460164#comment-15460164 ] Eduard Dudar commented on LUCENE-4065: -- enable position increments is incredibly useful for shingles

[jira] [Commented] (LUCENE-4065) FilteringTokenFilter should never corrupt the tokenstream graph

2013-01-09 Thread Commit Tag Bot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13548651#comment-13548651 ] Commit Tag Bot commented on LUCENE-4065: [trunk commit] Robert Muir

[jira] [Commented] (LUCENE-4065) FilteringTokenFilter should never corrupt the tokenstream graph

2013-01-09 Thread Commit Tag Bot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13548662#comment-13548662 ] Commit Tag Bot commented on LUCENE-4065: [branch_4x commit] Robert Muir

[jira] [Commented] (LUCENE-4065) FilteringTokenFilter should never corrupt the tokenstream graph

2012-05-17 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13277805#comment-13277805 ] Robert Muir commented on LUCENE-4065: - Another way to see it: imagine i have 'my test