[jira] [Commented] (LUCENE-4876) IndexWriterConfig.clone should clone the MergeScheduler

2013-07-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13721719#comment-13721719 ] ASF subversion and git services commented on LUCENE-4876: - Commit

[jira] [Commented] (LUCENE-4876) IndexWriterConfig.clone should clone the MergeScheduler

2013-07-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13721720#comment-13721720 ] ASF subversion and git services commented on LUCENE-4876: - Commit

[jira] [Commented] (LUCENE-4876) IndexWriterConfig.clone should clone the MergeScheduler

2013-07-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720476#comment-13720476 ] Adrien Grand commented on LUCENE-4876: -- bq. We keep clone() on IWC, and the rest of

[jira] [Commented] (LUCENE-4876) IndexWriterConfig.clone should clone the MergeScheduler

2013-07-26 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720512#comment-13720512 ] Shai Erera commented on LUCENE-4876: This is currently impossible because of SetOnce.

[jira] [Commented] (LUCENE-4876) IndexWriterConfig.clone should clone the MergeScheduler

2013-07-26 Thread selckin (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720518#comment-13720518 ] selckin commented on LUCENE-4876: - This is also encouraging to just 'return this' from

[jira] [Commented] (LUCENE-4876) IndexWriterConfig.clone should clone the MergeScheduler

2013-07-26 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720521#comment-13720521 ] Shai Erera commented on LUCENE-4876: That's right. I view IWC.clone as a service to

[jira] [Commented] (LUCENE-4876) IndexWriterConfig.clone should clone the MergeScheduler

2013-07-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720526#comment-13720526 ] Adrien Grand commented on LUCENE-4876: -- bq. This is currently impossible because of

[jira] [Commented] (LUCENE-4876) IndexWriterConfig.clone should clone the MergeScheduler

2013-07-26 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720656#comment-13720656 ] Shai Erera commented on LUCENE-4876: The purpose behind IWC was to centralize all IW

[jira] [Commented] (LUCENE-4876) IndexWriterConfig.clone should clone the MergeScheduler

2013-07-26 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720752#comment-13720752 ] Michael McCandless commented on LUCENE-4876: bq. In that case, the test

[jira] [Commented] (LUCENE-4876) IndexWriterConfig.clone should clone the MergeScheduler

2013-07-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720806#comment-13720806 ] Adrien Grand commented on LUCENE-4876: -- The SetOnceIndexWriter on IWC addresses my

[jira] [Commented] (LUCENE-4876) IndexWriterConfig.clone should clone the MergeScheduler

2013-07-26 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720830#comment-13720830 ] Michael McCandless commented on LUCENE-4876: +1, patch looks great. Thanks

[jira] [Commented] (LUCENE-4876) IndexWriterConfig.clone should clone the MergeScheduler

2013-07-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13719987#comment-13719987 ] Shai Erera commented on LUCENE-4876: Perhaps we can do a minor change -- stop calling

[jira] [Commented] (LUCENE-4876) IndexWriterConfig.clone should clone the MergeScheduler

2013-07-25 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13719988#comment-13719988 ] Michael McCandless commented on LUCENE-4876: +1

[jira] [Commented] (LUCENE-4876) IndexWriterConfig.clone should clone the MergeScheduler

2013-07-25 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720129#comment-13720129 ] Yonik Seeley commented on LUCENE-4876: -- bq. We keep clone() on IWC, and the rest of

[jira] [Commented] (LUCENE-4876) IndexWriterConfig.clone should clone the MergeScheduler

2013-07-24 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718258#comment-13718258 ] Michael McCandless commented on LUCENE-4876: Alas I'm not sure we did the

[jira] [Commented] (LUCENE-4876) IndexWriterConfig.clone should clone the MergeScheduler

2013-06-17 Thread selckin (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13685638#comment-13685638 ] selckin commented on LUCENE-4876: - The new requirement to implement clone() is not very

[jira] [Commented] (LUCENE-4876) IndexWriterConfig.clone should clone the MergeScheduler

2013-03-27 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13615811#comment-13615811 ] Michael McCandless commented on LUCENE-4876: +1, looks great!

[jira] [Commented] (LUCENE-4876) IndexWriterConfig.clone should clone the MergeScheduler

2013-03-27 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13615839#comment-13615839 ] Adrien Grand commented on LUCENE-4876: -- bq. Does PersistentSnapshotDeletionPolicy

[jira] [Commented] (LUCENE-4876) IndexWriterConfig.clone should clone the MergeScheduler

2013-03-24 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13612078#comment-13612078 ] Michael McCandless commented on LUCENE-4876: +1