[
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13721719#comment-13721719
]
ASF subversion and git services commented on LUCENE-4876:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13721720#comment-13721720
]
ASF subversion and git services commented on LUCENE-4876:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720476#comment-13720476
]
Adrien Grand commented on LUCENE-4876:
--
bq. We keep clone() on IWC, and the rest of
[
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720512#comment-13720512
]
Shai Erera commented on LUCENE-4876:
This is currently impossible because of SetOnce.
[
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720518#comment-13720518
]
selckin commented on LUCENE-4876:
-
This is also encouraging to just 'return this' from
[
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720521#comment-13720521
]
Shai Erera commented on LUCENE-4876:
That's right. I view IWC.clone as a service to
[
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720526#comment-13720526
]
Adrien Grand commented on LUCENE-4876:
--
bq. This is currently impossible because of
[
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720656#comment-13720656
]
Shai Erera commented on LUCENE-4876:
The purpose behind IWC was to centralize all IW
[
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720752#comment-13720752
]
Michael McCandless commented on LUCENE-4876:
bq. In that case, the test
[
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720806#comment-13720806
]
Adrien Grand commented on LUCENE-4876:
--
The SetOnceIndexWriter on IWC addresses my
[
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720830#comment-13720830
]
Michael McCandless commented on LUCENE-4876:
+1, patch looks great. Thanks
[
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13719987#comment-13719987
]
Shai Erera commented on LUCENE-4876:
Perhaps we can do a minor change -- stop calling
[
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13719988#comment-13719988
]
Michael McCandless commented on LUCENE-4876:
+1
[
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720129#comment-13720129
]
Yonik Seeley commented on LUCENE-4876:
--
bq. We keep clone() on IWC, and the rest of
[
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718258#comment-13718258
]
Michael McCandless commented on LUCENE-4876:
Alas I'm not sure we did the
[
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13685638#comment-13685638
]
selckin commented on LUCENE-4876:
-
The new requirement to implement clone() is not very
[
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13615811#comment-13615811
]
Michael McCandless commented on LUCENE-4876:
+1, looks great!
[
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13615839#comment-13615839
]
Adrien Grand commented on LUCENE-4876:
--
bq. Does PersistentSnapshotDeletionPolicy
[
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13612078#comment-13612078
]
Michael McCandless commented on LUCENE-4876:
+1
19 matches
Mail list logo